From 125a41810e475497ec72101af85172f99bec0f15 Mon Sep 17 00:00:00 2001 From: Florian Preusner Date: Tue, 9 Oct 2018 14:09:48 +0200 Subject: [PATCH 1/6] added comments and more options --- .../config/packages/eight_points_guzzle.yaml | 28 +++++++++++++++---- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/eightpoints/guzzle-bundle/7.0/config/packages/eight_points_guzzle.yaml b/eightpoints/guzzle-bundle/7.0/config/packages/eight_points_guzzle.yaml index d0698ed7..19c22080 100644 --- a/eightpoints/guzzle-bundle/7.0/config/packages/eight_points_guzzle.yaml +++ b/eightpoints/guzzle-bundle/7.0/config/packages/eight_points_guzzle.yaml @@ -1,17 +1,35 @@ +# EightPoints GuzzleBundle +# A full list of configuration options can be found here: +# https://github.com/8p/EightPointsGuzzleBundle/blob/master/src/Resources/doc/configuration-reference.md eight_points_guzzle: + # (de)activate logging/profiler; default: %kernel.debug% + logging: true + clients: my_client: # Write here the host where to do requests - # base_url: "http://target.url" +# base_url: "http://target.url" + # Request options: http://docs.guzzlephp.org/en/stable/request-options.html options: + # timeout in seconds timeout: 30 - # Configure headers. - # More info: http://docs.guzzlephp.org/en/stable/request-options.html#headers + # set to false to disable throwing exceptions on an HTTP protocol errors (4xx and 5xx responses) + http_errors: true + + # each key is the name of a header, and each value is a string or array of strings representing the + # header field values. headers: - User-Agent: "EightpointsGuzzleBundle/7.0" + User-Agent: "EightPointsGuzzleBundle/v7" # Find plugins here: # https://github.com/8p/EightPointsGuzzleBundle#known-and-supported-plugins - plugin: ~ + plugin: + # https://github.com/gregurco/GuzzleBundleOAuth2Plugin +# oauth2: +# base_uri: "https://example.com" +# token_url: "/oauth/token" +# client_id: "test-client-id" +# client_secret: "test-client-secret" # optional +# scope: "administration" From 86f975d1f38fbc91e9e670367603bc5e5da1271f Mon Sep 17 00:00:00 2001 From: Florian Preusner Date: Tue, 9 Oct 2018 14:20:16 +0200 Subject: [PATCH 2/6] #172 run assets:install --- eightpoints/guzzle-bundle/7.0/manifest.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/eightpoints/guzzle-bundle/7.0/manifest.json b/eightpoints/guzzle-bundle/7.0/manifest.json index 075b637f..30baa5a5 100644 --- a/eightpoints/guzzle-bundle/7.0/manifest.json +++ b/eightpoints/guzzle-bundle/7.0/manifest.json @@ -4,5 +4,8 @@ }, "copy-from-recipe": { "config/": "%CONFIG_DIR%/" + }, + "composer-scripts": { + "assets:install %PUBLIC_DIR%": "symfony-cmd" } } From 0a44034231e385bcddd051fba6904a3d21b22784 Mon Sep 17 00:00:00 2001 From: Florian Preusner Date: Tue, 9 Oct 2018 15:08:13 +0200 Subject: [PATCH 3/6] revert #172 run assets:install https://github.com/symfony/recipes-contrib/pull/512#discussion_r221609209 --- eightpoints/guzzle-bundle/7.0/manifest.json | 3 --- 1 file changed, 3 deletions(-) diff --git a/eightpoints/guzzle-bundle/7.0/manifest.json b/eightpoints/guzzle-bundle/7.0/manifest.json index 30baa5a5..075b637f 100644 --- a/eightpoints/guzzle-bundle/7.0/manifest.json +++ b/eightpoints/guzzle-bundle/7.0/manifest.json @@ -4,8 +4,5 @@ }, "copy-from-recipe": { "config/": "%CONFIG_DIR%/" - }, - "composer-scripts": { - "assets:install %PUBLIC_DIR%": "symfony-cmd" } } From 621982b06fffc68aa2a30569ccac8d33f7f4836e Mon Sep 17 00:00:00 2001 From: Florian Preusner Date: Tue, 9 Oct 2018 15:13:10 +0200 Subject: [PATCH 4/6] deactivated logging option --- .../guzzle-bundle/7.0/config/packages/eight_points_guzzle.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eightpoints/guzzle-bundle/7.0/config/packages/eight_points_guzzle.yaml b/eightpoints/guzzle-bundle/7.0/config/packages/eight_points_guzzle.yaml index 19c22080..ac211a6d 100644 --- a/eightpoints/guzzle-bundle/7.0/config/packages/eight_points_guzzle.yaml +++ b/eightpoints/guzzle-bundle/7.0/config/packages/eight_points_guzzle.yaml @@ -3,7 +3,7 @@ # https://github.com/8p/EightPointsGuzzleBundle/blob/master/src/Resources/doc/configuration-reference.md eight_points_guzzle: # (de)activate logging/profiler; default: %kernel.debug% - logging: true +# logging: true clients: my_client: From 55778b84da8850d38c347a6d45ab221f1c2a83ac Mon Sep 17 00:00:00 2001 From: Florian Preusner Date: Wed, 10 Oct 2018 14:44:02 +0200 Subject: [PATCH 5/6] deactivate plugins --- .../guzzle-bundle/7.0/config/packages/eight_points_guzzle.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eightpoints/guzzle-bundle/7.0/config/packages/eight_points_guzzle.yaml b/eightpoints/guzzle-bundle/7.0/config/packages/eight_points_guzzle.yaml index ac211a6d..5f545974 100644 --- a/eightpoints/guzzle-bundle/7.0/config/packages/eight_points_guzzle.yaml +++ b/eightpoints/guzzle-bundle/7.0/config/packages/eight_points_guzzle.yaml @@ -25,7 +25,7 @@ eight_points_guzzle: # Find plugins here: # https://github.com/8p/EightPointsGuzzleBundle#known-and-supported-plugins - plugin: + plugin: ~ # https://github.com/gregurco/GuzzleBundleOAuth2Plugin # oauth2: # base_uri: "https://example.com" From 2731657dfba14828cce8ba74f07d1f84e31b10b0 Mon Sep 17 00:00:00 2001 From: Florian Preusner Date: Sat, 13 Oct 2018 21:05:35 +0200 Subject: [PATCH 6/6] reverted some changes based on PR comments --- .../7.0/config/packages/eight_points_guzzle.yaml | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/eightpoints/guzzle-bundle/7.0/config/packages/eight_points_guzzle.yaml b/eightpoints/guzzle-bundle/7.0/config/packages/eight_points_guzzle.yaml index 5f545974..aa71cd83 100644 --- a/eightpoints/guzzle-bundle/7.0/config/packages/eight_points_guzzle.yaml +++ b/eightpoints/guzzle-bundle/7.0/config/packages/eight_points_guzzle.yaml @@ -2,13 +2,10 @@ # A full list of configuration options can be found here: # https://github.com/8p/EightPointsGuzzleBundle/blob/master/src/Resources/doc/configuration-reference.md eight_points_guzzle: - # (de)activate logging/profiler; default: %kernel.debug% -# logging: true - clients: my_client: # Write here the host where to do requests -# base_url: "http://target.url" + # base_url: "http://target.url" # Request options: http://docs.guzzlephp.org/en/stable/request-options.html options: @@ -26,10 +23,3 @@ eight_points_guzzle: # Find plugins here: # https://github.com/8p/EightPointsGuzzleBundle#known-and-supported-plugins plugin: ~ - # https://github.com/gregurco/GuzzleBundleOAuth2Plugin -# oauth2: -# base_uri: "https://example.com" -# token_url: "/oauth/token" -# client_id: "test-client-id" -# client_secret: "test-client-secret" # optional -# scope: "administration"