From b9e690bdfab02587450b318cca28b2caec1f6a58 Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Wed, 23 May 2018 15:23:52 +0200 Subject: [PATCH 1/2] [webpack-encore] use versioned assets --- .../1.0/config/packages/assets.yaml | 3 +++ symfony/webpack-encore-pack/1.0/manifest.json | 1 + .../webpack-encore-pack/1.0/webpack.config.js | 19 +++++++++++++------ 3 files changed, 17 insertions(+), 6 deletions(-) create mode 100644 symfony/webpack-encore-pack/1.0/config/packages/assets.yaml diff --git a/symfony/webpack-encore-pack/1.0/config/packages/assets.yaml b/symfony/webpack-encore-pack/1.0/config/packages/assets.yaml new file mode 100644 index 00000000..051d36dc --- /dev/null +++ b/symfony/webpack-encore-pack/1.0/config/packages/assets.yaml @@ -0,0 +1,3 @@ +framework: + assets: + json_manifest_path: '%kernel.project_dir%/public/build/manifest.json' diff --git a/symfony/webpack-encore-pack/1.0/manifest.json b/symfony/webpack-encore-pack/1.0/manifest.json index 0349dd45..d50fbce8 100644 --- a/symfony/webpack-encore-pack/1.0/manifest.json +++ b/symfony/webpack-encore-pack/1.0/manifest.json @@ -1,6 +1,7 @@ { "copy-from-recipe": { "assets/": "assets/", + "config/": "%CONFIG_DIR%/", "package.json": "package.json", "webpack.config.js": "webpack.config.js" }, diff --git a/symfony/webpack-encore-pack/1.0/webpack.config.js b/symfony/webpack-encore-pack/1.0/webpack.config.js index e36fa208..cc987d14 100644 --- a/symfony/webpack-encore-pack/1.0/webpack.config.js +++ b/symfony/webpack-encore-pack/1.0/webpack.config.js @@ -5,20 +5,27 @@ Encore .setOutputPath('public/build/') // the public path used by the web server to access the previous directory .setPublicPath('/build') + // the path inside the Symfony app, as given to the asset() function + .setManifestKeyPrefix('build/') + .cleanupOutputBeforeBuild() .enableSourceMaps(!Encore.isProduction()) - // uncomment to create hashed filenames (e.g. app.abc123.css) - // .enableVersioning(Encore.isProduction()) + + // the following line enables hashed filenames (e.g. app.abc123.css) + .enableVersioning(Encore.isProduction()) // uncomment to define the assets of the project - // .addEntry('js/app', './assets/js/app.js') - // .addStyleEntry('css/app', './assets/css/app.scss') + //.addEntry('js/app', './assets/js/app.js') + //.addStyleEntry('css/app', './assets/css/app.scss') + + // uncomment if you use TypeScript + //.enableTypeScriptLoader() // uncomment if you use Sass/SCSS files - // .enableSassLoader() + //.enableSassLoader() // uncomment for legacy applications that require $/jQuery as a global variable - // .autoProvidejQuery() + //.autoProvidejQuery() ; module.exports = Encore.getWebpackConfig(); From 261dfeaea437eba0b321dfb4d153d995ceede20b Mon Sep 17 00:00:00 2001 From: Ryan Weaver Date: Sun, 15 Jul 2018 14:40:19 -0400 Subject: [PATCH 2/2] tweaking language --- symfony/webpack-encore-pack/1.0/webpack.config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/symfony/webpack-encore-pack/1.0/webpack.config.js b/symfony/webpack-encore-pack/1.0/webpack.config.js index cc987d14..9b661c53 100644 --- a/symfony/webpack-encore-pack/1.0/webpack.config.js +++ b/symfony/webpack-encore-pack/1.0/webpack.config.js @@ -5,7 +5,7 @@ Encore .setOutputPath('public/build/') // the public path used by the web server to access the previous directory .setPublicPath('/build') - // the path inside the Symfony app, as given to the asset() function + // the public path you will use in Symfony's asset() function - e.g. asset('build/some_file.js') .setManifestKeyPrefix('build/') .cleanupOutputBeforeBuild()