skills/pbakaus_impeccable
1
0
Fork 0
mirror of https://github.com/pbakaus/impeccable.git synced 2026-09-12 06:06:37 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix: keep direction contracts out of production output (#673)

Browse Source 
Store direction contracts in development-only surface briefs and guard against browser-delivered leakage with regression coverage.

AI-assisted merge: reviewed and executed by Codex under maintainer direction.
This commit is contained in:
Morgan
2026-08-31 19:07:44 -04:00
committed by GitHub
parent ee1442d7af
commit 1130d00ebc
3 changed files with 44 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/skill-reference.test.mjs
+35
View File
@@ -7,6 +7,41 @@ import { fileURLToPath } from 'node:url';
const ROOT = fileURLToPath(new URL('..', import.meta.url));
describe('skill reference authoring contracts', () => {
it('keeps direction contracts in development-only surface briefs', () => {
const newWork = readFileSync(join(ROOT, 'skill/reference/new-work.md'), 'utf-8').replace(/\r\n?/g, '\n');
const recordDecision = newWork.match(/## 5\. Record the decision\n([\s\S]*?)\n## 6\./)?.[1] ?? '';
assert.match(recordDecision, /development-only contract/);
assert.match(recordDecision, /under `## Direction contract` in the relevant surface brief/);
assert.match(recordDecision, /read the brief once more/i);
assert.match(recordDecision, /all six contract blocks and the seed key/);
for (const block of ['THESIS', 'OWN-WORLD', 'STORY', 'FIRST VIEWPORT', 'FORM', 'FINISH']) {
assert.match(recordDecision, new RegExp(`${block}:`));
}
for (const browserArtifact of [
/HTML or framework comments/,
/hidden DOM/,
/<template>/,
/`data-\*` attributes/,
/serialized props or state/,
/React Server Component payloads/,
/client bundles/,
/metadata or JSON-LD/,
/accessibility-only text/,
]) {
assert.match(recordDecision, browserArtifact);
}
assert.match(recordDecision, /Never copy the direction contract into implementation source or any browser-delivered artifact/);
assert.doesNotMatch(newWork, /contract in the artifact's opening comment/);
assert.doesNotMatch(newWork, /survives the production build/);
assert.doesNotMatch(newWork, /grep the built output/);
assert.doesNotMatch(newWork, /emitted markup/);
assert.doesNotMatch(newWork, /first child of the document's body/);
});
it('keeps reduced-motion guidance on the animation build path', () => {
const animate = readFileSync(join(ROOT, 'skill/reference/animate.md'), 'utf-8').replace(/\r\n?/g, '\n');
const accessibility = animate.match(/## Accessibility and control\n([\s\S]*?)\n## Verify/)?.[1] ?? '';