Live v2: root manifest, mount-ack protocol, AST scaffolder, mechanical accept

A ground-up hardening of live mode, driven by a production session in a
nested-app monorepo that hit six distinct failure classes. Full design
rationale in docs/LIVE-REWRITE-PLAN.md; every Codex-reported failure now
has a mechanical fix and a regression test.

Roots: live/roots.mjs resolves appRoot/repoRoot/contextRoot once at boot
(keyed on dev-server configs, not monorepo brand markers), persists a
manifest, and every live CLI re-anchors onto it at startup, so a helper
run from the wrong directory can no longer fork session state. Context
files are discovered upward to the git root.

Render truth: variant_mounted / variant_mount_failed events give the
journal per-variant mount state; failures reach the agent's poll queue,
raise a persistent error card with Retry (no more localStorage wipe), and
an attach probe names root/dev-server mismatches explicitly. The browser
rehydrates from the server when localStorage is gone.

Svelte: the scaffolder now parses with the app's own svelte 5 compiler.
Control flow survives (an each collection crosses the contract as one
structured prop), keyed each blocks hydrate synthetic keys, and anything
a detached preview cannot support falls back to source-preview instead of
shipping a wrong scaffold. Preview modules live in per-publish revision
directories, defeating stale transform caches.

Accept: CSS is reconciled, not appended. Matching selectors are replaced,
params bake from params.json kinds, the compiler's unused-selector pass
prunes superseded rules (pre-existing dead rules protected), a selector-
loss postcondition refuses any write that would drop hand-written rules,
and live-complete refuses to finish while live plumbing remains in source.

Also: framework registry (live/frameworks/) with a crash-safe injection
journal, session-store snapshot caching with read-only reads, protocol
enum consolidation, steer Send button, honest DESIGN-panel empty states.

Testing: new unit suites (roots, AST scaffolder, accept CSS, accept
pipeline, framework conformance); e2e now fails on preview-tree 404s,
proves computed-style mount for every variant, drives the Tune panel
through baked params, and injects failures (broken mounts, republish,
storage loss). New runtime fixtures: monorepo-nested-vite (repo root !=
app root) and vite8-sveltekit-stateful (each blocks + state). Nightly
full-matrix cron. An independent adversarial review pass preceded this
commit; its blocker and major findings are fixed and regression-tested.

This work was produced with AI assistance (Claude Code).

Co-Authored-By: Claude Code <noreply@anthropic.com>
This commit is contained in:
Paul Bakaus
2026-07-27 15:09:40 -07:00
co-authored by Claude Code
parent 839dd10079
commit 17dabf4b7e
72 changed files with 9254 additions and 862 deletions
+53 -23
View File
@@ -21,10 +21,11 @@ import { execSync } from 'node:child_process';
import fs from 'node:fs';
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import { loadContext, resolveTargetSelection } from './context.mjs';
import { resolveTargetSelection } from './context.mjs';
import { resolveFiles } from './live-inject.mjs';
import { readLiveServerInfo } from './lib/impeccable-paths.mjs';
import { resolveLiveTarget } from './live-target.mjs';
import { resolveRoots, writeRootsManifest } from './live/roots.mjs';
const __dirname = path.dirname(fileURLToPath(import.meta.url));
@@ -60,6 +61,8 @@ The agent should then:
process.exit(0);
}
// Legacy workspace-monorepo selection first: it carries richer candidate
// metadata (context inheritance status) than the roots scan.
const targetSelection = resolveTargetSelection(liveTarget.originalCwd, liveTarget.targetOptions);
if (targetSelection) {
console.log(JSON.stringify({
@@ -71,11 +74,31 @@ The agent should then:
process.exit(0);
}
const ctx = loadContext(liveTarget.originalCwd, liveTarget.targetOptions);
const activeCwd = ctx.projectRoot;
const rootsResult = resolveRoots({
cwd: liveTarget.originalCwd,
targetPath: liveTarget.absoluteTargetPath,
});
if (rootsResult.selection) {
console.log(JSON.stringify({
ok: false,
error: 'target_selection_required',
targetCandidates: rootsResult.selection.candidates,
hint: 'Several apps with a dev-server config exist. Ask the user which one to use, then rerun with --target <path into that app>.',
}, null, 2));
process.exit(0);
}
const roots = rootsResult.manifest;
const activeCwd = roots.appRoot;
const outputTargetPath = liveTarget.targetPath || null;
const missingContext = missingLiveContext(ctx);
// Gate on readable CONTENT, not path existence, so an empty or unreadable
// PRODUCT.md routes to init instead of passing the gate and then reporting
// hasProduct: false in the same payload.
const product = safeRead(roots.productPath);
const design = safeRead(roots.designPath);
const missingContext = [];
if (!product) missingContext.push('PRODUCT.md');
if (!design) missingContext.push('DESIGN.md');
if (missingContext.length > 0) {
console.log(JSON.stringify({
ok: false,
@@ -83,14 +106,18 @@ The agent should then:
missing: missingContext,
nextCommand: missingContext.includes('PRODUCT.md') ? 'init' : 'document',
targetPath: outputTargetPath,
projectRoot: ctx.projectRoot,
repoRoot: ctx.repoRoot,
productPath: ctx.productPath,
designPath: ctx.designPath,
projectRoot: roots.appRoot,
repoRoot: roots.repoRoot,
productPath: relOrNull(liveTarget.originalCwd, roots.productPath),
designPath: relOrNull(liveTarget.originalCwd, roots.designPath),
}, null, 2));
process.exit(0);
}
// Persist the decision before anything else spawns, so every helper the
// agent runs later (from any cwd inside the repo) lands on the same roots.
writeRootsManifest(roots);
// 1. Check config (fail fast if missing — no point starting anything else)
const checkOut = runScript('live-inject.mjs', ['--check'], { cwd: activeCwd });
const checkResult = safeParse(checkOut);
@@ -98,8 +125,8 @@ The agent should then:
console.log(JSON.stringify({
...(checkResult || { ok: false, error: 'check_failed', raw: checkOut }),
targetPath: outputTargetPath,
projectRoot: ctx.projectRoot,
repoRoot: ctx.repoRoot,
projectRoot: roots.appRoot,
repoRoot: roots.repoRoot,
}));
process.exit(0);
}
@@ -143,22 +170,25 @@ The agent should then:
liveConfigPath: checkResult.path,
configDrift: drift,
targetPath: outputTargetPath,
projectRoot: ctx.projectRoot,
repoRoot: ctx.repoRoot,
hasProduct: ctx.hasProduct,
product: ctx.product,
productPath: ctx.productPath,
hasDesign: ctx.hasDesign,
design: ctx.design,
designPath: ctx.designPath,
projectRoot: roots.appRoot,
repoRoot: roots.repoRoot,
roots,
hasProduct: !!product,
product,
productPath: relOrNull(liveTarget.originalCwd, roots.productPath),
hasDesign: !!design,
design,
designPath: relOrNull(liveTarget.originalCwd, roots.designPath),
}, null, 2));
}
function missingLiveContext(ctx) {
const missing = [];
if (!ctx.hasProduct) missing.push('PRODUCT.md');
if (!ctx.hasDesign) missing.push('DESIGN.md');
return missing;
function safeRead(p) {
if (!p) return null;
try { return fs.readFileSync(p, 'utf-8'); } catch { return null; }
}
function relOrNull(base, p) {
return p ? path.relative(base, p) : null;
}
/**