From 1bcdf80f9140f63c528e514f858b9468c2055687 Mon Sep 17 00:00:00 2001
From: Paul Bakaus <paul.bakaus@gmail.com>
Date: Mon, 31 Aug 2026 23:27:49 -0400
Subject: [PATCH] Fix radius var fallback detection (#687)

Strip closing var() parentheses before resolving fallback radius tokens, preserving on-scale values and actionable ignore values.

AI-assisted change: implemented with Codex under @pbakaus direction.
---
 cli/engine/design-system.mjs |  4 +++-
 tests/design-system.test.mjs | 19 +++++++++++++++++++
 2 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/cli/engine/design-system.mjs b/cli/engine/design-system.mjs
index 28e01b1d2..7b7e588e9 100644
--- a/cli/engine/design-system.mjs
+++ b/cli/engine/design-system.mjs
@@ -995,7 +995,9 @@ function extractRadiusTokens(value) {
   return String(value || '')
     .replace(/\s*\/\s*/g, ' ')
     .split(/\s+/)
-    .map(token => token.trim())
+    // var() fallbacks leave the closing parenthesis on the final token. Strip
+    // it before length resolution so `8px)` is not treated as unitless 8rem.
+    .map(token => token.trim().replace(/\)+$/, ''))
     .filter(Boolean);
 }
 
diff --git a/tests/design-system.test.mjs b/tests/design-system.test.mjs
index ebd83243f..e6deba854 100644
--- a/tests/design-system.test.mjs
+++ b/tests/design-system.test.mjs
@@ -389,6 +389,25 @@ describe('checkSourceDesignSystem()', () => {
     );
   });
 
+  it('judges var() radius fallbacks without keeping the closing parenthesis', () => {
+    const designSystem = normalizeDesignSystem({
+      frontmatter: { rounded: { md: '8px' } },
+    });
+    const findings = checkSourceDesignSystem(`
+.good {
+  border-radius: var(--radius-md, 8px);
+}
+.bad {
+  border-radius: var(--radius-custom, 18px);
+}
+`, '/tmp/radius-fallbacks.css', { designSystem });
+
+    assert.deepEqual(
+      findings.map((item) => [item.antipattern, item.ignoreValue]),
+      [['design-system-radius', '18px']],
+    );
+  });
+
   it('strips CSS priority markers before checking font-family declarations', () => {
     const designSystem = sampleDesignSystem();
     const findings = checkSourceDesignSystem(`