skills/pbakaus_impeccable
1
0
Fork 0
mirror of https://github.com/pbakaus/impeccable.git synced 2026-09-19 17:46:36 +03:00
Code Issues Packages Projects Releases Wiki Activity

Define the agent embed behavior when the plugin-root variable is unexpanded

Browse Source 
The current plugins reference substitutes ${CLAUDE_PLUGIN_ROOT} inline
anywhere in plugin skill and agent content, superseding the hook-only
note this module carried from earlier research (review finding cited it).
The module header now states the actual contract, and because Grok Build
reads the same subtree with its own substitution behavior, the agent's
embed instruction gains a defined fallback: when the script path is
unreachable, the prompt survives as an <asset>.prompt.txt sidecar and the
manifest tells the parent, whose thread can resolve the script and embed
properly. A new build guard fails when an agent file carries an
unresolvable path form or an embed instruction whose fallback anchor
drifted.

Drafted with AI assistance, reviewed by a maintainer.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Abdul Wahab
2026-08-28 05:18:06 +05:00
co-authored by Cursor
parent d28a9dc31c
commit 3611594092
4 changed files with 123 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/plugin-paths.test.js
+62 -5
View File
@@ -20,7 +20,9 @@ import {
rewritePluginAgentMarkdown,
rewritePluginMarkdownTree,
verifyPluginSkillRewrite,
verifyPluginAgentRewrite,
CLAUDE_PROJECT_SCRIPTS_PATH,
AGENT_EMBED_FALLBACK,
} from '../scripts/lib/plugin-paths.js';
describe('rewritePluginMarkdown', () => {
@@ -94,25 +96,80 @@ describe('rewritePluginMarkdown', () => {
});
describe('rewritePluginAgentMarkdown', () => {
// The real source sentence shape: command, purpose clause, next sentence.
const sourceStep =
'after every generation, run `node .claude/skills/impeccable/scripts/embed-prompt.mjs <asset> ' +
'--prompt "<the prompt used>"` so the prompt lives inside the image itself. The build thread ' +
'composes what you made.';
test('rewrites agent instructions to the quoted plugin-root variable form', () => {
// A spawned agent never loads SKILL.md, so the <skill-base-dir> token
// Setup defines is unresolvable in its prompt. Claude Code substitutes
// ${CLAUDE_PLUGIN_ROOT} inline in plugin agent content.
const input =
'run `node .claude/skills/impeccable/scripts/embed-prompt.mjs <asset> --prompt "<the prompt used>"`';
expect(rewritePluginAgentMarkdown(input)).toBe(
const output = rewritePluginAgentMarkdown(sourceStep);
expect(output).toContain(
'run `node "${CLAUDE_PLUGIN_ROOT}/skills/impeccable/scripts/embed-prompt.mjs" <asset> --prompt "<the prompt used>"`',
);
});
test('appends the sidecar fallback as its own sentence, not mid-sentence', () => {
const output = rewritePluginAgentMarkdown(sourceStep);
// The fallback follows the full embed sentence and precedes the next one.
expect(output).toContain(
`so the prompt lives inside the image itself.${AGENT_EMBED_FALLBACK} The build thread`,
);
});
test('never emits the skill-base-dir token into an agent file', () => {
const input = 'node .claude/skills/impeccable/scripts/embed-prompt.mjs asset.png';
const output = rewritePluginAgentMarkdown(input);
const output = rewritePluginAgentMarkdown(sourceStep);
expect(output).not.toContain('<skill-base-dir>');
expect(output).not.toContain(CLAUDE_PROJECT_SCRIPTS_PATH);
});
});
describe('verifyPluginAgentRewrite', () => {
let root;
beforeEach(() => {
root = fs.mkdtempSync(path.join(os.tmpdir(), 'impeccable-agent-verify-'));
});
afterEach(() => {
fs.rmSync(root, { recursive: true, force: true });
});
const writeAgent = (contents) => {
const p = path.join(root, 'agent.md');
fs.writeFileSync(p, contents);
return p;
};
const sourceStep =
'run `node .claude/skills/impeccable/scripts/embed-prompt.mjs <asset> --prompt "<p>"` ' +
'so the prompt lives inside the image itself. Next sentence.';
test('accepts a correctly rewritten agent file', () => {
const p = writeAgent(rewritePluginAgentMarkdown(sourceStep));
expect(() => verifyPluginAgentRewrite(p)).not.toThrow();
});
test('fails when an unresolvable path form survives', () => {
const p = writeAgent('run `node "<skill-base-dir>/scripts/embed-prompt.mjs"` please.');
expect(() => verifyPluginAgentRewrite(p)).toThrow(/cannot\s+resolve/);
});
test('fails when the embed instruction lost its fallback sentence', () => {
// Simulate a source rewording that breaks the fallback anchor: the
// sentence-splice regex no-ops when no period follows the command.
const reworded = sourceStep.replace(
' so the prompt lives inside the image itself. Next sentence.',
' -- no closing period',
);
const p = writeAgent(rewritePluginAgentMarkdown(reworded));
expect(() => verifyPluginAgentRewrite(p)).toThrow(/sidecar/);
});
});
describe('rewritePluginMarkdownTree', () => {
let root;