mirror of
https://github.com/pbakaus/impeccable.git
synced 2026-09-14 15:16:35 +03:00
fix: address PR review bot findings
cursor[bot] findings on #433: - Nightly schedule no longer enables the paid opt-in suites: a schedule event has no diff base, so the change-detection fallback flagged every file-triggered suite, which would have billed the skill-behavior, accept-cleanup, and deepseek LLM suites nightly. The plan now pins the schedule event to deterministic suites plus the full live-e2e matrix, with a regression test. - Dismissing the mount-error card no longer strands the session: while the bar is hidden in GENERATING the card is the only recovery surface, so dismiss now returns the state machine to PICKING (session and server truth survive for a later republish). This work was produced with AI assistance (Claude Code). Co-Authored-By: Claude Code <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Code
parent
17dabf4b7e
commit
4ac54bebee
@@ -5970,7 +5970,16 @@
|
||||
});
|
||||
dismiss.textContent = '×';
|
||||
dismiss.setAttribute('aria-label', 'Dismiss');
|
||||
dismiss.addEventListener('click', (e) => { e.stopPropagation(); clearMountErrorCard(); });
|
||||
dismiss.addEventListener('click', (e) => {
|
||||
e.stopPropagation();
|
||||
clearMountErrorCard();
|
||||
// The card was the only recovery affordance while the bar is hidden;
|
||||
// dismissing it must hand the user back a usable surface. PICKING
|
||||
// reactivates the global mark and the picker. The saved session and
|
||||
// server truth survive, so a later republish (SSE `done`) still
|
||||
// resurrects the comparison through the normal handlers.
|
||||
if (state === 'GENERATING') setLiveState('PICKING');
|
||||
});
|
||||
head.appendChild(dismiss);
|
||||
card.appendChild(head);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user