mirror of
https://github.com/pbakaus/impeccable.git
synced 2026-09-14 23:26:39 +03:00
Visual decisions and default visualization
Paul's design, three pieces: serve-question.mjs: the world decision presented as a themed page instead of a text prompt. The script serves an impeccable-styled option board (assigned direction leading with THE ROLL badge, dealt challengers as alternates carrying their QUALITY BAR cards, re-roll and steer built in), prints the URL, opens the browser, and blocks until the user chooses; the answer lands on stdout as ANSWER JSON, so the shell call itself is the wait and no harness machinery is needed. Local images are served by the ephemeral server; nothing leaves the machine. generate-image.mjs + context.mjs IMAGE_GEN_AVAILABLE: when an OpenAI key is in the environment, context reports that image generation works even without a harness-native tool (gpt-image-2, billed to the user's key, stated before first use; Google skipped by decision). Harness-native tools always win when present. new-work.md: visualize-before-build is now the default whenever any image generation exists, not a codex.md special case; the attended presentation prefers the visual decision page and falls back to the structured question tool. Evals keep the unattended path untouched. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Fable 5
parent
4da6729075
commit
5612cdf45b
@@ -1127,6 +1127,7 @@ async function cli() {
|
||||
appendSurfaceBriefContext(parts, ctx);
|
||||
parts.push(buildResolvedContextDirective(ctx, cliOptions, { targetExists }));
|
||||
appendDetectorFallback(parts, ctx);
|
||||
appendImageGenDirective(parts);
|
||||
if (shouldWarnMissingTarget(ctx, targetProvided, targetExists)) {
|
||||
parts.push(buildMissingTargetDirective());
|
||||
}
|
||||
@@ -1141,6 +1142,7 @@ async function cli() {
|
||||
appendSurfaceBriefContext(parts, ctx);
|
||||
parts.push(buildResolvedContextDirective(ctx, cliOptions, { targetExists }));
|
||||
appendDetectorFallback(parts, ctx);
|
||||
appendImageGenDirective(parts);
|
||||
if (shouldWarnMissingTarget(ctx, targetProvided, targetExists)) {
|
||||
parts.push(buildMissingTargetDirective());
|
||||
}
|
||||
@@ -1243,6 +1245,20 @@ function automaticHookMode(ctx) {
|
||||
return 'none';
|
||||
}
|
||||
|
||||
|
||||
// Image generation availability: harness-native tools always win, but when the
|
||||
// environment carries an OpenAI key the API fallback works everywhere. The
|
||||
// flag only reports capability; generate-image.mjs states cost before use.
|
||||
function appendImageGenDirective(parts) {
|
||||
if (!process.env.OPENAI_API_KEY) return;
|
||||
const scriptsPath = path.dirname(fileURLToPath(import.meta.url));
|
||||
parts.push([
|
||||
'IMAGE_GEN_AVAILABLE: An OpenAI key is present, so image generation works even without a harness-native image tool:',
|
||||
`\`node ${scriptsPath}/generate-image.mjs --prompt "..." --out <file>\` (gpt-image-2, billed to the user's key; say so before the first render).`,
|
||||
'Prefer the harness-native image tool when one exists. Visualizing a direction before building it measurably strengthens the result.',
|
||||
].join(' '));
|
||||
}
|
||||
|
||||
// reference/craft-floor.md carries the detector-blind reflexes on every build,
|
||||
// so the only gap left here is the mechanical pass. A hook covers it, per-edit
|
||||
// or Stop; a session without one has to run the detector by hand. The detector
|
||||
|
||||
@@ -0,0 +1,54 @@
|
||||
#!/usr/bin/env node
|
||||
/**
|
||||
* API image generation fallback: renders a mock or world board with the
|
||||
* user's own OpenAI key when the harness has no native image generation.
|
||||
*
|
||||
* context.mjs reports availability (it checks OPENAI_API_KEY); harness-native
|
||||
* generation always wins when present. This uses gpt-image-2 and spends the
|
||||
* user's API credit (roughly $0.05-0.25 per image at default quality), so the
|
||||
* skill states that before the first call in a session.
|
||||
*
|
||||
* node generate-image.mjs --prompt "..." --out mock.png [--size 1536x1024] [--quality medium]
|
||||
* node generate-image.mjs --prompt-file prompt.txt --out mock.png
|
||||
*/
|
||||
import fs from 'node:fs';
|
||||
|
||||
function arg(name, fallback = null) {
|
||||
const i = process.argv.indexOf(`--${name}`);
|
||||
if (i === -1) return fallback;
|
||||
const v = process.argv[i + 1];
|
||||
return v && !v.startsWith('--') ? v : fallback;
|
||||
}
|
||||
|
||||
const key = process.env.OPENAI_API_KEY;
|
||||
if (!key) {
|
||||
console.error('generate-image: OPENAI_API_KEY is not set; use the harness-native image tool instead.');
|
||||
process.exit(1);
|
||||
}
|
||||
const promptFile = arg('prompt-file');
|
||||
const prompt = promptFile ? fs.readFileSync(promptFile, 'utf8') : arg('prompt');
|
||||
const out = arg('out');
|
||||
if (!prompt || !out) {
|
||||
console.error('generate-image: --prompt (or --prompt-file) and --out are required.');
|
||||
process.exit(1);
|
||||
}
|
||||
const size = arg('size', '1536x1024');
|
||||
const quality = arg('quality', 'medium');
|
||||
|
||||
const response = await fetch('https://api.openai.com/v1/images/generations', {
|
||||
method: 'POST',
|
||||
headers: { Authorization: `Bearer ${key}`, 'content-type': 'application/json' },
|
||||
body: JSON.stringify({ model: 'gpt-image-2', prompt, size, quality, n: 1 }),
|
||||
});
|
||||
if (!response.ok) {
|
||||
console.error(`generate-image: API error ${response.status}: ${(await response.text()).slice(0, 300)}`);
|
||||
process.exit(1);
|
||||
}
|
||||
const json = await response.json();
|
||||
const b64 = json?.data?.[0]?.b64_json;
|
||||
if (!b64) {
|
||||
console.error('generate-image: no image in response');
|
||||
process.exit(1);
|
||||
}
|
||||
fs.writeFileSync(out, Buffer.from(b64, 'base64'));
|
||||
console.log(`IMAGE: ${out} (${size}, ${quality}, gpt-image-2, billed to your OpenAI key)`);
|
||||
@@ -0,0 +1,195 @@
|
||||
#!/usr/bin/env node
|
||||
/**
|
||||
* Visual question server: present a decision to the user as a themed page
|
||||
* instead of a plain-text prompt, then block until they answer.
|
||||
*
|
||||
* The script IS the wait: run it via the shell, it serves the page, prints
|
||||
* the URL (and tries to open the default browser), and does not exit until
|
||||
* the user chooses. The answer lands on stdout as one line:
|
||||
*
|
||||
* ANSWER: {"optionId":"...","steer":"..."}
|
||||
*
|
||||
* Exit codes: 0 answered · 2 timed out or closed without answering.
|
||||
*
|
||||
* Payload (JSON file via --payload, or stdin):
|
||||
* {
|
||||
* "title": "Choose the visual world",
|
||||
* "question": "The roll assigned Fillmore Handbill. Keep it, take an alternate, or re-roll.",
|
||||
* "options": [
|
||||
* {
|
||||
* "id": "assigned", // returned verbatim
|
||||
* "label": "Fillmore Handbill",
|
||||
* "kicker": "THE ROLL", // optional badge; the assigned option leads
|
||||
* "lineage": "1966-71 Fillmore ...", // optional
|
||||
* "body": "why it fits, first viewport, risk ...", // optional, plain text
|
||||
* "hero": "https://... or /abs/path.webp", // optional image
|
||||
* "board": "https://... or /abs/path.webp" // optional secondary image
|
||||
* }, ...
|
||||
* ],
|
||||
* "reroll": true, // adds a re-roll action (returns {"optionId":"reroll"})
|
||||
* "steer": true // adds a free-text steer field returned with any answer
|
||||
* }
|
||||
*
|
||||
* Options render as large cards: hero render first when present (the dealt
|
||||
* catalog worlds already have cards; grounded directions may present text-only
|
||||
* or a freshly generated mock). Local image paths are served by this server;
|
||||
* nothing is uploaded anywhere.
|
||||
*
|
||||
* node serve-question.mjs --payload question.json [--timeout 900] [--no-open] [--port 0]
|
||||
*/
|
||||
import http from 'node:http';
|
||||
import fs from 'node:fs';
|
||||
import path from 'node:path';
|
||||
import { spawn } from 'node:child_process';
|
||||
|
||||
function arg(name, fallback = null) {
|
||||
const i = process.argv.indexOf(`--${name}`);
|
||||
if (i === -1) return fallback;
|
||||
const v = process.argv[i + 1];
|
||||
return v && !v.startsWith('--') ? v : fallback;
|
||||
}
|
||||
const hasFlag = (name) => process.argv.includes(`--${name}`);
|
||||
|
||||
const payloadPath = arg('payload');
|
||||
const timeoutSec = Number(arg('timeout', '900'));
|
||||
const portArg = Number(arg('port', '0'));
|
||||
|
||||
let raw;
|
||||
if (payloadPath) raw = fs.readFileSync(payloadPath, 'utf8');
|
||||
else raw = fs.readFileSync(0, 'utf8');
|
||||
const payload = JSON.parse(raw);
|
||||
if (!payload || !Array.isArray(payload.options) || payload.options.length === 0) {
|
||||
console.error('serve-question: payload needs an options array');
|
||||
process.exit(1);
|
||||
}
|
||||
|
||||
// Local images are served through /img/<index>/<kind>; remote URLs pass through.
|
||||
const localImages = [];
|
||||
function imageSrc(value) {
|
||||
if (!value) return null;
|
||||
if (/^https?:\/\//.test(value)) return value;
|
||||
const abs = path.resolve(value);
|
||||
if (!fs.existsSync(abs)) return null;
|
||||
localImages.push(abs);
|
||||
return `/img/${localImages.length - 1}`;
|
||||
}
|
||||
const options = payload.options.map((option) => ({
|
||||
...option,
|
||||
heroSrc: imageSrc(option.hero),
|
||||
boardSrc: imageSrc(option.board),
|
||||
}));
|
||||
|
||||
const esc = (s) => String(s ?? '').replace(/[&<>"]/g, (c) => ({ '&': '&', '<': '<', '>': '>', '"': '"' }[c]));
|
||||
|
||||
function page() {
|
||||
const cards = options.map((option, index) => `
|
||||
<article class="card${index === 0 ? ' lead' : ''}" data-id="${esc(option.id)}">
|
||||
${option.kicker ? `<span class="kicker">${esc(option.kicker)}</span>` : ''}
|
||||
${option.heroSrc ? `<img class="hero" src="${esc(option.heroSrc)}" alt="">` : '<div class="hero hero-blank"></div>'}
|
||||
<div class="body">
|
||||
<h2>${esc(option.label)}</h2>
|
||||
${option.lineage ? `<p class="lineage">${esc(option.lineage)}</p>` : ''}
|
||||
${option.body ? `<p class="detail">${esc(option.body)}</p>` : ''}
|
||||
${option.boardSrc ? `<details><summary>design-system board</summary><img src="${esc(option.boardSrc)}" alt=""></details>` : ''}
|
||||
<button class="choose" data-id="${esc(option.id)}">Build this</button>
|
||||
</div>
|
||||
</article>`).join('\n');
|
||||
return `<!doctype html>
|
||||
<meta charset="utf-8"><meta name="viewport" content="width=device-width,initial-scale=1">
|
||||
<title>${esc(payload.title || 'impeccable · decision')}</title>
|
||||
<style>
|
||||
:root { color-scheme: dark; }
|
||||
* { box-sizing: border-box; margin: 0; }
|
||||
body { background: #0c0b09; color: #efe9dc; font: 15px/1.55 ui-sans-serif, system-ui, sans-serif; padding: 3rem clamp(1rem, 5vw, 4rem); }
|
||||
header { max-width: 68rem; margin: 0 auto 2.5rem; }
|
||||
header .mark { color: #c8a24a; font-weight: 700; letter-spacing: .18em; font-size: .72rem; text-transform: uppercase; }
|
||||
h1 { font-size: clamp(1.5rem, 3vw, 2.2rem); line-height: 1.15; margin-top: .6rem; }
|
||||
.question { color: #b7ad99; margin-top: .7rem; max-width: 48rem; }
|
||||
.grid { display: grid; gap: 1.5rem; grid-template-columns: repeat(auto-fit, minmax(min(24rem, 100%), 1fr)); max-width: 90rem; margin: 0 auto; }
|
||||
.card { background: #14120e; border: 1px solid #2a261e; border-radius: 10px; overflow: hidden; display: flex; flex-direction: column; }
|
||||
.card.lead { border-color: #c8a24a; box-shadow: 0 1px 0 #c8a24a inset; }
|
||||
.kicker { position: absolute; margin: .8rem; background: #c8a24a; color: #14120e; font-size: .68rem; font-weight: 700; letter-spacing: .14em; padding: .25rem .6rem; border-radius: 3px; }
|
||||
.card { position: relative; }
|
||||
img.hero { width: 100%; aspect-ratio: 16/9; object-fit: cover; display: block; background: #1b1812; }
|
||||
.hero-blank { width: 100%; aspect-ratio: 16/9; background: repeating-linear-gradient(135deg, #17140f 0 14px, #14120e 14px 28px); }
|
||||
.body { padding: 1.1rem 1.2rem 1.3rem; display: flex; flex-direction: column; gap: .55rem; flex: 1; }
|
||||
h2 { font-size: 1.12rem; }
|
||||
.lineage { color: #c8a24a; font-size: .8rem; letter-spacing: .04em; }
|
||||
.detail { color: #b7ad99; font-size: .88rem; white-space: pre-wrap; }
|
||||
details { font-size: .8rem; color: #b7ad99; } details img { width: 100%; margin-top: .5rem; border-radius: 6px; }
|
||||
button.choose { margin-top: auto; align-self: start; background: #efe9dc; color: #14120e; border: 0; font: inherit; font-weight: 650; padding: .55rem 1.1rem; border-radius: 6px; cursor: pointer; }
|
||||
button.choose:hover { background: #c8a24a; }
|
||||
footer { max-width: 68rem; margin: 2.2rem auto 0; display: flex; gap: 1rem; align-items: center; flex-wrap: wrap; }
|
||||
#steer { flex: 1; min-width: 16rem; background: #14120e; color: #efe9dc; border: 1px solid #2a261e; border-radius: 6px; padding: .55rem .8rem; font: inherit; }
|
||||
#reroll { background: none; border: 1px solid #2a261e; color: #b7ad99; font: inherit; padding: .55rem 1.1rem; border-radius: 6px; cursor: pointer; }
|
||||
#reroll:hover { border-color: #c8a24a; color: #c8a24a; }
|
||||
.done { text-align: center; padding: 6rem 1rem; font-size: 1.2rem; }
|
||||
</style>
|
||||
<header>
|
||||
<div class="mark">impeccable</div>
|
||||
<h1>${esc(payload.title || 'Choose a direction')}</h1>
|
||||
${payload.question ? `<p class="question">${esc(payload.question)}</p>` : ''}
|
||||
</header>
|
||||
<main class="grid">${cards}</main>
|
||||
<footer>
|
||||
${payload.steer ? '<input id="steer" placeholder="Optional steer: what should be different or kept?">' : ''}
|
||||
${payload.reroll ? '<button id="reroll">Re-roll: none of these</button>' : ''}
|
||||
</footer>
|
||||
<script>
|
||||
const steer = () => document.getElementById('steer')?.value || '';
|
||||
async function answer(optionId) {
|
||||
await fetch('/answer', { method: 'POST', headers: { 'content-type': 'application/json' }, body: JSON.stringify({ optionId, steer: steer() }) });
|
||||
document.body.innerHTML = '<div class="done">Choice recorded. You can close this tab; the agent is resuming.</div>';
|
||||
}
|
||||
document.querySelectorAll('button.choose').forEach(b => b.addEventListener('click', () => answer(b.dataset.id)));
|
||||
document.getElementById('reroll')?.addEventListener('click', () => answer('reroll'));
|
||||
</script>`;
|
||||
}
|
||||
|
||||
const server = http.createServer((req, res) => {
|
||||
if (req.method === 'GET' && req.url === '/') {
|
||||
res.writeHead(200, { 'content-type': 'text/html; charset=utf-8' });
|
||||
res.end(page());
|
||||
return;
|
||||
}
|
||||
const imageMatch = req.method === 'GET' && req.url?.match(/^\/img\/(\d+)$/);
|
||||
if (imageMatch) {
|
||||
const abs = localImages[Number(imageMatch[1])];
|
||||
if (!abs) { res.writeHead(404); res.end(); return; }
|
||||
const type = abs.endsWith('.webp') ? 'image/webp' : abs.endsWith('.png') ? 'image/png' : 'image/jpeg';
|
||||
res.writeHead(200, { 'content-type': type });
|
||||
fs.createReadStream(abs).pipe(res);
|
||||
return;
|
||||
}
|
||||
if (req.method === 'POST' && req.url === '/answer') {
|
||||
let body = '';
|
||||
req.on('data', (chunk) => { body += chunk; });
|
||||
req.on('end', () => {
|
||||
res.writeHead(200, { 'content-type': 'application/json' });
|
||||
res.end('{"ok":true}');
|
||||
let parsed = {};
|
||||
try { parsed = JSON.parse(body); } catch { /* empty steer */ }
|
||||
console.log(`ANSWER: ${JSON.stringify({ optionId: parsed.optionId ?? null, steer: parsed.steer ?? '' })}`);
|
||||
setTimeout(() => process.exit(0), 150);
|
||||
});
|
||||
return;
|
||||
}
|
||||
res.writeHead(404); res.end();
|
||||
});
|
||||
|
||||
server.listen(portArg, '127.0.0.1', () => {
|
||||
const { port } = server.address();
|
||||
const url = `http://127.0.0.1:${port}/`;
|
||||
console.log(`QUESTION URL: ${url}`);
|
||||
console.log('Waiting for the user to choose in the browser (Ctrl-C aborts)...');
|
||||
if (!hasFlag('no-open')) {
|
||||
const opener = process.platform === 'darwin' ? 'open' : process.platform === 'win32' ? 'start' : 'xdg-open';
|
||||
try { spawn(opener, [url], { stdio: 'ignore', detached: true }).unref(); } catch { /* URL printed anyway */ }
|
||||
}
|
||||
if (timeoutSec > 0) {
|
||||
setTimeout(() => {
|
||||
console.log('serve-question: timed out with no answer');
|
||||
process.exit(2);
|
||||
}, timeoutSec * 1000).unref?.();
|
||||
}
|
||||
});
|
||||
Reference in New Issue
Block a user