Fix: report removed launcher downloads accurately (#741)

* Fix: distinguish removed launcher downloads from checksum failures

Related to #740; keep the antivirus investigation open. Add executable launcher regressions and a native Windows CI lane. AI assistance: prepared with Codex under Paul Bakaus direction.

* Fix: diagnose downloads removed during cache placement

Cover removal and truncation around rename and preserve fail-closed behavior through cache placement. AI-assisted under maintainer direction.

* Test Windows launcher hash and placement failures

Inject failures at command boundaries in a staged test copy while retaining real launcher control flow. Cover both platforms with the same assertions. AI-assisted under maintainer direction.
This commit is contained in:
Paul Bakaus
2026-09-05 11:30:19 -07:00
committed by GitHub
parent 381d52b38f
commit 6e61113e3c
5 changed files with 236 additions and 7 deletions
+14
View File
@@ -188,6 +188,20 @@ jobs:
- run: cargo build --workspace --all-targets
- run: cargo test --workspace --no-fail-fast
launcher-windows:
runs-on: windows-latest
needs: changes
if: needs.changes.outputs.core == 'true'
steps:
- name: Checkout repository
uses: actions/checkout@v7
- name: Setup Node
uses: actions/setup-node@v7
with:
node-version: 24
- name: Exercise Windows launcher downloads and verification
run: node --test tests/launcher-download.test.mjs
# Behavior gate: replays the tests/oracle/ goldens against a release build
# of the engine from THIS checkout (so a PR is judged on its own source,
# not on the last published binary). Without this job the oracle only ever