skills/pbakaus_impeccable
1
0
Fork 0
mirror of https://github.com/pbakaus/impeccable.git synced 2026-09-11 21:57:14 +03:00
Code Issues Packages Projects Releases Wiki Activity

Probe the import the hook actually uses, and fail closed on rejection

Browse Source 
Greptile flagged that the probe does not enforce the Node 22 engines floor.
Two parts to that, and they land differently.

The real defect is narrower and worse than stated: the hook closure imports
`node:fs`, `node:os`, `node:path` and `node:url`, and the `node:` scheme needs
14.18, so a bare `import('fs')` probe passed on 12 and 13 and those runtimes
then died on the real import, which is the banner this branch exists to remove.
Probing `node:fs` closes that. The added `.catch(()=>process.exit(1))` is load
bearing rather than tidiness: before Node 15 an unhandled rejection is only a
warning and the process still exits 0, so a rejected probe would have read as a
pass on exactly the versions in question.

Not enforcing 22 is deliberate and stays. The probe asks whether this runtime
can load our code, not whether it is a supported one, so a 14.18-to-21 runtime
that works today keeps working rather than being silently switched off. The
notice names 22 because that is the version worth installing, and it only ever
reaches someone whose runtime already failed the probe, so no user is shown a
threshold that contradicts what ran.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Abdul Wahab
2026-07-26 21:20:26 +05:00
co-authored by Claude Opus 5
parent 4f999ceff8
commit 86cdf528c5
7 changed files with 25 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/lib/transformers/hooks.js
+15 -3
View File
@@ -56,7 +56,19 @@ const CLAUDE_PROJECT_HOOK = '${CLAUDE_PROJECT_DIR}/.claude/skills/impeccable/scr
// or no node at all, kills the hook script while it is still being parsed,
// before the script's own always-exit-0 contract can run. Nothing written in
// ESM can report that, the doctor and the sub-commands included, so the command
// string carries the probe: dynamic import, and no-op at exit 0 when it fails.
// string carries the probe, and no-ops at exit 0 when it fails.
//
// The probe imports `node:fs` rather than `fs` because that is what the hook
// closure actually imports, and the `node:` scheme needs 14.18: a bare `fs`
// probe passes on 12 and 13, which then die on the real import. `.catch` with an
// explicit exit is required, not decoration, because before Node 15 an unhandled
// rejection is only a warning and the process still exits 0, so a rejected probe
// would read as a pass. What the probe does NOT do is enforce the engines floor
// of 22. That is deliberate: it asks whether this runtime can load our code, not
// whether it is supported, so a 14.18-to-21 runtime that works today keeps
// working instead of being silently switched off. The notice names 22 because
// that is the version to install, and it is only ever shown to someone whose
// runtime already failed the probe.
//
// `notice` is the shell that reports the dead runtime to the user, and it is
// passed in rather than baked in because only some harnesses have a channel for
@@ -78,8 +90,8 @@ const CLAUDE_PROJECT_HOOK = '${CLAUDE_PROJECT_DIR}/.claude/skills/impeccable/scr
// as quiet there as it was before the probe existed.
const guardedNode = (hookPath, notice = '') => {
const probe = notice
? `! { node -e "import('fs')" 2>/dev/null || { ${notice}; exit 0; }; }`
: `! node -e "import('fs')" 2>/dev/null`;
? `! { node -e "import('node:fs').catch(()=>process.exit(1))" 2>/dev/null || { ${notice}; exit 0; }; }`
: `! node -e "import('node:fs').catch(()=>process.exit(1))" 2>/dev/null`;
return `[ ! -f "${hookPath}" ] || ${probe} || node "${hookPath}"`;
};
// The message says `on PATH` deliberately: the common cause is a hook shell whose