skills/pbakaus_impeccable
1
0
Fork 0
mirror of https://github.com/pbakaus/impeccable.git synced 2026-09-19 01:26:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

Add the mode and area axes to the roll

Browse Source 
Two gaps, both reported from real use. Worlds were drawn with no mode
awareness at all: selectApprovedChallengers never received the mode, so a
build asking for an app UI could draw six worlds that only make sense on a
landing page. And surface alone is too coarse for compositions, because
"operate" spans onboarding, dashboards, editors and settings, so an
onboarding flow could legitimately be dealt a settings composition.

Worlds gain `allowedModes` on the review record, beside breadth and rating,
because it is a reviewer judgment rather than authored content. Absent means
eligible in every mode, so nothing needs backfilling and no existing roll
changes. Applied per tier and skipped where it would empty one, matching how
minRating and strength already degrade. It is a ceiling the reviewer lowers,
not a category they assign: a world is an identity, and identities transfer
across modes further than compositions do.

Compositions gain an optional `area`, one level below surface, with a
taxonomy per surface (COMPOSITION_AREAS). Area is a preference rather than a
filter: a request reorders the ranking to put area matches first and tops up
from the rest of the surface, because the per-area pools are small and
dealing one on-target composition would be worse than three good ones. A
stable partition of an already deterministic ranking stays deterministic.

`--area` on the CLI requires `--mode`, since areas are scoped to a surface,
and is validated against that surface's list so a wrong-surface area fails
loudly instead of silently matching nothing.

Also validated `breadth`, which selection has honoured for a while with
nothing checking it, so a typo read as "general" and quietly returned a
narrow world to the pool.

Four new tests: worlds excluded from a mode stay out, absent allowedModes
stays eligible everywhere, a tier whose every world excludes the mode falls
back instead of starving, and an area-scoped deal prefers its area, tops up
to three, and reproduces from its key.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Paul Bakaus
2026-07-29 16:45:20 -07:00
co-authored by Claude Opus 5
parent 7c32d42055
commit a94331baf0
5 changed files with 246 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
skill/scripts/concept-seed.mjs
+30 -8
View File
@@ -38,10 +38,17 @@
* Usage:
* node scripts/concept-seed.mjs --scope direction --mode persuade
* node scripts/concept-seed.mjs --scope surface --mode operate --from <key>
* node scripts/concept-seed.mjs --scope surface --mode operate --area onboarding-and-setup
* node scripts/concept-seed.mjs --scope direction --candidate-count 6
* node scripts/concept-seed.mjs --scope direction --mode persuade --from <key> --reroll 1
* node scripts/concept-seed.mjs --chosen <challenger-id> --from <key> --scope direction
*
* --area names the area of concern inside that mode (an onboarding flow and a
* settings page are both operate, and want different compositions). It needs
* --mode, prefers compositions in that area, and tops up from the rest of the
* surface rather than dealing fewer. --mode also gates which worlds are
* eligible, for worlds whose reviewer marked them as carrying only some modes.
*
* --mode names the requested surface's mode (persuade, operate, read,
* experience) so the appended compositions match its register of work; omitted,
* they roll from the full approved pool.
@@ -68,7 +75,7 @@ import {
validateConceptCatalog,
WELL_TIERS,
} from './lib/concept-catalog.mjs';
import { readCompositionCatalog } from './lib/composition-catalog.mjs';
import { areasForSurface, readCompositionCatalog } from './lib/composition-catalog.mjs';
import {
runSyncSelection,
selectApprovedChallengers as selectApprovedChallengersCore,
@@ -127,9 +134,10 @@ function requireLocalConcepts() {
return local;
}
async function fetchRoll({ scope, key, mode, reroll }) {
async function fetchRoll({ scope, key, mode, area, reroll }) {
const params = new URLSearchParams({ scope, key, reroll: String(reroll) });
if (mode) params.set('mode', mode);
if (area) params.set('area', area);
const controller = new AbortController();
const timer = setTimeout(() => controller.abort(), apiBudgetMs());
try {
@@ -210,9 +218,9 @@ function driveSelection(generator) {
return runSyncSelection(generator, input => crypto.createHash('sha256').update(input).digest('hex'));
}
export function selectApprovedCompositions({ scope, key, reroll = 0, mode = null, sourceCompositions = null, count = 3 }) {
export function selectApprovedCompositions({ scope, key, reroll = 0, mode = null, area = null, sourceCompositions = null, count = 3 }) {
const compositions = sourceCompositions ?? requireLocalConcepts().compositions;
return driveSelection(selectApprovedCompositionsCore({ scope, key, reroll, mode, compositions, count }));
return driveSelection(selectApprovedCompositionsCore({ scope, key, reroll, mode, area, compositions, count }));
}
// Compatibility for callers that need a single smoke-test sample.
@@ -220,9 +228,9 @@ export function selectApprovedComposition(options) {
return selectApprovedCompositions({ ...options, count: 1 })[0] ?? null;
}
export function selectApprovedChallengers({ scope, key, reroll = 0, sourceConcepts = null }) {
export function selectApprovedChallengers({ scope, key, reroll = 0, mode = null, sourceConcepts = null }) {
const source = sourceConcepts ?? requireLocalConcepts().concepts;
const { approved, picks } = driveSelection(selectApprovedChallengersCore({ scope, key, reroll, concepts: source }));
const { approved, picks } = driveSelection(selectApprovedChallengersCore({ scope, key, reroll, mode, concepts: source }));
return {
approved,
picks,
@@ -238,6 +246,7 @@ export function renderConceptSeed({
key = process.env.IMPECCABLE_CONCEPT_SEED || crypto.randomBytes(4).toString('hex'),
reroll = 0,
mode = null,
area = null,
candidateCount = 7,
catalogDir = CATALOG_DIR,
_resolvedData = undefined,
@@ -251,6 +260,15 @@ export function renderConceptSeed({
if (mode !== null && !SEED_MODES.has(mode)) {
throw new Error('concept-seed: --mode must be persuade, operate, read, or experience');
}
if (area !== null) {
if (mode === null) {
throw new Error('concept-seed: --area needs --mode, because areas are scoped to a surface');
}
const allowed = areasForSurface(mode);
if (!allowed.includes(area)) {
throw new Error(`concept-seed: --area must be one of the ${mode} areas (${allowed.join(', ')})`);
}
}
if (!Number.isInteger(candidateCount) || candidateCount < 5 || candidateCount > 7) {
throw new Error('concept-seed: --candidate-count must be an integer from 5 to 7');
}
@@ -272,6 +290,7 @@ export function renderConceptSeed({
scope,
key,
reroll,
mode,
sourceConcepts: local.concepts,
});
data = {
@@ -280,16 +299,17 @@ export function renderConceptSeed({
approvedCount: approved.length,
catalogCount,
challengers: picks,
compositions: selectApprovedCompositions({ scope, key, reroll, mode, sourceCompositions: local.compositions }),
compositions: selectApprovedCompositions({ scope, key, reroll, mode, area, sourceCompositions: local.compositions }),
};
} else {
// Keep local renders synchronous for prepared eval sessions and tests;
// installed skills without a bundled catalog resolve through the API.
return fetchRoll({ scope, key, mode, reroll }).then(roll => renderConceptSeed({
return fetchRoll({ scope, key, mode, area, reroll }).then(roll => renderConceptSeed({
scope,
key,
reroll,
mode,
area,
candidateCount,
catalogDir,
_resolvedData: roll ? {
@@ -439,6 +459,7 @@ if (process.argv[1] && resolve(process.argv[1]) === fileURLToPath(import.meta.ur
const scopeIdx = args.indexOf('--scope');
const rerollIdx = args.indexOf('--reroll');
const modeIdx = args.indexOf('--mode');
const areaIdx = args.indexOf('--area');
const candidateCountIdx = args.indexOf('--candidate-count');
const chosenIdx = args.indexOf('--chosen');
try {
@@ -472,6 +493,7 @@ if (process.argv[1] && resolve(process.argv[1]) === fileURLToPath(import.meta.ur
: (process.env.IMPECCABLE_CONCEPT_SEED || crypto.randomBytes(4).toString('hex')),
reroll: rerollIdx !== -1 ? Number(args[rerollIdx + 1]) : 0,
mode: modeIdx !== -1 ? args[modeIdx + 1] : null,
area: areaIdx !== -1 ? args[areaIdx + 1] : null,
candidateCount: candidateCountIdx !== -1 ? Number(args[candidateCountIdx + 1]) : 7,
}));
}