Add the mode and area axes to the roll

Two gaps, both reported from real use. Worlds were drawn with no mode
awareness at all: selectApprovedChallengers never received the mode, so a
build asking for an app UI could draw six worlds that only make sense on a
landing page. And surface alone is too coarse for compositions, because
"operate" spans onboarding, dashboards, editors and settings, so an
onboarding flow could legitimately be dealt a settings composition.

Worlds gain `allowedModes` on the review record, beside breadth and rating,
because it is a reviewer judgment rather than authored content. Absent means
eligible in every mode, so nothing needs backfilling and no existing roll
changes. Applied per tier and skipped where it would empty one, matching how
minRating and strength already degrade. It is a ceiling the reviewer lowers,
not a category they assign: a world is an identity, and identities transfer
across modes further than compositions do.

Compositions gain an optional `area`, one level below surface, with a
taxonomy per surface (COMPOSITION_AREAS). Area is a preference rather than a
filter: a request reorders the ranking to put area matches first and tops up
from the rest of the surface, because the per-area pools are small and
dealing one on-target composition would be worse than three good ones. A
stable partition of an already deterministic ranking stays deterministic.

`--area` on the CLI requires `--mode`, since areas are scoped to a surface,
and is validated against that surface's list so a wrong-surface area fails
loudly instead of silently matching nothing.

Also validated `breadth`, which selection has honoured for a while with
nothing checking it, so a typo read as "general" and quietly returned a
narrow world to the pool.

Four new tests: worlds excluded from a mode stay out, absent allowedModes
stays eligible everywhere, a tier whose every world excludes the mode falls
back instead of starving, and an area-scoped deal prefers its area, tops up
to three, and reproduces from its key.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Paul Bakaus
2026-07-29 16:45:20 -07:00
co-authored by Claude Opus 5
parent 7c32d42055
commit a94331baf0
5 changed files with 246 additions and 12 deletions
+28
View File
@@ -24,6 +24,13 @@ export const CONCEPT_STRENGTHS = new Set(['world', 'composition', 'dual']);
// validateConceptCatalog needs it.
export { WELL_TIERS };
// Reviewer axes that gate the challenger draw without touching approval.
export const CONCEPT_BREADTHS = new Set(['general', 'niche']);
// The registers of work a roll can be asked for. Kept here beside the review
// validation that uses it; roll-selection.mjs filters on it and the seeder
// validates the --mode flag against the same four.
export const SEED_MODES = new Set(['persuade', 'operate', 'read', 'experience']);
const WEB_LEVERAGE_RE = /(?:\b3d\b|\badaptive\b|\banimat(?:e|ed|ion)\b|\bapi\b|\baria\b|\baudio\b|\bautomated?\b|\bbarcode\b|\bbroadcastchannel\b|\bbrowser\b|\bcamera\b|canvas\b|\bcaption\b|\bcollaborat(?:e|ive|ion)\b|\bcompar(?:e|ison)\b|\bcomput(?:e|ed|ation)\b|\bcomputer[- ]vision\b|\bconstraint[- ]solving\b|\bcryptographic?\b|\bcss\b|\bdeep[- ]link(?:ing)?\b|\bdirect manipulation\b|\bdom\b|\bdrag\b|\bfilter\b|\bfocus\b|\bgenerative\b|\bgeolocat(?:e|ed|ion)\b|\bgesture\b|\bgpu\b|\bgraph\b|\bhistory\b|\bindexeddb\b|\binteractive\b|\bintersectionobserver\b|\bkeyboard\b|\blive\b|\blocal\b|\bmicrophone\b|\bmotion\b|\bmultiplayer\b|\bnative\b|\bnotification\b|\boffline\b|\bpersonaliz(?:e|ed|ation)\b|\bplayable\b|\bpointer\b|\bprocedural\b|\bprovenance\b|\breal[- ]?time\b|\bresizeobserver\b|\bresponsive\b|\breveal\b|\bscrub\b|\bsearch\b|\bsearchparams\b|\bsensor\b|\bserver[- ]sent\b|\bservice worker\b|\bshader\b|\bsimulat(?:e|ed|ion|or)\b|\bspatial\b|\bstate\b|\bstream(?:ing)?\b|\bsvg\b|\bsynchroniz(?:e|ed|ation)\b|\btimeline\b|\btouch\b|\burl|\bvideo\b|\bweb(?:gl|socket|vtt)?\b|\bworker\b|\bzoom\b)/i;
export const SYSTEM_PREFIXES = [
'Palette/material:',
@@ -289,6 +296,27 @@ export function validateConceptCatalog(catalog, reviewData, {
errors.push(`review ${id} rating only applies to approved concepts`);
}
}
// Breadth: a world too narrow to serve an arbitrary build keeps its approval
// and leaves the challenger pool. Selection has honoured this for a while but
// nothing validated it, so a typo would silently read as "general".
if (review?.breadth !== undefined && !CONCEPT_BREADTHS.has(review.breadth)) {
errors.push(`review ${id} breadth must be one of ${[...CONCEPT_BREADTHS].join(', ')}`);
}
// Mode eligibility: which registers of work this world can carry. Absent
// means all of them, which is why it needs no backfill. Listing every mode
// is the same as omitting it, and an empty list would deal nothing, so both
// are rejected in favour of leaving the field out.
if (review?.allowedModes !== undefined) {
if (!Array.isArray(review.allowedModes) || review.allowedModes.length === 0) {
errors.push(`review ${id} allowedModes must be a non-empty array, or omitted to allow every mode`);
} else if (review.allowedModes.some(mode => !SEED_MODES.has(mode))) {
errors.push(`review ${id} allowedModes may only contain ${[...SEED_MODES].join(', ')}`);
} else if (new Set(review.allowedModes).size !== review.allowedModes.length) {
errors.push(`review ${id} allowedModes must not repeat a mode`);
} else if (review.allowedModes.length === SEED_MODES.size) {
errors.push(`review ${id} allowedModes lists every mode; omit the field instead`);
}
}
}
const wellTierById = new Map((catalog?.wells || []).map(well => [well.id, well.tier]));