skills/pbakaus_impeccable
1
0
Fork 0
mirror of https://github.com/pbakaus/impeccable.git synced 2026-09-12 06:06:37 +03:00
Code Issues Packages Projects Releases Wiki Activity

Refresh the Impeccable product experience

Browse Source 
Rework the landing page proof, steering demo, feature grid, slop catalog, detector coverage, theming, Live workflow, and responsive behavior.\n\nAI-assisted implementation by OpenAI Codex.
This commit is contained in:
Paul Bakaus
2026-07-15 23:29:47 -07:00
parent 8682c85c57
commit bbed6eef08
553 changed files with 8903 additions and 97987 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugin/skills/impeccable/SKILL.md
+1 -1
View File
@@ -26,7 +26,7 @@ Approach every design task as the design lead at a small studio known for giving
**Existing worlds are sacred.** Most of impeccable's work happens inside a site or app that already exists. When the surface has a committed design system (real tokens, deliberately chosen faces, a palette the brand owns), work inside that world: extend it, sharpen it, leave it unmistakably the same brand, and never degrade a working page's performance. Inventing parallel colors, fonts, or styles on an existing surface is a defect, not creativity. A scoped refinement keeps the named scope's content and media footprint unless the brief explicitly changes them; build the added emphasis by recomposing what is already there through hierarchy, proportion, rhythm, and the system's own motifs.
**New identity work reads the playbook first.** When nothing committed exists (greenfield, or a codebase with no real tokens or chosen faces), or the user asks for a redesign that discards the current look, you MUST read [reference/new-work.md](reference/new-work.md) before making any design decision. Not optional, not skippable under time pressure: producing new identity without it yields the generic default this skill exists to prevent. A redesign is new work; read the incumbent as evidence, not as a template or an obstacle: where it carries a deliberate, ownable visual idea, preserve that lineage and intensify it instead of replacing it with contemporary polish. `context.mjs` prints this directive when it detects the situation. Scoped fixes inside an existing world don't need the playbook; the craft floor below governs them.
**New identity work reads the playbook first.** When nothing committed exists (greenfield, or a codebase with no real tokens or chosen faces), or the user explicitly asks for a redesign that discards the current look, you MUST read [reference/new-work.md](reference/new-work.md) before making any design decision. Missing DESIGN.md alone does not make work greenfield: code, tokens, chosen type, components, and assets are incumbent design authority. Preserve and extend them unless the user asked to replace them. Producing a genuinely new identity without the playbook yields the generic default this skill exists to prevent. Scoped fixes inside an existing world don't need it; the craft floor below governs them. `context.mjs` prints the appropriate authority directive.
## Modes
plugin/skills/impeccable/reference/live-generation.md
-32
View File
@@ -1,32 +0,0 @@
# Live generation worker
You generate reviewable variants for an existing interface. The supervisor owns all filesystem writes, publication, cancellation, and recovery. Return only the requested structured output.
## Identity and quality
- Preserve the existing product identity by default: palette roles, available fonts, component roles, copy, semantics, accessibility, and public APIs.
- Treat DESIGN.md as visual authority and PRODUCT.md as strategy/voice authority.
- Define one shared identity lock and distinct design axes before authoring the first variant.
- Make each variant independently shippable. Vary hierarchy, topology, typography, color commitment, density, or structural decomposition, not arbitrary decoration.
- Preserve short labels as readable units and avoid unnecessary wrapping at the supplied viewport.
- Prefer hierarchy, proportion, rhythm, and composition before adding nested chrome.
- Silently reject overflow, awkward wrapping, accidental compression, weak alignment, inaccessible states, and off-brand component treatments.
## Authoring contract
- The selected root is a complete replacement with exactly one top-level element.
- Preserve copy and dynamic relationships unless the user explicitly requests content changes.
- Never emit `data-impeccable-*` wrappers inside variant markup.
- Follow `event.scaffold.cssAuthoring` exactly. Fence every preview selector to its variant.
- Do not write source or project files. Return only paths and content permitted by the current output schema.
- Published variants are immutable. Never repeat or revise an earlier variant in a later phase.
- The staged artifact identifies the exact selected page/component. Inspect its real imports, shared layouts, styles, tokens, and route ownership with read-only tools whenever needed; do not assume a single-page project or guess from filenames.
## Progressive phases
- `first`: return variant 1 and the complete coherent plan. Defer parameters.
- `remainder`: return variants 2 through N together, following the stored plan, plus final parameter wiring CSS and the manifest for every variant. Do not change variant 1 or any default appearance.
- `params`: recovery only when all variants were durably published but their parameters were not. Return only parameter wiring CSS and the manifest.
- Parameters are coarse, meaningful axes already present in the designs. Tiny elements may have none; larger compositions usually expose two or three. Never exceed four per variant.
The supervisor runs the Impeccable detector before publication. On a repair turn, use judgment on every finding: fix real defects, but preserve contextually intentional design and detector false positives by returning the narrow `detectorWaivers` entry requested by the repair schema with a concrete reason. Never persist project ignore config or add inline ignore comments from this read-only worker. Publication proceeds only when every new finding was fixed or explicitly waived.
plugin/skills/impeccable/reference/live.md
+18 -73
View File
@@ -10,24 +10,21 @@ Execute in order. No step skipped, no step reordered.
1. `live.mjs`: boot. If the request names or implies a file, route, or app inside a monorepo, infer the concrete path and run `node .claude/skills/impeccable/scripts/live.mjs --target <path>` instead; then run the rest of this live session from the returned `projectRoot`.
2. Open the app URL that serves `pageFile` (infer from `package.json`, docs, terminal output, or an open tab). Never use `serverPort`; it's the helper, not the app. **Cursor:** `browser_navigate` to that URL before polling; do not skip. **Other harnesses:** use the available browser tool; if the URL is uncertain, ask the user once.
3. Poll loop with the default long timeout (600000 ms). Run `live-poll.mjs` again immediately after every event or `--reply`; Codex runs this one-shot poll in the foreground. Never pass a short `--timeout=`.
3. Poll loop with the default long timeout (600000 ms). After every event or `--reply`, run `live-poll.mjs` again immediately. Never pass a short `--timeout=`.
The global bar **Impeccable mark** dims and shows a pulsing amber dot when no agent is long-polling `/poll`. Hover the mark for the hint; restart `live-poll.mjs` to reconnect.
4. On `generate`: reuse `event.scaffold` when present; read the screenshot if present; load the action's reference; deliver variants using the harness policy below; `--reply done`; poll again. In Codex, delegate the complete event to `impeccable_live_generator` and resume the foreground poll immediately; the generator owns publication and the reply.
4. On `generate`: read screenshot if present; load the action's reference; plan three distinct directions; write all variants in one edit; `--reply done`; poll again.
5. On `steer`: read the message and `pageUrl`; do the work (page edits, navigation help, or a short reply in the `--reply` message); `--reply steer_done`; poll again. No pickup ack. The Steer bar unlocks when `steer_done` arrives over SSE.
6. On `accept` / `discard`: the poll script runs `live-accept.mjs`, acknowledges the delivered event, and prints `_completionAck`. Plain accepts/discards are terminal immediately. Carbonize accepts remain recoverable until the foreground task runs `live-complete.mjs --id EVENT_ID`; finish that cleanup before polling again.
6. On `accept` / `discard`: the poll script runs `live-accept.mjs`, acknowledges the delivered event, and prints `_completionAck`. Plain accepts/discards are terminal immediately; carbonize accepts remain recoverable until you finish cleanup, run `live-complete.mjs --id EVENT_ID`, and only then poll again.
7. If interrupted, run `live-status.mjs` or `live-resume.mjs` before guessing. The durable journal replays unacknowledged work after helper restart.
8. On `exit`: run the cleanup at the bottom.
Harness policy:
- **Claude Code**: run the poll as a **background task** (no short timeout). The harness notifies you when it completes, so the main conversation stays free. Do not block the shell.
- **Cursor**: run **one-shot** poll in a **background terminal** with notify on `"type":"(steer|generate|accept|discard|exit)"`. After each event the poll exits; handle it, `--reply`, then start `live-poll.mjs` again. Do **not** use `--stream` on Cursor: incremental stdout notify is slower in practice than exit-based notify (~5s vs sub-second in testing).
- **Codex**: run the default one-shot poll in a **yielded foreground exec session**. Do not suffix it with `&`, use `--stream`, or leave Live without an active foreground poll. When `generate` arrives, delegate to the low-effort `impeccable_live_generator` agent with a compact handoff, then immediately start the next foreground poll while that agent publishes and replies. Do not paste this full reference into the handoff. Handle Steer, Accept/Discard, manual Apply, carbonize, and Exit in the main task; after each handler/reply, restart the foreground poll.
- **Codex**: run the poll in the **foreground** (blocking shell; not a background task, not a subagent). Codex background exec sessions do not reliably surface poll stdout back into the conversation at the moment events arrive, so a "fire-and-forget" background poll will stall live mode.
- **Other harnesses**: one-shot foreground unless you know stdout reliably returns to this session when a shell exits.
Generation delivery policy:
- **Default (Claude Code, Cursor, and other harnesses):** keep the established atomic single-edit delivery unless that harness has independently demonstrated that progressive tool calls are faster and reliable. This avoids trading model latency for extra tool-call latency on harnesses with different streaming behavior.
Chat is overhead. No recap, no tutorial output, no pasting PRODUCT / DESIGN bodies. Spend tokens on tools and edits; on failure, one or two short sentences.
## Start
@@ -38,10 +35,6 @@ node .claude/skills/impeccable/scripts/live.mjs
Output JSON: `{ ok, serverPort, serverToken, pageFiles, hasProduct, product, productPath, hasDesign, design, designPath }`. `pageFiles` is the list of HTML entries the live script was injected into. Keep PRODUCT.md and DESIGN.md in mind for variant generation; **DESIGN.md wins on visual decisions; PRODUCT.md wins on strategic/voice decisions.** When DESIGN.md is missing, identity is **not** absent; extract it from CSS variables, computed styles, and sibling components on the page (see Step 4 Phase A). Identity preservation is the default; departure from existing identity requires an explicit trigger from PRODUCT.md anti-references or the user's freeform prompt.
Normally `codexWorker.enabled` is `false`; run the default unfiltered `live-poll.mjs` command in the foreground. If an explicitly opted-in run returns `codexWorker.enabled: true`, follow the experimental worker section below instead.
If an explicitly opted-in run includes `codexWorker.error: "codex_cli_unavailable"`, tell the user once that Live fell back to foreground generation, then run the returned unfiltered `codexWorker.foregroundPoll`. Do not retry or install anything during the session.
`serverPort` and `serverToken` belong to the small **Impeccable live helper** HTTP server (serves `/live.js`, SSE, and `/poll`). That port is **not** your dev server and is usually not the URL you open to view the app. The browser page is whatever origin serves one of the `pageFiles` entries (Vite / Next / Bun / tunnel / LAN hostname).
If output is `{ ok: false, error: "config_missing" | "config_invalid", path }`, this project hasn't been configured for live mode (or its config is stale). See **First-time setup** at the bottom.
@@ -93,61 +86,20 @@ node .claude/skills/impeccable/scripts/live-complete.mjs --id SESSION_ID
Server restart rule: start `live-server.mjs` again, then poll. Startup requeues unacknowledged pending events from the journal, so do not ask the user to click Go again unless `live-resume.mjs` says no active session exists.
### Experimental dedicated Codex worker
The app-server supervisor is retained for controlled experiments, but it is not the primary Codex path. Enable it explicitly for a run:
```bash
IMPECCABLE_LIVE_CODEX_WORKER=1 node .claude/skills/impeccable/scripts/live.mjs
```
Activation remains process-local. The worker is off by default, including in Codex. `IMPECCABLE_LIVE_CODEX_WORKER=1` is the direct opt-in; alternatively, Codex may opt in through `experimentalCodexWorker.enabled`. A committed setting can never switch a non-Codex harness onto this path:
```json
{
"experimentalCodexWorker": {
"enabled": true,
"profile": "quality",
"delivery": "progressive"
}
}
```
When explicitly enabled, the worker remains Codex-only. Claude, Gemini, Cursor, and every other harness keep their portable polling behavior. Before detaching anything, Live resolves the configured Codex executable using the same explicit-path/PATH rules as Node spawn. A missing CLI becomes an immediate, durable foreground fallback. Otherwise Live records the worker as `starting` and returns immediately. Run only the returned foreground control poll. It checks the owned worker process every two seconds and safely restores generation/accept/discard leasing if startup, authentication, model selection, or the worker process fails. Dedicated-worker leases expire after 15 seconds, so a hard process loss cannot strand browser work behind the portable ten-minute lease.
```bash
node .claude/skills/impeccable/scripts/live-poll.mjs --stream --types=steer,manual_edit_apply,carbonize_cleanup,exit --codex-worker-fallback
```
The supervisor launches its own `codex app-server --stdio` process, dynamically prefers the strongest visible general model (currently GPT-5.6 Sol), and uses medium reasoning. The optional `fast` profile retains Spark/mini selection and low reasoning for controlled comparisons. It creates a dedicated Impeccable-owned thread and persists only that id in `.impeccable/live/codex-worker.json`; it never lists, resumes, steers, or writes to the desktop task. A crash reconnect may resume that id only when the ownership marker and project cwd both match. Clean Live exit interrupts the active turn, archives the dedicated thread, and stops app-server.
The first generation turn in a worker task attaches the installed Impeccable skill as a native app-server skill input and resolves inherited/monorepo PRODUCT.md and DESIGN.md through the same context loader as the foreground skill. Each generation supplies the exact selected source artifact, event, scaffold, page URL, and action reference. The persistent read-only thread decides which imports, route layouts, styles, tokens, or shared components it needs to inspect; no lexical source-neighborhood heuristic stands in for repository understanding. Annotated requests attach `screenshotPath` as a real high-detail local image instead of a JSON path.
One persistent app-server thread performs both normal generation turns so identity, repository discoveries, the variant plan, and skill guidance remain coherent. Model turns run read-only and return structured staged-artifact files. Before publication, the supervisor runs the Impeccable detector against the staged candidate, compares it with the pre-existing baseline, and asks the same thread for one repair when new findings appear. The repair must fix real defects or explicitly classify contextually intentional/false-positive findings with narrow, reasoned per-candidate waivers; only findings left neither fixed nor waived block publication. Existing project detector ignores are honored by the scan, while the read-only worker never persists new config or inline suppressions. The supervisor then validates paths and publishes exclusively through the generation publisher's epoch/source-hash/immutable-prefix fence. Source-wrapper sessions use an isolated preview under `.impeccable/live/previews/`; the true source stays byte-identical until Accept. Progressive variant 1 is immediately reviewable; variants 2 through N and their parameters arrive together from turn two. Accept/Discard interrupts the active app-server turn, while the durable generation fence rejects any late completion that still races cancellation.
Controls:
```bash
node .claude/skills/impeccable/scripts/live-codex-worker.mjs --status
node .claude/skills/impeccable/scripts/live-codex-worker.mjs --stop
```
Model and binary overrides are `IMPECCABLE_LIVE_CODEX_PROFILE`, `IMPECCABLE_LIVE_CODEX_MODEL`, `IMPECCABLE_LIVE_CODEX_EFFORT`, and `IMPECCABLE_CODEX_PATH`. `delivery: "atomic"` retains the one-turn publication control. Steer, manual Apply, carbonize cleanup, and Exit remain on the high-judgment foreground control lane; the server's type filter prevents either lane from leasing the other's events.
## Handle `generate`
**Replace mode** (default): `{id, action, freeformPrompt?, count, pageUrl, element, screenshotPath?, comments?, strokes?}`.
**Insert mode** (`event.mode === "insert"`): `{id, mode: "insert", count, pageUrl, insert: { position, anchor }, placeholder: { width, height }, freeformPrompt?, screenshotPath?, comments?, strokes?}`. No `action`. Requires a non-empty `freeformPrompt` **or** annotations. Screenshot is sent only when annotations exist (same rule as replace). Use `placeholder` dimensions as a soft size hint for net-new content.
Speed matters; the user is watching the selected element. Reuse server preflight metadata when available, minimize discovery calls, and follow the harness-specific delivery policy above.
Speed matters; the user is watching a spinner. Minimize tool calls by using the wrap/insert helper and writing all variants in a single edit.
### Insert mode branch
When `event.mode === "insert"`:
1. Read the screenshot if `event.screenshotPath` is present (annotations only).
2. If `event.scaffold` is present, use it as the insert-helper result and do **not** run the helper again. Otherwise run the insert helper instead of wrap:
2. Run the insert helper instead of wrap:
```bash
node .claude/skills/impeccable/scripts/live-insert.mjs --id EVENT_ID --count EVENT_COUNT --position after \
@@ -157,7 +109,7 @@ node .claude/skills/impeccable/scripts/live-insert.mjs --id EVENT_ID --count EVE
- `--position` ← `event.insert.position` (`before` | `after`)
- Anchor flags ← `event.insert.anchor` (same mapping as wrap: id, classes, tag, text)
The scaffold has **no** `data-impeccable-variant="original"`. Variants are net-new HTML+CSS inserted at `insertLine`. For Operate/Read surfaces load `operate.md`; Persuade/Experience surfaces use SKILL.md's mode guidance plus `new-work.md` when the variant invents identity (freeform only, no action sub-command). Deliver using the harness policy, then `--reply done`.
The scaffold has **no** `data-impeccable-variant="original"`. Variants are net-new HTML+CSS inserted at `insertLine`. Load `brand.md` or `product.md` (freeform only, no action sub-command). Write all variants in one edit, then `--reply done`.
For Svelte/SvelteKit targets, `live-insert.mjs` returns `previewMode: "svelte-component"` with `mode: "insert"`, `file` pointing at a temporary `node_modules/.impeccable-live/<id>/manifest.json`, `componentDir` pointing at the variant component files, and `sourceFile` pointing at the real `.svelte` route. Write each inserted variant as a real Svelte component (`v1.svelte`, `v2.svelte`, …) under `componentDir`. Insert variants must be non-empty net-new content with a single top-level root, no `data-impeccable-*` attributes, and CSS in each component's `<style>` block. Do **not** edit the route source during generation; the browser mounts the temporary component before/after the live anchor while the user cycles variants. On Accept, `live-accept.mjs` inserts the selected component markup into `sourceFile` immediately and deletes the temp session after the source write succeeds.
@@ -182,8 +134,6 @@ Reading annotations precisely:
### 2. Wrap the element
When `event.scaffold` is present, the local helper already found and wrapped the source before the poll returned. Treat `event.scaffold` as the successful helper output and skip this command entirely. `event.scaffoldAttempted` with `scaffoldError` means local preflight could not finish; use the command/fallback path below. This optimization removes a deterministic tool round trip without changing the generated design.
```bash
node .claude/skills/impeccable/scripts/live-wrap.mjs --id EVENT_ID --count EVENT_COUNT --element-id "ELEMENT_ID" --classes "class1,class2" --tag "div" --text "TEXT_SNIPPET"
```
@@ -203,9 +153,7 @@ Output on success: `{ file, insertLine, commentSyntax, styleMode, styleTag, cssS
For Svelte/SvelteKit targets, `live-wrap.mjs` returns `previewMode: "svelte-component"` with `file` pointing at a temporary `node_modules/.impeccable-live/<id>/manifest.json`, `componentDir` pointing at the variant component files, and `sourceFile` pointing at the real `.svelte` route. Write each variant as a real Svelte component (`v1.svelte`, `v2.svelte`, …) under `componentDir`; use the `propContract` prop names for dynamic text (`{propName}`), not literal snapshot strings. Put variant CSS in each component's `<style>` block with semantic class selectors (no `@scope`, no `data-impeccable-*`). Reply with `--file` set to the manifest path; the browser dynamically imports and mounts the compiled components so Svelte HMR does not reset page state while the user cycles variants. On Accept, `live-accept.mjs` inlines the accepted component back into `sourceFile` immediately after source promotion succeeds.
For Nuxt/Vue targets, `live-wrap.mjs` returns `previewMode: "vue-component"` with `file` pointing at an app-local generated manifest under `<appDir>/.impeccable-live/<id>/manifest.json`, `componentDir` pointing at real Vue SFC variants, and `sourceFile` pointing at the untouched `.vue` route. Write `v1.vue`, `v2.vue`, … with one root inside `<template>` and variant CSS in `<style scoped>`; keep dynamic text on the `propContract` bindings as `{{ propName }}`. Do **not** rewrite `sourceFile` during generation: Nuxt/Vite compiles and mounts these dev-only modules without invalidating the route. Accept is the only route write and inlines the selected template/CSS under the source lock; Discard deletes the generated session.
**Params on component-preview paths go in a sidecar, never as an attribute.** Svelte parses `{` inside an attribute value as the start of an expression, and both Svelte/Vue previews mount without an HTML variant wrapper. Declare params in `componentDir/params.json`, keyed by variant number, using the exact param schema from section 7:
**Params on the Svelte component path go in a sidecar, never as an attribute.** Svelte parses `{` inside an attribute value as the start of an expression, so a `data-impeccable-params='[{…}]'` attribute on a component element fails to compile (`Expected token }`). Declare params for this path in `componentDir/params.json`, keyed by variant number, using the exact param schema from section 7:
```json
{
@@ -239,7 +187,7 @@ All three carry `fallback: "agent-driven"`. Follow **Handle fallback** below.
### 3. Load the action's reference
If `event.action` is `impeccable` (the default freeform action), use SKILL.md's shared laws plus the loaded mode depth (`operate.md` for Operate/Read; `new-work.md` when the variant invents identity). Do not load a sub-command reference. **Freeform is not a pass to skip parameters:** you still follow the composition budget and the freeform bias in **§7 Parameters** below. Sub-command files list MUST-have signature knobs; freeform has no such file, so sizing knobs from surface weight and primary axes is entirely on you.
If `event.action` is `impeccable` (the default freeform action), use SKILL.md's shared laws plus the loaded register reference (`brand.md` or `product.md`). Do not load a sub-command reference. **Freeform is not a pass to skip parameters:** you still follow the composition budget and the freeform bias in **§7 Parameters** below. Sub-command files list MUST-have signature knobs; freeform has no such file, so sizing knobs from surface weight and primary axes is entirely on you.
Any other `event.action` (`bolder`, `quieter`, `distill`, `polish`, `typeset`, `colorize`, `layout`, `adapt`, `animate`, `delight`, `overdrive`): Read `reference/<action>.md` before planning. Each sub-command encodes a specific discipline; skipping its reference produces generic output. Those files may require specific params; layer them on top of the §7 budget, not instead of it.
@@ -304,7 +252,7 @@ Instead, work from the brand:
1. Read PRODUCT.md's Brand Personality words. What physical, spatial, or material experiences would embody those words if design were not involved? (A personality described as "specific, earned, unmistakable" evokes a hand-stamped letter, a numbered print, a watchmaker's loupe. A personality described as "restless, loud, unfiltered" evokes a concert poster, a spray-painted wall, a megaphone.)
2. From those physical experiences, derive three visual directions that are genuinely different from each other AND from the current surface you're departing.
3. Avoid the **reflex-reject lanes** in [new-work.md](new-work.md). Don't trade one monoculture for another. If you find yourself reaching for "Swiss-grid" or "Terminal" or "Industrial-signage" by reflex, you are pattern-matching a catalog in your training data, not reading the brand. Start over from the personality words.
3. Avoid the **reflex-reject lanes** in [brand.md](brand.md). Don't trade one monoculture for another. If you find yourself reaching for "Swiss-grid" or "Terminal" or "Industrial-signage" by reflex, you are pattern-matching a catalog in your training data, not reading the brand. Start over from the personality words.
4. Each direction must be expressible in one concrete sentence that names a real-world referent ("a museum exhibition label system for a contemporary art gallery" not "clean and minimal"). If your sentence contains only adjectives, it's not concrete enough.
5. **While planning each direction, also name its 2–3 parameter knobs** (per the §7 budget table). The same principle as default mode: decide "what's tunable" during planning, not after writing the HTML. A departure-mode hero with 0 parameters is not "bold creative vision," it's a missed opportunity for the user to fine-tune the direction they pick.
@@ -343,13 +291,11 @@ In **departure mode**, the prompt narrows the lanes you draw from, not the famil
When the prompt and PRODUCT.md anti-references conflict (the prompt asks for X, the anti-references ban X), the anti-references win; they describe the brand's standing position, the prompt is one moment.
### 6. Deliver variants
### 6. Write all variants in a single edit
Complete HTML replacement of the original element for each variant, not a CSS-only patch. Consider the element's context (computed styles, parent structure, CSS variables from `event.element`).
Colocate preview CSS as a `<style>` tag inside the variant wrapper; `<style>` works anywhere in modern browsers and keeps each delivered state internally complete (no FOUC).
**Atomic default:** write CSS + all variants + parameter manifests in one edit at `insertLine`, preserving the established behavior.
Write CSS + all variants in ONE edit at the `insertLine` reported by `wrap`. Colocate CSS as a `<style>` tag inside the variant wrapper; `<style>` works anywhere in modern browsers and this ensures CSS and HTML arrive atomically (no FOUC).
Use the `cssAuthoring` object returned by `live-wrap.mjs` to author the temporary preview CSS. The style opening tag shown below is the common case; replace it with `cssAuthoring.styleTag` when the tool returns a different one. The variant markup shape is otherwise stable:
@@ -373,7 +319,7 @@ Use the `cssAuthoring` object returned by `live-wrap.mjs` to author the temporar
The first variant has no `display: none` (visible by default). All others do. If variants use only inline styles and no preview CSS, omit the `<style>` tag entirely.
The browser's MutationObserver accepts either delivery shape. On the transactional progressive path it shows arrived variants and pending dots immediately; Accept and Discard are available as soon as one variant exists. Accepting an arrived variant fences the worker before the browser releases the picker, so later publications are rejected.
One edit, all variants; the browser's MutationObserver picks everything up in one pass.
For `styleMode: "scoped"`, author every `:scope` rule with a descendant combinator. The `@scope` boundary is the **variant wrapper `<div data-impeccable-variant="N">`**, not the element you're designing. A bare `:scope { background: cream; }` styles the wrapper, not the inner replacement, so the cream lands on a `display: contents` shell while the actual element keeps page defaults. Always step in: `:scope > .card`, `:scope > section`, `:scope .hero-title`, etc. The fake test agent's CSS in `tests/live-e2e/agent.mjs` is a faithful template; every scoped rule starts `:scope > ...`.
@@ -415,7 +361,7 @@ Each variant can expose **coarse** knobs alongside the full HTML/CSS replacement
**Hard cap per variant**: at most **four** parameters so the panel stays legible; rare fifth only if the reference explicitly allows it.
**How to declare.** Put a JSON manifest on the variant wrapper (HTML/JSX path). **On `svelte-component` and `vue-component` paths, do not use this attribute.** Declare params in `componentDir/params.json` keyed by variant number instead (see the component-preview paragraphs in the wrap section). The param schema below is identical for every path.
**How to declare.** Put a JSON manifest on the variant wrapper (HTML/JSX path). **On the Svelte `svelte-component` path, do not use this attribute** (Svelte can't compile `{` inside an attribute value). Declare params in `componentDir/params.json` keyed by variant number instead (see the Svelte component paragraph in the wrap section). The param schema below is identical for both paths.
```html
<div data-impeccable-variant="1" data-impeccable-params='[
@@ -516,7 +462,7 @@ Event: `{id, variantId, _acceptResult, _completionAck}`. The poll script already
- The accept event includes `pageUrl`; the poll script must forward it to `live-accept.mjs --page-url PAGE_URL` so accept-time cleanup only scrubs staged copy edits for the current page.
- `_completionAck.ok !== true`: do not poll yet. Run `live-status.mjs` / `live-resume.mjs`, complete the cleanup manually if needed, then run `live-complete.mjs --id EVENT_ID`.
- `_acceptResult.handled: true` and `carbonize: false`: nothing to do. Poll again.
- `_acceptResult.handled: true` and `carbonize: true`: post-accept cleanup is required, but it must not stall Codex's control lane. See "Required after accept (carbonize)" below. The `event._acceptResult.todo` field, `_completionAck.requiresComplete`, and stderr banner all point at this required follow-up; none are decorative.
- `_acceptResult.handled: true` and `carbonize: true`: **post-accept cleanup is required before the next poll.** See the "Required after accept (carbonize)" section below. The `event._acceptResult.todo` field, `_completionAck.requiresComplete`, and a stderr banner all point at this required follow-up; none are decorative. After cleanup, run `live-complete.mjs --id EVENT_ID`, then poll again.
- `_acceptResult.handled: false, mode: "fallback"`: the session lived in a generated file and the script refused to persist there. You've already written the accepted variant into true source during Handle fallback Step 3; just clean up the temporary wrapper in the served file if any, and poll again.
- `_acceptResult.handled: false` without `mode`: manual cleanup: read file, find markers, edit.
@@ -524,7 +470,7 @@ Event: `{id, variantId, _acceptResult, _completionAck}`. The poll script already
When `_acceptResult.carbonize === true`, the accepted variant was stitched into source with helper markers and inline CSS so the browser can render it immediately with no visual gap. That stitch-in is **temporary**. The agent must rewrite it into permanent form before doing anything else. Skipping this leaves dead `@scope` rules for unaccepted variants, a pointless `data-impeccable-variant` wrapper, and `impeccable-carbonize-start/end` comment noise in the source file; all of which accumulate across sessions.
Do these five steps synchronously before the next poll. The source lock, generation epoch, and expected-source hash remain the final safety gates against a generator finishing concurrently with Accept.
Do these five steps in the current thread, synchronously, before the next poll. Do not poll again until the file is clean.
1. **Locate the carbonize block** in the source file (`_acceptResult.file`). It's bracketed by `<!-- impeccable-carbonize-start SESSION_ID -->` and `<!-- impeccable-carbonize-end SESSION_ID -->` and contains a `<style data-impeccable-css="SESSION_ID">` element. If the variant declared parameters, an `<!-- impeccable-param-values SESSION_ID: {...} -->` comment sits alongside the style tag with the user's chosen values; read it first; it drives steps 3 and 4 below.
2. **Move the CSS rules** into the project's real stylesheet. Which stylesheet depends on the project (e.g. `site/styles/workflow.css` for an Astro project, or the component's co-located CSS file for a Vite/Next project; pick whichever already owns styling for the surrounding element).
@@ -532,9 +478,9 @@ Do these five steps synchronously before the next poll. The source lock, generat
4. **Unwrap the accepted content.** Delete the inner `<div data-impeccable-variant="N" style="display: contents">` that wraps it. On JSX/TSX, also delete the outer `<div data-impeccable-carbonize="SESSION_ID" style={{ display: 'contents' }}>` wrapper if present (accept adds it so ternary/`return` slots keep a single root). Drop `data-impeccable-params` and any `data-p-*` attributes; those are live-mode plumbing, not source.
5. **Delete the inline `<style>` block, the `<!-- impeccable-param-values -->` comment if present, and both `<!-- impeccable-carbonize-start/end -->` markers.** Also drop any `@scope` rules for variants other than the accepted one; those are dead code now.
After the file is clean, the cleanup owner runs `live-complete.mjs --id SESSION_ID` and verifies `phase: "completed"`. Poll again only after that verification.
After the file is clean, run `live-complete.mjs --id SESSION_ID`, verify it reports `phase: "completed"`, then poll again.
With the experimental dedicated worker, Accept emits a foreground `carbonize_cleanup` control event: `{id, sessionId, file, variantId, acceptResult}`. Perform the same five steps above for `sessionId`, run `live-complete.mjs --id SESSION_ID`, then acknowledge the control event with `live-poll.mjs --reply EVENT_ID complete --file FILE`. The experimental stream resumes after this reply.
A background agent may be used for the rewrite, but the current thread is responsible for verifying the five steps are complete before issuing the next poll. In practice, inline is usually faster and less error-prone.
## Handle `discard`
@@ -599,7 +545,6 @@ When the poll returns `exit`, proceed to cleanup. If the poll is still running a
## Cleanup
```bash
node .claude/skills/impeccable/scripts/live-codex-worker.mjs --stop # only when codexWorker.enabled was true
node .claude/skills/impeccable/scripts/live-server.mjs stop
```
plugin/skills/impeccable/reference/new-work.md
+26 -38
View File
@@ -1,59 +1,47 @@
# New identity work
You are reading this because nothing committed exists yet (greenfield), or the user asked for a redesign that discards the current look. The task is the same either way: invent a visual identity that could not be mistaken for anyone else's, in the grammar of the surface's mode (SKILL.md's Registers section), and build it to the craft floor. SKILL.md's rules all still apply; this file is the process that produces the identity.
Read this only when the project has no committed visual identity, or the user explicitly asked to replace the current one. A missing DESIGN.md is not enough: code, tokens, chosen type, components, and assets are incumbent design authority. If they exist, preserve and extend them unless the brief says to discard them.
## Seed
This playbook is task-scoped. PRODUCT.md owns durable product facts and DESIGN.md owns durable visual invariants; the direction for one page or feature belongs in the current task, not in either document.
If the project is brand-new (no committed tokens, fonts, or brand colors found in the code), run `node .claude/skills/impeccable/scripts/palette.mjs` for a brand seed color. The seed exists to break your reflex palette; it does not override the subject. When the subject's world clearly dictates color (an era, a place, a material, a medium), derive the palette from that world and use the seed only to check yourself. Otherwise anchor on it. The palette has exactly two legitimate sources: the seed, or the subject's world. What the category usually looks like is neither, and quietly swapping in the category's habitual palette and theme after drawing a seed is the reflex this step exists to break. Color commits at page scale: fields that own whole regions, not accents scattered over a neutral ground. A dark page with one glowing accent is the category's reflex, not a choice. Use OKLCH throughout. Skip this entirely when the code already has committed brand colors: identity-preservation wins.
## Choose the authority
## Ground it in the subject
Classify the work before inventing anything:
Name one concrete subject, its audience, and the page's single job. The subject's own world (its materials, instruments, artifacts, places, history, vernacular) is where distinctive choices come from. What would this thing look like as a physical object? What did its world look like before the web? A design whose subject appears only in the copy is a template wearing a costume.
- **Extend**: an incumbent system exists and the task adds or improves a surface. Preserve its lineage, semantics, and affordances.
- **Surface redesign**: the current identity remains, but this surface may change its topology, hierarchy, and expression.
- **New identity**: nothing committed exists, or the user explicitly authorized a rebrand.
## Decide, then build
When the evidence is mixed, preserve. Novelty is not permission to erase authored decisions.
Derive the concept with this procedure, recording each step in your reasoning before the next begins. One: state the product's unique mechanism in one sentence, the thing competitors cannot truthfully claim. Two: competitive analysis; describe the page this category always ships, and the counter-position page a contrarian ships, and treat both structures as off the table. Three: from the audience's world and the subject's cultural home, list seven concrete materials, objects, documents, or rituals they know by heart, each with one line on why it resonates and can carry the mechanism, ordered by resonance. Four: run `node .claude/skills/impeccable/scripts/concept-seed.mjs` and follow what it prints: it assigns which candidate to build (your top-ranked candidate is what every run would ship; a single ranking is deterministic, so the dice come from outside) and supplies challenger forms to weigh against your list on exactly two axes, audience identification and product clarity. Five: the chosen form supplies the page's structure, reading order, and component conventions; the product supplies every fact. Commit every atom: nav, buttons, inputs, and links are rebuilt in the form's vocabulary, and a stock component inside a committed form is a lapse. The form has its own native arrangement; borrow its skeleton, not just its clothes. Land the first build fully committed; committing is the hard part, and the passes that follow exist to make the committed thing clear and effective, never to dilute it. Conversion conventions live inside the form's own vocabulary: a hero that hooks in one line, a visible primary action, a legible reading order. The chosen form also dictates the first viewport's geometry: render the form at the scale it has in life, edge to edge when that is its nature; embedding it as a panel inside a standard marketing layout forfeits it. Cinematic full-bleed openings, intentionally divergent grids, and color drenched across whole regions are in bounds whenever the form calls for them; on an unattended build, the safe layout is the risk. The form has native motion, what it does in life between states; give the page that motion once, orchestrated, rather than scattered hover effects.
## Find the concept
Then state the chosen direction as a contract, written as a comment block at the top of the artifact (invisible to visitors, binding for you), five short blocks, two hundred words at most. UNIQUE: the one idea this page owns. NOT-TEMPLATE: how the page's structure differs from the category's standard arrangement, stated plainly and honestly. OWN-WORLD: the palette and component language, specific enough that the components and colors alone, shown without content, would be recognizable as this page's world and nobody else's. STORY: what the visitor understands, believes, and does, from first viewport to action. FIRST VIEWPORT: the exact composition, what is where and at what scale. FORM: the chosen candidate and its position on your ordered list, plus the seed key the script printed. If any block is missing or reads like a mood, the direction isn't decided yet. The build is judged against this contract; delivering different pixels than the contract promises is a defect on whichever side is weaker. When a user can respond and the work is substantial, pause there for confirmation; when the harness has native image generation, follow [codex.md](codex.md)'s mock flow before code. When no user can respond, record the decision in your reasoning and proceed without pausing. Either way the decision comes first; code that precedes a direction is the template reflex in motion.
Name the subject, audience, page job, and visitor mode from SKILL.md. Then identify the product's unique mechanism: what it does, proves, or enables that a neighboring product cannot truthfully claim.
## Plan, self-check, build
Derive the concept from that mechanism through one primary transformation: information topology, evidence, temporal behavior, or spatial mapping. The transformation must change how the surface is organized or behaves, not merely how it is decorated. This produces stranger and more defensible work than imitating a culturally specific document or object. Borrowing a literal cultural form is allowed only when it is genuinely native to the product and audience, and never as costume.
Plan a compact token system in your reasoning: palette, type, layout concept in one sentence, and a **signature**: the one element this surface will be remembered by, drawn from the subject's world. A signature carries weight: sized and placed so the page organizes itself around it. The layout has exactly two legitimate sources: the concept, or the content's own structure. The category's habitual skeleton is neither, and assembling the usual sections in the usual order after choosing a concept is the same reflex the palette rule breaks, expressed in structure. Then audit the plan: work through what you'd produce for a similar brief from another client, and wherever the two plans converge (same palette family, same face, same skeleton), that part is your generic default, not a choice. Revise it, then build, deriving every color and type decision from the revised plan.
For **Operate** and **Read**, start with the task and information structure. Native controls remain native controls; expression comes from hierarchy, density, rhythm, state, and the system around them. For **Persuade** and **Experience** creating a new identity, explore more freely, but keep the product legible and the primary action obvious.
**Pace the scroll like a studio.** The scroll is a rhythm, not a stack: alternate full-bleed bands of the palette, vary the treatment from section to section inside the one system (a dense passage earns a quiet one, a graphic section earns a typographic one), ground at least one section in the signature motif as texture, and end anchored by a real close. One spacing rhythm throughout, kept like a promise: sections breathe in large, legible beats, and the space above a heading always exceeds the space below it. A page whose every section wears the same weight and density reads as monotone no matter how strong the concept.
Run `node .claude/skills/impeccable/scripts/concept-seed.mjs` only for Persuade or Experience new-identity work when two or more directions remain equally credible. It is an entropy source, not an authority: never let the draw overrule the strongest fit. When color is genuinely unconstrained, `node .claude/skills/impeccable/scripts/palette.mjs` may break a reflex palette; subject evidence and incumbent color still win.
**The first viewport is a thesis, not a header.** The visitor should meet the concept doing its job immediately: the work itself, the product working, the content answering, the task at hand. Generic chrome around a generic promise is the template answer; earn it or replace it. The composition is derived the same way the palette is: if a neighboring product could ship the same arrangement of the same blocks, the viewport isn't composed yet. The memory test: if someone left after one viewport, what would they describe an hour later? If the honest answer is a mood ("clean", "tasteful"), the concept hasn't committed yet.
## State the direction
**Everything bold, nothing bland.** Bold is not decoration and not clutter; it is commitment to the concept, carried through every section. Commitment takes whatever form the concept and the mode demand: maximal or severely clean, drenched in color or nearly monochrome, copy so precise it stings, the product demonstrating itself, or a system so exact it feels inevitable (a decisive typographic voice, one owned accent, an unmistakable rhythm). A spare page built on one uncompromising idea is bold; a busy page of tasteful defaults is bland. The signature is where the concept peaks, not the only place it lives; cut anything that neither advances the concept nor serves the visitor's mode. Polish is the floor, not the point: when torn between refined and committed, commit.
Before code, write a task-scoped direction contract of at most 120 words in your reasoning:
**Prove, don't claim.** A surface earns belief by showing its subject doing its job: the interface at work, the mechanism dramatized, the content delivering, specifics a competitor couldn't copy-paste. The visitor should understand by looking, before reading a word. Sections that restate a claim in different words add length, not substance, and a page that demonstrates everything you discovered while planning reads as cruft: build only the sections a visitor needs to understand, trust, and act.
- the thesis this surface owns;
- the structural or behavioral transformation;
- what authority is preserved;
- the first viewport's composition and primary action;
- the signature element the surface will be remembered by.
## Commit
Do not embed this contract as a comment in the production artifact or turn it into a second design system. In an attended substantial build, confirm it once. In an unattended run, record it and continue.
Pick a color strategy before picking colors: Restrained (neutrals + one accent; the default when the visitor came to operate or read) / Committed (one saturated color carries 30-60% of the surface) / Full palette (3-4 named roles) / Drenched (the surface IS the color). Persuade and Experience surfaces have permission for the bolder strategies; take them when the brief allows. Dark vs. light is never a default: write one sentence of physical scene (who uses this, where, under what light, in what mood) and let it force the answer. The warm cream near-white body background is the saturated AI default; where the axis is free, pick a background that is a choice.
## Build once, commit fully
- Name a real reference before picking a strategy; unnamed ambition becomes beige.
- Palette IS voice: a calm brand and a restless brand should not share palette mechanics, and each new surface differentiates from the last.
- When a cultural-symbol palette is the obvious pull, reach past it. Let the cultural reading come from typography, imagery, and copy, not the palette.
Plan one compact token system and one layout source: the concept or the content's real structure. Build the strongest coherent direction once. Commitment means the transformation governs the whole surface; it does not mean every control must be rebuilt as a metaphor.
## Type and imagery
Make the first viewport demonstrate the product's mechanism. Pace long surfaces through contrast in density and scale, and cut sections that only repeat claims. Briefs that depend on imagery ship real, verified imagery. Preserve semantic HTML, familiar interaction behavior, accessibility, and the project's technical conventions.
Choose faces like objects from the subject's world, in the mode's register: Operate and Read surfaces are well served by system stacks and workhorse UI faces; Persuade and Experience surfaces want faces with a point of view, and these training-data defaults mean you stopped looking: Fraunces, Playfair Display, Cormorant, Lora, Crimson, Newsreader, Syne, Space Grotesk, Space Mono, IBM Plex, Inter-as-display, DM Sans, DM Serif, Outfit, Plus Jakarta Sans, Instrument Sans.
## Finish proportionally
Briefs that imply imagery (food, travel, place, product, fashion) must ship real, verified imagery, searched for the subject's physical object rather than the category; a colored rectangle where a photo belongs reads as incomplete, and one decisive photo beats five mediocre ones. Verify stock URLs resolve before shipping them.
## Calibration
AI-generated interfaces cluster around a few looks regardless of subject: warm cream + high-contrast serif + terracotta accent; near-black + one neon accent (acid green, cyan) + glowing edges; broadsheet-editorial hairlines + italic display serif + small tracked mono labels. All are legitimate when the brief calls for them; the brief always wins. Where the brief leaves the aesthetic free, landing in one of them means your self-check failed. Same one tier deeper: if someone could guess your aesthetic from the category alone, or from category-plus-avoidance, rework until neither answer is obvious.
**Name the aesthetic lane, then test it.** Before committing to moves, say which lane this is (a specimen page, minimal-cool tech, acid maximalism...). Then the inverse test: describe what you're about to build the way a competitor would describe theirs; if that sentence fits the modal page in the category, restart. Currently saturated lanes count as reflexes, not choices, when the brief doesn't require them; the flooded one right now is editorial-typographic (display serif, often italic, small mono labels, ruled separators, monochromatic restraint, no imagery).
## Persuade and Experience moves
Layout: asymmetric compositions and intentional grid breaks are on the table; fluid spacing with `clamp()` that breathes on larger viewports; for image-led briefs, full-bleed hero imagery with overlaid navigation is a canonical move, letting the photograph be the design. Permissions the Operate world doesn't get: ambitious first-load motion (one orchestrated page-load beats scattered micro-interactions; skipping entrance motion entirely is also a voice), single-purpose viewports (one dominant idea per fold, deliberate pacing), and art direction per section when the narrative demands it; consistency of voice beats consistency of treatment.
## Finish like a studio
Look at what you built the way a design lead would, with whatever eyes the harness gives you (browser, screenshot tool, or reading the code cold): major sections individually on long pages, mobile and desktop at minimum. Write an honest critique against the brief and the stated direction, patch material defects, and re-inspect; don't invent defects to demonstrate diligence. Then verify against SKILL.md's craft floor and run the detector; a bold page that ships mechanical defects is not done, and neither is a polished page missing something the brief asked for.
When the harness can run a separate agent, the review above belongs there, not here: hand the reviewer the artifact path, its direction contract, and the detector command, and have it return a short list of material fixes; apply them and finish. A fresh reader catches what the builder's own eyes slide past, and the build thread stays spent on building.
Inspect desktop and mobile, write one honest critique against the brief and direction, patch material defects, then run the detector once. Repeat only when a real defect remains. A separate reviewer is optional when the harness already provides one and the extra cost is earned by the risk; it is not a default step and its presence is not evidence of quality.
plugin/skills/impeccable/scripts/context.mjs
+119 -22
View File
@@ -42,6 +42,11 @@ const WORKSPACE_DISCOVERY_IGNORED_DIRS = new Set([
'.cache',
'coverage',
]);
const VISUAL_SOURCE_DIRS = ['src', 'app', 'pages', 'components', 'site', 'public', 'styles'];
const STYLE_EXTENSIONS = new Set(['.css', '.scss', '.sass', '.less', '.styl']);
const UI_EXTENSIONS = new Set(['.html', '.htm', '.jsx', '.tsx', '.vue', '.svelte', '.astro']);
const VISUAL_SCAN_FILE_LIMIT = 250;
const VISUAL_SCAN_DEPTH_LIMIT = 4;
// ─── Update check ──────────────────────────────────────────────────────────
// Piggyback a lightweight skill-version check on the once-per-session boot.
@@ -78,6 +83,7 @@ export function loadContext(cwd = process.cwd(), options = {}) {
contextDir: resolved.contextDir,
productContextDir: productPath ? path.dirname(productPath) : null,
designContextDir: designPath ? path.dirname(designPath) : null,
hasVisualImplementation: hasVisualImplementation(resolved.projectRoot),
projectRoot: resolved.projectRoot,
repoRoot: resolved.repoRoot,
isMonorepo: resolved.isMonorepo,
@@ -690,6 +696,85 @@ function safeRead(p) {
}
}
/**
* Best-effort evidence that the project already has an incumbent visual
* implementation. DESIGN.md is documentation, not the only source of design
* authority: real tokens, chosen type, and a component system in code must not
* be mistaken for a greenfield identity merely because the document is absent.
*
* The scan is deliberately bounded and conservative. A package.json or one
* empty scaffold component is not enough; a tokenized stylesheet, an authored
* HTML surface, or several styled UI components is.
*/
export function hasVisualImplementation(projectRoot) {
if (!projectRoot) return false;
const root = path.resolve(projectRoot);
const queue = [];
for (const rel of VISUAL_SOURCE_DIRS) {
const dir = path.join(root, rel);
if (fs.existsSync(dir)) queue.push({ dir, depth: 0 });
}
let scannedFiles = 0;
let styledComponents = 0;
const inspectFile = (filePath) => {
if (scannedFiles++ >= VISUAL_SCAN_FILE_LIMIT) return false;
const ext = path.extname(filePath).toLowerCase();
if (!STYLE_EXTENSIONS.has(ext) && !UI_EXTENSIONS.has(ext)) return false;
let body;
try {
body = fs.readFileSync(filePath, 'utf-8').slice(0, 64 * 1024);
} catch {
return false;
}
const base = path.basename(filePath).toLowerCase();
if (STYLE_EXTENSIONS.has(ext)) {
const customProperties = body.match(/--[a-z0-9_-]+\s*:/gi)?.length ?? 0;
const visualDeclarations = body.match(/\b(?:color|background(?:-color)?|border(?:-color)?|font-family)\s*:/gi)?.length ?? 0;
if (/\b(?:tokens?|theme|design-system)\b/.test(base) && body.trim().length > 80) return true;
if (customProperties >= 3 || visualDeclarations >= 5) return true;
}
if ((ext === '.html' || ext === '.htm') && body.length > 600 && /<style\b|<link[^>]+stylesheet/i.test(body)) {
return true;
}
if (!['.html', '.htm'].includes(ext) && body.length > 300 && /class(?:Name)?\s*=|style\s*=|styled\(|css`/i.test(body)) {
styledComponents += 1;
if (styledComponents >= 3) return true;
}
return false;
};
// Root-level authored surfaces and styles are common in small projects.
try {
for (const entry of fs.readdirSync(root, { withFileTypes: true })) {
if (entry.isFile() && inspectFile(path.join(root, entry.name))) return true;
}
} catch { /* unreadable root: no evidence */ }
while (queue.length && scannedFiles < VISUAL_SCAN_FILE_LIMIT) {
const { dir, depth } = queue.shift();
let entries;
try {
entries = fs.readdirSync(dir, { withFileTypes: true });
} catch {
continue;
}
for (const entry of entries) {
if (entry.isDirectory()) {
if (depth >= VISUAL_SCAN_DEPTH_LIMIT || entry.name.startsWith('.') || WORKSPACE_DISCOVERY_IGNORED_DIRS.has(entry.name)) continue;
queue.push({ dir: path.join(dir, entry.name), depth: depth + 1 });
} else if (entry.isFile() && inspectFile(path.join(dir, entry.name))) {
return true;
}
if (scannedFiles >= VISUAL_SCAN_FILE_LIMIT) break;
}
}
return styledComponents >= 3;
}
function escapeRegExp(value) {
return String(value).replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
}
@@ -897,21 +982,32 @@ async function cli() {
if (!ctx.hasProduct) {
// Direct stdout message instead of relying on empty output as a signal
// — cheap models miss the empty case more often than the explicit one.
const parts = [
'NO_PRODUCT_MD: This project has no PRODUCT.md yet. ' +
'For `init`, `teach`, `craft`, `shape`, ' +
'or wording that clearly maps to a from-scratch build/shape flow, load ' +
'reference/init.md and write PRODUCT.md first, unless no user can ' +
'respond (a one-shot or automated run, or the user said not to ask): ' +
'then write a one-paragraph understanding of the product, audience, ' +
'and the page\'s job from the brief, and continue. For any other ' +
'(scoped) command against existing code, proceed using the code as ' +
`context and offer \`${IMPECCABLE_COMMAND} init\` as a suggestion (do not block).`,
'NEW_WORK: No committed design context was found. If this task produces ' +
'new design (a build from scratch, or a redesign that discards the ' +
'current look), you MUST read reference/new-work.md before making any ' +
'design decision. Scoped fixes to existing code do not need it.',
];
const parts = ctx.hasVisualImplementation
? [
'NO_PRODUCT_MD: This project has no PRODUCT.md yet, but it does have an incumbent visual implementation. ' +
'For `init` or `teach`, load reference/init.md and create PRODUCT.md. For `craft`, `shape`, or other work ' +
'against the existing product, read its CSS, tokens, components, and assets first and proceed without blocking; ' +
`offer \`${IMPECCABLE_COMMAND} init\` as a follow-up. Only treat the work as greenfield when the user explicitly ` +
'asks to discard or replace the current identity.',
'EXISTING_VISUAL_SYSTEM: Code and assets are the incumbent design authority. Missing DESIGN.md is a documentation ' +
'gap, not permission to invent a replacement identity. Preserve and extend the implementation unless the user ' +
'explicitly requests a rebrand, or inspection proves the detected files contain no coherent visual decisions.',
]
: [
'NO_PRODUCT_MD: This project has no PRODUCT.md yet. ' +
'For `init`, `teach`, `craft`, `shape`, ' +
'or wording that clearly maps to a from-scratch build/shape flow, load ' +
'reference/init.md and write PRODUCT.md first, unless no user can ' +
'respond (a one-shot or automated run, or the user said not to ask): ' +
'then write a one-paragraph understanding of the product, audience, ' +
'and the page\'s job from the brief, and continue. For any other ' +
'(scoped) command against existing code, proceed using the code as ' +
`context and offer \`${IMPECCABLE_COMMAND} init\` as a suggestion (do not block).`,
'NEW_WORK: No committed design context was found. If this task produces ' +
'new design (a build from scratch, or a redesign that discards the ' +
'current look), you MUST read reference/new-work.md before making any ' +
'design decision. Scoped fixes to existing code do not need it.',
];
parts.push(buildResolvedContextDirective(ctx, cliOptions, { targetExists }));
if (shouldWarnMissingTarget(ctx, targetProvided, targetExists)) {
parts.push(buildMissingTargetDirective());
@@ -934,13 +1030,13 @@ async function cli() {
// inline, so no register-file read is mandated here. What IS mandated:
// the new-work playbook when no committed design system exists yet.
if (!ctx.hasDesign) {
parts.push(
'NEW_WORK: PRODUCT.md exists but no DESIGN.md was found. If the code ' +
'has no committed design system either (check the project files), and ' +
'this task produces new design or a redesign that discards the current ' +
'look, you MUST read reference/new-work.md before making any design ' +
'decision. Scoped fixes inside an existing design system do not need it.',
);
parts.push(ctx.hasVisualImplementation
? 'EXISTING_VISUAL_SYSTEM: PRODUCT.md exists and DESIGN.md is missing, but code contains incumbent visual decisions. ' +
'Treat CSS, tokens, components, and assets as design authority. Do not route to new identity work merely because the ' +
'document is absent; preserve and extend the implementation unless the user explicitly asks to discard it.'
: 'NEW_WORK: PRODUCT.md exists but no DESIGN.md or incumbent visual implementation was found. If this task produces ' +
'new design or a redesign that discards the current look, you MUST read reference/new-work.md before making any ' +
'design decision. Scoped fixes to existing code do not need it.');
}
if (register) {
parts.push(`REGISTER: \`${register}\` (family hint: brand = Persuade/Experience surfaces, product = Operate/Read). Derive the visitor's mode per SKILL.md.`);
@@ -991,6 +1087,7 @@ function buildResolvedContextDirective(ctx, options, { targetExists = null } = {
repoRoot: ctx.repoRoot,
productPath: ctx.productPath,
designPath: ctx.designPath,
hasVisualImplementation: ctx.hasVisualImplementation,
}, null, 2)}`;
}
plugin/skills/impeccable/scripts/detector/detect-antipatterns-browser.js
+8 -26
View File
@@ -1264,11 +1264,6 @@ function findShadowColor(layer) {
if (fn) return { color: parseAnyColor(fn[0]), start: fn.index, end: fn.index + fn[0].length };
const hex = layer.match(/#[0-9a-fA-F]{3,8}\b/);
if (hex) return { color: parseAnyColor(hex[0]), start: hex.index, end: hex.index + hex[0].length };
// Keep unresolved custom properties intact as one color token. Otherwise
// names such as `--signal-blue` are accidentally parsed as the named color
// `blue`, and digits in names such as `--accent-500` become shadow lengths.
const variable = layer.match(/var\([^)]*\)/i);
if (variable) return { color: null, start: variable.index, end: variable.index + variable[0].length };
const wordRe = /[a-zA-Z][a-zA-Z]*/g;
let m;
while ((m = wordRe.exec(layer)) !== null) {
@@ -1278,13 +1273,6 @@ function findShadowColor(layer) {
return null;
}
const CHROMATIC_CUSTOM_PROPERTY_HINT_RE = /(?:^|-)(?:accent|kinpaku|patina|gold|red|orange|amber|yellow|lime|green|emerald|teal|cyan|blue|indigo|violet|purple|magenta|pink|rose|coral|aqua|mint|burgundy|crimson|scarlet)(?:-|$)/i;
function unresolvedShadowTokenLooksChromatic(layer) {
const variable = layer.match(/var\(\s*(--[\w-]+)/i);
return variable ? CHROMATIC_CUSTOM_PROPERTY_HINT_RE.test(variable[1]) : false;
}
// Extract the length values of a shadow layer in declaration order, with the
// color token removed so its components aren't misread as lengths. Handles
// computed-style px values AND authored unitless zeros ("0 0 20px"); rem/em
@@ -1686,22 +1674,16 @@ function scanCssTextForInsetStripe(content) {
// menu items — are wider or leave width to layout.
const declaredWidth = cssLengthToPx(resolveVarRefs(decls.get('width') || decls.get('inline-size') || '', customProps));
if (declaredWidth != null && declaredWidth <= 40) continue;
for (const authoredLayer of shadow.split(/,(?![^(]*\))/)) {
const layer = resolveVarRefs(authoredLayer, customProps);
const value = resolveVarRefs(shadow, customProps);
for (const layer of value.split(/,(?![^(]*\))/)) {
if (!/\binset\b/i.test(layer)) continue;
const colorInfo = findShadowColor(layer);
if (!colorInfo) continue;
if (colorInfo.color) {
const c = colorInfo.color;
if ((c.a ?? 1) < 0.1) continue;
const chroma = Math.max(c.r, c.g, c.b) - Math.min(c.r, c.g, c.b);
if (chroma < 30) continue;
} else if (!unresolvedShadowTokenLooksChromatic(authoredLayer)) {
// External custom properties are unknowable in an isolated artifact.
// Only explicit accent or hue semantics justify treating one as
// chromatic; neutral shadow/divider tokens and currentColor stay legal.
continue;
}
// Unresolvable colors (currentColor, external vars): don't guess.
if (!colorInfo || !colorInfo.color) continue;
const c = colorInfo.color;
if ((c.a ?? 1) < 0.1) continue;
const chroma = Math.max(c.r, c.g, c.b) - Math.min(c.r, c.g, c.b);
if (chroma < 30) continue;
const vals = extractShadowLengths(layer, colorInfo.start, colorInfo.end);
const x = vals[0] || 0, y = vals[1] || 0, blur = vals[2] || 0, sp = vals[3] || 0;
if (blur !== 0 || sp !== 0) continue;
plugin/skills/impeccable/scripts/detector/engines/regex/detect-text.mjs
+4 -26
View File
@@ -2,7 +2,7 @@ import { GENERIC_FONTS, OVERUSED_FONTS } from '../../shared/constants.mjs';
import { isNeutralColor } from '../../shared/color.mjs';
import { extractGoogleFontFamilies } from '../../shared/fonts.mjs';
import { checkSourceDesignSystem } from '../../design-system.mjs';
import { scanCssTextForGlow, scanCssTextForInsetStripe, scanCssTextForMarquee, scanCssTextForRadialHalo } from '../../rules/checks.mjs';
import { scanCssTextForGlow, scanCssTextForMarquee, scanCssTextForRadialHalo } from '../../rules/checks.mjs';
import { isFullPage } from '../../shared/page.mjs';
import { applyInlineIgnores } from '../../shared/inline-ignores.mjs';
import { finding } from '../../findings.mjs';
@@ -340,12 +340,12 @@ const REGEX_ANALYZERS = [
];
// ---------------------------------------------------------------------------
// Style block extraction (Astro/Vue/Svelte <style> blocks)
// Style block extraction (Vue/Svelte <style> blocks)
// ---------------------------------------------------------------------------
function extractStyleBlocks(content, ext) {
ext = ext.toLowerCase();
if (ext !== '.astro' && ext !== '.vue' && ext !== '.svelte') return [];
if (ext !== '.vue' && ext !== '.svelte') return [];
const blocks = [];
const re = /<style[^>]*>([\s\S]*?)<\/style>/gi;
let m;
@@ -472,16 +472,8 @@ function detectText(content, filePath, options = {}) {
profile,
phase: 'source',
}));
if (cssLike.has(ext)) {
findings.push(...profileFindings(profile, {
engine: 'regex',
phase: 'source',
ruleId: 'side-tab',
target: filePath,
}, () => scanCssTextForInsetStripe(content).map(hit => finding(hit.id, filePath, hit.snippet))));
}
// Extract and scan <style> blocks from Astro/Vue/Svelte components.
// Extract and scan <style> blocks from Vue/Svelte SFCs
const styleBlocks = profile
? profileStep(profile, {
engine: 'regex',
@@ -496,13 +488,6 @@ function detectText(content, filePath, options = {}) {
profile,
phase: 'style-block',
}));
findings.push(...profileFindings(profile, {
engine: 'regex',
phase: 'style-block',
ruleId: 'side-tab',
target: filePath,
}, () => scanCssTextForInsetStripe(block.content)
.map(hit => finding(hit.id, filePath, hit.snippet, block.startLine))));
}
// Extract and scan CSS-in-JS template literals
@@ -520,13 +505,6 @@ function detectText(content, filePath, options = {}) {
profile,
phase: 'css-in-js',
}));
findings.push(...profileFindings(profile, {
engine: 'regex',
phase: 'css-in-js',
ruleId: 'side-tab',
target: filePath,
}, () => scanCssTextForInsetStripe(block.content)
.map(hit => finding(hit.id, filePath, hit.snippet, block.startLine))));
}
if (options?.designSystem) {
plugin/skills/impeccable/scripts/detector/rules/checks.mjs
+8 -26
View File
@@ -475,11 +475,6 @@ function findShadowColor(layer) {
if (fn) return { color: parseAnyColor(fn[0]), start: fn.index, end: fn.index + fn[0].length };
const hex = layer.match(/#[0-9a-fA-F]{3,8}\b/);
if (hex) return { color: parseAnyColor(hex[0]), start: hex.index, end: hex.index + hex[0].length };
// Keep unresolved custom properties intact as one color token. Otherwise
// names such as `--signal-blue` are accidentally parsed as the named color
// `blue`, and digits in names such as `--accent-500` become shadow lengths.
const variable = layer.match(/var\([^)]*\)/i);
if (variable) return { color: null, start: variable.index, end: variable.index + variable[0].length };
const wordRe = /[a-zA-Z][a-zA-Z]*/g;
let m;
while ((m = wordRe.exec(layer)) !== null) {
@@ -489,13 +484,6 @@ function findShadowColor(layer) {
return null;
}
const CHROMATIC_CUSTOM_PROPERTY_HINT_RE = /(?:^|-)(?:accent|kinpaku|patina|gold|red|orange|amber|yellow|lime|green|emerald|teal|cyan|blue|indigo|violet|purple|magenta|pink|rose|coral|aqua|mint|burgundy|crimson|scarlet)(?:-|$)/i;
function unresolvedShadowTokenLooksChromatic(layer) {
const variable = layer.match(/var\(\s*(--[\w-]+)/i);
return variable ? CHROMATIC_CUSTOM_PROPERTY_HINT_RE.test(variable[1]) : false;
}
// Extract the length values of a shadow layer in declaration order, with the
// color token removed so its components aren't misread as lengths. Handles
// computed-style px values AND authored unitless zeros ("0 0 20px"); rem/em
@@ -897,22 +885,16 @@ function scanCssTextForInsetStripe(content) {
// menu items — are wider or leave width to layout.
const declaredWidth = cssLengthToPx(resolveVarRefs(decls.get('width') || decls.get('inline-size') || '', customProps));
if (declaredWidth != null && declaredWidth <= 40) continue;
for (const authoredLayer of shadow.split(/,(?![^(]*\))/)) {
const layer = resolveVarRefs(authoredLayer, customProps);
const value = resolveVarRefs(shadow, customProps);
for (const layer of value.split(/,(?![^(]*\))/)) {
if (!/\binset\b/i.test(layer)) continue;
const colorInfo = findShadowColor(layer);
if (!colorInfo) continue;
if (colorInfo.color) {
const c = colorInfo.color;
if ((c.a ?? 1) < 0.1) continue;
const chroma = Math.max(c.r, c.g, c.b) - Math.min(c.r, c.g, c.b);
if (chroma < 30) continue;
} else if (!unresolvedShadowTokenLooksChromatic(authoredLayer)) {
// External custom properties are unknowable in an isolated artifact.
// Only explicit accent or hue semantics justify treating one as
// chromatic; neutral shadow/divider tokens and currentColor stay legal.
continue;
}
// Unresolvable colors (currentColor, external vars): don't guess.
if (!colorInfo || !colorInfo.color) continue;
const c = colorInfo.color;
if ((c.a ?? 1) < 0.1) continue;
const chroma = Math.max(c.r, c.g, c.b) - Math.min(c.r, c.g, c.b);
if (chroma < 30) continue;
const vals = extractShadowLengths(layer, colorInfo.start, colorInfo.end);
const x = vals[0] || 0, y = vals[1] || 0, blur = vals[2] || 0, sp = vals[3] || 0;
if (blur !== 0 || sp !== 0) continue;
plugin/skills/impeccable/scripts/lib/impeccable-paths.mjs
-4
View File
@@ -60,10 +60,6 @@ export function getLiveServerPath(cwd = process.cwd(), options = {}) {
return path.join(getLiveDir(cwd, options), 'server.json');
}
export function getLiveCodexWorkerStatePath(cwd = process.cwd(), options = {}) {
return path.join(getLiveDir(cwd, options), 'codex-worker.json');
}
export function getLegacyLiveServerPath(cwd = process.cwd(), options = {}) {
return path.join(resolveProjectRoot(cwd, options), '.impeccable-live.json');
}
plugin/skills/impeccable/scripts/live-accept.mjs
+18 -244
View File
@@ -16,27 +16,15 @@
import fs from 'node:fs';
import path from 'node:path';
import { isGeneratedFile } from './lib/is-generated.mjs';
import { getLiveDir } from './lib/impeccable-paths.mjs';
import { readBuffer as readManualEditsBuffer, writeBuffer as writeManualEditsBuffer } from './live/manual-edits-buffer.mjs';
import { withSourceLockSync } from './live/source-lock.mjs';
import {
applyDeferredSvelteComponentAccepts,
findSvelteComponentManifest,
inlineSvelteComponentAccept,
removeSvelteComponentSession,
} from './live/svelte-component.mjs';
import {
findVueComponentManifest,
inlineVueComponentAccept,
retireVueComponentSession,
} from './live/vue-component.mjs';
import {
findSourceArtifactManifest,
removeSourceArtifactSession,
} from './live/source-artifact.mjs';
const EXTENSIONS = ['.html', '.jsx', '.tsx', '.vue', '.svelte', '.astro'];
const ACCEPT_LOCK_WAIT_MS = 1_000;
// ---------------------------------------------------------------------------
// CLI
@@ -77,32 +65,6 @@ Output (JSON):
if (!id) { console.error('Missing --id'); process.exit(1); }
if (!isDiscard && !variantNum) { console.error('Need --discard or --variant N'); process.exit(1); }
const requestedOperation = isDiscard ? 'discard' : 'accept';
const priorReceipt = readAcceptReceipt(process.cwd(), id);
if (priorReceipt) {
const sameOperation = priorReceipt.operation === requestedOperation
&& (isDiscard || String(priorReceipt.variantId) === String(variantNum));
console.log(JSON.stringify(sameOperation
? { ...priorReceipt.result, handled: true, alreadyApplied: true }
: {
handled: false,
error: 'accept_receipt_conflict',
priorOperation: priorReceipt.operation,
priorVariantId: priorReceipt.variantId ?? null,
}));
return;
}
const emitResult = (result) => {
if (result?.handled !== false) {
writeAcceptReceipt(process.cwd(), id, {
operation: requestedOperation,
variantId: isDiscard ? null : String(variantNum),
result,
});
}
console.log(JSON.stringify(result));
};
let paramValues = null;
if (paramValuesRaw) {
try { paramValues = JSON.parse(paramValuesRaw); }
@@ -110,147 +72,34 @@ Output (JSON):
}
// Find the file containing this session's markers
const sourceArtifactManifest = findSourceArtifactManifest(id, process.cwd());
const found = sourceArtifactManifest ? null : findSessionFile(id, process.cwd());
const found = findSessionFile(id, process.cwd());
const svelteComponentManifest = found ? null : findSvelteComponentManifest(id, process.cwd());
const vueComponentManifest = found || svelteComponentManifest ? null : findVueComponentManifest(id, process.cwd());
if (!found && !sourceArtifactManifest && !svelteComponentManifest && !vueComponentManifest) {
if (!found && !svelteComponentManifest) {
console.log(JSON.stringify({ handled: false, error: 'Session markers not found for id: ' + id }));
process.exit(0);
}
if (sourceArtifactManifest) {
if (isDiscard) {
removeSourceArtifactSession(id, process.cwd());
emitResult({
handled: true,
file: sourceArtifactManifest.sourceFile,
sourceFile: sourceArtifactManifest.sourceFile,
previewMode: sourceArtifactManifest.previewMode,
carbonize: false,
});
return;
}
let result;
try {
result = withSourceLockSync(
sourceArtifactManifest.sourcePath,
'accept:' + id,
() => acceptSourceArtifact(sourceArtifactManifest, variantNum, paramValues),
{ waitMs: ACCEPT_LOCK_WAIT_MS },
);
} catch (err) {
result = { handled: false, error: err.message };
}
if (result.handled !== false) {
removeSourceArtifactSession(id, process.cwd());
try {
scrubManualEditsAgainstOriginalBlock(result.acceptedOriginalText || '', process.cwd(), pageUrl);
} catch {}
}
delete result.acceptedOriginalText;
if (result.carbonize) {
result.todo = 'REQUIRED before next poll: carbonize cleanup in ' + sourceArtifactManifest.sourceFile + '. See reference/live.md "Required after accept".';
}
emitResult({
handled: result.handled !== false,
file: sourceArtifactManifest.sourceFile,
sourceFile: sourceArtifactManifest.sourceFile,
previewMode: sourceArtifactManifest.previewMode,
...result,
});
return;
}
if (vueComponentManifest) {
if (isDiscard) {
let result;
try {
result = withSourceLockSync(
path.resolve(process.cwd(), vueComponentManifest.sourceFile),
'discard:' + id,
() => {
retireVueComponentSession(id, process.cwd());
return { handled: true };
},
{ waitMs: ACCEPT_LOCK_WAIT_MS },
);
} catch (err) {
result = { handled: false, error: err.message };
}
emitResult({
...result,
file: vueComponentManifest.sourceFile,
carbonize: false,
previewMode: 'vue-component',
componentDir: vueComponentManifest.componentDir,
});
return;
}
let result;
try {
result = withSourceLockSync(
path.resolve(process.cwd(), vueComponentManifest.sourceFile),
'accept:' + id,
() => inlineVueComponentAccept(vueComponentManifest, variantNum, process.cwd()),
{ waitMs: ACCEPT_LOCK_WAIT_MS },
);
} catch (err) {
result = {
handled: false,
error: err.message,
file: vueComponentManifest.sourceFile,
sourceFile: vueComponentManifest.sourceFile,
previewMode: 'vue-component',
componentDir: vueComponentManifest.componentDir,
carbonize: false,
};
}
emitResult(result);
return;
}
if (svelteComponentManifest) {
if (isDiscard) {
let result;
try {
result = withSourceLockSync(
path.resolve(process.cwd(), svelteComponentManifest.sourceFile),
'discard:' + id,
() => {
removeSvelteComponentSession(id, process.cwd());
return { handled: true };
},
{ waitMs: ACCEPT_LOCK_WAIT_MS },
);
} catch (err) {
result = { handled: false, error: err.message };
}
emitResult({
...result,
removeSvelteComponentSession(id, process.cwd());
console.log(JSON.stringify({
handled: true,
file: svelteComponentManifest.sourceFile,
carbonize: false,
previewMode: 'svelte-component',
componentDir: svelteComponentManifest.componentDir,
});
}));
return;
}
let result;
try {
result = withSourceLockSync(
path.resolve(process.cwd(), svelteComponentManifest.sourceFile),
'accept:' + id,
() => inlineSvelteComponentAccept(
svelteComponentManifest,
variantNum,
paramValues,
process.cwd(),
),
{ waitMs: ACCEPT_LOCK_WAIT_MS },
result = inlineSvelteComponentAccept(
svelteComponentManifest,
variantNum,
paramValues,
process.cwd(),
);
} catch (err) {
result = {
@@ -265,7 +114,7 @@ Output (JSON):
if (result.carbonize) {
result.todo = 'REQUIRED before next poll: carbonize cleanup in ' + result.file + '. See reference/live.md "Required after accept".';
}
emitResult({ handled: result.handled !== false, ...result });
console.log(JSON.stringify({ handled: result.handled !== false, ...result }));
return;
}
@@ -297,7 +146,7 @@ Output (JSON):
if (isDiscard) {
const result = handleDiscard(id, lines, targetFile);
emitResult({ handled: true, file: relFile, carbonize: false, ...result });
console.log(JSON.stringify({ handled: true, file: relFile, carbonize: false, ...result }));
} else {
const result = handleAccept(id, variantNum, lines, targetFile, paramValues);
const acceptedOriginalText = result.acceptedOriginalText || '';
@@ -318,7 +167,7 @@ Output (JSON):
// Non-fatal; the buffer stays as-is and the user can discard later.
}
}
emitResult({ handled: true, file: relFile, ...result });
console.log(JSON.stringify({ handled: true, file: relFile, ...result }));
}
}
@@ -386,14 +235,7 @@ function scrubManualEditsAgainstFile(_targetFile, cwd = process.cwd(), originalB
// Discard
// ---------------------------------------------------------------------------
function handleDiscard(id, _lines, targetFile) {
return withSourceLockSync(targetFile, 'discard:' + id, () => {
const lines = fs.readFileSync(targetFile, 'utf-8').split('\n');
return handleDiscardUnlocked(id, lines, targetFile);
}, { waitMs: ACCEPT_LOCK_WAIT_MS });
}
function handleDiscardUnlocked(id, lines, targetFile) {
function handleDiscard(id, lines, targetFile) {
const block = findMarkerBlock(id, lines);
if (!block) return { handled: false, error: 'Markers not found' };
@@ -488,24 +330,7 @@ function reindentContent(contentLines, fromIndent, toIndent) {
});
}
function handleAccept(id, variantNum, _lines, targetFile, paramValues) {
return withSourceLockSync(targetFile, 'accept:' + id, () => {
const lines = fs.readFileSync(targetFile, 'utf-8').split('\n');
return handleAcceptUnlocked(id, variantNum, lines, targetFile, paramValues);
}, { waitMs: ACCEPT_LOCK_WAIT_MS });
}
function handleAcceptUnlocked(id, variantNum, lines, targetFile, paramValues) {
const built = buildAcceptedWrappedSource(id, variantNum, lines, targetFile, paramValues);
if (built.handled === false) return built;
fs.writeFileSync(targetFile, built.content, 'utf-8');
return {
carbonize: built.carbonize,
acceptedOriginalText: built.acceptedOriginalText,
};
}
function buildAcceptedWrappedSource(id, variantNum, lines, targetFile, paramValues) {
function handleAccept(id, variantNum, lines, targetFile, paramValues) {
const block = findMarkerBlock(id, lines);
if (!block) return { handled: false, error: 'Markers not found' };
@@ -550,38 +375,9 @@ function buildAcceptedWrappedSource(id, variantNum, lines, targetFile, paramValu
...replacement,
...lines.slice(replaceRange.end + 1),
];
return {
content: newLines.join('\n'),
carbonize: needsCarbonize,
acceptedOriginalText: originalContent.join('\n'),
};
}
fs.writeFileSync(targetFile, newLines.join('\n'), 'utf-8');
function acceptSourceArtifact(manifest, variantNum, paramValues) {
const source = fs.readFileSync(manifest.sourcePath, 'utf-8');
const preview = fs.readFileSync(manifest.previewPath, 'utf-8');
const original = String(manifest.originalSource || '');
if (!original) return { handled: false, error: 'source_artifact_original_missing' };
const first = source.indexOf(original);
if (first < 0) return { handled: false, error: 'source_artifact_original_changed' };
if (source.indexOf(original, first + original.length) >= 0) {
return { handled: false, error: 'source_artifact_original_ambiguous' };
}
const wrapped = source.slice(0, first) + preview + source.slice(first + original.length);
const built = buildAcceptedWrappedSource(
manifest.id,
variantNum,
wrapped.split('\n'),
manifest.sourcePath,
paramValues,
);
if (built.handled === false) return built;
fs.writeFileSync(manifest.sourcePath, built.content, 'utf-8');
return {
handled: true,
carbonize: built.carbonize,
acceptedOriginalText: built.acceptedOriginalText,
};
return { carbonize: needsCarbonize, acceptedOriginalText: originalContent.join('\n') };
}
function readSourceShadowPreviewMeta(content, id) {
@@ -1002,28 +798,6 @@ function searchDir(dir, query, seen, depth) {
// Utilities
// ---------------------------------------------------------------------------
function acceptReceiptPath(cwd, id) {
return path.join(getLiveDir(cwd), 'accept-receipts', `${id}.json`);
}
function readAcceptReceipt(cwd, id) {
try { return JSON.parse(fs.readFileSync(acceptReceiptPath(cwd, id), 'utf-8')); } catch { return null; }
}
function writeAcceptReceipt(cwd, id, receipt) {
const file = acceptReceiptPath(cwd, id);
fs.mkdirSync(path.dirname(file), { recursive: true });
const value = {
id,
...receipt,
completedAt: new Date().toISOString(),
};
const temporary = `${file}.${process.pid}.${Date.now()}.tmp`;
fs.writeFileSync(temporary, JSON.stringify(value, null, 2) + '\n', 'utf-8');
fs.renameSync(temporary, file);
return value;
}
function argVal(args, flag) {
const idx = args.indexOf(flag);
return idx !== -1 && idx + 1 < args.length ? args[idx + 1] : null;
plugin/skills/impeccable/scripts/live-browser.js
+104 -413
View File
File diff suppressed because it is too large Load Diff
plugin/skills/impeccable/scripts/live-codex-worker.mjs
-292
View File
@@ -1,292 +0,0 @@
#!/usr/bin/env node
import { spawn } from 'node:child_process';
import fs from 'node:fs';
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import { createCodexAppServerClient } from './live/codex-app-server-client.mjs';
import {
CODEX_CLI_SETUP_URL,
CODEX_WORKER_OWNER,
codexWorkerProcessStateIsOwned,
codexWorkerStateIsOwned,
resolveCodexExecutable,
resolveCodexWorkerConfig,
} from './live/codex-worker.mjs';
import { CodexLiveWorkerSupervisor } from './live/codex-worker-supervisor.mjs';
import {
getLiveCodexWorkerStatePath,
readLiveServerInfo,
resolveLiveConfigPath,
} from './lib/impeccable-paths.mjs';
const args = process.argv.slice(2);
const cwd = process.cwd();
const scriptPath = fileURLToPath(import.meta.url);
const scriptsDir = path.dirname(scriptPath);
const statePath = getLiveCodexWorkerStatePath(cwd);
if (args.includes('--help') || args.includes('-h')) {
console.log(`Usage: node live-codex-worker.mjs [--background [--no-wait] | --status | --stop]
Codex Live generation supervisor. It owns a separate
app-server process and dedicated worker thread; it never attaches to the
foreground desktop task.
It is enabled by default when a Codex runtime signal is present. Set
IMPECCABLE_LIVE_CODEX_WORKER=0 to use the portable foreground path.
Project config may tune the worker but cannot activate it across harnesses.
Optional environment:
IMPECCABLE_LIVE_CODEX_PROFILE quality (default) or fast
IMPECCABLE_LIVE_CODEX_MODEL Model override; otherwise a quality model is selected dynamically
IMPECCABLE_LIVE_CODEX_EFFORT Reasoning effort override (default: medium)
IMPECCABLE_CODEX_PATH Codex binary path (default: codex)
Outside Codex this command exits without polling, leaving the portable
foreground Live path unchanged.`);
process.exit(0);
}
if (args.includes('--status')) {
const state = readJson(statePath);
console.log(JSON.stringify(state
? { ...state, reachable: pidReachable(state.pid) }
: { ok: false, status: 'not_started' }));
process.exit(0);
}
if (args.includes('--stop')) {
const state = readJson(statePath);
if (state?.pid && !codexWorkerProcessStateIsOwned(state, cwd)) {
console.log(JSON.stringify({
ok: false,
status: 'not_stopped',
error: 'codex_worker_state_unowned',
}));
process.exitCode = 2;
process.exit();
}
if (!state?.pid || !pidReachable(state.pid)) {
console.log(JSON.stringify({ ok: true, status: 'not_running' }));
process.exit(0);
}
process.kill(state.pid, 'SIGTERM');
const stopped = await waitFor(
() => !pidReachable(state.pid),
positiveInteger(process.env.IMPECCABLE_LIVE_CODEX_STOP_TIMEOUT_MS, 5_000),
);
if (!stopped) {
console.log(JSON.stringify({ ok: false, status: 'stop_timeout', pid: state.pid }));
process.exitCode = 2;
process.exit();
}
console.log(JSON.stringify({ ok: true, status: 'stopped', pid: state.pid }));
process.exit(0);
}
const liveConfig = readLiveConfig(cwd);
const config = resolveCodexWorkerConfig({ env: process.env, liveConfig });
if (!config.enabled) {
console.log(JSON.stringify({
ok: false,
error: 'codex_worker_disabled',
fallback: 'foreground',
}));
process.exit(0);
}
if (args.includes('--background')) {
const existing = readJson(statePath);
if (codexWorkerProcessStateIsOwned(existing, cwd)
&& existing?.pid
&& pidReachable(existing.pid)
&& ['starting', 'ready', 'working'].includes(existing.status)) {
console.log(JSON.stringify({ ...existing, ok: true, reused: true }));
process.exit(0);
}
}
const executable = resolveCodexExecutable(config.codexPath, { cwd, env: process.env });
if (!executable.available) {
const unavailable = writeState({
ok: false,
owner: CODEX_WORKER_OWNER,
pid: null,
status: 'unavailable',
mode: 'foreground',
error: executable.error,
command: executable.command,
message: 'Codex CLI not found. Live is using the main agent for generation.',
setup: {
docsUrl: CODEX_CLI_SETUP_URL,
afterInstall: 'codex login',
},
});
console.log(JSON.stringify({ ...unavailable, fallback: 'foreground' }));
process.exit(0);
}
config.codexPath = executable.resolvedPath;
if (args.includes('--background')) {
fs.mkdirSync(path.dirname(statePath), { recursive: true });
const logPath = path.join(path.dirname(statePath), 'codex-worker.log');
const logFd = fs.openSync(logPath, 'a');
const child = spawn(process.execPath, [scriptPath, '--foreground'], {
cwd,
env: process.env,
detached: true,
stdio: ['ignore', logFd, logFd],
});
child.unref();
fs.closeSync(logFd);
const observed = readJson(statePath);
const starting = observed?.pid === child.pid && ['ready', 'working'].includes(observed.status)
? observed
: writeState({
ok: true,
owner: CODEX_WORKER_OWNER,
pid: child.pid,
status: 'starting',
threadId: null,
model: config.model,
effort: config.effort,
profile: config.profile,
delivery: config.delivery,
});
if (args.includes('--no-wait')) {
console.log(JSON.stringify({ ...starting, ok: true, starting: true, logPath }));
process.exit(0);
}
const ready = await waitFor(() => {
const state = readJson(statePath);
if (state?.pid !== child.pid) return null;
if (state.status === 'error') return state;
return ['ready', 'working'].includes(state.status) ? state : null;
}, positiveInteger(process.env.IMPECCABLE_LIVE_CODEX_START_TIMEOUT_MS, 12_000));
if (!ready || ready.status === 'error') {
let terminated = true;
if (pidReachable(child.pid)) {
process.kill(child.pid, 'SIGTERM');
terminated = Boolean(await waitFor(
() => !pidReachable(child.pid),
positiveInteger(process.env.IMPECCABLE_LIVE_CODEX_STOP_TIMEOUT_MS, 2_000),
));
}
console.log(JSON.stringify({
ok: false,
error: ready?.error || 'codex_worker_start_timeout',
fallback: terminated ? 'foreground' : null,
terminated,
childPid: child.pid,
logPath,
}));
process.exitCode = 2;
} else {
console.log(JSON.stringify({ ...ready, ok: true, logPath }));
}
process.exit();
}
await runForeground();
async function runForeground() {
const server = readLiveServerInfo(cwd)?.info;
if (!server?.port || !server?.token) {
writeState({ ok: false, status: 'error', error: 'live_server_not_running' });
process.exitCode = 1;
return;
}
const client = createCodexAppServerClient({
command: config.codexPath,
cwd,
requestTimeoutMs: 30_000,
turnTimeoutMs: 240_000,
clientInfo: {
name: 'impeccable_live',
title: 'Impeccable Live dedicated worker',
version: '0.1.0',
},
});
const supervisor = new CodexLiveWorkerSupervisor({
cwd,
base: `http://localhost:${server.port}`,
token: server.token,
client,
config,
statePath,
scriptsDir,
log: (message) => process.stderr.write(`[impeccable-codex-worker] ${message}\n`),
});
let shuttingDown = false;
const shutdown = async () => {
if (shuttingDown) return;
shuttingDown = true;
await supervisor.shutdown({ archive: true }).catch(() => {});
process.exit(0);
};
process.once('SIGINT', shutdown);
process.once('SIGTERM', shutdown);
try {
await supervisor.initialize();
await supervisor.run();
} catch (error) {
writeState({
ok: false,
status: 'error',
error: error.message,
stack: error.stack,
});
await supervisor.shutdown().catch(() => {});
process.exitCode = 1;
}
}
function readLiveConfig(projectCwd) {
const configPath = resolveLiveConfigPath({ cwd: projectCwd, scriptsDir });
return readJson(configPath) || {};
}
function writeState(value) {
fs.mkdirSync(path.dirname(statePath), { recursive: true });
const state = {
cwd: path.resolve(cwd),
pid: process.pid,
updatedAt: new Date().toISOString(),
...value,
};
const temporary = `${statePath}.${process.pid}.${Date.now()}.tmp`;
fs.writeFileSync(temporary, JSON.stringify(state, null, 2) + '\n', 'utf-8');
fs.renameSync(temporary, statePath);
return state;
}
function readJson(file) {
try { return JSON.parse(fs.readFileSync(file, 'utf-8')); } catch { return null; }
}
function pidReachable(pid) {
if (!Number.isInteger(pid) || pid < 1) return false;
try {
process.kill(pid, 0);
return true;
} catch (error) {
return error?.code === 'EPERM';
}
}
async function waitFor(check, timeoutMs) {
const deadline = Date.now() + timeoutMs;
while (Date.now() < deadline) {
const result = check();
if (result) return result;
await new Promise((resolve) => setTimeout(resolve, 25));
}
return null;
}
function positiveInteger(value, fallback) {
const parsed = Number(value);
return Number.isInteger(parsed) && parsed > 0 ? parsed : fallback;
}
plugin/skills/impeccable/scripts/live-inject.mjs
+4 -147
View File
@@ -27,8 +27,6 @@ const __dirname = path.dirname(fileURLToPath(import.meta.url));
const CONFIG_PATH = resolveLiveConfigPath({ cwd: process.cwd(), scriptsDir: __dirname });
const MARKER_OPEN_TEXT = 'impeccable-live-start';
const MARKER_CLOSE_TEXT = 'impeccable-live-end';
const NUXT_PLUGIN_MARKER = 'impeccable-live-nuxt-plugin';
const NUXT_PLUGIN_NAME = 'impeccable-live.client.ts';
const IGNORE_MARKER_OPEN = '# impeccable-live-ignore-start';
const IGNORE_MARKER_CLOSE = '# impeccable-live-ignore-end';
@@ -37,14 +35,9 @@ export const LIVE_IGNORE_PATTERNS = Object.freeze([
'.impeccable/hook.pending.json',
'.impeccable/config.local.json',
'.impeccable/live/server.json',
'.impeccable/live/codex-worker.json',
'.impeccable/live/codex-worker.log',
'.impeccable/live/sessions/',
'.impeccable/live/previews/',
'.impeccable/live/annotations/',
'.impeccable/live/artifacts/',
'.impeccable/live/accept-receipts/',
'.impeccable/live/locks/',
'.impeccable/live/cache/',
'.impeccable/live/manual-edit-apply-transaction.json',
'.impeccable/live/manual-edit-events.jsonl',
@@ -53,15 +46,10 @@ export const LIVE_IGNORE_PATTERNS = Object.freeze([
'.impeccable/live/deferred-svelte-component-accepts.json',
'.impeccable-live.json',
'.impeccable-live/',
'app/.impeccable-live/',
'src/.impeccable-live/',
'node_modules/.impeccable-live/',
'src/lib/impeccable/ImpeccableLiveRoot.svelte',
'src/lib/impeccable/__runtime.js',
'src/lib/impeccable/[0-9a-f]*/',
'plugins/impeccable-live.client.ts',
'app/plugins/impeccable-live.client.ts',
'src/plugins/impeccable-live.client.ts',
]);
/**
@@ -125,7 +113,6 @@ Output (JSON):
const resolvedFiles = resolveFiles(process.cwd(), config);
const svelteKit = detectSvelteKitProject(process.cwd(), config);
const nuxt = detectNuxtProject(process.cwd());
if (args.includes('--remove')) {
if (svelteKit) {
@@ -133,12 +120,6 @@ Output (JSON):
console.log(JSON.stringify({ ok: true, adapter: 'sveltekit', results: [adapterResult] }));
return;
}
if (nuxt) {
const adapterResult = removeNuxtLiveAdapter({ cwd: process.cwd(), project: nuxt });
console.log(JSON.stringify({ ok: !adapterResult.error, adapter: 'nuxt', results: [adapterResult] }));
if (adapterResult.error) process.exitCode = 1;
return;
}
const results = resolvedFiles.map((relFile) => {
const absFile = path.resolve(process.cwd(), relFile);
if (!fs.existsSync(absFile)) return { file: relFile, error: 'file_not_found' };
@@ -164,28 +145,13 @@ Output (JSON):
console.error(JSON.stringify({ ok: false, error: 'missing_port' }));
process.exit(1);
}
const gitIgnore = ensureLiveGitIgnores(
process.cwd(),
nuxt ? [nuxt.pluginFile] : [],
);
const gitIgnore = ensureLiveGitIgnores(process.cwd());
if (svelteKit) {
const adapterResult = applySvelteKitLiveAdapter({ cwd: process.cwd(), port, config });
console.log(JSON.stringify({ ok: true, port, adapter: 'sveltekit', gitIgnore, results: [adapterResult] }));
return;
}
if (nuxt) {
const adapterResult = applyNuxtLiveAdapter({ cwd: process.cwd(), port, project: nuxt });
console.log(JSON.stringify({
ok: !adapterResult.error,
port,
adapter: 'nuxt',
gitIgnore,
results: [adapterResult],
}));
if (adapterResult.error) process.exitCode = 1;
return;
}
const results = resolvedFiles.map((relFile) => {
const absFile = path.resolve(process.cwd(), relFile);
@@ -209,12 +175,12 @@ Output (JSON):
if (!anyInserted) process.exit(1);
}
export function ensureLiveGitIgnores(cwd = process.cwd(), extraPatterns = []) {
export function ensureLiveGitIgnores(cwd = process.cwd()) {
const target = resolveIgnoreTarget(cwd);
const existing = fs.existsSync(target.path) ? fs.readFileSync(target.path, 'utf-8') : '';
const block = [
IGNORE_MARKER_OPEN,
...new Set([...LIVE_IGNORE_PATTERNS, ...extraPatterns]),
...LIVE_IGNORE_PATTERNS,
IGNORE_MARKER_CLOSE,
].join('\n');
const markerRe = new RegExp(`${escapeRegExp(IGNORE_MARKER_OPEN)}[\\s\\S]*?${escapeRegExp(IGNORE_MARKER_CLOSE)}`);
@@ -236,119 +202,10 @@ export function ensureLiveGitIgnores(cwd = process.cwd(), extraPatterns = []) {
file: path.relative(cwd, target.path).split(path.sep).join('/'),
mode: target.mode,
changed: updated !== existing,
patterns: [...new Set([...LIVE_IGNORE_PATTERNS, ...extraPatterns])],
patterns: [...LIVE_IGNORE_PATTERNS],
};
}
// ---------------------------------------------------------------------------
// Nuxt adapter
//
// A script element placed in app.vue is compiled as Vue-rendered DOM and is
// not executed. Nuxt instead auto-discovers client plugins. Keep the adapter
// generated, dev-only, and outside user-authored source: Live creates one
// marked .client.ts plugin on start and removes it on stop.
// ---------------------------------------------------------------------------
export function detectNuxtProject(cwd = process.cwd()) {
const configFile = fs.readdirSync(cwd, { withFileTypes: true })
.find((entry) => entry.isFile() && /^nuxt\.config\.(?:js|mjs|cjs|ts|mts|cts)$/.test(entry.name))
?.name;
if (!configFile) return null;
const config = fs.readFileSync(path.join(cwd, configFile), 'utf-8');
const literalSrcDir = config.match(/\bsrcDir\s*:\s*(['"])([^'"]+)\1/);
let appDir = '';
if (literalSrcDir) {
const candidate = literalSrcDir[2]
.replace(/\\/g, '/')
.replace(/^\.\//, '')
.replace(/\/+$/, '');
const normalized = path.posix.normalize(candidate);
if (normalized !== '..' && !normalized.startsWith('../') && !path.isAbsolute(normalized)) {
appDir = normalized === '.' ? '' : normalized;
}
} else if (
fs.existsSync(path.join(cwd, 'app', 'app.vue'))
|| fs.existsSync(path.join(cwd, 'app', 'pages'))
) {
appDir = 'app';
}
const pluginFile = [appDir, 'plugins', NUXT_PLUGIN_NAME].filter(Boolean).join('/');
return { configFile, appDir, pluginFile };
}
export function buildNuxtPlugin(port) {
return `/* ${NUXT_PLUGIN_MARKER} */
const liveSrc = 'http://localhost:${port}/live.js';
const liveSelector = 'script[data-impeccable-live-nuxt]';
export default defineNuxtPlugin(() => {
if (!import.meta.dev || typeof document === 'undefined') return;
const expectedSrc = new URL(liveSrc, window.location.href).href;
let script = document.querySelector(liveSelector);
if (script?.src === expectedSrc) return;
script?.remove();
script = document.createElement('script');
script.src = liveSrc;
script.async = true;
script.dataset.impeccableLiveNuxt = '';
document.head.appendChild(script);
import.meta.hot?.dispose(() => {
if (script?.isConnected) script.remove();
});
});
/* /${NUXT_PLUGIN_MARKER} */
`;
}
export function applyNuxtLiveAdapter({ cwd = process.cwd(), port, project = detectNuxtProject(cwd) }) {
if (!project) return { error: 'nuxt_not_detected' };
const absFile = path.join(cwd, project.pluginFile);
const existing = fs.existsSync(absFile) ? fs.readFileSync(absFile, 'utf-8') : null;
if (existing !== null && !existing.includes(NUXT_PLUGIN_MARKER)) {
return {
file: project.pluginFile,
error: 'nuxt_plugin_conflict',
hint: `${project.pluginFile} already exists and is not managed by Impeccable Live`,
};
}
const content = buildNuxtPlugin(port);
fs.mkdirSync(path.dirname(absFile), { recursive: true });
if (content !== existing) fs.writeFileSync(absFile, content, 'utf-8');
return {
file: project.pluginFile,
inserted: true,
changed: content !== existing,
devOnly: true,
};
}
export function removeNuxtLiveAdapter({ cwd = process.cwd(), project = detectNuxtProject(cwd) }) {
if (!project) return { error: 'nuxt_not_detected' };
const absFile = path.join(cwd, project.pluginFile);
if (!fs.existsSync(absFile)) {
return { file: project.pluginFile, removed: false, note: 'no adapter present' };
}
const content = fs.readFileSync(absFile, 'utf-8');
if (!content.includes(NUXT_PLUGIN_MARKER)) {
return {
file: project.pluginFile,
removed: false,
error: 'nuxt_plugin_conflict',
hint: `${project.pluginFile} is not managed by Impeccable Live`,
};
}
fs.unlinkSync(absFile);
const pluginDir = path.dirname(absFile);
if (fs.readdirSync(pluginDir).length === 0) fs.rmdirSync(pluginDir);
return { file: project.pluginFile, removed: true };
}
function resolveIgnoreTarget(cwd) {
const gitExcludePath = resolveGitInfoExcludePath(cwd);
if (gitExcludePath) {
plugin/skills/impeccable/scripts/live-poll.mjs
+16 -81
View File
@@ -10,12 +10,10 @@
*/
import { execFileSync } from 'node:child_process';
import fs from 'node:fs';
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import { completionAckForAcceptResult, completionTypeForAcceptResult } from './live/completion.mjs';
import { getLiveCodexWorkerStatePath, readLiveServerInfo } from './lib/impeccable-paths.mjs';
import { codexWorkerProcessStateIsOwned } from './live/codex-worker.mjs';
import { readLiveServerInfo } from './lib/impeccable-paths.mjs';
// Absolute path to a sibling script in this skill's scripts dir, so runtime
// error hints print a directly-runnable command instead of a placeholder.
@@ -29,7 +27,7 @@ const scriptCmd = (name) => `node "${path.join(SELF_DIR, name)}"`;
export const PER_REQUEST_TIMEOUT_MS = 270_000;
export const DEFAULT_EVENT_LEASE_MS = 600_000;
const EVENT_TYPES_NEEDING_AGENT_REPLY = new Set(['generate', 'steer', 'manual_edit_apply', 'carbonize_cleanup']);
const EVENT_TYPES_NEEDING_AGENT_REPLY = new Set(['generate', 'steer', 'manual_edit_apply']);
function readServerInfo() {
const record = readLiveServerInfo(process.cwd());
@@ -40,8 +38,8 @@ function readServerInfo() {
return record.info;
}
export function buildPollReplyPayload(token, { id, type, message, file, data, sourceEventType }) {
return { token, id, type, message, file, data, sourceEventType };
export function buildPollReplyPayload(token, { id, type, message, file, data }) {
return { token, id, type, message, file, data };
}
export function manualApplyPollBanner(event = {}) {
@@ -154,14 +152,7 @@ export async function waitForEventAck(base, token, eventId, {
return false;
}
export async function fetchNextEvent(base, token, {
totalDeadline,
types,
resolveTypes,
perRequestTimeoutMs = PER_REQUEST_TIMEOUT_MS,
leaseMs = DEFAULT_EVENT_LEASE_MS,
signal,
} = {}) {
export async function fetchNextEvent(base, token, { totalDeadline } = {}) {
while (true) {
if (totalDeadline && Date.now() >= totalDeadline) {
return { type: 'timeout' };
@@ -170,15 +161,8 @@ export async function fetchNextEvent(base, token, {
const remaining = totalDeadline
? totalDeadline - Date.now()
: PER_REQUEST_TIMEOUT_MS;
const slice = Math.min(Math.max(remaining, 1000), perRequestTimeoutMs);
const query = new URLSearchParams({
token,
timeout: String(slice),
leaseMs: String(leaseMs),
});
const normalizedTypes = normalizePollTypes(resolveTypes ? await resolveTypes() : types);
if (normalizedTypes.length > 0) query.set('types', normalizedTypes.join(','));
const res = await fetch(`${base}/poll?${query}`, { signal });
const slice = Math.min(Math.max(remaining, 1000), PER_REQUEST_TIMEOUT_MS);
const res = await fetch(`${base}/poll?token=${token}&timeout=${slice}&leaseMs=${DEFAULT_EVENT_LEASE_MS}`);
if (res.status === 401) {
const err = new Error('Authentication failed. The server token may have changed.');
@@ -200,7 +184,7 @@ export async function fetchNextEvent(base, token, {
}
}
export async function augmentEventWithAcceptHandling(event, base, token, { deferReply = false } = {}) {
export async function augmentEventWithAcceptHandling(event, base, token) {
if (event.type !== 'accept' && event.type !== 'discard') return event;
const __dirname = path.dirname(fileURLToPath(import.meta.url));
@@ -218,21 +202,11 @@ export async function augmentEventWithAcceptHandling(event, base, token, { defer
event._acceptResult = { handled: false, mode: 'error', error: err.message };
}
if (deferReply) {
event._completionAck = { ok: false, deferred: true };
return event;
}
await completeAcceptHandling(event, base, token);
return event;
}
export async function completeAcceptHandling(event, base, token) {
const completionType = completionTypeForAcceptResult(event.type, event._acceptResult);
try {
await postReply(base, token, {
id: event.id,
type: completionType,
sourceEventType: event.type,
message: event._acceptResult?.error,
file: event._acceptResult?.file,
data: event._acceptResult?.carbonize === true ? { carbonize: true } : undefined,
@@ -243,6 +217,7 @@ export async function completeAcceptHandling(event, base, token) {
if (!event._completionAck) {
event._completionAck = completionAckForAcceptResult(event.id, completionType, event._acceptResult);
}
return event;
}
@@ -270,9 +245,9 @@ export function printPollEvent(event) {
console.log(JSON.stringify(event));
}
export async function runPollOnce(base, token, { totalTimeout = 600_000, types, resolveTypes, perRequestTimeoutMs } = {}) {
export async function runPollOnce(base, token, { totalTimeout = 600_000 } = {}) {
const deadline = Date.now() + totalTimeout;
const event = await fetchNextEvent(base, token, { totalDeadline: deadline, types, resolveTypes, perRequestTimeoutMs });
const event = await fetchNextEvent(base, token, { totalDeadline: deadline });
await augmentEventWithAcceptHandling(event, base, token);
writeCarbonizeBanner(event);
printPollEvent(event);
@@ -283,14 +258,11 @@ export async function runPollStream(base, token, {
ackTimeoutMs = 600_000,
ackPollIntervalMs = 400,
shouldContinue = () => true,
types,
resolveTypes,
perRequestTimeoutMs,
} = {}) {
process.stderr.write('[impeccable-poll] stream mode: one JSON object per line on stdout; use --reply while this process stays running\n');
while (shouldContinue()) {
const event = await fetchNextEvent(base, token, { types, resolveTypes, perRequestTimeoutMs });
const event = await fetchNextEvent(base, token);
await augmentEventWithAcceptHandling(event, base, token);
writeCarbonizeBanner(event);
printPollEvent(event);
@@ -350,19 +322,14 @@ Modes:
Options:
--timeout=MS One-shot poll timeout in ms (default: 600000). Ignored in --stream mode
--types=A,B Lease only these event types (used by partitioned Codex control lane)
--codex-worker-fallback
Add generation events only if the dedicated Codex worker fails or exits
--ack-timeout=MS Stream mode: max wait for --reply after generate/steer (default: 600000)
--file PATH Attach a source file path to the reply (generate/steer flow)
--data JSON Attach a JSON result object to the reply (manual_edit_apply flow). Must be valid JSON
--help Show this help message
Harness note:
Default one-shot mode is the primary contract, including Codex foreground polling.
Claude Code may run it as a background task; Cursor uses a background terminal with exit notification.
--stream is retained for explicitly enabled experimental worker control lanes.
Do not use --stream on Cursor.`);
Default one-shot mode is the portable contract for Claude Code, Codex, and Cursor.
--stream is experimental for harnesses with fast incremental stdout; do not use on Cursor.`);
process.exit(0);
}
@@ -393,55 +360,23 @@ Harness note:
}
const streamMode = args.includes('--stream');
const typesArg = args.find((a) => a.startsWith('--types='));
const types = normalizePollTypes(typesArg ? typesArg.slice('--types='.length) : null);
const workerFallback = args.includes('--codex-worker-fallback');
const resolveTypes = workerFallback ? () => resolveCodexWorkerFallbackTypes(types) : null;
const perRequestTimeoutMs = workerFallback ? 2_000 : undefined;
const ackTimeoutArg = args.find((a) => a.startsWith('--ack-timeout='));
const ackTimeoutMs = ackTimeoutArg ? parseInt(ackTimeoutArg.split('=')[1], 10) : 600_000;
try {
if (streamMode) {
await runPollStream(base, info.token, { ackTimeoutMs, types, resolveTypes, perRequestTimeoutMs });
await runPollStream(base, info.token, { ackTimeoutMs });
return;
}
const timeoutArg = args.find((a) => a.startsWith('--timeout='));
const totalTimeout = timeoutArg ? parseInt(timeoutArg.split('=')[1], 10) : 600_000;
await runPollOnce(base, info.token, { totalTimeout, types, resolveTypes, perRequestTimeoutMs });
await runPollOnce(base, info.token, { totalTimeout });
} catch (err) {
handlePollError(err);
}
}
export function normalizePollTypes(value) {
const values = Array.isArray(value) ? value : String(value || '').split(',');
return [...new Set(values.map((type) => String(type).trim()).filter(Boolean))];
}
export function resolveCodexWorkerFallbackTypes(baseTypes, {
cwd = process.cwd(),
state = readJson(getLiveCodexWorkerStatePath(cwd)),
isPidReachable = pidReachable,
} = {}) {
const base = normalizePollTypes(baseTypes);
const workerOwnsGeneration = codexWorkerProcessStateIsOwned(state, cwd)
&& ['starting', 'ready', 'working'].includes(state?.status)
&& isPidReachable(state?.pid);
if (workerOwnsGeneration) return base;
return normalizePollTypes([...base, 'generate', 'accept', 'discard', 'prefetch']);
}
function readJson(file) {
try { return JSON.parse(fs.readFileSync(file, 'utf-8')); } catch { return null; }
}
function pidReachable(pid) {
if (!Number.isInteger(pid) || pid <= 0) return false;
try { process.kill(pid, 0); return true; } catch { return false; }
}
// Auto-execute when run directly
const _running = process.argv[1];
if (_running?.endsWith('live-poll.mjs') || _running?.endsWith('live-poll.mjs/')) {
plugin/skills/impeccable/scripts/live-publish.mjs
-37
View File
@@ -1,37 +0,0 @@
#!/usr/bin/env node
import {
prepareGenerationArtifact,
publishGenerationArtifact,
} from './live/generation-publisher.mjs';
const args = process.argv.slice(2);
const result = args.includes('--prepare')
? prepareGenerationArtifact({
id: arg(args, '--id'),
sourceFile: arg(args, '--file'),
})
: publishGenerationArtifact({
id: arg(args, '--id'),
epoch: Number(arg(args, '--epoch')),
sourceFile: arg(args, '--file'),
artifactFile: arg(args, '--artifact'),
expectedSourceHash: arg(args, '--expected-source-hash'),
arrivedVariants: optionalNumber(arg(args, '--arrived')),
expectedVariants: optionalNumber(arg(args, '--expected')),
publicationKind: arg(args, '--kind'),
});
console.log(JSON.stringify(result));
if (!result.ok) process.exitCode = 2;
function arg(values, name) {
const index = values.indexOf(name);
return index >= 0 ? values[index + 1] : undefined;
}
function optionalNumber(value) {
if (value === undefined) return undefined;
const number = Number(value);
return Number.isInteger(number) ? number : undefined;
}
plugin/skills/impeccable/scripts/live-server.mjs
+26 -309
View File
@@ -29,14 +29,11 @@ import {
resolveLiveBrowserScriptParts,
} from './live/browser-script-parts.mjs';
import { createLiveSessionStore } from './live/session-store.mjs';
import { runGenerationPreflight } from './live/generation-preflight.mjs';
import { validateEvent } from './live/event-validation.mjs';
import { selectAvailablePendingEvent } from './live/poll-lanes.mjs';
import { createManualEditRoutes } from './live/manual-edit-routes.mjs';
import { LIVE_COMMANDS } from './live/vocabulary.mjs';
import {
getDesignSidecarPath,
getLiveCodexWorkerStatePath,
getLiveDir,
getLiveAnnotationsDir,
IMPECCABLE_COMMAND_PREFIX,
@@ -54,7 +51,6 @@ import {
applyDeferredSvelteComponentAccepts,
removeAllSvelteComponentSessions,
} from './live/svelte-component.mjs';
import { removeAllVueComponentSessions } from './live/vue-component.mjs';
const __dirname = path.dirname(fileURLToPath(import.meta.url));
// PRODUCT.md / DESIGN.md live wherever context.mjs resolves. The generated
@@ -160,135 +156,29 @@ function restorePendingEventsFromStore() {
}
}
function findAvailablePendingEvent(now = Date.now(), types = null) {
return selectAvailablePendingEvent(state.pendingEvents, { now, types });
function findAvailablePendingEvent(now = Date.now()) {
for (const entry of state.pendingEvents) {
if (entry.leaseUntil && entry.leaseUntil > now) continue;
return entry;
}
return null;
}
function leaseEvent(entry, leaseMs) {
prepareGenerateEventForLease(entry);
if (!entry.event?.id) {
const idx = state.pendingEvents.indexOf(entry);
if (idx !== -1) state.pendingEvents.splice(idx, 1);
return entry.event;
}
entry.leaseUntil = Date.now() + leaseMs;
recordGenerateDelivery(entry);
scheduleLeaseFlush();
broadcastAgentPollingIfChanged();
return entry.event;
}
function recordGenerateDelivery(entry) {
const event = entry?.event;
if (!event || event.type !== 'generate' || event.generationReadyAt) return;
const at = Date.now();
entry.event = { ...event, generationReadyAt: at };
state.sessionStore?.appendEvent(entry.event);
recordAgentPhase(event.id, 'generation_ready', { at });
}
function prepareGenerateEventForLease(entry) {
const event = entry?.event;
if (!event || event.type !== 'generate' || event.scaffoldAttempted) return;
recordAgentPhase(event.id, 'picked_up');
recordAgentPhase(event.id, 'scaffolding');
const worker = getCodexWorkerStatus();
const result = runGenerationPreflight(event, {
cwd: process.cwd(),
scriptsDir: __dirname,
isolated: worker?.mode === 'dedicated-app-server' && worker?.reachable === true,
});
entry.event = {
...event,
scaffoldAttempted: true,
scaffoldDurationMs: result.durationMs ?? null,
...(result.ok ? { scaffold: result.scaffold } : { scaffoldError: result.error || result.reason }),
};
state.sessionStore?.appendEvent(entry.event);
recordAgentPhase(event.id, result.ok ? 'source_ready' : 'scaffold_fallback', {
durationMs: result.durationMs ?? null,
previewMode: result.scaffold?.previewMode || 'source',
});
}
function recordAgentPhase(id, phase, details = {}) {
if (!id) return;
const event = {
type: 'agent_phase',
id,
phase,
at: Date.now(),
...details,
};
state.sessionStore?.appendEvent(event);
broadcast(event);
}
function recordGenerationCheckpoint(event) {
if (!event?.id || event.type !== 'checkpoint') return;
if (generationIsFenced(event.id)) return;
const arrived = Number(event.arrivedVariants) || 0;
const expected = Number(event.expectedVariants) || 0;
if (arrived <= 0 || expected <= 0) return;
const previewMode = event.previewMode || 'source';
const previewFile = event.previewFile || event.file;
if (previewFile) {
broadcast({
type: 'variant_progress',
id: event.id,
file: previewFile,
sourceFile: event.sourceFile || (previewMode === 'source' ? previewFile : undefined),
previewFile,
previewMode,
arrivedVariants: arrived,
expectedVariants: expected,
publicationKind: event.publicationKind || 'variants',
});
}
const details = {
arrivedVariants: arrived,
expectedVariants: expected,
checkpointReason: event.reason || null,
};
const at = Date.now();
if (!generationPhaseAlreadyRecorded(event.id, 'first_reviewable')) {
recordAgentPhase(event.id, 'first_reviewable', { ...details, at });
}
if (arrived >= 2 && expected >= 3 && !generationPhaseAlreadyRecorded(event.id, 'second_reviewable')) {
recordAgentPhase(event.id, 'second_reviewable', { ...details, at });
}
if (arrived >= expected && !generationPhaseAlreadyRecorded(event.id, 'all_variants_ready')) {
recordAgentPhase(event.id, 'all_variants_ready', { ...details, at });
}
}
function generationIsFenced(id) {
if (!state.sessionStore || !id) return false;
try {
const snapshot = state.sessionStore.getSnapshot(id, { includeCompleted: true });
return snapshot?.generationCanceled === true;
} catch {
return false;
}
}
function generationPhaseAlreadyRecorded(id, phase) {
if (!state.sessionStore) return false;
try {
const snapshot = state.sessionStore.getSnapshot(id, { includeCompleted: true });
return !!snapshot?.generationTimings?.[phase];
} catch {
return false;
}
}
function acknowledgePendingEvent(id, sourceEventType) {
function acknowledgePendingEvent(id) {
if (!id) return false;
const idx = state.pendingEvents.findIndex((entry) => (
entry.event?.id === id
&& (!sourceEventType || entry.event?.type === sourceEventType)
));
const idx = state.pendingEvents.findIndex((entry) => entry.event?.id === id);
if (idx === -1) return false;
const acknowledged = state.pendingEvents[idx].event;
state.pendingEvents.splice(idx, 1);
@@ -297,39 +187,9 @@ function acknowledgePendingEvent(id, sourceEventType) {
return acknowledged;
}
function releasePendingEvent(id, sourceEventType) {
const entry = state.pendingEvents.find((item) => (
item.event?.id === id
&& (!sourceEventType || item.event?.type === sourceEventType)
));
if (!entry) return null;
entry.leaseUntil = 0;
scheduleLeaseFlush();
return entry.event;
}
function retirePendingGeneration(id) {
if (!id) return 0;
let retired = 0;
for (let index = state.pendingEvents.length - 1; index >= 0; index -= 1) {
const event = state.pendingEvents[index]?.event;
if (event?.id !== id || event.type !== 'generate') continue;
state.pendingEvents.splice(index, 1);
retired += 1;
}
if (retired > 0) {
scheduleLeaseFlush();
broadcastAgentPollingIfChanged();
}
return retired;
}
function findPendingEventById(id, sourceEventType) {
function findPendingEventById(id) {
if (!id) return null;
const entry = state.pendingEvents.find((item) => (
item.event?.id === id
&& (!sourceEventType || item.event?.type === sourceEventType)
));
const entry = state.pendingEvents.find((item) => item.event?.id === id);
return entry?.event || null;
}
@@ -364,13 +224,7 @@ function summarizeActiveSessionForClient(snapshot = {}) {
arrivedVariants: snapshot.arrivedVariants ?? 0,
visibleVariant: snapshot.visibleVariant ?? null,
checkpointRevision: snapshot.checkpointRevision ?? 0,
browserCheckpointRevision: snapshot.browserCheckpointRevision ?? snapshot.checkpointRevision ?? 0,
publicationCheckpointRevision: snapshot.publicationCheckpointRevision ?? 0,
paramValues: snapshot.paramValues || {},
paramsPublished: snapshot.paramsPublished === true,
generationPhase: snapshot.generationPhase ?? null,
generationCanceled: snapshot.generationCanceled === true,
cancelReason: snapshot.cancelReason ?? null,
};
}
@@ -415,21 +269,13 @@ function scheduleLeaseFlush() {
function flushPendingPolls() {
let changed = false;
while (state.pendingPolls.length > 0) {
let pollIndex = -1;
let entry = null;
for (let index = 0; index < state.pendingPolls.length; index += 1) {
const candidate = findAvailablePendingEvent(Date.now(), state.pendingPolls[index].types);
if (!candidate) continue;
pollIndex = index;
entry = candidate;
break;
}
const entry = findAvailablePendingEvent();
if (!entry) {
scheduleLeaseFlush();
broadcastAgentPollingIfChanged();
return;
}
const [poll] = state.pendingPolls.splice(pollIndex, 1);
const poll = state.pendingPolls.shift();
poll.resolve(leaseEvent(entry, poll.leaseMs));
changed = true;
}
@@ -438,10 +284,9 @@ function flushPendingPolls() {
}
function agentPollingConnected() {
// A leased event only proves that a poll returned once. The foreground task
// may have ended immediately afterward, so only an actively waiting poll is
// evidence that steering can wake the task right now.
return state.pendingPolls.length > 0;
const now = Date.now();
return state.pendingPolls.length > 0
|| state.pendingEvents.some((entry) => entry.leaseUntil && entry.leaseUntil > now);
}
function broadcastAgentPollingIfChanged() {
@@ -494,58 +339,6 @@ function getManualEditStatus() {
}
}
function getCodexWorkerStatus() {
let worker;
try {
worker = JSON.parse(fs.readFileSync(getLiveCodexWorkerStatePath(process.cwd()), 'utf-8'));
} catch {
return null;
}
if (!worker || typeof worker !== 'object') return null;
const processActive = Number.isInteger(worker.pid) && worker.pid > 0 && pidReachable(worker.pid);
const activeStatus = ['starting', 'ready', 'working'].includes(worker.status);
const unavailable = activeStatus && !processActive;
const error = unavailable ? 'codex_worker_unavailable' : stringOrNull(worker.error);
const status = unavailable ? 'unavailable' : stringOrNull(worker.status) || 'unknown';
return {
status,
mode: stringOrNull(worker.mode)
|| (activeStatus && processActive ? 'dedicated-app-server' : 'foreground'),
reachable: processActive,
error,
message: worker.error === 'codex_cli_unavailable'
? 'Codex CLI not found. Live is using the main agent for generation.'
: error
? 'Background generation is unavailable. Live is using the main agent.'
: null,
command: stringOrNull(worker.command),
setup: worker.error === 'codex_cli_unavailable' && worker.setup
? {
docsUrl: stringOrNull(worker.setup.docsUrl),
afterInstall: stringOrNull(worker.setup.afterInstall),
}
: null,
model: stringOrNull(worker.model),
profile: stringOrNull(worker.profile),
delivery: stringOrNull(worker.delivery),
updatedAt: stringOrNull(worker.updatedAt),
};
}
function stringOrNull(value) {
return typeof value === 'string' && value.trim() ? value : null;
}
function pidReachable(pid) {
try {
process.kill(pid, 0);
return true;
} catch (error) {
return error?.code === 'EPERM';
}
}
// ---------------------------------------------------------------------------
// Load scripts
// ---------------------------------------------------------------------------
@@ -728,7 +521,6 @@ function createRequestHandler({ detectScript, liveScriptParts }) {
connectedClients: state.sseClients.size,
pendingEvents: state.pendingEvents.map((entry) => summarizePendingEventForStatus(entry)),
agentPolling: agentPollingConnected(),
codexWorker: getCodexWorkerStatus(),
activeSessions: sessions,
manualEdits: getManualEditStatus(),
}));
@@ -838,7 +630,6 @@ function createRequestHandler({ detectScript, liveScriptParts }) {
type: 'connected',
hasProjectContext: hasProjectContext(),
agentPolling: agentPollingConnected(),
codexWorker: getCodexWorkerStatus(),
activeSessions: activeSessionSummaries(),
}) + '\n\n');
@@ -898,15 +689,6 @@ function createRequestHandler({ detectScript, liveScriptParts }) {
res.end(JSON.stringify({ error }));
return;
}
if (msg.type === 'agent_phase') {
recordAgentPhase(msg.id, msg.phase, {
...(Number.isFinite(msg.durationMs) ? { durationMs: msg.durationMs } : {}),
owner: typeof msg.owner === 'string' ? msg.owner : undefined,
});
res.writeHead(200, { 'Content-Type': 'application/json' });
res.end(JSON.stringify({ ok: true }));
return;
}
if (state.sessionStore && msg.id) {
try {
state.sessionStore.appendEvent(msg);
@@ -916,10 +698,6 @@ function createRequestHandler({ detectScript, liveScriptParts }) {
return;
}
}
if (msg.type === 'accept' || msg.type === 'discard') {
retirePendingGeneration(msg.id);
}
recordGenerationCheckpoint(msg);
if (msg.type === 'exit') {
cleanupSvelteComponentSessionsBeforeExit();
}
@@ -960,12 +738,6 @@ function createRequestHandler({ detectScript, liveScriptParts }) {
// Agent poll endpoints (unchanged from WS version)
// ---------------------------------------------------------------------------
function parsePollTypes(value) {
if (!value) return null;
const types = String(value).split(',').map((type) => type.trim()).filter(Boolean);
return types.length > 0 ? new Set(types) : null;
}
function handlePollGet(req, res, url) {
const token = url.searchParams.get('token');
if (token !== state.token) {
@@ -976,14 +748,13 @@ function handlePollGet(req, res, url) {
state.lastPollAt = Date.now();
const timeout = parseInt(url.searchParams.get('timeout') || DEFAULT_POLL_TIMEOUT, 10);
const leaseMs = parseInt(url.searchParams.get('leaseMs') || '30000', 10);
const types = parsePollTypes(url.searchParams.get('types'));
const available = findAvailablePendingEvent(Date.now(), types);
const available = findAvailablePendingEvent();
if (available) {
res.writeHead(200, { 'Content-Type': 'application/json' });
res.end(JSON.stringify(leaseEvent(available, leaseMs)));
return;
}
const poll = { resolve, leaseMs, types };
const poll = { resolve, leaseMs };
const timer = setTimeout(() => {
const idx = state.pendingPolls.indexOf(poll);
if (idx !== -1) state.pendingPolls.splice(idx, 1);
@@ -1012,20 +783,12 @@ function sessionFileMetadataFromPollReply(file) {
if (!file || typeof file !== 'string') return { file };
const normalized = file.split(path.sep).join('/');
const base = { file: normalized };
const sourceArtifactPreview = normalized.includes('.impeccable/live/previews/')
&& !normalized.endsWith('/manifest.json');
const metadataFile = sourceArtifactPreview
? normalized.slice(0, normalized.lastIndexOf('/') + 1) + 'manifest.json'
: normalized;
if (!metadataFile.endsWith('/manifest.json') && metadataFile !== 'manifest.json') return base;
if (!metadataFile.includes('node_modules/.impeccable-live/')
&& !metadataFile.includes('src/lib/impeccable/')
&& !metadataFile.includes('/.impeccable-live/')
&& !metadataFile.includes('.impeccable/live/previews/')) return base;
if (!normalized.endsWith('/manifest.json') && normalized !== 'manifest.json') return base;
if (!normalized.includes('node_modules/.impeccable-live/') && !normalized.includes('src/lib/impeccable/')) return base;
let full;
try {
full = path.resolve(process.cwd(), metadataFile);
full = path.resolve(process.cwd(), normalized);
const rel = path.relative(process.cwd(), full);
if (!rel || rel.startsWith('..') || path.isAbsolute(rel)) return base;
} catch {
@@ -1034,40 +797,18 @@ function sessionFileMetadataFromPollReply(file) {
try {
const manifest = JSON.parse(fs.readFileSync(full, 'utf-8'));
if (!['svelte-component', 'vue-component', 'source-artifact'].includes(manifest?.previewMode)
|| !manifest.sourceFile) return base;
const previewFile = manifest.previewMode === 'source-artifact'
? String(manifest.previewFile || normalized).split(path.sep).join('/')
: normalized;
if (manifest?.previewMode !== 'svelte-component' || !manifest.sourceFile) return base;
return {
file: String(manifest.sourceFile).split(path.sep).join('/'),
sourceFile: String(manifest.sourceFile).split(path.sep).join('/'),
previewFile,
previewMode: manifest.previewMode,
previewFile: normalized,
previewMode: 'svelte-component',
};
} catch {
return base;
}
}
function inferSourceEventType(msg = {}, pendingEvents = state.pendingEvents) {
const pendingTypes = new Set(
pendingEvents
.filter((entry) => entry.event?.id === msg.id)
.map((entry) => entry.event?.type),
);
if (msg.type === 'discarded' || msg.type === 'discard') return 'discard';
if (msg.type === 'complete') {
if (pendingTypes.has('carbonize_cleanup')) return 'carbonize_cleanup';
return pendingTypes.has('accept') ? 'accept' : (pendingTypes.has('generate') ? 'generate' : undefined);
}
if (msg.type === 'steer_done') return 'steer';
// `agent_done` can be the automatic acknowledgement for a carbonize Accept.
// New pollers send sourceEventType explicitly; default to generate only for
// older callers so a late worker cannot acknowledge a queued Accept.
return msg.type === 'agent_done' || msg.type === 'done' ? 'generate' : undefined;
}
function handlePollPost(req, res) {
let body = '';
req.on('data', (c) => { body += c; });
@@ -1128,23 +869,7 @@ function handlePollPost(req, res) {
res.end(JSON.stringify({ error: 'stale_manual_edit_apply_reply', ...rollback }));
return;
}
const sourceEventType = msg.sourceEventType || inferSourceEventType(msg);
if (msg.type === 'retry') {
const releasedEvent = releasePendingEvent(msg.id, sourceEventType);
if (!releasedEvent) {
res.writeHead(msg.id ? 404 : 400, { 'Content-Type': 'application/json' });
res.end(JSON.stringify({
error: msg.id ? 'unknown_poll_retry_id' : 'missing_poll_retry_id',
id: msg.id,
}));
return;
}
flushPendingPolls();
res.writeHead(200, { 'Content-Type': 'application/json' });
res.end(JSON.stringify({ ok: true, released: true }));
return;
}
const pendingEventBeforeAck = findPendingEventById(msg.id, sourceEventType);
const pendingEventBeforeAck = findPendingEventById(msg.id);
if (pendingEventBeforeAck?.type === 'steer' && msg.type === 'steer_done'
&& !msg.file && !(typeof msg.message === 'string' && msg.message.trim())) {
res.writeHead(400, { 'Content-Type': 'application/json' });
@@ -1154,7 +879,7 @@ function handlePollPost(req, res) {
}));
return;
}
const acknowledgedEvent = acknowledgePendingEvent(msg.id, sourceEventType);
const acknowledgedEvent = acknowledgePendingEvent(msg.id);
let skipJournalReply = false;
let existingSession = null;
if (!acknowledgedEvent && state.sessionStore && msg.id) {
@@ -1246,11 +971,6 @@ function cleanupSvelteComponentSessionsBeforeExit() {
} catch (err) {
console.warn('[impeccable] Svelte component session cleanup failed:', err.message);
}
try {
removeAllVueComponentSessions(process.cwd());
} catch (err) {
console.warn('[impeccable] Vue component session cleanup failed:', err.message);
}
}
function applyLegacyDeferredAcceptsOnStartup() {
@@ -1363,10 +1083,7 @@ if (args.includes('--background')) {
process.exit(0);
}
} catch { /* not ready yet */ }
// The detached child is typically listening in 35-45ms. A 200ms polling
// floor dominated configured cold Live startup; poll cheaply and return
// as soon as the child has written its ready record.
await new Promise(r => setTimeout(r, 5));
await new Promise(r => setTimeout(r, 200));
}
console.error('Timed out waiting for live server to start.');
process.exit(1);
plugin/skills/impeccable/scripts/live-status.mjs
+5 -13
View File
@@ -36,24 +36,16 @@ export async function statusCli() {
agentPolling: server.agentPolling,
pendingEvents: server.pendingEvents,
} : null,
codexWorker: server?.codexWorker || null,
activeSessions: server?.activeSessions || activeSessions,
recoveryHint: recoveryHint({ server, manualApply }),
recoveryHint: manualApply
? manualApplyResumeHint(manualApply)
: server
? 'Run live-poll.mjs to continue pending work, or live-complete.mjs --id <session> after manual cleanup.'
: 'Start live-server.mjs to requeue pending durable events, then run live-poll.mjs.',
};
console.log(JSON.stringify(payload, null, 2));
}
function recoveryHint({ server, manualApply }) {
if (manualApply) return manualApplyResumeHint(manualApply);
if (server?.codexWorker?.error === 'codex_cli_unavailable') {
return `Install Codex CLI (${server.codexWorker.setup?.docsUrl}), run ${server.codexWorker.setup?.afterInstall || 'codex login'}, then restart Live. The current session can continue through live-poll.mjs.`;
}
if (server) {
return 'Run live-poll.mjs to continue pending work, or live-complete.mjs --id <session> after manual cleanup.';
}
return 'Start live-server.mjs to requeue pending durable events, then run live-poll.mjs.';
}
function findPendingManualApply(server, activeSessions) {
const fromServer = server?.pendingEvents?.find((event) => event?.type === 'manual_edit_apply');
if (fromServer) return fromServer;
plugin/skills/impeccable/scripts/live-wrap.mjs
+17 -93
View File
@@ -20,15 +20,6 @@ import {
scaffoldSvelteComponentSession,
shouldUseSvelteComponentInjection,
} from './live/svelte-component.mjs';
import {
buildVueComponentCssAuthoring,
scaffoldVueComponentSession,
shouldUseVueComponentInjection,
} from './live/vue-component.mjs';
import {
SOURCE_ARTIFACT_PREVIEW_MODE,
scaffoldSourceArtifactSession,
} from './live/source-artifact.mjs';
const EXTENSIONS = ['.html', '.jsx', '.tsx', '.vue', '.svelte', '.astro'];
@@ -59,8 +50,6 @@ Optional:
--page-url URL Current page URL. Required when pending manual edits may
affect the picked source block. Pending edits are filtered
to this page so an edit on /a doesn't bleed into /b.
--isolated Keep ordinary HTML/JSX/Astro source untouched during
preview; write the wrapper to an isolated Live artifact.
--help Show this help message
Output (JSON):
@@ -79,7 +68,6 @@ The agent should insert variant HTML at insertLine.`);
const filePath = argVal(args, '--file');
const text = argVal(args, '--text');
const pageUrl = argVal(args, '--page-url');
const isolated = args.includes('--isolated');
if (!id) { console.error('Missing --id'); process.exit(1); }
if (!elementId && !classes && !query) {
@@ -172,29 +160,11 @@ The agent should insert variant HTML at insertLine.`);
if (filtered.length === 1) {
match = filtered[0];
} else if (filtered.length === 0) {
const normalizedText = String(text).replace(/\s+/g, ' ').trim();
if (normalizedText.length < 8) {
// Very short labels cannot disambiguate siblings reliably. Preserve
// the legacy behavior for these low-information picker events.
match = candidates[0];
} else {
// Rendered text that is absent from every candidate usually means
// the source uses expressions or component props. Picking the first
// same-class sibling silently edits the wrong instance (observed on
// Astro result cards), so stop and surface every candidate instead.
console.error(JSON.stringify({
error: 'element_ambiguous',
fallback: 'agent-driven',
reason: 'rendered_text_not_in_source',
file: path.relative(process.cwd(), targetFile),
candidates: candidates.map((c) => ({
startLine: c.startLine + 1,
endLine: c.endLine + 1,
})),
hint: 'Rendered text does not occur in any matching source branch. The element may use dynamic props or expressions; inspect the candidates and wrap the intended instance manually.',
}));
process.exit(1);
}
// Source uses dynamic content (`<h1>{title}</h1>` etc.) so the
// browser-side textContent doesn't appear literally in source. Fall
// back to first-match rather than refusing — this is the same
// behavior unmodified callers see, just preserved.
match = candidates[0];
} else {
// Multiple candidates ALSO match the text. Truly ambiguous — refuse
// rather than pick wrong, and hand the agent the candidate locations
@@ -237,7 +207,6 @@ The agent should insert variant HTML at insertLine.`);
// Strip only the COMMON minimum leading whitespace across the picked lines;
// `deindentContent` on the accept side already mirrors this convention.
let originalLines = lines.slice(startLine, endLine + 1);
const sourceOriginalLines = [...originalLines];
// Buffer-aware "original" content: if the user has pending manual edits for
// this page whose originalText appears in the picked source range, apply
@@ -300,9 +269,6 @@ The agent should insert variant HTML at insertLine.`);
const originalIndented = reindentOriginal(' ');
const relTargetFile = path.relative(process.cwd(), targetFile).split(path.sep).join('/');
const useSvelteComponent = shouldUseSvelteComponentInjection(targetFile);
const useVueComponent = !useSvelteComponent && shouldUseVueComponentInjection(targetFile);
const useFrameworkComponent = useSvelteComponent || useVueComponent;
const useSourceArtifact = isolated && !useFrameworkComponent;
// Wrapper attributes differ by syntax. HTML allows plain string attrs;
// JSX requires object-literal style and parses string attrs as HTML (which
@@ -321,11 +287,8 @@ The agent should insert variant HTML at insertLine.`);
// tuck both marker comments INSIDE it. accept/discard then expands its
// replacement range to include the wrapper's `<div>` open / close lines
// so the entire scaffold gets removed cleanly.
const sourceArtifactAttr = useSourceArtifact
? ' data-impeccable-preview="' + SOURCE_ARTIFACT_PREVIEW_MODE + '"'
: '';
const wrapperLines = isJsx ? [
indent + '<div data-impeccable-variants="' + id + '" data-impeccable-variant-count="' + count + '"' + sourceArtifactAttr + ' ' + styleContents + '>',
indent + '<div data-impeccable-variants="' + id + '" data-impeccable-variant-count="' + count + '" ' + styleContents + '>',
indent + ' ' + commentSyntax.open + ' impeccable-variants-start ' + id + ' ' + commentSyntax.close,
indent + ' ' + commentSyntax.open + ' Original ' + commentSyntax.close,
indent + ' <div data-impeccable-variant="original">',
@@ -336,7 +299,7 @@ The agent should insert variant HTML at insertLine.`);
indent + '</div>',
] : [
indent + commentSyntax.open + ' impeccable-variants-start ' + id + ' ' + commentSyntax.close,
indent + '<div data-impeccable-variants="' + id + '" data-impeccable-variant-count="' + count + '"' + sourceArtifactAttr + ' ' + styleContents + '>',
indent + '<div data-impeccable-variants="' + id + '" data-impeccable-variant-count="' + count + '" ' + styleContents + '>',
indent + ' ' + commentSyntax.open + ' Original ' + commentSyntax.close,
indent + ' <div data-impeccable-variant="original">',
originalIndented,
@@ -352,8 +315,6 @@ The agent should insert variant HTML at insertLine.`);
let outputEndLine = startLine + wrapperLines.length + (originalLines.length - 1);
let insertLine;
let svelteSession = null;
let vueSession = null;
let sourceArtifactSession = null;
if (useSvelteComponent) {
// Svelte/SvelteKit resets component-local state on markup HMR updates.
@@ -373,38 +334,6 @@ The agent should insert variant HTML at insertLine.`);
outputStartLine = 1;
outputEndLine = 1;
insertLine = 1;
} else if (useVueComponent) {
// Nuxt route-module HMR can invalidate the active page while a generated
// wrapper is only partially written. Stage real Vue SFCs in an app-local
// dev module tree and leave the route untouched until Accept.
vueSession = scaffoldVueComponentSession({
id,
count,
sourceFile: relTargetFile,
sourceStartLine: startLine + 1,
sourceEndLine: endLine + 1,
originalLines,
cwd: process.cwd(),
});
outputFile = path.resolve(process.cwd(), vueSession.manifestFile);
outputStartLine = 1;
outputEndLine = 1;
insertLine = 1;
} else if (useSourceArtifact) {
sourceArtifactSession = scaffoldSourceArtifactSession({
id,
count,
sourceFile: relTargetFile,
sourceStartLine: startLine + 1,
sourceEndLine: endLine + 1,
originalSource: sourceOriginalLines.join('\n'),
previewContent: wrapperLines.join('\n'),
cwd: process.cwd(),
});
outputFile = path.resolve(process.cwd(), sourceArtifactSession.previewFile);
outputStartLine = 1;
outputEndLine = wrapperLines.length + (originalLines.length - 1);
insertLine = 6 + (originalLines.length - 1) + 1;
} else {
// Replace the original element with the wrapper
const newLines = [
@@ -427,20 +356,15 @@ The agent should insert variant HTML at insertLine.`);
const outputRelFile = path.relative(process.cwd(), outputFile).split(path.sep).join('/');
const svelteComponentAuthoring = useSvelteComponent ? buildSvelteComponentCssAuthoring(count) : null;
const vueComponentAuthoring = useVueComponent ? buildVueComponentCssAuthoring(count) : null;
const componentSession = svelteSession || vueSession;
const componentPreviewMode = useSvelteComponent ? 'svelte-component' : useVueComponent ? 'vue-component' : undefined;
const previewMode = componentPreviewMode || (useSourceArtifact ? SOURCE_ARTIFACT_PREVIEW_MODE : undefined);
console.log(JSON.stringify({
file: outputRelFile,
sourceFile: useFrameworkComponent || useSourceArtifact ? relTargetFile : undefined,
previewMode,
previewManifest: sourceArtifactSession?.manifestFile,
componentDir: componentSession?.componentDir,
propContract: componentSession?.propContract,
sourceStartLine: useFrameworkComponent ? startLine + 1 : undefined,
sourceEndLine: useFrameworkComponent ? endLine + 1 : undefined,
sourceFile: useSvelteComponent ? relTargetFile : undefined,
previewMode: useSvelteComponent ? 'svelte-component' : undefined,
componentDir: svelteSession?.componentDir,
propContract: svelteSession?.propContract,
sourceStartLine: useSvelteComponent ? startLine + 1 : undefined,
sourceEndLine: useSvelteComponent ? endLine + 1 : undefined,
startLine: outputStartLine, // 1-indexed for the agent
// wrapperLines is an array but one element (the original-content slot)
// is a `\n`-joined multi-line string, so the actual file-row count is
@@ -450,10 +374,10 @@ The agent should insert variant HTML at insertLine.`);
endLine: outputEndLine, // 1-indexed
insertLine, // 1-indexed: where variants go
commentSyntax: commentSyntax,
styleMode: componentPreviewMode || styleMode.mode,
styleTag: useFrameworkComponent ? null : styleMode.styleTag,
cssSelectorPrefixExamples: useFrameworkComponent ? [] : buildCssSelectorPrefixExamples(styleMode.mode, count),
cssAuthoring: svelteComponentAuthoring || vueComponentAuthoring || buildCssAuthoring(styleMode, count),
styleMode: useSvelteComponent ? 'svelte-component' : styleMode.mode,
styleTag: useSvelteComponent ? null : styleMode.styleTag,
cssSelectorPrefixExamples: useSvelteComponent ? [] : buildCssSelectorPrefixExamples(styleMode.mode, count),
cssAuthoring: useSvelteComponent ? svelteComponentAuthoring : buildCssAuthoring(styleMode, count),
originalLineCount: originalLines.length,
}));
}
plugin/skills/impeccable/scripts/live.mjs
+1 -52
View File
@@ -10,7 +10,7 @@
*
* After this, the agent's only remaining steps are:
* - Open the project's live dev/preview URL in the browser (optional, if browser automation exists)—not `serverPort`; that port is the Impeccable helper for /live.js and /poll
* - Enter the harness-native poll loop: `node live-poll.mjs`
* - Enter the poll loop: `node live-poll.mjs`
*
* Usage:
* node live.mjs # Prepare everything, print JSON, exit
@@ -25,7 +25,6 @@ import { loadContext, resolveTargetSelection } from './context.mjs';
import { resolveFiles } from './live-inject.mjs';
import { readLiveServerInfo } from './lib/impeccable-paths.mjs';
import { resolveLiveTarget } from './live-target.mjs';
import { resolveCodexWorkerConfig } from './live/codex-worker.mjs';
const __dirname = path.dirname(fileURLToPath(import.meta.url));
@@ -41,7 +40,6 @@ Prepare everything for live variant mode in a single command:
- Starts (or reuses) the live server in the background
- Injects the browser script tag
- Reads PRODUCT.md / DESIGN.md for project context
- Keeps the experimental Codex app-server worker off unless explicitly enabled
- In monorepos, choose a child app first; --target <path> is the fallback/manual path
On success, prints a JSON blob with:
@@ -131,10 +129,6 @@ The agent should then:
const resolvedFiles = resolveFiles(activeCwd, checkResult.config);
const drift = scanForDrift(activeCwd, resolvedFiles, checkResult.config);
// Codex-only and explicitly opt-in. The foreground portable path is the
// default, and a failed app-server startup never takes ownership of its queue.
const codexWorker = ensureCodexWorker(activeCwd, checkResult.config);
// 5. Emit everything the agent needs
console.log(JSON.stringify({
ok: true,
@@ -143,7 +137,6 @@ The agent should then:
pageFiles: resolvedFiles,
liveConfigPath: checkResult.path,
configDrift: drift,
codexWorker,
targetPath: outputTargetPath,
projectRoot: ctx.projectRoot,
repoRoot: ctx.repoRoot,
@@ -294,50 +287,6 @@ function ensureServerRunning(cwd = process.cwd()) {
return safeParse(out);
}
function ensureCodexWorker(cwd, liveConfig) {
const config = resolveCodexWorkerConfig({ env: process.env, liveConfig });
if (!config.enabled) {
return { enabled: false, mode: 'foreground', codexOnly: true };
}
const out = runScript('live-codex-worker.mjs', ['--background', '--no-wait'], { cwd });
const result = safeParse(out);
if (!result?.ok) {
const safeFallback = result?.fallback === 'foreground' && result?.terminated !== false;
return {
enabled: !safeFallback,
mode: safeFallback ? 'foreground' : 'startup-failed-stop-required',
codexOnly: true,
fallback: safeFallback,
error: result?.error || 'codex_worker_start_failed',
message: result?.message || (safeFallback
? 'Dedicated Codex generation is unavailable. Live is using the main agent.'
: 'The dedicated Codex worker did not stop cleanly.'),
command: result?.command || config.codexPath,
setup: result?.setup || null,
childPid: result?.childPid || null,
logPath: result?.logPath || null,
foregroundTypes: safeFallback
? ['generate', 'accept', 'discard', 'prefetch', 'steer', 'manual_edit_apply', 'carbonize_cleanup', 'exit']
: [],
foregroundPoll: safeFallback ? 'live-poll.mjs' : null,
};
}
return {
enabled: true,
mode: result.starting ? 'prewarming-app-server' : 'dedicated-app-server',
codexOnly: true,
pid: result.pid,
threadId: result.threadId,
model: result.model,
effort: result.effort,
profile: result.profile,
delivery: result.delivery,
foregroundTypes: ['steer', 'manual_edit_apply', 'carbonize_cleanup', 'exit'],
foregroundPoll: 'live-poll.mjs --stream --types=steer,manual_edit_apply,carbonize_cleanup,exit --codex-worker-fallback',
logPath: result.logPath || null,
};
}
// ---------------------------------------------------------------------------
// Auto-execute
// ---------------------------------------------------------------------------
plugin/skills/impeccable/scripts/live/codex-app-server-client.mjs
-559
View File
@@ -1,559 +0,0 @@
import { spawn } from 'node:child_process';
import { performance } from 'node:perf_hooks';
const DEFAULT_CLIENT_INFO = {
name: 'impeccable_live',
title: 'Impeccable Live',
version: '0.0.1',
};
function modelSearchText(model) {
return [model?.id, model?.model, model?.displayName]
.filter(Boolean)
.join(' ')
.toLowerCase();
}
/**
* Pick a low-latency visible model without depending on a particular catalog
* version. The caller still owns the model list and may override this choice.
*/
export function selectFastCodexModel(models = []) {
const visible = models.filter((model) => model && !model.hidden);
const preferences = [
(model) => /codex/.test(modelSearchText(model)) && /spark/.test(modelSearchText(model)),
(model) => /codex/.test(modelSearchText(model)) && /mini/.test(modelSearchText(model)),
(model) => /mini/.test(modelSearchText(model)),
(model) => model.isDefault,
];
for (const preference of preferences) {
const match = visible.find(preference);
if (match) return match;
}
return visible[0] || null;
}
/** Pick the strongest visible general Codex model for design-sensitive work. */
export function selectQualityCodexModel(models = []) {
const visible = models.filter((model) => model && !model.hidden);
const preferences = [
(model) => /5\.6/.test(modelSearchText(model)) && /sol/.test(modelSearchText(model)),
(model) => model.isDefault && !/(?:spark|mini)/.test(modelSearchText(model)),
(model) => !/(?:spark|mini)/.test(modelSearchText(model)),
(model) => model.isDefault,
];
for (const preference of preferences) {
const match = visible.find(preference);
if (match) return match;
}
return visible[0] || null;
}
/** Pick the least expensive supported effort, falling back to the catalog default. */
export function selectLowestReasoningEffort(model = {}) {
const efforts = (model.supportedReasoningEfforts || [])
.map((option) => typeof option === 'string' ? option : option?.reasoningEffort)
.filter(Boolean);
for (const candidate of ['none', 'minimal', 'low']) {
if (efforts.includes(candidate)) return candidate;
}
return model.defaultReasoningEffort || efforts[0] || 'low';
}
export const selectFastModel = selectFastCodexModel;
export const selectLowestEffort = selectLowestReasoningEffort;
export class CodexAppServerError extends Error {
constructor(message, { code, data, cause } = {}) {
super(message, { cause });
this.name = 'CodexAppServerError';
if (code !== undefined) this.code = code;
if (data !== undefined) this.data = data;
}
}
function requireString(value, name) {
if (typeof value !== 'string' || !value.trim()) {
throw new TypeError(`${name} must be a non-empty string`);
}
return value;
}
function asError(error, fallback) {
if (error instanceof Error) return error;
return new CodexAppServerError(fallback, { data: error });
}
export class CodexAppServerClient {
constructor({
command = 'codex',
args = ['app-server', '--stdio'],
cwd = process.cwd(),
env = process.env,
spawnFactory = spawn,
clock = () => performance.now(),
clientInfo = DEFAULT_CLIENT_INFO,
initializeParams = {},
requestTimeoutMs = 30_000,
turnTimeoutMs = 120_000,
} = {}) {
this.command = command;
this.args = [...args];
this.cwd = cwd;
this.env = env;
this.spawnFactory = spawnFactory;
this.clock = clock;
this.clientInfo = { ...DEFAULT_CLIENT_INFO, ...clientInfo };
this.initializeParams = { ...initializeParams };
this.requestTimeoutMs = requestTimeoutMs;
this.turnTimeoutMs = turnTimeoutMs;
this.process = null;
this.state = 'disconnected';
this.connectionGeneration = 0;
this.lastExit = null;
this.stderr = '';
this.initializeResult = null;
this.connectedAt = null;
this._nextRequestId = 1;
this._pending = new Map();
this._notificationListeners = new Set();
this._disconnectListeners = new Set();
this._dedicatedThreadIds = new Set();
this._connectPromise = null;
this._stdoutBuffer = '';
this._failedGeneration = 0;
}
get connected() {
return this.state === 'connected';
}
get dedicatedThreadIds() {
return [...this._dedicatedThreadIds];
}
async connect() {
if (this.connected) return this;
if (this._connectPromise) return this._connectPromise;
this._connectPromise = this._connect();
try {
return await this._connectPromise;
} finally {
this._connectPromise = null;
}
}
async _connect() {
if (this.state !== 'disconnected') {
throw new CodexAppServerError(`cannot connect while client is ${this.state}`);
}
this.state = 'connecting';
this.lastExit = null;
this.stderr = '';
this._stdoutBuffer = '';
const generation = ++this.connectionGeneration;
const startedAt = this.clock();
let child;
try {
child = this.spawnFactory(this.command, this.args, {
cwd: this.cwd,
env: this.env,
stdio: ['pipe', 'pipe', 'pipe'],
});
this._bindProcess(child, generation);
this.process = child;
this.initializeResult = await this.request('initialize', {
...this.initializeParams,
clientInfo: this.clientInfo,
});
this._send({ method: 'initialized', params: {} });
this.connectedAt = this.clock();
this.startupMs = this.connectedAt - startedAt;
this.state = 'connected';
return this;
} catch (error) {
this._failConnection(asError(error, 'failed to connect to Codex app-server'), generation);
child?.stdin?.end?.();
child?.kill?.('SIGTERM');
throw error;
}
}
_bindProcess(child, generation) {
if (!child?.stdin || !child?.stdout) {
throw new TypeError('spawnFactory must return a child process with stdin and stdout');
}
child.stdout.setEncoding?.('utf8');
child.stderr?.setEncoding?.('utf8');
child.stdout.on('data', (chunk) => this._onStdout(chunk, generation));
child.stderr?.on('data', (chunk) => {
if (generation === this.connectionGeneration) this.stderr += String(chunk);
});
child.stdin.on?.('error', (error) => this._failConnection(
new CodexAppServerError(`Codex app-server stdin error: ${error.message}`, { cause: error }),
generation,
));
child.once('error', (error) => this._failConnection(
new CodexAppServerError(`Codex app-server process error: ${error.message}`, { cause: error }),
generation,
));
child.once('exit', (code, signal) => {
const suffix = signal ? `signal ${signal}` : `code ${code}`;
this._failConnection(new CodexAppServerError(`Codex app-server exited with ${suffix}`), generation, {
code,
signal,
});
});
}
_onStdout(chunk, generation) {
if (generation !== this.connectionGeneration || this.state === 'disconnected' || this.state === 'closing') {
return;
}
this._stdoutBuffer += String(chunk);
let newline;
while ((newline = this._stdoutBuffer.indexOf('\n')) !== -1) {
const line = this._stdoutBuffer.slice(0, newline).trim();
this._stdoutBuffer = this._stdoutBuffer.slice(newline + 1);
if (!line) continue;
try {
this._onMessage(JSON.parse(line));
} catch (error) {
this._emitNotification({
method: 'client/protocol-error',
params: { line, error: error.message },
receivedAt: this.clock(),
});
}
}
}
_onMessage(message) {
if (message?.id !== undefined && message?.id !== null && this._pending.has(message.id)) {
const pending = this._pending.get(message.id);
this._pending.delete(message.id);
if (pending.timer) clearTimeout(pending.timer);
if (message.error) {
const detail = typeof message.error.message === 'string'
? message.error.message
: JSON.stringify(message.error);
pending.reject(new CodexAppServerError(`${pending.method}: ${detail}`, {
code: message.error.code,
data: message.error.data,
}));
} else {
pending.resolve(message.result);
}
return;
}
if (message?.method) {
this._emitNotification({ ...message, receivedAt: this.clock() });
}
}
_emitNotification(notification) {
for (const entry of [...this._notificationListeners]) {
if (entry.method && entry.method !== notification.method) continue;
try {
entry.listener(notification);
} catch {
// A consumer exception must not break protocol dispatch for other listeners.
}
}
}
_send(message) {
if (!this.process || this.state === 'disconnected' || this.state === 'closing') {
throw new CodexAppServerError('Codex app-server is not connected');
}
try {
this.process.stdin.write(`${JSON.stringify(message)}\n`);
} catch (error) {
throw new CodexAppServerError('failed to write to Codex app-server', { cause: error });
}
}
request(method, params = {}, { timeoutMs = this.requestTimeoutMs } = {}) {
requireString(method, 'method');
if (!this.process || this.state === 'disconnected' || this.state === 'closing') {
return Promise.reject(new CodexAppServerError('Codex app-server is not connected'));
}
const id = this._nextRequestId++;
return new Promise((resolve, reject) => {
let timer = null;
if (Number.isFinite(timeoutMs) && timeoutMs > 0) {
timer = setTimeout(() => {
this._pending.delete(id);
reject(new CodexAppServerError(`${method} timed out after ${timeoutMs}ms`));
}, timeoutMs);
timer.unref?.();
}
this._pending.set(id, { method, resolve, reject, timer, sentAt: this.clock() });
try {
this._send({ method, id, params });
} catch (error) {
this._pending.delete(id);
if (timer) clearTimeout(timer);
reject(error);
}
});
}
notify(method, params = {}) {
requireString(method, 'method');
this._send({ method, params });
}
onNotification(method, listener) {
if (typeof method === 'function') {
listener = method;
method = null;
}
if (typeof listener !== 'function') throw new TypeError('listener must be a function');
const entry = { method, listener };
this._notificationListeners.add(entry);
return () => this._notificationListeners.delete(entry);
}
async listModels(params = {}) {
const result = await this.request('model/list', {
includeHidden: false,
limit: 100,
...params,
});
return result?.data || [];
}
async selectFastModel(params = {}) {
return selectFastCodexModel(await this.listModels(params));
}
async startDedicatedThread(params) {
if (!params || typeof params !== 'object' || Array.isArray(params)) {
throw new TypeError('dedicated thread parameters are required');
}
const result = await this.request('thread/start', { ...params });
const threadId = requireString(result?.thread?.id, 'thread/start result.thread.id');
this._dedicatedThreadIds.add(threadId);
return result.thread;
}
async resumeDedicatedThread(threadId, params = {}) {
requireString(threadId, 'threadId');
if (params.history !== undefined || params.path !== undefined) {
throw new TypeError('dedicated threads may only be resumed by explicit threadId');
}
const result = await this.request('thread/resume', { ...params, threadId });
const resumedId = requireString(result?.thread?.id || threadId, 'thread/resume result.thread.id');
if (resumedId !== threadId) {
throw new CodexAppServerError(`thread/resume returned unexpected thread ${resumedId}`);
}
this._dedicatedThreadIds.add(threadId);
return result.thread;
}
_requireDedicatedThread(threadId) {
requireString(threadId, 'threadId');
if (!this._dedicatedThreadIds.has(threadId)) {
throw new CodexAppServerError(
`thread ${threadId} is not owned by this client; start or explicitly resume a dedicated thread first`,
);
}
}
async startTurn({ threadId, input, timeoutMs = this.turnTimeoutMs, onStarted, onAgentMessage, ...params }) {
this._requireDedicatedThread(threadId);
const normalizedInput = typeof input === 'string'
? [{ type: 'text', text: input }]
: input;
if (!Array.isArray(normalizedInput) || normalizedInput.length === 0) {
throw new TypeError('input must be a non-empty string or input array');
}
const requestedAt = this.clock();
let turnId = null;
let started = null;
let completed = null;
let tokenUsage = null;
const agentMessages = [];
const agentMessageCallbacks = [];
let firstAgentMessageAt = null;
const buffered = [];
let completionResolve;
let completionReject;
let completionTimer = null;
const completionPromise = new Promise((resolve, reject) => {
completionResolve = resolve;
completionReject = reject;
});
completionPromise.catch(() => {});
const consider = (notification) => {
const notificationThreadId = notification.params?.threadId;
const notificationTurnId = notification.params?.turnId || notification.params?.turn?.id;
if (notificationThreadId !== threadId) return;
if (!turnId) {
buffered.push(notification);
return;
}
if (notificationTurnId !== turnId) return;
if (notification.method === 'turn/started') started = notification;
if (notification.method === 'thread/tokenUsage/updated') {
tokenUsage = notification.params?.tokenUsage || tokenUsage;
}
if (notification.method === 'item/completed'
&& notification.params?.item?.type === 'agentMessage'
&& typeof notification.params.item.text === 'string') {
const message = notification.params.item.text;
agentMessages.push(message);
if (firstAgentMessageAt == null) firstAgentMessageAt = notification.receivedAt ?? this.clock();
if (typeof onAgentMessage === 'function') {
agentMessageCallbacks.push(Promise.resolve().then(() => onAgentMessage(message, {
threadId,
turnId,
notification,
})));
}
}
if (notification.method === 'turn/completed') {
completed = notification;
completionResolve(notification);
}
};
const unsubscribe = this.onNotification(consider);
const onDisconnect = (error) => completionReject(error);
this._disconnectListeners.add(onDisconnect);
if (Number.isFinite(timeoutMs) && timeoutMs > 0) {
completionTimer = setTimeout(() => {
completionReject(new CodexAppServerError(`turn completion timed out after ${timeoutMs}ms`));
}, timeoutMs);
completionTimer.unref?.();
}
try {
const result = await this.request('turn/start', {
...params,
threadId,
input: normalizedInput,
}, { timeoutMs });
turnId = requireString(result?.turn?.id, 'turn/start result.turn.id');
if (typeof onStarted === 'function') onStarted(turnId, result.turn);
for (const notification of buffered.splice(0)) consider(notification);
await completionPromise;
await Promise.all(agentMessageCallbacks);
const completedAt = completed?.receivedAt ?? this.clock();
const status = completed?.params?.turn?.status || result.turn?.status || null;
if (status !== 'completed') {
const interrupted = status === 'interrupted' || status === 'cancelled' || status === 'canceled';
throw new CodexAppServerError(`turn ${turnId} completed with status ${status || 'unknown'}`, {
code: interrupted ? 'TURN_INTERRUPTED' : 'TURN_FAILED',
data: completed?.params?.turn || result.turn || null,
});
}
return {
threadId,
turnId,
turn: completed?.params?.turn || result.turn,
startResponse: result,
started,
completed,
tokenUsage,
status,
agentMessages,
message: agentMessages.at(-1) || null,
requestedAt,
firstAgentMessageAt,
firstAgentMessageMs: firstAgentMessageAt == null ? null : firstAgentMessageAt - requestedAt,
completedAt,
durationMs: completedAt - requestedAt,
};
} finally {
unsubscribe();
this._disconnectListeners.delete(onDisconnect);
if (completionTimer) clearTimeout(completionTimer);
}
}
interruptTurn(threadId, turnId) {
this._requireDedicatedThread(threadId);
requireString(turnId, 'turnId');
return this.request('turn/interrupt', { threadId, turnId });
}
async unsubscribeThread(threadId) {
this._requireDedicatedThread(threadId);
return this.request('thread/unsubscribe', { threadId });
}
async archiveThread(threadId) {
this._requireDedicatedThread(threadId);
const result = await this.request('thread/archive', { threadId });
this._dedicatedThreadIds.delete(threadId);
return result;
}
async reconnect({ threadId, resumeParams = {} } = {}) {
if (threadId !== undefined) requireString(threadId, 'threadId');
await this.disconnect();
await this.connect();
if (threadId !== undefined) return this.resumeDedicatedThread(threadId, resumeParams);
return this;
}
async disconnect() {
if (this.state === 'disconnected') return;
const child = this.process;
const generation = this.connectionGeneration;
this.state = 'closing';
this.process = null;
try {
child?.stdin?.end?.();
} finally {
child?.kill?.('SIGTERM');
this._failConnection(new CodexAppServerError('Codex app-server connection closed'), generation);
}
}
async close({ threadId, archive = false, unsubscribe = false } = {}) {
if (threadId !== undefined && this.connected) {
if (archive) await this.archiveThread(threadId);
else if (unsubscribe) await this.unsubscribeThread(threadId);
}
await this.disconnect();
this._notificationListeners.clear();
this._dedicatedThreadIds.clear();
}
_failConnection(error, generation, exit = null) {
if (generation !== this.connectionGeneration) return;
if (this._failedGeneration === generation) {
if (exit && !this.lastExit) this.lastExit = { ...exit, at: this.clock() };
return;
}
this._failedGeneration = generation;
if (exit) this.lastExit = { ...exit, at: this.clock() };
this.state = 'disconnected';
this.process = null;
for (const pending of this._pending.values()) {
if (pending.timer) clearTimeout(pending.timer);
pending.reject(error);
}
this._pending.clear();
for (const listener of [...this._disconnectListeners]) listener(error);
}
}
export function createCodexAppServerClient(options) {
return new CodexAppServerClient(options);
}
plugin/skills/impeccable/scripts/live/codex-worker-supervisor.mjs
-962
View File
@@ -1,962 +0,0 @@
import fs from 'node:fs';
import path from 'node:path';
import { execFileSync, spawnSync } from 'node:child_process';
import { randomBytes } from 'node:crypto';
import { fileURLToPath } from 'node:url';
import {
selectLowestReasoningEffort,
selectQualityCodexModel,
} from './codex-app-server-client.mjs';
import { loadContext } from '../context.mjs';
import { reconcilePublishedSourceVariants } from './generation-publisher.mjs';
import {
CODEX_WORKER_OWNER,
applyCodexWorkerOutput,
buildCodexWorkerInstructions,
buildCodexWorkerTurnInputs,
buildGenerationTurnInput,
codexWorkerDetectorRepairSchema,
codexWorkerOutputSchemaForPhase,
codexWorkerStateIsOwned,
generationIsCanceled,
isCodexComponentPreviewMode,
prepareCodexWorkerPhase,
publishCodexWorkerPhase,
readPreparedArtifact,
resolveCodexWorkerSkillPath,
} from './codex-worker.mjs';
import {
augmentEventWithAcceptHandling,
completeAcceptHandling,
fetchNextEvent,
postReply,
requiresAgentReply,
} from '../live-poll.mjs';
import { createLiveSessionStore } from './session-store.mjs';
export const CODEX_WORKER_EVENT_TYPES = Object.freeze(['generate', 'accept', 'discard', 'prefetch']);
export const CODEX_WORKER_EVENT_LEASE_MS = 15_000;
const LOCAL_SCRIPTS_DIR = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
export class CodexLiveWorkerSupervisor {
constructor({
cwd,
base,
token,
client,
config,
statePath,
scriptsDir,
fetchEvent = fetchNextEvent,
handleAccept = augmentEventWithAcceptHandling,
completeAccept = completeAcceptHandling,
reply = postReply,
publishCheckpoint = postVariantCheckpoint,
publishPhase = postAgentPhase,
postCleanup = postCarbonizeCleanup,
detectCandidate = detectPreparedArtifact,
sessionStore = null,
log = () => {},
}) {
this.cwd = path.resolve(cwd);
this.base = base;
this.token = token;
this.client = client;
this.config = config;
this.statePath = statePath;
this.scriptsDir = scriptsDir;
this.fetchEvent = fetchEvent;
this.handleAccept = handleAccept;
this.completeAccept = completeAccept;
this.reply = reply;
this.publishCheckpoint = publishCheckpoint;
this.publishPhase = publishPhase;
this.postCleanup = postCleanup;
this.detectCandidate = detectCandidate;
this.sessionStore = sessionStore || createLiveSessionStore({ cwd: this.cwd });
this.log = log;
this.running = false;
this.queue = Promise.resolve();
this.active = null;
this.canceled = new Set();
this.queuedGenerationIds = new Set();
this.pollAbortController = null;
this.activePoll = null;
this.failure = null;
this.thread = null;
this.threadReady = Promise.resolve(null);
this.model = null;
this.liveSpec = '';
this.threadPrimed = false;
}
async initialize() {
this.liveSpec = readOptional(path.join(this.scriptsDir, '..', 'reference', 'live-generation.md'));
await this.client.connect();
const models = await this.client.listModels();
this.model = this.config.model
? models.find((model) => model.id === this.config.model || model.model === this.config.model)
: this.config.profile === 'fast'
? selectFastCodexModel(models)
: selectQualityCodexModel(models);
if (!this.model) throw supervisorError('codex_worker_model_unavailable');
const prior = readJson(this.statePath);
if (codexWorkerStateIsOwned(prior, this.cwd) && prior.status !== 'archived') {
try {
this.thread = await this.client.resumeDedicatedThread(prior.threadId, {
model: this.model.model || this.model.id,
cwd: this.cwd,
approvalPolicy: 'never',
sandbox: 'read-only',
baseInstructions: buildCodexWorkerInstructions(this.liveSpec),
});
this.threadPrimed = prior.threadPrimed === true;
} catch (error) {
this.log(`resume failed; creating replacement worker thread: ${error.message}`);
}
}
if (!this.thread) {
this.thread = await this.startWorkerThread();
}
this.threadReady = Promise.resolve(this.thread);
this.writeState('ready');
return this.status();
}
async run() {
if (!this.thread) await this.initialize();
this.running = true;
this.pollAbortController = new AbortController();
while (this.running) {
let event;
try {
const poll = this.fetchEvent(this.base, this.token, {
types: CODEX_WORKER_EVENT_TYPES,
leaseMs: CODEX_WORKER_EVENT_LEASE_MS,
signal: this.pollAbortController.signal,
});
this.activePoll = poll;
event = await poll;
} catch (error) {
if (!this.running && (error?.name === 'AbortError' || this.pollAbortController.signal.aborted)) break;
throw error;
} finally {
this.activePoll = null;
}
if (!this.running) break;
if (!event || event.type === 'timeout') continue;
if (event.type === 'exit') {
await this.cancelActive('live_exit');
this.running = false;
break;
}
if (event.type === 'accept' || event.type === 'discard') {
this.canceled.add(event.id);
const replaceBusyThread = this.active?.eventId === event.id;
// Cancellation fences publication synchronously. Do not make the
// deterministic Accept/Discard path wait on a slow app-server
// interrupt round trip before it can update source and reply.
void this.cancelActive(event.type, event.id);
if (replaceBusyThread) this.rotateWorkerThread(event.type);
const handled = await this.handleAccept(event, this.base, this.token, {
deferReply: event.type === 'accept',
});
if (handled?._acceptResult?.handled !== true) {
this.log(`${event.type} ${event.id} source update failed: ${handled?._acceptResult?.error || 'unhandled'}`);
}
if (event.type === 'accept' && handled?._acceptResult?.carbonize === true) {
await this.postCleanup(this.base, this.token, {
id: event.id,
sessionId: event.id,
file: handled._acceptResult.file,
variantId: event.variantId,
acceptResult: handled._acceptResult,
});
}
if (handled?._completionAck?.deferred === true) {
await this.completeAccept(handled, this.base, this.token);
}
continue;
}
if (event.type === 'generate') {
if (this.queuedGenerationIds.has(event.id)) continue;
this.queuedGenerationIds.add(event.id);
this.queue = this.queue
.then(() => this.processGeneration(event))
.catch((error) => this.handleGenerationFailure(event, error))
.finally(() => this.queuedGenerationIds.delete(event.id));
continue;
}
if (event.type === 'prefetch') continue;
if (requiresAgentReply(event)) {
await this.reply(this.base, this.token, {
id: event.id,
type: 'error',
sourceEventType: event.type,
message: `Dedicated Codex worker does not handle ${event.type}; disable IMPECCABLE_LIVE_CODEX_WORKER for the portable foreground path.`,
});
}
}
await this.queue.catch(() => {});
await this.shutdown({ archive: !this.failure });
}
async processGeneration(event) {
if (this.isCanceled(event.id)) return;
await this.threadReady;
if (this.isCanceled(event.id)) return;
if (!event.scaffold?.file) event.scaffold = runDeterministicScaffold(event, {
cwd: this.cwd,
scriptsDir: this.scriptsDir,
});
this.active = { eventId: event.id, turnId: null, threadId: this.thread.id };
this.writeState('working', { eventId: event.id });
try {
const expectedVariants = Number(event.count || 1);
const snapshot = this.sessionStore.getSnapshot(event.id, { includeCompleted: true });
const sameEpoch = Number(snapshot?.generationEpoch || 1) === Number(event.generationEpoch || 1);
let arrivedVariants = sameEpoch ? Number(snapshot?.arrivedVariants || 0) : 0;
let completedRemainder = false;
if (this.config.delivery === 'progressive' && expectedVariants > 1) {
if (arrivedVariants < 1) {
await this.runGenerationPhase(event, 'first', 1);
arrivedVariants = 1;
}
if (this.isCanceled(event.id)) return;
if (arrivedVariants < expectedVariants) {
await this.runGenerationPhase(event, 'remainder', expectedVariants);
arrivedVariants = expectedVariants;
completedRemainder = true;
}
if (this.isCanceled(event.id)) return;
const latest = this.sessionStore.getSnapshot(event.id, { includeCompleted: true });
if (!completedRemainder && arrivedVariants >= expectedVariants && latest?.paramsPublished !== true) {
await this.runGenerationPhase(event, 'params', expectedVariants);
}
} else if (arrivedVariants < expectedVariants) {
await this.runGenerationPhase(event, 'atomic', expectedVariants);
}
if (this.isCanceled(event.id)) return;
await this.reply(this.base, this.token, {
id: event.id,
type: 'done',
sourceEventType: event.type,
file: event.scaffold.file,
});
} finally {
if (this.active?.eventId === event.id) {
this.active = null;
this.writeState('ready');
}
}
}
startWorkerThread() {
this.threadPrimed = false;
return this.client.startDedicatedThread({
model: this.model.model || this.model.id,
cwd: this.cwd,
approvalPolicy: 'never',
sandbox: 'read-only',
ephemeral: false,
serviceName: 'impeccable_live_codex_worker',
baseInstructions: buildCodexWorkerInstructions(this.liveSpec),
});
}
rotateWorkerThread(reason) {
const priorThread = this.thread;
const drainingQueue = this.queue;
this.queue = Promise.resolve();
this.thread = null;
this.threadReady = this.startWorkerThread().then((thread) => {
this.thread = thread;
this.writeState('ready', {
rotatedAt: new Date().toISOString(),
rotationReason: reason,
});
return thread;
});
void this.threadReady.catch((error) => {
this.writeState('error', { error: error.message, rotationReason: reason });
this.log(`replacement worker thread failed: ${error.message}`);
});
if (priorThread) {
void drainingQueue.finally(async () => {
await this.client.archiveThread(priorThread.id).catch((error) => {
this.log(`retired worker thread archive failed: ${error.message}`);
});
});
}
return this.threadReady;
}
async runGenerationPhase(event, phase, arrivedVariants) {
for (let attempt = 0; attempt < 2; attempt += 1) {
try {
return await this.runGenerationPhaseOnce(event, phase, arrivedVariants);
} catch (error) {
const sourceChangedDuringGeneration = error?.code === 'publish_source_hash_mismatch';
if (!sourceChangedDuringGeneration || attempt > 0 || this.isCanceled(event.id)) throw error;
this.log(`source changed during ${event.id} ${phase}; re-preparing once before publication`);
}
}
}
async runGenerationPhaseOnce(event, phase, arrivedVariants) {
if (this.isCanceled(event.id)) return;
const phaseStartedAt = Date.now();
await this.publishPhase(this.base, this.token, {
eventId: event.id,
phase: generationPhaseName(phase, 'generating'),
});
const prepared = prepareCodexWorkerPhase({
id: event.id,
sourceFile: event.scaffold.file,
cwd: this.cwd,
});
const artifact = readPreparedArtifact(prepared, {
cwd: this.cwd,
maxBytes: this.config.maxArtifactBytes,
});
const contexts = readGenerationContexts(this.cwd, this.scriptsDir, event, {
includeStable: !this.threadPrimed,
});
const prompt = buildGenerationTurnInput({
event,
phase,
prepared,
artifact,
variantPlan: this.sessionStore.getSnapshot(event.id, { includeCompleted: true })?.variantPlan || null,
...contexts,
});
const input = buildCodexWorkerTurnInputs({
prompt,
skillPath: this.threadPrimed ? null : resolveCodexWorkerSkillPath(this.scriptsDir),
screenshotPath: event.screenshotPath,
cwd: this.cwd,
});
if (this.isCanceled(event.id)) return;
const outputSchema = codexWorkerOutputSchemaForPhase(
phase,
Number(event.count || arrivedVariants),
{ sourceDelta: (phase === 'first' || phase === 'remainder' || phase === 'params') && !isCodexComponentPreviewMode(prepared.previewMode) },
);
let result = await this.runTurnWithReconnect({
input,
outputSchema,
eventId: event.id,
effort: phase === 'params' ? 'low' : undefined,
});
this.threadPrimed = true;
this.writeState('working', { eventId: event.id });
if (this.isCanceled(event.id)) return;
await this.publishPhase(this.base, this.token, {
eventId: event.id,
phase: generationPhaseName(phase, 'validating'),
durationMs: Date.now() - phaseStartedAt,
});
const baselineFindings = this.detectCandidate(prepared, {
cwd: this.cwd,
scriptsDir: this.scriptsDir,
});
let applied;
let newFindings;
let acceptedDetectorWaivers = [];
for (let repairAttempt = 0; repairAttempt <= 1; repairAttempt += 1) {
restorePreparedArtifact(prepared, artifact, { cwd: this.cwd });
applied = applyCodexWorkerOutput({
output: result.answer,
prepared,
phase,
expectedVariants: Number(event.count || arrivedVariants),
sessionId: event.id,
scaffold: event.scaffold,
cwd: this.cwd,
maxBytes: this.config.maxArtifactBytes,
});
reconcileCandidateIfNeeded({
applied,
artifact,
prepared,
phase,
arrivedVariants,
cwd: this.cwd,
});
newFindings = diffDetectorFindings(
baselineFindings,
this.detectCandidate(prepared, { cwd: this.cwd, scriptsDir: this.scriptsDir }),
);
const waiverResolution = resolveDetectorFindingWaivers(
newFindings,
extractDetectorWaivers(result.answer),
);
newFindings = waiverResolution.unresolved;
acceptedDetectorWaivers = waiverResolution.accepted;
if (newFindings.length === 0) break;
if (repairAttempt === 1) {
const error = supervisorError('worker_output_detector_findings');
error.findings = newFindings;
throw error;
}
restorePreparedArtifact(prepared, artifact, { cwd: this.cwd });
result = await this.runTurnWithReconnect({
input: buildCodexWorkerTurnInputs({
prompt: buildDetectorRepairPrompt(phase, newFindings),
cwd: this.cwd,
}),
outputSchema: codexWorkerDetectorRepairSchema(outputSchema),
eventId: event.id,
});
if (this.isCanceled(event.id)) return;
}
if (applied.plan) {
this.sessionStore.appendEvent({
type: 'variant_plan',
id: event.id,
plan: applied.plan,
});
}
if (acceptedDetectorWaivers.length > 0) {
this.sessionStore.appendEvent({
type: 'detector_waivers',
id: event.id,
phase,
waivers: acceptedDetectorWaivers.map(({ waiver }) => waiver),
});
}
if (this.isCanceled(event.id)) return;
const published = publishCodexWorkerPhase({ event, prepared, arrivedVariants, phase, cwd: this.cwd });
let checkpointError;
for (let attempt = 0; attempt < 2; attempt += 1) {
try {
await this.publishCheckpoint(this.base, this.token, {
event,
published,
scaffold: event.scaffold,
arrivedVariants,
});
checkpointError = null;
break;
} catch (error) {
checkpointError = error;
}
}
if (checkpointError) throw checkpointError;
if (['remainder', 'params', 'atomic'].includes(phase)) {
await this.publishPhase(this.base, this.token, {
eventId: event.id,
phase: 'parameters_ready',
durationMs: Date.now() - phaseStartedAt,
});
}
}
async runTurnWithReconnect({
input,
outputSchema,
onAgentMessage,
eventId = this.active?.eventId,
effort,
}) {
let firstError;
for (let attempt = 0; attempt < 2; attempt += 1) {
try {
const threadId = this.thread.id;
if (this.active?.eventId === eventId) this.active.threadId = threadId;
const turn = await this.client.startTurn({
threadId,
input,
cwd: this.cwd,
model: this.model.model || this.model.id,
effort: preferredEffort(this.model, effort || this.config.effort),
summary: 'none',
approvalPolicy: 'never',
sandboxPolicy: { type: 'readOnly' },
outputSchema,
onAgentMessage,
onStarted: (turnId) => {
if (this.active?.eventId === eventId) this.active.turnId = turnId;
if (eventId && this.isCanceled(eventId)) {
this.client.interruptTurn(threadId, turnId).catch(() => {});
}
},
});
return { ...turn, answer: turn.message };
} catch (error) {
if (!firstError) firstError = error;
if (eventId && this.isCanceled(eventId)) throw error;
if (attempt > 0 || error.code === 'TURN_INTERRUPTED') throw error;
this.log(`app-server turn failed; reconnecting once: ${error.message}`);
await this.reconnect();
}
}
throw firstError;
}
async reconnect() {
this.thread = await this.reconnectThread(this.thread, this.model);
this.writeState('ready', { reconnectedAt: new Date().toISOString() });
}
async reconnectThread(thread, model = this.model) {
const resumed = await this.client.reconnect({
threadId: thread.id,
resumeParams: {
model: model.model || model.id,
cwd: this.cwd,
approvalPolicy: 'never',
sandbox: 'read-only',
baseInstructions: buildCodexWorkerInstructions(this.liveSpec),
},
});
if (thread === this.thread) {
this.thread = resumed;
this.writeState('ready', { reconnectedAt: new Date().toISOString() });
}
return resumed;
}
async cancelActive(reason, eventId = null) {
if (!this.active) return;
if (eventId && this.active.eventId !== eventId) return;
this.canceled.add(this.active.eventId);
const threadId = this.active.threadId || this.thread?.id;
if (threadId && this.active.turnId) {
await this.client.interruptTurn(threadId, this.active.turnId).catch(() => {});
}
this.log(`interrupted ${this.active.eventId}: ${reason}`);
}
async handleGenerationFailure(event, error) {
if (this.isCanceled(event.id) || error.code === 'TURN_INTERRUPTED') return;
this.log(`generation ${event.id} failed: ${error.stack || error.message}`);
this.failure = {
eventId: event.id,
error: error.message,
failedAt: new Date().toISOString(),
};
this.running = false;
this.pollAbortController?.abort();
if (this.activePoll) {
await Promise.race([
this.activePoll.catch(() => null),
new Promise((resolve) => {
const timer = setTimeout(resolve, 250);
timer.unref?.();
}),
]);
}
await this.reply(this.base, this.token, {
id: event.id,
type: 'retry',
sourceEventType: event.type,
}).catch(() => {});
this.writeState('failed', this.failure);
}
isCanceled(eventId) {
return this.canceled.has(eventId) || generationIsCanceled(eventId, { cwd: this.cwd });
}
async shutdown({ archive = false } = {}) {
this.running = false;
await this.cancelActive('shutdown');
await Promise.race([
this.threadReady.catch(() => null),
new Promise((resolve) => {
const timer = setTimeout(resolve, 1_000);
timer.unref?.();
}),
]);
let archived = false;
if (archive && this.thread) {
try {
await this.client.archiveThread(this.thread.id);
archived = true;
} catch (error) {
if (/no rollout found/i.test(String(error?.message || ''))) {
archived = true;
this.log('empty worker thread had no persisted rollout; treating it as archived');
} else {
this.log(`thread archive failed: ${error.message}`);
}
}
}
await this.client.close().catch(() => {});
this.writeState(
this.failure ? 'failed' : archived ? 'archived' : 'stopped',
{ archived, ...(this.failure || {}) },
);
}
status() {
return {
ok: true,
owner: CODEX_WORKER_OWNER,
cwd: this.cwd,
pid: process.pid,
status: this.active ? 'working' : 'ready',
threadId: this.thread?.id || null,
model: this.model?.model || this.model?.id || null,
effort: this.model ? preferredEffort(this.model, this.config.effort) : this.config.effort,
profile: this.config.profile,
delivery: this.config.delivery,
threadPrimed: this.threadPrimed,
eventId: this.active?.eventId || null,
};
}
writeState(status, extra = {}) {
const state = {
...this.status(),
...extra,
status,
updatedAt: new Date().toISOString(),
};
atomicWriteJson(this.statePath, state);
return state;
}
}
function generationPhaseName(phase, state) {
if (phase === 'first') return `first_variant_${state}`;
if (phase === 'params') return `variant_parameters_${state}`;
return `remaining_variants_${state}`;
}
function preferredEffort(model, requested) {
const supported = (model?.supportedReasoningEfforts || [])
.map((option) => typeof option === 'string' ? option : option?.reasoningEffort)
.filter(Boolean);
if (requested && supported.includes(requested)) return requested;
return selectLowestReasoningEffort(model);
}
export async function postVariantCheckpoint(base, token, {
event,
published,
scaffold,
arrivedVariants,
}) {
const response = await fetch(`${base}/events`, {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({
token,
type: 'checkpoint',
id: event.id,
revision: published.revision,
revisionDomain: 'publication',
phase: 'cycling',
reason: 'variants_progress',
arrivedVariants,
expectedVariants: event.count,
sourceFile: scaffold.sourceFile || scaffold.file,
previewFile: scaffold.file,
previewMode: scaffold.previewMode || 'source',
publicationKind: published.publicationKind || 'variants',
}),
});
if (!response.ok) throw supervisorError(`checkpoint_${response.status}`);
}
export async function postAgentPhase(base, token, {
eventId,
phase,
durationMs,
}) {
const response = await fetch(`${base}/events`, {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({
token,
type: 'agent_phase',
id: eventId,
phase,
owner: CODEX_WORKER_OWNER,
...(Number.isFinite(durationMs) ? { durationMs } : {}),
}),
});
if (!response.ok) throw supervisorError(`agent_phase_${response.status}`);
}
export async function postCarbonizeCleanup(base, token, {
sessionId,
file,
variantId,
acceptResult,
id = randomBytes(4).toString('hex'),
}) {
const response = await fetch(`${base}/events`, {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({
token,
type: 'carbonize_cleanup',
id,
sessionId,
file,
variantId,
acceptResult,
}),
});
if (!response.ok) throw supervisorError(`carbonize_cleanup_${response.status}`);
return { id, ...(await response.json()) };
}
export function buildDeterministicScaffoldCommand(event, scriptsDir) {
const insert = event.mode === 'insert';
const script = path.join(scriptsDir, insert ? 'live-insert.mjs' : 'live-wrap.mjs');
const args = ['--id', String(event.id), '--count', String(event.count || 3)];
const target = insert ? event.insert?.anchor || {} : event.element || {};
if (!insert) args.push('--isolated');
if (insert) args.push('--position', String(event.insert?.position || 'after'));
if (target.id) args.push('--element-id', String(target.id));
const classes = Array.isArray(target.classes) ? target.classes.join(',') : target.className;
if (classes) args.push('--classes', String(classes));
if (target.tagName || target.tag) args.push('--tag', String(target.tagName || target.tag).toLowerCase());
const text = String(target.textContent || target.text || '').trim().replace(/\s+/g, ' ').slice(0, 80);
if (!target.id && !classes && text) args.push('--query', text);
if (text) args.push('--text', text);
return { script, args };
}
export function runDeterministicScaffold(event, {
cwd = process.cwd(),
scriptsDir,
exec = execFileSync,
} = {}) {
const command = buildDeterministicScaffoldCommand(event, scriptsDir);
let output;
try {
output = exec(process.execPath, [command.script, ...command.args], {
cwd,
encoding: 'utf-8',
timeout: 30_000,
});
} catch (error) {
throw supervisorError(`codex_worker_scaffold_failed:${error.stderr || error.message}`);
}
let scaffold;
try { scaffold = JSON.parse(String(output).trim()); } catch { throw supervisorError('codex_worker_scaffold_invalid'); }
if (!scaffold?.file || scaffold.error) {
throw supervisorError(`codex_worker_scaffold_${scaffold?.error || 'missing_file'}`);
}
return scaffold;
}
function restorePreparedArtifact(prepared, artifact, { cwd }) {
if (!isCodexComponentPreviewMode(prepared.previewMode)) {
fs.writeFileSync(path.resolve(cwd, prepared.artifactFile), artifact.content, 'utf-8');
return;
}
const componentDir = path.resolve(cwd, prepared.componentDir);
fs.mkdirSync(componentDir, { recursive: true });
for (const name of fs.readdirSync(componentDir)) {
if (/^(?:v\d+\.(?:svelte|vue)|params\.json)$/.test(name)) {
fs.unlinkSync(path.join(componentDir, name));
}
}
for (const [name, content] of Object.entries(artifact.files || {})) {
fs.writeFileSync(path.join(componentDir, name), content, 'utf-8');
}
fs.writeFileSync(
path.resolve(cwd, prepared.artifactFile),
JSON.stringify(artifact.manifest, null, 2) + '\n',
'utf-8',
);
}
function reconcileCandidateIfNeeded({ applied, artifact, prepared, phase, arrivedVariants, cwd }) {
if (isCodexComponentPreviewMode(prepared.previewMode) || applied.sourceDelta || phase !== 'remainder') return;
const candidatePath = path.resolve(cwd, prepared.artifactFile);
const reconciled = reconcilePublishedSourceVariants({
current: artifact.content,
candidate: fs.readFileSync(candidatePath, 'utf-8'),
priorArrived: Math.max(1, arrivedVariants - 1),
});
if (!reconciled.ok) throw supervisorError(`reconcile_${reconciled.error}`);
fs.writeFileSync(candidatePath, reconciled.content, 'utf-8');
}
export function detectPreparedArtifact(prepared, {
cwd = process.cwd(),
scriptsDir = LOCAL_SCRIPTS_DIR,
spawn = spawnSync,
} = {}) {
const targets = detectorTargets(prepared, cwd);
if (targets.length === 0) return [];
const detectorScript = [
path.join(scriptsDir, 'detect.mjs'),
path.join(LOCAL_SCRIPTS_DIR, 'detect.mjs'),
].find((candidate) => fs.existsSync(candidate));
if (!detectorScript) throw supervisorError('codex_worker_detector_unavailable');
const result = spawn(process.execPath, [detectorScript, '--json', ...targets], {
cwd,
encoding: 'utf-8',
maxBuffer: 8 * 1024 * 1024,
});
if (result.error) throw supervisorError(`codex_worker_detector_failed:${result.error.message}`);
try {
const findings = JSON.parse(String(result.stdout || '[]'));
if (!Array.isArray(findings)) throw new Error('expected findings array');
return findings;
} catch (error) {
throw supervisorError(`codex_worker_detector_invalid:${error.message}`);
}
}
function detectorTargets(prepared, cwd) {
if (!isCodexComponentPreviewMode(prepared.previewMode)) {
return [path.resolve(cwd, prepared.artifactFile)];
}
const componentDir = path.resolve(cwd, prepared.componentDir);
try {
return fs.readdirSync(componentDir)
.filter((name) => /\.(?:vue|svelte)$/.test(name))
.map((name) => path.join(componentDir, name));
} catch {
return [];
}
}
export function diffDetectorFindings(before, after) {
const remaining = new Map();
for (const finding of before || []) {
const key = detectorFindingKey(finding);
remaining.set(key, (remaining.get(key) || 0) + 1);
}
const added = [];
for (const finding of after || []) {
const key = detectorFindingKey(finding);
const count = remaining.get(key) || 0;
if (count > 0) remaining.set(key, count - 1);
else added.push(finding);
}
return added;
}
function detectorFindingKey(finding) {
return [
path.basename(String(finding?.file || '')),
finding?.antipattern || finding?.id || '',
finding?.snippet || '',
finding?.ignoreValue || '',
].join('\u0000');
}
export function buildDetectorRepairPrompt(phase, findings) {
return [
`The candidate for Live phase ${phase} has new Impeccable detector findings.`,
'Use design judgment on every finding. Fix real defects. If a finding is contextually intentional or a detector false positive, leave that design intact and add one narrow detectorWaivers entry copied from the finding with a concrete reason. Return detectorWaivers as an empty array when every finding was fixed. Every finding must either disappear on the next scan or match an explicit waiver; unresolved findings still block publication.',
'Return the complete replacement JSON for the same phase and schema. Do not explain, call tools, persist project detector config, add inline ignore comments, or alter immutable variants.',
'<detector_findings>',
JSON.stringify((findings || []).slice(0, 40).map((finding) => ({
rule: finding.antipattern || finding.id,
name: finding.name,
description: finding.description,
severity: finding.severity,
snippet: finding.snippet,
file: path.basename(String(finding.file || '')),
ignoreValue: finding.ignoreValue || '',
})), null, 2),
'</detector_findings>',
].join('\n');
}
export function resolveDetectorFindingWaivers(findings, waivers) {
const candidates = (Array.isArray(waivers) ? waivers : [])
.map(normalizeDetectorWaiver)
.filter(Boolean);
const accepted = [];
const unresolved = [];
for (const finding of findings || []) {
const waiver = candidates.find((candidate) => detectorWaiverMatches(candidate, finding));
if (waiver) accepted.push({ finding, waiver });
else unresolved.push(finding);
}
return { accepted, unresolved };
}
function extractDetectorWaivers(output) {
try {
const parsed = typeof output === 'string' ? JSON.parse(output) : output;
return Array.isArray(parsed?.detectorWaivers) ? parsed.detectorWaivers : [];
} catch {
return [];
}
}
function normalizeDetectorWaiver(waiver) {
if (!waiver || typeof waiver !== 'object') return null;
const normalized = {
rule: String(waiver.rule || '').trim().toLowerCase(),
file: path.basename(String(waiver.file || '').trim()),
snippet: String(waiver.snippet || '').trim(),
ignoreValue: String(waiver.ignoreValue || '').trim(),
reason: String(waiver.reason || '').trim(),
};
return normalized.rule && normalized.reason && (normalized.snippet || normalized.ignoreValue)
? normalized
: null;
}
function detectorWaiverMatches(waiver, finding) {
const rule = String(finding?.antipattern || finding?.id || '').trim().toLowerCase();
const file = path.basename(String(finding?.file || '').trim());
const snippet = String(finding?.snippet || '').trim();
const ignoreValue = String(finding?.ignoreValue || '').trim();
if (waiver.rule !== rule) return false;
if (waiver.file && waiver.file !== file) return false;
if (waiver.ignoreValue) return waiver.ignoreValue === ignoreValue;
return Boolean(waiver.snippet && waiver.snippet === snippet);
}
function readGenerationContexts(cwd, scriptsDir, event, { includeStable = true } = {}) {
const context = loadContext(cwd);
const action = event?.action;
const safeAction = typeof action === 'string' && /^[a-z-]+$/.test(action) && action !== 'impeccable'
? action
: null;
return {
product: includeStable ? context.product || '' : '',
design: includeStable ? context.design || '' : '',
actionReference: safeAction
? readOptional(path.join(scriptsDir, '..', 'reference', `${safeAction}.md`))
: '',
contextMetadata: includeStable ? {
productPath: context.productPath,
designPath: context.designPath,
projectRoot: context.projectRoot,
repoRoot: context.repoRoot,
isMonorepo: context.isMonorepo,
} : {},
};
}
function readOptional(file) {
try { return fs.readFileSync(file, 'utf-8'); } catch { return ''; }
}
function readJson(file) {
try { return JSON.parse(fs.readFileSync(file, 'utf-8')); } catch { return null; }
}
function atomicWriteJson(file, value) {
fs.mkdirSync(path.dirname(file), { recursive: true });
const temporary = `${file}.${process.pid}.${Date.now()}.tmp`;
fs.writeFileSync(temporary, JSON.stringify(value, null, 2) + '\n', 'utf-8');
fs.renameSync(temporary, file);
}
function supervisorError(code) {
const error = new Error(code);
error.code = code;
return error;
}
plugin/skills/impeccable/scripts/live/codex-worker.mjs
-979
View File
@@ -1,979 +0,0 @@
import fs from 'node:fs';
import path from 'node:path';
import {
prepareGenerationArtifact,
publishGenerationArtifact,
} from './generation-publisher.mjs';
import { createLiveSessionStore } from './session-store.mjs';
export const CODEX_WORKER_OWNER = 'impeccable-live-codex-worker-v1';
export const CODEX_CLI_SETUP_URL = 'https://learn.chatgpt.com/docs/codex/cli';
const VARIANT_PLAN_SCHEMA = Object.freeze({
type: 'object',
properties: {
identityLock: {
type: 'array',
minItems: 1,
maxItems: 8,
items: { type: 'string', minLength: 1, maxLength: 240 },
},
directions: {
type: 'array',
minItems: 1,
maxItems: 6,
items: {
type: 'object',
properties: {
variantId: { type: 'integer', minimum: 1, maximum: 6 },
name: { type: 'string', minLength: 1, maxLength: 80 },
axis: { type: 'string', minLength: 1, maxLength: 120 },
intent: { type: 'string', minLength: 1, maxLength: 300 },
},
required: ['variantId', 'name', 'axis', 'intent'],
additionalProperties: false,
},
},
},
required: ['identityLock', 'directions'],
additionalProperties: false,
});
export const CODEX_WORKER_OUTPUT_SCHEMA = Object.freeze({
type: 'object',
properties: {
files: {
type: 'array',
minItems: 1,
items: {
type: 'object',
properties: {
path: { type: 'string', minLength: 1 },
content: { type: 'string' },
},
required: ['path', 'content'],
additionalProperties: false,
},
},
},
required: ['files'],
additionalProperties: false,
});
const DETECTOR_WAIVER_SCHEMA = Object.freeze({
type: 'array',
maxItems: 40,
items: {
type: 'object',
properties: {
rule: { type: 'string', minLength: 1 },
file: { type: 'string' },
snippet: { type: 'string' },
ignoreValue: { type: 'string' },
reason: { type: 'string', minLength: 1, maxLength: 500 },
},
required: ['rule', 'file', 'snippet', 'ignoreValue', 'reason'],
additionalProperties: false,
},
});
export function codexWorkerOutputSchemaForPhase(
phase,
expectedVariants = 3,
{ sourceDelta = false } = {},
) {
const requirePlan = Number(expectedVariants) > 1 && (phase === 'first' || phase === 'atomic');
if (sourceDelta) return codexSourceDeltaOutputSchema(phase, requirePlan, expectedVariants);
return {
...CODEX_WORKER_OUTPUT_SCHEMA,
properties: requirePlan
? { ...CODEX_WORKER_OUTPUT_SCHEMA.properties, plan: VARIANT_PLAN_SCHEMA }
: CODEX_WORKER_OUTPUT_SCHEMA.properties,
required: requirePlan ? ['files', 'plan'] : ['files'],
};
}
export function codexWorkerDetectorRepairSchema(outputSchema) {
return {
...outputSchema,
properties: {
...outputSchema.properties,
detectorWaivers: DETECTOR_WAIVER_SCHEMA,
},
required: [...outputSchema.required, 'detectorWaivers'],
};
}
function codexSourceDeltaOutputSchema(phase, requirePlan, expectedVariants) {
const variantDelta = (minimum, maximum = minimum) => ({
type: 'object',
properties: {
variantId: { type: 'integer', minimum, maximum },
markup: { type: 'string', minLength: 1 },
css: { type: 'string', minLength: 1 },
},
required: ['variantId', 'markup', 'css'],
additionalProperties: false,
});
let phaseProperties;
let phaseRequired;
if (phase === 'first') {
phaseProperties = { sourceDelta: variantDelta(1) };
phaseRequired = ['sourceDelta'];
} else if (phase === 'remainder') {
phaseProperties = {
sourceDeltas: {
type: 'array',
minItems: Math.max(1, Number(expectedVariants) - 1),
maxItems: Math.max(1, Number(expectedVariants) - 1),
items: variantDelta(2, Number(expectedVariants)),
},
parameterCss: { type: 'string' },
paramsJson: { type: 'string', minLength: 2 },
};
phaseRequired = ['sourceDeltas', 'parameterCss', 'paramsJson'];
} else if (phase === 'params') {
phaseProperties = {
parameterCss: { type: 'string' },
paramsJson: { type: 'string', minLength: 2 },
};
phaseRequired = ['parameterCss', 'paramsJson'];
} else {
phaseProperties = { sourceDelta: variantDelta(Number(expectedVariants)) };
phaseRequired = ['sourceDelta'];
}
return {
type: 'object',
properties: requirePlan
? { ...phaseProperties, plan: VARIANT_PLAN_SCHEMA }
: phaseProperties,
required: requirePlan ? [...phaseRequired, 'plan'] : phaseRequired,
additionalProperties: false,
};
}
export function resolveCodexWorkerConfig({ env = process.env, liveConfig = {} } = {}) {
const configured = liveConfig.experimentalCodexWorker || liveConfig.codexWorker || {};
const envEnabled = parseBoolean(env.IMPECCABLE_LIVE_CODEX_WORKER);
const configuredEnabled = parseBoolean(configured.enabled);
// The app-server lane is experimental and opt-in. A committed project
// setting can enable it only inside Codex; it can never switch another
// harness onto a Codex-specific runtime path.
const enabled = envEnabled == null
? isCodexRuntime(env) && configuredEnabled === true
: envEnabled;
const profile = nonEmpty(env.IMPECCABLE_LIVE_CODEX_PROFILE)
|| nonEmpty(configured.profile)
|| 'quality';
const requestedDelivery = nonEmpty(env.IMPECCABLE_LIVE_CODEX_DELIVERY)
|| nonEmpty(configured.delivery)
|| 'progressive';
return {
enabled,
model: nonEmpty(env.IMPECCABLE_LIVE_CODEX_MODEL) || nonEmpty(configured.model) || null,
codexPath: nonEmpty(env.IMPECCABLE_CODEX_PATH) || nonEmpty(configured.codexPath) || 'codex',
effort: nonEmpty(env.IMPECCABLE_LIVE_CODEX_EFFORT)
|| nonEmpty(configured.effort)
|| (profile === 'fast' ? 'low' : 'medium'),
profile: profile === 'fast' ? 'fast' : 'quality',
delivery: requestedDelivery === 'atomic' ? 'atomic' : 'progressive',
maxArtifactBytes: positiveInteger(configured.maxArtifactBytes, 2_000_000),
};
}
/**
* Resolve the executable exactly as Node's spawn path would: explicit paths
* stay project-relative, while bare commands are searched on PATH. This is a
* filesystem-only preflight so Live can fall back synchronously without
* adding another Codex process to the initialization critical path.
*/
export function resolveCodexExecutable(command = 'codex', {
cwd = process.cwd(),
env = process.env,
platform = process.platform,
} = {}) {
const requested = String(command || '').trim();
if (!requested) {
return { available: false, error: 'codex_cli_unavailable', command: 'codex' };
}
const pathApi = platform === 'win32' ? path.win32 : path;
const pathLike = pathApi.isAbsolute(requested)
|| requested.includes('/')
|| requested.includes('\\');
const extensions = executableExtensions(requested, env, platform);
const candidates = [];
if (pathLike) {
const base = pathApi.isAbsolute(requested) ? requested : pathApi.resolve(cwd, requested);
for (const extension of extensions) candidates.push(base + extension);
} else {
const pathValue = env.PATH || env.Path || env.path
|| (platform === 'win32' ? '' : '/usr/bin:/bin');
for (const rawEntry of String(pathValue).split(pathApi.delimiter)) {
const entry = rawEntry.replace(/^"|"$/g, '') || cwd;
for (const extension of extensions) candidates.push(pathApi.join(entry, requested + extension));
}
}
for (const candidate of candidates) {
try {
fs.accessSync(candidate, platform === 'win32' ? fs.constants.F_OK : fs.constants.X_OK);
if (!fs.statSync(candidate).isFile()) continue;
return { available: true, command: requested, resolvedPath: candidate };
} catch {
// Keep searching PATH. Shell aliases are intentionally ignored because
// child_process.spawn cannot resolve them either.
}
}
return { available: false, error: 'codex_cli_unavailable', command: requested };
}
function executableExtensions(command, env, platform) {
if (platform !== 'win32') return [''];
if (path.win32.extname(command)) return [''];
const value = env.PATHEXT || env.Pathext || '.COM;.EXE;.BAT;.CMD';
return String(value)
.split(';')
.map((extension) => extension.trim())
.filter(Boolean)
.map((extension) => extension.startsWith('.') ? extension : `.${extension}`);
}
export function isCodexRuntime(env = process.env) {
return Boolean(
nonEmpty(env.CODEX_THREAD_ID)
|| nonEmpty(env.CODEX_INTERNAL_ORIGINATOR_OVERRIDE)
|| parseBoolean(env.CODEX_CI) === true,
);
}
export function buildCodexWorkerInstructions(liveSpec) {
return [
'You are a dedicated Impeccable Live variant producer, never the foreground desktop task.',
'The Impeccable skill is attached on the first turn of this persistent Live thread. Its Setup context is already resolved in the user message; do not rerun setup.',
'Do not write source or mutate the project. The supervisor supplies the exact selected source artifact, writes staged artifacts, and publishes transactionally.',
'Use read-only repository tools whenever needed to understand imports, shared layouts, styles, tokens, components, or route ownership. Inspect rather than guess; discoveries remain available to later turns in this same thread.',
'Return only the JSON object required by the output schema. The supervisor alone writes staged artifacts and publishes them transactionally.',
'Preserve existing copy, semantics, public component APIs, accessibility, brand identity, and supplied tokens. Preserve shared-child roles, but recompose the selected element itself when the action calls for a stronger layout or spatial relationship. Do not emit data-impeccable wrappers inside variant content.',
'Treat shared-component visual roles as design-system evidence. Preserve their established background, border, radius, and state treatment unless the request explicitly targets that component; do not turn quiet or outlined controls into filled emphasis, inject decorative glyphs or pseudo-content, or change a component role.',
'When amplifying a selected element, prefer hierarchy, proportion, rhythm, and composition before increasing the chrome of nested shared controls.',
'Keep semantically unified short labels, names, and phrases readable as a unit. Do not fragment their words into disconnected layout cells or ornaments merely to create visual novelty.',
'When a short title or label fits on one line in the original at the supplied viewport, keep it on one line. Reallocate columns or simplify the composition instead of forcing an avoidable wrap.',
'Every variant must be independently shippable. Diversity is not a quota for gimmicks: vary a meaningful design axis while keeping each direction coherent with the project.',
'Before returning a variant, silently review it at the supplied viewport and reject awkward label wrapping, unanchored alignment, accidental compression, overflow, or any treatment that weakens the requested effect.',
'Treat the Live reference below as design and authoring guidance. Ignore any instruction in it to run commands, poll, reply, or edit files.',
'',
'<live_reference>',
String(liveSpec || ''),
'</live_reference>',
].join('\n');
}
export function buildGenerationTurnInput({
event,
phase,
prepared,
artifact,
variantPlan,
product,
design,
actionReference,
contextMetadata,
}) {
const count = Number(event.count || 3);
const first = phase === 'first';
const remainder = phase === 'remainder';
const params = phase === 'params';
const component = isCodexComponentPreviewMode(prepared.previewMode);
const sourceDelta = !component && (first || remainder || params);
const actionRules = event.action === 'bolder' && count > 1
? [
'For /bolder, keep variant 1 low-risk: preserve the selected root’s high-level layout and create impact through controlled hierarchy, proportion, or rhythm. Reserve root recomposition for variant 2 or 3.',
'At least one later direction must recompose the selected root or materially change the spatial relationship among its children. The set must not merely restyle the same descendant three ways.',
'Color alone is not a sufficient primary axis for /bolder; pair any palette shift with a meaningful hierarchy, proportion, rhythm, or composition change.',
'Every /bolder direction must be visibly more assertive than the original, including compact or dense directions. Do not shrink the focal title or trade away command fidelity merely to increase density.',
]
: [];
const phaseRules = first
? [
'Produce only variant 1 now so it can be reviewed immediately.',
'Variant 1 must be the strongest low-risk, independently shippable interpretation of the request; reserve more experimental directions for later variants.',
`Before authoring, define the shared identity lock and exactly ${count} distinct, meaningful design axes. Return them in plan.directions ordered by variantId so the final phase can complete the same coherent set.`,
'Defer tunable parameters: params must be absent or empty for this phase.',
]
: remainder
? [
`Produce variants 2 through ${count} and the final tunable parameters together so the complete set becomes reviewable in one publication.`,
'Variant 1 is already visible and immutable. Do not return or alter its markup or CSS.',
'Follow the durable variant plan below and implement every remaining direction as an independently shippable option.',
'Return the parameter manifest and wiring CSS for all variants, including immutable variant 1. Parameters may only expose meaningful axes already present in the designs and must not change any default appearance.',
'Parameter schema examples: range = {"id":"scale","kind":"range","label":"Scale","min":0.8,"max":1.2,"step":0.1,"default":1}; steps = {"id":"density","kind":"steps","label":"Density","options":[{"value":"compact","label":"Compact"},{"value":"roomy","label":"Roomy"}]}; toggle = {"id":"accent","kind":"toggle","label":"Accent","default":false}.',
'Range wiring sets --p-<id>. Steps and toggles use data-p-<id> on the variant wrapper. Return an empty array for a variant only when no meaningful coarse axis exists.',
]
: params
? [
`All ${count} variants are already reviewable and immutable. Return only their parameter manifest and parameter wiring CSS.`,
'Do not return markup or restyle any default appearance. Parameters may only expose meaningful axes already present in the designs.',
'The staged artifact and schema below are complete. Do not call tools or inspect the repository during this phase.',
'Parameter schema examples: range = {"id":"scale","kind":"range","label":"Scale","min":0.8,"max":1.2,"step":0.1,"default":1}; steps = {"id":"density","kind":"steps","label":"Density","options":[{"value":"compact","label":"Compact"},{"value":"roomy","label":"Roomy"}]}; toggle = {"id":"accent","kind":"toggle","label":"Accent","default":false}.',
'Range wiring sets --p-<id>. Steps and toggles use data-p-<id> on the variant wrapper. Return an empty array for a variant only when no meaningful coarse axis exists.',
]
: [
`Produce the complete set of ${count} variants and final parameters atomically.`,
`Before authoring, define the shared identity lock and exactly ${count} distinct, meaningful design axes and return them in plan.directions ordered by variantId.`,
];
const contextBlocks = [];
if (product) contextBlocks.push('<product_context>', String(product), '</product_context>');
if (design) contextBlocks.push('<design_context>', String(design), '</design_context>');
if (actionReference) contextBlocks.push('<action_reference>', String(actionReference), '</action_reference>');
if (contextMetadata && Object.keys(contextMetadata).length > 0) {
contextBlocks.push('<context_metadata>', JSON.stringify(contextMetadata, null, 2), '</context_metadata>');
}
return [
`LIVE GENERATION PHASE: ${phase}`,
...phaseRules,
...actionRules,
sourceDelta
? first
? 'Return exactly sourceDelta for variant 1 plus the complete variant plan. markup is only the selected root replacement, without an outer data-impeccable wrapper. css is only the complete fenced base CSS for variant 1, following event.scaffold.cssAuthoring.'
: remainder
? `Return exactly sourceDeltas with one entry for each variant 2 through ${count}, ordered by variantId, plus parameterCss and paramsJson. Each markup value is only the selected root replacement; each css value is the complete fenced base CSS for that variant. parameterCss contains tuning rules for variants 1 through ${count}. paramsJson is a JSON-encoded object with exactly the keys ${Array.from({ length: count }, (_, index) => JSON.stringify(String(index + 1))).join(', ')}, each containing an array of 0-4 range, steps, or toggle parameter specs.`
: `Return only parameterCss and paramsJson. parameterCss contains deferred tuning rules for variants 1 through ${count}. paramsJson is a JSON-encoded object with exactly the keys ${Array.from({ length: count }, (_, index) => JSON.stringify(String(index + 1))).join(', ')}, each containing an array of 0-4 range, steps, or toggle parameter specs.`
: component
? first
? `Return only v1.${artifact.componentExtension} relative to componentDir. The supervisor updates manifest.json.`
: remainder
? `Return exactly v2.${artifact.componentExtension} through v${count}.${artifact.componentExtension} plus params.json relative to componentDir.`
: params
? 'Return only params.json relative to componentDir, keyed by variant number.'
: `Return v1.${artifact.componentExtension} through v${count}.${artifact.componentExtension} plus params.json relative to componentDir.`
: `Return exactly one file whose path is ${JSON.stringify(prepared.artifactFile)} and whose content is the complete staged source artifact.`,
sourceDelta
? `Do not repeat the staged artifact${remainder || params ? ', prior variants' : ''}, style tags, wrapper comments, or any data-impeccable attributes. The supervisor merges and validates this output transactionally.${remainder || params ? ' parameterCss may only wire explicit data-p-* states or --p-* variables; it must not restyle default appearance.' : ''}`
: component
? 'Never include manifest.json or paths outside componentDir. Never repeat an immutable variant in a later phase.'
: 'Keep the existing session wrapper and markers intact. Add only valid variant blocks and preview CSS inside that wrapper.',
'',
'<event>',
JSON.stringify(sanitizeEvent(event), null, 2),
'</event>',
'<variant_plan>',
JSON.stringify(variantPlan || null, null, 2),
'</variant_plan>',
'',
...contextBlocks,
'<staged_artifact>',
JSON.stringify(artifact, null, 2),
'</staged_artifact>',
].join('\n');
}
export function buildCodexWorkerTurnInputs({ prompt, skillPath, screenshotPath, cwd = process.cwd() }) {
const inputs = [];
if (skillPath && fs.existsSync(skillPath)) {
inputs.push({ type: 'skill', name: 'impeccable', path: path.resolve(skillPath) });
}
const screenshot = resolveInside(cwd, screenshotPath);
if (screenshot && fs.existsSync(screenshot)) {
inputs.push({ type: 'localImage', path: screenshot, detail: 'high' });
}
inputs.push({ type: 'text', text: String(prompt) });
return inputs;
}
export function resolveCodexWorkerSkillPath(scriptsDir) {
const candidates = [
path.join(scriptsDir, '..', 'SKILL.md'),
path.join(scriptsDir, '..', 'SKILL.src.md'),
];
return candidates.find((candidate) => fs.existsSync(candidate)) || null;
}
export function readPreparedArtifact(prepared, { cwd = process.cwd(), maxBytes = 2_000_000 } = {}) {
if (isCodexComponentPreviewMode(prepared.previewMode)) {
const componentDir = resolveInside(cwd, prepared.componentDir);
const manifestPath = resolveInside(cwd, prepared.artifactFile);
if (!componentDir || !manifestPath) throw workerError('artifact_path_outside_project');
const manifest = readBounded(manifestPath, maxBytes);
const parsed = JSON.parse(manifest);
const componentExtension = parsed.componentExtension
|| (prepared.previewMode === 'vue-component' ? 'vue' : 'svelte');
const files = {};
for (const name of fs.readdirSync(componentDir)) {
if (!new RegExp(`^(?:v\\d+\\.${escapeRegExp(componentExtension)}|params\\.json)$`).test(name)) continue;
files[name] = readBounded(path.join(componentDir, name), maxBytes);
}
return {
previewMode: prepared.previewMode,
componentDir: prepared.componentDir,
componentExtension,
manifest: parsed,
files,
};
}
const artifactPath = resolveInside(cwd, prepared.artifactFile);
if (!artifactPath) throw workerError('artifact_path_outside_project');
return {
previewMode: prepared.previewMode || 'source',
path: prepared.artifactFile,
content: readBounded(artifactPath, maxBytes),
};
}
export function applyCodexWorkerOutput({
output,
prepared,
phase,
expectedVariants,
sessionId,
scaffold,
cwd = process.cwd(),
maxBytes = 2_000_000,
}) {
const parsed = typeof output === 'string' ? parseWorkerJson(output) : output;
const requirePlan = Number(expectedVariants) > 1 && (phase === 'first' || phase === 'atomic');
if (requirePlan && !parsed?.plan) throw workerError('worker_output_plan_missing');
const plan = parsed?.plan ? normalizeVariantPlan(parsed.plan, expectedVariants) : null;
if (!isCodexComponentPreviewMode(prepared.previewMode) && (phase === 'first' || phase === 'remainder' || phase === 'params')) {
const artifactPath = resolveInside(cwd, prepared.artifactFile);
if (!artifactPath) throw workerError('artifact_path_outside_project');
const common = {
sessionId,
expectedVariants: Number(expectedVariants),
styleMode: scaffold?.styleMode || scaffold?.cssAuthoring?.mode || 'scoped',
styleTag: scaffold?.styleTag,
jsx: scaffold?.commentSyntax?.open === '{/*',
};
let content = fs.readFileSync(artifactPath, 'utf-8');
if (phase === 'first') {
content = applyCodexSourceDelta({ ...common, source: content, delta: parsed?.sourceDelta, expectedVariantId: 1 });
} else if (phase === 'remainder') {
const deltas = Array.isArray(parsed?.sourceDeltas) ? parsed.sourceDeltas : [];
const expectedIds = Array.from({ length: Math.max(0, Number(expectedVariants) - 1) }, (_, index) => index + 2);
const ids = deltas.map((delta) => Number(delta?.variantId));
if (ids.length !== expectedIds.length || ids.some((id, index) => id !== expectedIds[index])) {
throw workerError('worker_output_source_delta_variant_invalid');
}
for (const delta of deltas) {
content = applyCodexSourceDelta({ ...common, source: content, delta, expectedVariantId: Number(delta.variantId) });
}
content = applyCodexSourceParameters({
...common,
source: content,
parameterCss: parsed?.parameterCss,
paramsJson: parsed?.paramsJson,
});
} else {
content = applyCodexSourceParameters({
...common,
source: content,
parameterCss: parsed?.parameterCss,
paramsJson: parsed?.paramsJson,
});
}
if (Buffer.byteLength(content) > maxBytes) throw workerError('worker_output_too_large');
fs.writeFileSync(artifactPath, content, 'utf-8');
return { files: [prepared.artifactFile], plan, sourceDelta: true };
}
if (!Array.isArray(parsed?.files) || parsed.files.length === 0) {
throw workerError('worker_output_files_missing');
}
const seen = new Set();
let totalBytes = 0;
for (const file of parsed.files) {
if (!file || typeof file.path !== 'string' || typeof file.content !== 'string') {
throw workerError('worker_output_file_invalid');
}
if (seen.has(file.path)) throw workerError('worker_output_file_duplicate');
seen.add(file.path);
totalBytes += Buffer.byteLength(file.content);
}
if (totalBytes > maxBytes) throw workerError('worker_output_too_large');
if (!isCodexComponentPreviewMode(prepared.previewMode)) {
if (parsed.files.length !== 1 || parsed.files[0].path !== prepared.artifactFile) {
throw workerError('worker_output_source_path_invalid');
}
const artifactPath = resolveInside(cwd, prepared.artifactFile);
if (!artifactPath) throw workerError('artifact_path_outside_project');
fs.writeFileSync(artifactPath, parsed.files[0].content, 'utf-8');
return { files: [prepared.artifactFile], plan };
}
const componentDir = resolveInside(cwd, prepared.componentDir);
const manifestPath = resolveInside(cwd, prepared.artifactFile);
if (!componentDir || !manifestPath) throw workerError('artifact_path_outside_project');
const manifest = JSON.parse(fs.readFileSync(manifestPath, 'utf-8'));
const extension = manifest.componentExtension
|| (prepared.previewMode === 'vue-component' ? 'vue' : 'svelte');
const variantPattern = new RegExp(`^v(\\d+)\\.${escapeRegExp(extension)}$`);
const allowed = new Set();
const firstVariant = phase === 'first' ? 1 : phase === 'remainder' ? 2 : phase === 'atomic' ? 1 : null;
const lastVariant = phase === 'first' ? 1 : phase === 'remainder' || phase === 'atomic' ? expectedVariants : null;
if (firstVariant != null) {
for (let variant = firstVariant; variant <= lastVariant; variant += 1) allowed.add(`v${variant}.${extension}`);
}
if (phase === 'remainder' || phase === 'params' || phase === 'atomic') allowed.add('params.json');
for (const file of parsed.files) {
if (!allowed.has(file.path)) {
const attemptedVariant = Number(variantPattern.exec(file.path)?.[1] || 0);
if (phase === 'remainder' && attemptedVariant > 0 && attemptedVariant < firstVariant) {
throw workerError('published_variant_changed');
}
throw workerError('worker_output_component_path_invalid');
}
const target = resolveInside(componentDir, file.path);
if (!target || path.dirname(target) !== componentDir) {
throw workerError('worker_output_component_path_invalid');
}
fs.writeFileSync(target, file.content, 'utf-8');
}
for (const required of allowed) {
if (!seen.has(required)) {
throw workerError('worker_output_component_file_missing', { file: required });
}
}
manifest.arrivedVariants = phase === 'first' ? 1 : expectedVariants;
fs.writeFileSync(manifestPath, JSON.stringify(manifest, null, 2) + '\n', 'utf-8');
return { files: [...seen], plan };
}
export function applyCodexSourceDelta({
source,
delta,
sessionId,
expectedVariantId = 2,
expectedVariants = 3,
styleMode = 'scoped',
styleTag = null,
jsx = false,
parameterCss = null,
paramsJson = null,
}) {
if (!delta || typeof delta !== 'object' || Array.isArray(delta)) {
throw workerError('worker_output_source_delta_missing');
}
const variantId = Number(expectedVariantId);
const variantCount = Number(expectedVariants);
if (!Number.isInteger(variantId) || variantId < 1 || variantId > variantCount
|| Number(delta.variantId) !== variantId) {
throw workerError('worker_output_source_delta_variant_invalid');
}
const markup = String(delta.markup || '').trim();
const css = String(delta.css || '').trim();
if (!markup || !css) throw workerError('worker_output_source_delta_empty');
if (/data-impeccable-(?:variant|variants|css)|impeccable-variants-(?:start|end)/i.test(markup)) {
throw workerError('worker_output_source_delta_wrapper_forbidden');
}
if (/<\/?style\b|`|\$\{/i.test(css)) {
throw workerError('worker_output_source_delta_css_unsafe');
}
validateSourceDeltaCss(css, { variantIds: [variantId], styleMode, requireVariantId: variantId });
const normalizedParameterCss = String(parameterCss || '').trim();
const params = paramsJson == null ? null : normalizeSourceParams(paramsJson, variantCount);
if (params) {
if (normalizedParameterCss) {
if (/<\/?style\b|`|\$\{/i.test(normalizedParameterCss)) {
throw workerError('worker_output_source_delta_css_unsafe');
}
validateSourceDeltaCss(normalizedParameterCss, {
variantIds: Array.from({ length: variantCount }, (_, index) => index + 1),
styleMode,
});
}
} else if (parameterCss != null || paramsJson != null) {
throw workerError('worker_output_source_delta_params_invalid');
}
const id = String(sessionId || '');
if (!id) throw workerError('worker_output_source_delta_session_missing');
const wrapper = findSessionWrapper(source, id);
if (!wrapper) throw workerError('worker_output_source_delta_wrapper_missing');
const wrapperSource = source.slice(wrapper.openStart, wrapper.closeEnd);
if (extractSourceVariantBlock(wrapperSource, variantId)) throw workerError('worker_output_source_delta_variant_exists');
const escapedId = escapeRegExp(id);
const styleOpen = new RegExp(`<style\\b[^>]*\\bdata-impeccable-css=(?:"${escapedId}"|'${escapedId}')[^>]*>`, 'i');
const styleMatch = styleOpen.exec(source);
let merged = source;
let newStyleBlock = null;
if (styleMatch) {
const styleContentStart = styleMatch.index + styleMatch[0].length;
const styleClose = source.indexOf('</style>', styleContentStart);
if (styleClose < 0 || styleClose > wrapper.closeEnd) {
throw workerError('worker_output_source_delta_style_invalid');
}
const styleContent = source.slice(styleContentStart, styleClose);
let nextStyleContent;
const firstTick = styleContent.indexOf('`');
const lastTick = styleContent.lastIndexOf('`');
if (firstTick >= 0 || lastTick >= 0) {
if (firstTick < 0 || lastTick <= firstTick) {
throw workerError('worker_output_source_delta_style_invalid');
}
nextStyleContent = styleContent.slice(0, lastTick).trimEnd()
+ '\n' + [css, normalizedParameterCss].filter(Boolean).join('\n') + '\n'
+ styleContent.slice(lastTick);
} else {
nextStyleContent = styleContent.trimEnd()
+ '\n' + [css, normalizedParameterCss].filter(Boolean).join('\n') + '\n';
}
merged = source.slice(0, styleContentStart) + nextStyleContent + source.slice(styleClose);
} else {
if (variantId !== 1) throw workerError('worker_output_source_delta_style_missing');
const openingTag = String(styleTag || `<style data-impeccable-css="${id}">`)
.replaceAll('SESSION_ID', id);
newStyleBlock = jsx
? [openingTag + '{`', css, '`}</style>'].join('\n')
: [openingTag, css, '</style>'].join('\n');
}
const nextWrapper = findSessionWrapper(merged, id);
if (!nextWrapper) throw workerError('worker_output_source_delta_wrapper_missing');
const endMarker = findSessionEndMarker(merged, id, nextWrapper);
const closeLineStart = merged.lastIndexOf('\n', nextWrapper.closeStart) + 1;
const closeLinePrefix = merged.slice(closeLineStart, nextWrapper.closeStart);
const childIndent = endMarker?.indent || nextWrapper.indent + ' ';
const contentIndent = childIndent + ' ';
const indentedMarkup = markup.split('\n')
.map((line) => line.trim() ? contentIndent + line : '')
.join('\n');
const variantBlock = [
...(newStyleBlock
? newStyleBlock.split('\n').map((line) => childIndent + line)
: []),
`${childIndent}<div data-impeccable-variant="${variantId}">`,
indentedMarkup,
`${childIndent}</div>`,
].join('\n');
if (endMarker) {
merged = merged.slice(0, endMarker.lineStart) + variantBlock + '\n' + merged.slice(endMarker.lineStart);
} else if (/^\s*$/.test(closeLinePrefix)) {
merged = merged.slice(0, closeLineStart) + variantBlock + '\n' + merged.slice(closeLineStart);
} else {
merged = merged.slice(0, nextWrapper.closeStart)
+ '\n' + variantBlock + '\n' + nextWrapper.indent
+ merged.slice(nextWrapper.closeStart);
}
if (params) merged = applySourceParams(merged, id, params, variantCount);
return merged;
}
export function applyCodexSourceParameters({
source,
sessionId,
expectedVariants = 3,
styleMode = 'scoped',
parameterCss = '',
paramsJson,
}) {
const variantCount = Number(expectedVariants);
const params = normalizeSourceParams(paramsJson, variantCount);
const css = String(parameterCss || '').trim();
if (/<\/?style\b|`|\$\{/i.test(css)) {
throw workerError('worker_output_source_delta_css_unsafe');
}
if (css) {
validateSourceDeltaCss(css, {
variantIds: Array.from({ length: variantCount }, (_, index) => index + 1),
styleMode,
});
}
const id = String(sessionId || '');
if (!id) throw workerError('worker_output_source_delta_session_missing');
let merged = String(source || '');
if (css) {
const escapedId = escapeRegExp(id);
const styleOpen = new RegExp(`<style\\b[^>]*\\bdata-impeccable-css=(?:"${escapedId}"|'${escapedId}')[^>]*>`, 'i');
const styleMatch = styleOpen.exec(merged);
if (!styleMatch) throw workerError('worker_output_source_delta_style_missing');
const contentStart = styleMatch.index + styleMatch[0].length;
const styleClose = merged.indexOf('</style>', contentStart);
if (styleClose < 0) throw workerError('worker_output_source_delta_style_invalid');
const styleContent = merged.slice(contentStart, styleClose);
const lastTick = styleContent.lastIndexOf('`');
const nextStyleContent = lastTick >= 0
? styleContent.slice(0, lastTick).trimEnd() + '\n' + css + '\n' + styleContent.slice(lastTick)
: styleContent.trimEnd() + '\n' + css + '\n';
merged = merged.slice(0, contentStart) + nextStyleContent + merged.slice(styleClose);
}
return applySourceParams(merged, id, params, variantCount);
}
function validateSourceDeltaCss(css, { variantIds, styleMode, requireVariantId = null }) {
const allowed = new Set(variantIds.map(String));
const refs = [...String(css).matchAll(/\[data-impeccable-variant=(?:"([^"]+)"|'([^']+)')\]/g)]
.map((match) => match[1] || match[2]);
if ((requireVariantId != null && !refs.includes(String(requireVariantId)))
|| refs.some((variant) => !allowed.has(variant))) {
throw workerError('worker_output_source_delta_css_unfenced');
}
if (!String(css).trim()) return;
const astroGlobal = styleMode === 'astro-global-prefixed';
if (astroGlobal ? /@scope\b/.test(css) : !/@scope\s*\(/.test(css)) {
throw workerError('worker_output_source_delta_css_strategy_invalid');
}
}
function normalizeSourceParams(paramsJson, expectedVariants) {
if (!Number.isInteger(expectedVariants) || expectedVariants < 1
|| Buffer.byteLength(String(paramsJson)) > 20_000) {
throw workerError('worker_output_source_delta_params_invalid');
}
let parsed;
try {
parsed = JSON.parse(String(paramsJson));
} catch {
throw workerError('worker_output_source_delta_params_invalid');
}
if (!parsed || typeof parsed !== 'object' || Array.isArray(parsed)) {
throw workerError('worker_output_source_delta_params_invalid');
}
const expectedKeys = Array.from({ length: expectedVariants }, (_, index) => String(index + 1));
if (Object.keys(parsed).sort().join(',') !== expectedKeys.join(',')) {
throw workerError('worker_output_source_delta_params_invalid');
}
for (const key of expectedKeys) {
if (!Array.isArray(parsed[key]) || parsed[key].length > 4) {
throw workerError('worker_output_source_delta_params_invalid');
}
const ids = new Set();
for (const spec of parsed[key]) {
const id = String(spec?.id || '');
const kind = String(spec?.kind || '');
if (!/^[a-z][a-z0-9-]{0,31}$/.test(id) || ids.has(id)
|| !['range', 'steps', 'toggle'].includes(kind)
|| typeof spec?.label !== 'string' || !spec.label.trim()) {
throw workerError('worker_output_source_delta_params_invalid');
}
ids.add(id);
if (kind === 'range'
&& !['min', 'max', 'step', 'default'].every((field) => Number.isFinite(spec[field]))) {
throw workerError('worker_output_source_delta_params_invalid');
}
if (kind === 'steps' && (!Array.isArray(spec.options) || spec.options.length < 2
|| spec.options.some((option) => (
typeof option?.value !== 'string' || typeof option?.label !== 'string'
)))) {
throw workerError('worker_output_source_delta_params_invalid');
}
if (kind === 'toggle' && typeof spec.default !== 'boolean') {
throw workerError('worker_output_source_delta_params_invalid');
}
}
}
return parsed;
}
function applySourceParams(source, sessionId, params, expectedVariants) {
const wrapper = findSessionWrapper(source, sessionId);
if (!wrapper) throw workerError('worker_output_source_delta_wrapper_missing');
let body = source.slice(wrapper.openStart, wrapper.closeEnd);
for (let variant = 1; variant <= expectedVariants; variant += 1) {
const attr = escapeRegExp(String(variant));
const open = new RegExp(`<div\\b[^>]*\\bdata-impeccable-variant=(?:"${attr}"|'${attr}')[^>]*>`, 'i');
const match = open.exec(body);
if (!match) throw workerError('worker_output_source_delta_variant_missing', { variant });
const json = JSON.stringify(params[String(variant)])
.replaceAll('&', '&amp;')
.replaceAll("'", '&apos;');
const nextOpen = match[0]
.replace(/\sdata-impeccable-params=(?:"[^"]*"|'[^']*')/i, '')
.replace(/>$/, ` data-impeccable-params='${json}'>`);
body = body.slice(0, match.index) + nextOpen + body.slice(match.index + match[0].length);
}
return source.slice(0, wrapper.openStart) + body + source.slice(wrapper.closeEnd);
}
function findSessionEndMarker(source, sessionId, wrapper) {
const marker = `impeccable-variants-end ${sessionId}`;
const markerAt = source.indexOf(marker, wrapper.openStart);
if (markerAt < 0 || markerAt >= wrapper.closeStart) return null;
const lineStart = source.lastIndexOf('\n', markerAt) + 1;
const indent = source.slice(lineStart, markerAt).match(/^\s*/)?.[0] || '';
return { lineStart, indent };
}
function normalizeVariantPlan(plan, expectedVariants) {
if (!plan || typeof plan !== 'object' || Array.isArray(plan)) {
throw workerError('worker_output_plan_invalid');
}
const identityLock = Array.isArray(plan.identityLock)
? plan.identityLock.map((item) => String(item || '').trim()).filter(Boolean)
: [];
const directions = Array.isArray(plan.directions) ? plan.directions : [];
if (identityLock.length < 1 || identityLock.length > 8 || directions.length !== Number(expectedVariants)) {
throw workerError('worker_output_plan_invalid');
}
const normalizedDirections = directions.map((direction) => ({
variantId: Number(direction?.variantId),
name: String(direction?.name || '').trim(),
axis: String(direction?.axis || '').trim(),
intent: String(direction?.intent || '').trim(),
}));
const expectedIds = Array.from({ length: Number(expectedVariants) }, (_, index) => index + 1);
const sortedIds = normalizedDirections.map((direction) => direction.variantId).sort((a, b) => a - b);
if (normalizedDirections.some((direction) => (
!Number.isInteger(direction.variantId)
|| !direction.name
|| !direction.axis
|| !direction.intent
)) || sortedIds.some((id, index) => id !== expectedIds[index])) {
throw workerError('worker_output_plan_invalid');
}
return { identityLock, directions: normalizedDirections };
}
export function prepareCodexWorkerPhase({ id, sourceFile, cwd = process.cwd() }) {
const prepared = prepareGenerationArtifact({ id, sourceFile, cwd });
if (!prepared.ok) throw workerError(`prepare_${prepared.error}`, prepared);
return prepared;
}
export function publishCodexWorkerPhase({
event,
prepared,
arrivedVariants,
phase,
cwd = process.cwd(),
}) {
const published = publishGenerationArtifact({
id: event.id,
epoch: prepared.epoch,
sourceFile: event.scaffold.file,
artifactFile: prepared.artifactFile,
expectedSourceHash: prepared.expectedSourceHash,
arrivedVariants,
expectedVariants: Number(event.count || arrivedVariants),
publicationKind: ['remainder', 'params', 'atomic'].includes(phase) ? 'params' : 'variants',
cwd,
});
if (!published.ok) throw workerError(`publish_${published.error}`, published);
return published;
}
export function generationIsCanceled(eventId, { cwd = process.cwd() } = {}) {
const snapshot = createLiveSessionStore({ cwd, sessionId: eventId }).getSnapshot(eventId, { includeCompleted: true });
return snapshot?.generationCanceled === true;
}
export function codexWorkerStateIsOwned(state, cwd) {
return codexWorkerOwnerMatches(state, cwd)
&& typeof state?.threadId === 'string'
&& state.threadId.length > 0;
}
export function isCodexComponentPreviewMode(value) {
return value === 'svelte-component' || value === 'vue-component';
}
export function codexWorkerProcessStateIsOwned(state, cwd) {
return codexWorkerOwnerMatches(state, cwd)
&& Number.isInteger(state?.pid)
&& state.pid > 0;
}
function codexWorkerOwnerMatches(state, cwd) {
return state?.owner === CODEX_WORKER_OWNER
&& canonicalPath(state?.cwd) === canonicalPath(cwd);
}
function canonicalPath(value) {
if (!value || typeof value !== 'string') return null;
const resolved = path.resolve(value);
try { return fs.realpathSync.native(resolved); } catch { return resolved; }
}
function sanitizeEvent(event) {
const copy = { ...event };
delete copy.agentAction;
delete copy._acceptResult;
delete copy._completionAck;
return copy;
}
function findSessionWrapper(source, sessionId) {
const escapedId = escapeRegExp(sessionId);
const open = new RegExp(`<div\\b[^>]*\\bdata-impeccable-variants=(?:"${escapedId}"|'${escapedId}')[^>]*>`, 'i');
const wrapperOpen = open.exec(source);
if (!wrapperOpen) return null;
const token = /<div\b[^>]*\/\s*>|<div\b[^>]*>|<\/div\s*>/gi;
token.lastIndex = wrapperOpen.index;
let depth = 0;
let match;
while ((match = token.exec(source))) {
if (/^<\/div/i.test(match[0])) {
depth -= 1;
if (depth === 0) {
const lineStart = source.lastIndexOf('\n', wrapperOpen.index) + 1;
const indent = source.slice(lineStart, wrapperOpen.index).match(/^\s*/)?.[0] || '';
return {
openStart: wrapperOpen.index,
closeStart: match.index,
closeEnd: token.lastIndex,
indent,
};
}
} else if (!/\/\s*>$/.test(match[0])) {
depth += 1;
}
}
return null;
}
function extractSourceVariantBlock(source, variantId) {
const attr = escapeRegExp(String(variantId));
return new RegExp(`<div\\b[^>]*\\bdata-impeccable-variant=(?:"${attr}"|'${attr}')[^>]*>`, 'i').test(source);
}
function parseWorkerJson(value) {
const text = String(value || '').trim().replace(/^```(?:json)?\s*/i, '').replace(/\s*```$/, '');
try {
return JSON.parse(text);
} catch (error) {
throw workerError('worker_output_json_invalid', { message: error.message });
}
}
function parseBoolean(value) {
if (value == null || value === '') return null;
if (/^(?:1|true|yes|on)$/i.test(String(value))) return true;
if (/^(?:0|false|no|off)$/i.test(String(value))) return false;
return null;
}
function nonEmpty(value) {
return typeof value === 'string' && value.trim() ? value.trim() : null;
}
function positiveInteger(value, fallback) {
const parsed = Number(value);
return Number.isInteger(parsed) && parsed > 0 ? parsed : fallback;
}
function resolveInside(root, value) {
if (!value || typeof value !== 'string') return null;
const resolvedRoot = path.resolve(root);
const resolved = path.resolve(resolvedRoot, value);
const relative = path.relative(resolvedRoot, resolved);
if (!relative || (!relative.startsWith('..') && !path.isAbsolute(relative))) return resolved;
return null;
}
function readBounded(file, maxBytes) {
const stat = fs.statSync(file);
if (stat.size > maxBytes) throw workerError('artifact_too_large', { bytes: stat.size });
return fs.readFileSync(file, 'utf-8');
}
function workerError(code, detail = {}) {
const error = new Error(code);
error.code = code;
Object.assign(error, detail);
return error;
}
function escapeRegExp(value) {
return String(value).replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
}
plugin/skills/impeccable/scripts/live/event-validation.mjs
-15
View File
@@ -118,15 +118,6 @@ export function validateEvent(msg) {
return 'checkpoint: paramValues must be an object';
}
return null;
case 'agent_phase':
if (!isValidId(msg.id)) return 'agent_phase: missing or malformed id';
if (typeof msg.phase !== 'string' || !/^[a-z][a-z0-9_]{1,63}$/.test(msg.phase)) {
return 'agent_phase: missing or malformed phase';
}
if (msg.durationMs !== undefined && (!Number.isFinite(msg.durationMs) || msg.durationMs < 0)) {
return 'agent_phase: durationMs must be a non-negative number';
}
return null;
case 'exit':
return null;
case 'prefetch':
@@ -140,12 +131,6 @@ export function validateEvent(msg) {
if (msg.message.length > 4000) return 'steer: message too long';
if (msg.pageUrl !== undefined && typeof msg.pageUrl !== 'string') return 'steer: pageUrl must be string';
return null;
case 'carbonize_cleanup':
if (!isValidId(msg.id)) return 'carbonize_cleanup: missing or malformed id';
if (!isValidId(msg.sessionId)) return 'carbonize_cleanup: missing or malformed sessionId';
if (!msg.file || typeof msg.file !== 'string') return 'carbonize_cleanup: missing file';
if (!isValidVariantId(String(msg.variantId))) return 'carbonize_cleanup: missing or malformed variantId';
return null;
default:
return 'Unknown event type: ' + msg.type;
}
plugin/skills/impeccable/scripts/live/generation-preflight.mjs
-93
View File
@@ -1,93 +0,0 @@
import { execFileSync } from 'node:child_process';
import path from 'node:path';
const PREFLIGHT_TIMEOUT_MS = 15_000;
export function buildGenerationPreflight(event, scriptsDir, { isolated = false } = {}) {
if (!event || event.type !== 'generate' || !event.id) return null;
const isInsert = event.mode === 'insert';
const target = isInsert ? insertTarget(event) : replaceTarget(event);
if (!target.elementId && !target.classes) return null;
const script = path.join(scriptsDir, isInsert ? 'live-insert.mjs' : 'live-wrap.mjs');
const args = [script, '--id', event.id, '--count', String(event.count || 3)];
if (!isInsert && isolated) args.push('--isolated');
if (isInsert) args.push('--position', target.position);
if (target.elementId) args.push('--element-id', target.elementId);
if (target.classes) args.push('--classes', target.classes);
if (target.tag) args.push('--tag', target.tag);
if (target.text) args.push('--text', target.text);
if (!isInsert && event.pageUrl) args.push('--page-url', event.pageUrl);
return { script, args, mode: isInsert ? 'insert' : 'replace' };
}
export function runGenerationPreflight(event, {
cwd = process.cwd(),
scriptsDir,
execFileSyncImpl = execFileSync,
timeoutMs = PREFLIGHT_TIMEOUT_MS,
isolated = false,
} = {}) {
const command = buildGenerationPreflight(event, scriptsDir, { isolated });
if (!command) {
return { ok: false, skipped: true, reason: 'insufficient_locator' };
}
const startedAt = performance.now();
try {
const stdout = execFileSyncImpl(process.execPath, command.args, {
cwd,
encoding: 'utf-8',
timeout: timeoutMs,
stdio: ['ignore', 'pipe', 'pipe'],
});
const line = String(stdout).trim().split('\n').filter(Boolean).pop();
if (!line) throw new Error('preflight returned no scaffold metadata');
return {
ok: true,
mode: command.mode,
durationMs: performance.now() - startedAt,
scaffold: JSON.parse(line),
};
} catch (error) {
return {
ok: false,
mode: command.mode,
durationMs: performance.now() - startedAt,
error: compactError(error),
};
}
}
function replaceTarget(event) {
return normalizeTarget(event.element || {});
}
function insertTarget(event) {
return {
...normalizeTarget(event.insert?.anchor || {}),
position: event.insert?.position === 'before' ? 'before' : 'after',
};
}
function normalizeTarget(target) {
const classes = Array.isArray(target.classes)
? target.classes.join(' ')
: String(target.classes || '').trim();
const text = typeof target.textContent === 'string'
? target.textContent.trim().slice(0, 80)
: '';
return {
elementId: target.id || target.elementId || undefined,
classes: classes || undefined,
tag: target.tagName || target.tag || undefined,
text: text || undefined,
};
}
function compactError(error) {
const stderr = error?.stderr ? String(error.stderr).trim() : '';
const message = stderr.split('\n').filter(Boolean).pop() || error?.message || 'preflight failed';
return String(message).slice(0, 500);
}
plugin/skills/impeccable/scripts/live/generation-publisher.mjs
-617
View File
@@ -1,617 +0,0 @@
import fs from 'node:fs';
import path from 'node:path';
import { createHash } from 'node:crypto';
import { createLiveSessionStore } from './session-store.mjs';
import { withSourceLockSync } from './source-lock.mjs';
import { getLiveDir } from '../lib/impeccable-paths.mjs';
import {
SOURCE_ARTIFACT_PREVIEW_MODE,
findSourceArtifactManifest,
} from './source-artifact.mjs';
export function sha256(value) {
return createHash('sha256').update(value).digest('hex');
}
export function reconcilePublishedSourceVariants({ current, candidate, priorArrived = 0 } = {}) {
let reconciled = String(candidate || '');
const stable = String(current || '');
for (let variant = 1; variant <= Number(priorArrived || 0); variant += 1) {
const stableBlock = extractVariantBlock(stable, variant);
const candidateBlock = extractVariantBlock(reconciled, variant);
if (!stableBlock || !candidateBlock) {
return failure('published_variant_missing', { variant });
}
const offset = reconciled.indexOf(candidateBlock);
reconciled = reconciled.slice(0, offset) + stableBlock + reconciled.slice(offset + candidateBlock.length);
}
return { ok: true, content: reconciled };
}
export function prepareGenerationArtifact({ id, sourceFile, cwd = process.cwd() } = {}) {
if (!id) return failure('missing_session_id');
if (!sourceFile) return failure('missing_file');
const requestedPath = resolveInside(cwd, sourceFile);
if (!requestedPath || !fs.existsSync(requestedPath)) return failure(requestedPath ? 'source_missing' : 'path_outside_project');
const componentTarget = readComponentPublicationTarget(requestedPath, cwd, id);
if (componentTarget?.error) return componentTarget;
const sourceArtifactTarget = componentTarget ? null : readSourceArtifactPublicationTarget(requestedPath, cwd, id);
if (sourceArtifactTarget?.error) return sourceArtifactTarget;
const sourcePath = componentTarget?.sourcePath || sourceArtifactTarget?.sourcePath || requestedPath;
try {
return withSourceLockSync(sourcePath, 'generation-prepare:' + id, () => {
const store = createLiveSessionStore({ cwd, sessionId: id });
const snapshot = store.getSnapshot(id, { includeCompleted: true });
if (!snapshot?.updatedAt) return failure('session_missing');
if (snapshot.generationCanceled === true) {
return failure('stale_generation_epoch', { canceled: true, phase: snapshot.phase });
}
const source = fs.readFileSync(sourcePath, 'utf-8');
const artifactBase = sourceArtifactTarget
? fs.readFileSync(sourceArtifactTarget.previewPath, 'utf-8')
: source;
const revision = Number(snapshot.publishedRevision || 0) + 1;
const artifactDir = path.join(getLiveDir(cwd), 'artifacts');
if (componentTarget) {
return prepareComponentArtifact({
id,
revision,
snapshot,
source,
sourcePath,
requestedPath,
target: componentTarget,
artifactDir,
cwd,
});
}
const extension = path.extname(sourcePath) || '.html';
const artifactPath = path.join(artifactDir, id + '-r' + revision + extension);
fs.mkdirSync(artifactDir, { recursive: true });
fs.writeFileSync(artifactPath, artifactBase, 'utf-8');
return {
ok: true,
id,
epoch: Number(snapshot.generationEpoch || 1),
revision,
sourceFile: relative(cwd, sourcePath),
...(sourceArtifactTarget ? {
previewFile: relative(cwd, sourceArtifactTarget.previewPath),
previewMode: SOURCE_ARTIFACT_PREVIEW_MODE,
} : {}),
artifactFile: relative(cwd, artifactPath),
expectedSourceHash: sha256(source),
};
}, { cwd });
} catch (error) {
if (error?.code === 'SOURCE_LOCKED') return failure('source_locked');
return failure('prepare_failed', { message: error?.message || String(error) });
}
}
export function publishGenerationArtifact({
id,
epoch,
sourceFile,
artifactFile,
expectedSourceHash,
arrivedVariants,
expectedVariants,
publicationKind,
cwd = process.cwd(),
} = {}) {
if (!id) return failure('missing_session_id');
if (!Number.isInteger(epoch) || epoch < 1) return failure('invalid_generation_epoch');
if (!sourceFile || !artifactFile) return failure('missing_file');
if (publicationKind && !['variants', 'params'].includes(publicationKind)) {
return failure('invalid_publication_kind');
}
const requestedPath = resolveInside(cwd, sourceFile);
const artifactPath = resolveInside(cwd, artifactFile);
if (!requestedPath || !artifactPath) return failure('path_outside_project');
if (!fs.existsSync(requestedPath)) return failure('source_missing');
if (!fs.existsSync(artifactPath)) return failure('artifact_missing');
const componentTarget = readComponentPublicationTarget(requestedPath, cwd, id);
if (componentTarget?.error) return componentTarget;
const sourceArtifactTarget = componentTarget ? null : readSourceArtifactPublicationTarget(requestedPath, cwd, id);
if (sourceArtifactTarget?.error) return sourceArtifactTarget;
const artifactManifest = readJson(artifactPath);
const isComponentArtifact = isComponentPreviewMode(artifactManifest?.previewMode);
if (Boolean(componentTarget) !== isComponentArtifact) {
return failure('artifact_preview_mode_mismatch');
}
if (componentTarget && componentTarget.manifest.previewMode !== artifactManifest?.previewMode) {
return failure('artifact_preview_mode_mismatch');
}
const sourcePath = componentTarget?.sourcePath || sourceArtifactTarget?.sourcePath || requestedPath;
try {
return withSourceLockSync(sourcePath, 'generation:' + id + ':' + epoch, () => {
const store = createLiveSessionStore({ cwd, sessionId: id });
const snapshot = store.getSnapshot(id, { includeCompleted: true });
if (!snapshot?.updatedAt) return failure('session_missing');
if (snapshot.generationCanceled === true) {
return failure('stale_generation_epoch', { canceled: true, phase: snapshot.phase });
}
if (Number(snapshot.generationEpoch || 1) !== epoch) {
return failure('stale_generation_epoch', { expectedEpoch: snapshot.generationEpoch || 1 });
}
const current = fs.readFileSync(sourcePath, 'utf-8');
const currentHash = sha256(current);
if (!expectedSourceHash || currentHash !== expectedSourceHash) {
return failure('source_hash_mismatch', { actualSourceHash: currentHash });
}
if (componentTarget) {
return publishComponentArtifact({
id,
epoch,
snapshot,
target: componentTarget,
artifactManifest,
artifactPath,
sourcePath,
arrivedVariants,
expectedVariants,
publicationKind,
store,
cwd,
});
}
const stablePreview = sourceArtifactTarget
? fs.readFileSync(sourceArtifactTarget.previewPath, 'utf-8')
: current;
const artifact = fs.readFileSync(artifactPath, 'utf-8');
if (!artifact.includes('data-impeccable-variants="' + id + '"')) {
return failure('artifact_missing_session_wrapper');
}
const delivered = countDeliveredVariants(artifact);
if (delivered < 1) return failure('artifact_has_no_variants');
if (Number.isInteger(arrivedVariants) && delivered < arrivedVariants) {
return failure('artifact_variant_count_mismatch', { delivered });
}
const priorArrived = Math.max(0, Number(snapshot.arrivedVariants || 0));
for (let variant = 1; variant <= priorArrived; variant++) {
const currentVariant = extractVariantBlock(stablePreview, variant);
const artifactVariant = extractVariantBlock(artifact, variant);
if (!currentVariant || !artifactVariant) {
return failure('published_variant_missing', { variant });
}
if (sha256(withoutVariantParams(currentVariant)) !== sha256(withoutVariantParams(artifactVariant))) {
return failure('published_variant_changed', { variant });
}
}
const currentPreviewCss = extractPreviewCss(stablePreview, id);
const artifactPreviewCss = extractPreviewCss(artifact, id);
if (priorArrived > 0 && currentPreviewCss && !artifactPreviewCss.startsWith(currentPreviewCss)) {
return failure('published_variant_css_changed');
}
const commitSnapshot = store.getSnapshot(id, { includeCompleted: true });
if (commitSnapshot?.generationCanceled === true) {
return failure('stale_generation_epoch', { canceled: true, phase: commitSnapshot.phase });
}
if (Number(commitSnapshot?.generationEpoch || 1) !== epoch) {
return failure('stale_generation_epoch', { expectedEpoch: commitSnapshot?.generationEpoch || 1 });
}
const artifactHash = sha256(artifact);
const publishPath = sourceArtifactTarget?.previewPath || sourcePath;
atomicReplace(publishPath, artifact);
const revision = Number(commitSnapshot.publishedRevision || 0) + 1;
store.appendEvent({
type: 'variant_published',
id,
generationEpoch: epoch,
revision,
digest: artifactHash,
sourceFile: relative(cwd, sourcePath),
...(sourceArtifactTarget ? {
previewFile: relative(cwd, publishPath),
previewMode: SOURCE_ARTIFACT_PREVIEW_MODE,
} : {}),
arrivedVariants: delivered,
expectedVariants: Number(expectedVariants || snapshot.expectedVariants || delivered),
publicationKind: publicationKind || 'variants',
at: Date.now(),
});
return {
ok: true,
id,
epoch,
revision,
digest: artifactHash,
sourceFile: relative(cwd, sourcePath),
...(sourceArtifactTarget ? {
previewFile: relative(cwd, publishPath),
previewMode: SOURCE_ARTIFACT_PREVIEW_MODE,
} : {}),
arrivedVariants: delivered,
expectedVariants: Number(expectedVariants || snapshot.expectedVariants || delivered),
publicationKind: publicationKind || 'variants',
};
}, { cwd });
} catch (error) {
if (error?.code === 'SOURCE_LOCKED') return failure('source_locked');
return failure('publish_failed', { message: error?.message || String(error) });
}
}
function prepareComponentArtifact({
id,
revision,
snapshot,
source,
sourcePath,
requestedPath,
target,
artifactDir,
cwd,
}) {
const artifactComponentDir = path.join(
artifactDir,
id + '-r' + revision + '-' + target.manifest.previewMode + '-' + process.pid + '-' + Date.now(),
);
fs.mkdirSync(artifactComponentDir, { recursive: true });
copyDirectoryFiles(target.componentPath, artifactComponentDir);
const artifactPath = path.join(artifactComponentDir, 'manifest.json');
const artifactManifest = {
...target.manifest,
componentDir: relative(cwd, artifactComponentDir),
};
fs.writeFileSync(artifactPath, JSON.stringify(artifactManifest, null, 2) + '\n', 'utf-8');
return {
ok: true,
id,
epoch: Number(snapshot.generationEpoch || 1),
revision,
sourceFile: relative(cwd, requestedPath),
targetSourceFile: relative(cwd, sourcePath),
artifactFile: relative(cwd, artifactPath),
componentDir: relative(cwd, artifactComponentDir),
previewMode: target.manifest.previewMode,
expectedSourceHash: sha256(source),
};
}
function publishComponentArtifact({
id,
epoch,
snapshot,
target,
artifactManifest,
artifactPath,
sourcePath,
arrivedVariants,
expectedVariants,
publicationKind,
store,
cwd,
}) {
if (!artifactManifest || typeof artifactManifest !== 'object') {
return failure('artifact_manifest_invalid');
}
if (artifactManifest.id !== id || target.manifest.id !== id) {
return failure('artifact_session_mismatch');
}
const artifactComponentPath = resolveInside(cwd, artifactManifest.componentDir);
if (!artifactComponentPath || path.resolve(artifactComponentPath) !== path.dirname(artifactPath)) {
return failure('artifact_component_dir_mismatch');
}
if (!isDescendant(path.join(getLiveDir(cwd), 'artifacts'), artifactComponentPath)) {
return failure('artifact_not_staged');
}
const immutableMismatch = componentManifestMismatch(target.manifest, artifactManifest);
if (immutableMismatch) {
return failure('artifact_manifest_changed', { field: immutableMismatch });
}
const expected = Number(expectedVariants || target.manifest.count || snapshot.expectedVariants || 0);
const declared = optionalPositiveInteger(artifactManifest.arrivedVariants);
const delivered = Number.isInteger(arrivedVariants) ? arrivedVariants : declared;
if (!Number.isInteger(delivered) || delivered < 1) return failure('artifact_has_no_variants');
if (expected > 0 && delivered > expected) {
return failure('artifact_variant_count_mismatch', { delivered, expected });
}
if (declared !== null && declared !== delivered) {
return failure('artifact_variant_count_mismatch', { delivered: declared, expected: delivered });
}
const priorArrived = Math.max(
optionalPositiveInteger(target.manifest.arrivedVariants) || 0,
Number(snapshot.arrivedVariants || 0),
);
if (delivered < priorArrived) {
return failure('artifact_variant_count_regressed', { delivered, priorArrived });
}
const componentExtension = target.manifest.componentExtension
|| (target.manifest.previewMode === 'vue-component' ? 'vue' : 'svelte');
const variantContents = [];
for (let variant = 1; variant <= delivered; variant++) {
const artifactVariantPath = path.join(artifactComponentPath, 'v' + variant + '.' + componentExtension);
if (!regularFileInside(artifactComponentPath, artifactVariantPath)) {
return failure('artifact_variant_missing', { variant });
}
const content = fs.readFileSync(artifactVariantPath, 'utf-8');
if (!content.trim()) return failure('artifact_variant_empty', { variant });
const targetVariantPath = path.join(target.componentPath, 'v' + variant + '.' + componentExtension);
if (variant <= priorArrived && !regularFileInside(target.componentPath, targetVariantPath)) {
return failure('published_variant_missing', { variant });
}
if (variant <= priorArrived) {
const prior = fs.readFileSync(targetVariantPath, 'utf-8');
if (sha256(prior) !== sha256(content)) {
return failure('published_variant_changed', { variant });
}
}
variantContents.push({ variant, content, targetPath: targetVariantPath });
}
const artifactParamsPath = path.join(artifactComponentPath, 'params.json');
let paramsContent = null;
if (fs.existsSync(artifactParamsPath)) {
if (!regularFileInside(artifactComponentPath, artifactParamsPath)) {
return failure('artifact_params_invalid');
}
paramsContent = fs.readFileSync(artifactParamsPath, 'utf-8');
const params = parseJson(paramsContent);
if (!params || typeof params !== 'object' || Array.isArray(params)) {
return failure('artifact_params_invalid');
}
}
// Components and optional params become reachable before the manifest
// advertises them. Committing the manifest last makes publication atomic
// from the browser's point of view while the source lock excludes Accept.
fs.mkdirSync(target.componentPath, { recursive: true });
for (const variant of variantContents) {
if (variant.variant > priorArrived) atomicReplace(variant.targetPath, variant.content);
}
if (paramsContent !== null) {
atomicReplace(path.join(target.componentPath, 'params.json'), paramsContent);
}
const commitSnapshot = store.getSnapshot(id, { includeCompleted: true });
if (commitSnapshot?.generationCanceled === true) {
return failure('stale_generation_epoch', { canceled: true, phase: commitSnapshot.phase });
}
if (Number(commitSnapshot?.generationEpoch || 1) !== epoch) {
return failure('stale_generation_epoch', { expectedEpoch: commitSnapshot?.generationEpoch || 1 });
}
const publishedManifest = {
...target.manifest,
componentDir: relative(cwd, target.componentPath),
arrivedVariants: delivered,
};
delete publishedManifest.manifestPath;
const manifestContent = JSON.stringify(publishedManifest, null, 2) + '\n';
atomicReplace(target.manifestPath, manifestContent);
const digest = digestComponentPublication(manifestContent, variantContents, paramsContent);
const revision = Number(snapshot.publishedRevision || 0) + 1;
const sourceFile = relative(cwd, sourcePath);
const previewFile = relative(cwd, target.manifestPath);
store.appendEvent({
type: 'variant_published',
id,
generationEpoch: epoch,
revision,
digest,
sourceFile,
previewFile,
previewMode: target.manifest.previewMode,
arrivedVariants: delivered,
expectedVariants: expected || delivered,
publicationKind: publicationKind || 'variants',
at: Date.now(),
});
return {
ok: true,
id,
epoch,
revision,
digest,
sourceFile,
previewFile,
previewMode: target.manifest.previewMode,
componentDir: relative(cwd, target.componentPath),
arrivedVariants: delivered,
expectedVariants: expected || delivered,
publicationKind: publicationKind || 'variants',
};
}
const COMPONENT_MANIFEST_FIELDS = [
'id',
'mode',
'previewMode',
'sourceFile',
'sourceStartLine',
'sourceEndLine',
'insertLine',
'position',
'anchorStartLine',
'anchorEndLine',
'count',
'propContract',
'originalMarkup',
'anchorMarkup',
'runtimeModule',
'componentModuleBase',
'framework',
'componentExtension',
];
function readComponentPublicationTarget(manifestPath, cwd, id) {
if (path.basename(manifestPath) !== 'manifest.json') return null;
const manifest = readJson(manifestPath);
if (!manifest || !isComponentPreviewMode(manifest.previewMode)) return null;
if (manifest.id !== id) return failure('artifact_session_mismatch');
const sourcePath = resolveInside(cwd, manifest.sourceFile);
const componentPath = resolveInside(cwd, manifest.componentDir);
if (!sourcePath || !componentPath) return failure('path_outside_project');
if (!fs.existsSync(sourcePath)) return failure('source_missing');
if (path.resolve(componentPath) !== path.dirname(manifestPath)) {
return failure('manifest_component_dir_mismatch');
}
return { manifest, manifestPath, sourcePath, componentPath };
}
function readSourceArtifactPublicationTarget(requestedPath, cwd, id) {
const manifest = findSourceArtifactManifest(id, cwd);
if (!manifest) return null;
if (path.resolve(requestedPath) !== path.resolve(manifest.previewPath)) {
return failure('source_artifact_preview_mismatch');
}
return manifest;
}
function componentManifestMismatch(target, artifact) {
for (const field of COMPONENT_MANIFEST_FIELDS) {
if (JSON.stringify(target[field] ?? null) !== JSON.stringify(artifact[field] ?? null)) return field;
}
return null;
}
function isComponentPreviewMode(value) {
return value === 'svelte-component' || value === 'vue-component';
}
function copyDirectoryFiles(sourceDir, targetDir) {
for (const entry of fs.readdirSync(sourceDir, { withFileTypes: true })) {
if (!entry.isFile() || entry.isSymbolicLink()) continue;
fs.copyFileSync(path.join(sourceDir, entry.name), path.join(targetDir, entry.name));
}
}
function regularFileInside(root, file) {
const rel = path.relative(root, file);
if (!rel || rel.startsWith('..') || path.isAbsolute(rel)) return false;
try {
return fs.lstatSync(file).isFile();
} catch {
return false;
}
}
function isDescendant(root, candidate) {
const rel = path.relative(root, candidate);
return Boolean(rel) && !rel.startsWith('..') && !path.isAbsolute(rel);
}
function digestComponentPublication(manifestContent, variants, paramsContent) {
const hash = createHash('sha256');
hash.update(manifestContent);
for (const variant of variants) {
hash.update('\0v' + variant.variant + '\0');
hash.update(variant.content);
}
if (paramsContent !== null) hash.update('\0params\0' + paramsContent);
return hash.digest('hex');
}
function readJson(file) {
try {
return JSON.parse(fs.readFileSync(file, 'utf-8'));
} catch {
return null;
}
}
function parseJson(value) {
try {
return JSON.parse(value);
} catch {
return null;
}
}
function optionalPositiveInteger(value) {
const number = Number(value);
return Number.isInteger(number) && number > 0 ? number : null;
}
function countDeliveredVariants(source) {
const matches = source.match(/<div\b[^>]*\bdata-impeccable-variant=(?:"|')(?!original(?:"|'))[^"']+(?:"|')[^>]*>/g);
return matches?.length || 0;
}
function extractVariantBlock(source, variant) {
const open = /<div\b[^>]*>/gi;
let match;
let start = -1;
const attr = new RegExp("\\bdata-impeccable-variant=(?:\"" + variant + "\"|'" + variant + "')");
while ((match = open.exec(source))) {
if (attr.test(match[0])) {
start = match.index;
break;
}
}
if (start < 0) return null;
const token = /<div\b[^>]*\/\s*>|<div\b[^>]*>|<\/div\s*>/gi;
token.lastIndex = start;
let depth = 0;
while ((match = token.exec(source))) {
if (/^<\/div/i.test(match[0])) {
depth -= 1;
if (depth === 0) return source.slice(start, token.lastIndex);
} else if (!/\/\s*>$/.test(match[0])) {
depth += 1;
}
}
return null;
}
function withoutVariantParams(block) {
return String(block || '').replace(
/\sdata-impeccable-params=(?:"[^"]*"|'[^']*')/i,
'',
);
}
function extractPreviewCss(source, id) {
const escapedId = String(id).replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
const open = new RegExp("<style\\b[^>]*\\bdata-impeccable-css=(?:\"" + escapedId + "\"|'" + escapedId + "')[^>]*>", 'i');
const match = open.exec(source);
if (!match) return '';
const start = match.index + match[0].length;
const end = source.indexOf('</style>', start);
if (end < 0) return '';
return source.slice(start, end)
.replace(/^\s*\{\s*`\s*/, '')
.replace(/\s*`\s*\}\s*$/, '')
.trim();
}
function atomicReplace(target, content) {
let mode = 0o666;
try { mode = fs.statSync(target).mode; } catch {}
const temp = target + '.impeccable-publish-' + process.pid + '-' + Date.now();
try {
fs.writeFileSync(temp, content, { encoding: 'utf-8', mode });
fs.renameSync(temp, target);
} finally {
try { fs.unlinkSync(temp); } catch {}
}
}
function resolveInside(cwd, value) {
const resolved = path.resolve(cwd, value);
const rel = path.relative(cwd, resolved);
if (rel.startsWith('..') || path.isAbsolute(rel)) return null;
return resolved;
}
function relative(cwd, value) {
return path.relative(cwd, value).split(path.sep).join('/');
}
function failure(error, details = {}) {
return { ok: false, error, ...details };
}
plugin/skills/impeccable/scripts/live/poll-lanes.mjs
-14
View File
@@ -1,14 +0,0 @@
export function eventPriority(event = {}) {
if (event.type === 'accept' || event.type === 'discard' || event.type === 'exit') return 0;
if (event.type === 'manual_edit_apply' || event.type === 'steer' || event.type === 'carbonize_cleanup') return 1;
if (event.type === 'generate') return 2;
return 3;
}
export function selectAvailablePendingEvent(entries, { now = Date.now(), types = null } = {}) {
const allowed = types instanceof Set ? types : (Array.isArray(types) ? new Set(types) : null);
return entries
.filter((entry) => !(entry.leaseUntil && entry.leaseUntil > now))
.filter((entry) => !allowed || allowed.has(entry.event?.type))
.sort((a, b) => eventPriority(a.event) - eventPriority(b.event) || a.seq - b.seq)[0] || null;
}
plugin/skills/impeccable/scripts/live/session-store.mjs
+14 -137
View File
@@ -3,13 +3,6 @@ import path from 'node:path';
import { getLegacyLiveSessionsDir, getLiveSessionsDir } from '../lib/impeccable-paths.mjs';
const COMPLETED_PHASES = new Set(['completed', 'discarded']);
const GENERATION_FENCED_PHASES = new Set([
'accept_requested',
'discard_requested',
'carbonize_required',
'completed',
'discarded',
]);
export function createLiveSessionStore({ cwd = process.cwd(), sessionId } = {}) {
const rootDir = getLiveSessionsDir(cwd);
@@ -45,10 +38,7 @@ export function createLiveSessionStore({ cwd = process.cwd(), sessionId } = {})
if (!fs.existsSync(journalPath) && fs.existsSync(legacyJournalPath)) {
fs.copyFileSync(legacyJournalPath, journalPath);
}
// Publisher/complete helpers can append from a separate process while
// the server is alive. Rebuild here so sequence numbers and phase
// fences never come from a stale in-memory cache.
const prior = rebuildSnapshotFromJournal(getReadableJournalPath(normalized.id), normalized.id);
const prior = loadCachedOrRebuild(normalized.id);
const seq = prior.nextSeq;
const entry = {
seq,
@@ -126,21 +116,9 @@ function baseSnapshot(id) {
pendingEvent: null,
deliveryLease: null,
checkpointRevision: 0,
browserCheckpointRevision: 0,
publicationCheckpointRevision: 0,
activeOwner: null,
sourceMarkers: {},
fallbackMode: null,
generationPhase: null,
generationTimings: {},
generationEpoch: 1,
publishedRevision: 0,
deliveredVariants: {},
variantPlan: null,
paramsPublished: false,
generationCanceled: false,
generationCanceledAt: null,
cancelReason: null,
annotationArtifacts: [],
diagnostics: [],
updatedAt: null,
@@ -180,9 +158,6 @@ function applyEvent(snapshot, entry, inheritedDiagnostics = []) {
...snapshot,
paramValues: { ...(snapshot.paramValues || {}) },
sourceMarkers: { ...(snapshot.sourceMarkers || {}) },
generationTimings: { ...(snapshot.generationTimings || {}) },
deliveredVariants: { ...(snapshot.deliveredVariants || {}) },
variantPlan: snapshot.variantPlan || null,
annotationArtifacts: [...(snapshot.annotationArtifacts || [])],
diagnostics: [...(snapshot.diagnostics || [])],
updatedAt: entry.ts || new Date().toISOString(),
@@ -195,81 +170,14 @@ function applyEvent(snapshot, entry, inheritedDiagnostics = []) {
switch (event.type) {
case 'generate':
next.phase = 'generate_requested';
next.generationEpoch = Number(event.generationEpoch || next.generationEpoch || 1);
next.pageUrl = event.pageUrl ?? next.pageUrl;
next.expectedVariants = event.count ?? next.expectedVariants;
next.pendingEventSeq = entry.seq ?? next.pendingEventSeq;
next.pendingEvent = toPendingEvent(event);
next.variantPlan = null;
if (event.screenshotPath) upsertArtifact(next.annotationArtifacts, { type: 'screenshot', path: event.screenshotPath });
break;
case 'variant_plan':
if (!next.generationCanceled && !GENERATION_FENCED_PHASES.has(next.phase)) {
next.variantPlan = event.plan ?? next.variantPlan;
}
break;
case 'detector_waivers':
if (!next.generationCanceled && !GENERATION_FENCED_PHASES.has(next.phase)) {
next.detectorWaivers = [
...(next.detectorWaivers || []),
...(Array.isArray(event.waivers) ? event.waivers : []),
];
}
break;
case 'variant_published':
if (next.generationCanceled || GENERATION_FENCED_PHASES.has(next.phase)) {
next.diagnostics.push({
error: 'late_generation_event_ignored',
type: event.type,
phase: next.phase,
revision: event.revision ?? null,
});
break;
}
if (Number(event.generationEpoch || 0) !== Number(next.generationEpoch || 1)) {
next.diagnostics.push({
error: 'stale_generation_epoch_ignored',
epoch: event.generationEpoch ?? null,
expectedEpoch: next.generationEpoch || 1,
});
break;
}
next.phase = 'variants_progress';
next.publishedRevision = Math.max(next.publishedRevision || 0, Number(event.revision || 0));
next.arrivedVariants = Math.max(next.arrivedVariants || 0, Number(event.arrivedVariants || 0));
next.expectedVariants = Number(event.expectedVariants || next.expectedVariants || 0);
if (event.publicationKind === 'params') next.paramsPublished = true;
next.sourceFile = event.sourceFile ?? next.sourceFile;
next.previewFile = event.previewFile ?? next.previewFile;
next.previewMode = event.previewMode ?? next.previewMode;
if (event.revision) {
next.deliveredVariants[String(event.revision)] = {
digest: event.digest || null,
arrivedVariants: Number(event.arrivedVariants || 0),
publishedAt: event.at || null,
};
}
break;
case 'agent_phase':
next.generationPhase = event.phase ?? next.generationPhase;
if (event.phase) {
next.generationTimings[event.phase] = {
at: event.at ?? (Date.parse(entry.ts || '') || null),
durationMs: event.durationMs ?? null,
};
}
break;
case 'variants_ready':
case 'agent_done':
if ((next.generationCanceled || GENERATION_FENCED_PHASES.has(next.phase))
&& !(event.type === 'agent_done' && event.carbonize === true && next.phase === 'accept_requested')) {
next.diagnostics.push({
error: 'late_generation_event_ignored',
type: event.type,
phase: next.phase,
});
break;
}
next.phase = event.carbonize === true ? 'carbonize_required' : 'variants_ready';
next.sourceFile = event.sourceFile ?? event.file ?? next.sourceFile;
next.previewFile = event.previewFile ?? next.previewFile;
@@ -286,45 +194,27 @@ function applyEvent(snapshot, entry, inheritedDiagnostics = []) {
}
break;
case 'checkpoint':
if (next.generationCanceled || GENERATION_FENCED_PHASES.has(next.phase)) {
if (COMPLETED_PHASES.has(next.phase)) {
next.diagnostics.push({ error: 'checkpoint_after_terminal_ignored', phase: event.phase ?? null, revision: event.revision ?? null });
break;
}
{
const revisionDomain = event.revisionDomain === 'publication'
|| (event.reason === 'variants_progress' && !event.owner)
? 'publication'
: 'browser';
const revisionField = revisionDomain === 'publication'
? 'publicationCheckpointRevision'
: 'browserCheckpointRevision';
const currentRevision = next[revisionField]
?? (revisionDomain === 'browser' ? next.checkpointRevision : 0)
?? 0;
if ((event.revision ?? 0) >= currentRevision) {
next.phase = event.phase ?? next.phase;
next[revisionField] = event.revision ?? currentRevision;
if (revisionDomain === 'browser') {
next.checkpointRevision = event.revision ?? next.checkpointRevision;
next.activeOwner = event.owner ?? next.activeOwner;
}
next.arrivedVariants = event.arrivedVariants ?? next.arrivedVariants;
if (revisionDomain === 'browser') next.visibleVariant = event.visibleVariant ?? next.visibleVariant;
next.sourceFile = event.sourceFile ?? next.sourceFile;
next.previewFile = event.previewFile ?? next.previewFile;
next.previewMode = event.previewMode ?? next.previewMode;
if (revisionDomain === 'browser' && event.paramValues) next.paramValues = { ...event.paramValues };
} else {
next.diagnostics.push({ error: 'stale_checkpoint_ignored', revision: event.revision, revisionDomain });
}
if ((event.revision ?? 0) >= (next.checkpointRevision ?? 0)) {
next.phase = event.phase ?? next.phase;
next.checkpointRevision = event.revision ?? next.checkpointRevision;
next.activeOwner = event.owner ?? next.activeOwner;
next.arrivedVariants = event.arrivedVariants ?? next.arrivedVariants;
next.visibleVariant = event.visibleVariant ?? next.visibleVariant;
next.sourceFile = event.sourceFile ?? next.sourceFile;
next.previewFile = event.previewFile ?? next.previewFile;
next.previewMode = event.previewMode ?? next.previewMode;
if (event.paramValues) next.paramValues = { ...event.paramValues };
} else {
next.diagnostics.push({ error: 'stale_checkpoint_ignored', revision: event.revision });
}
break;
case 'accept':
case 'accept_intent':
next.phase = 'accept_requested';
next.generationCanceled = true;
next.generationCanceledAt = event.at ?? (Date.parse(entry.ts || '') || Date.now());
next.cancelReason = 'accept';
next.visibleVariant = Number(event.variantId ?? next.visibleVariant);
if (event.paramValues) next.paramValues = { ...event.paramValues };
next.pendingEventSeq = entry.seq ?? next.pendingEventSeq;
@@ -342,12 +232,6 @@ function applyEvent(snapshot, entry, inheritedDiagnostics = []) {
next.pendingEventSeq = entry.seq ?? next.pendingEventSeq;
next.pendingEvent = toPendingEvent(event);
break;
case 'carbonize_cleanup':
next.phase = 'carbonize_cleanup_requested';
next.sourceFile = event.file ?? next.sourceFile;
next.pendingEventSeq = entry.seq ?? next.pendingEventSeq;
next.pendingEvent = toPendingEvent(event);
break;
case 'steer_done':
next.phase = 'steer_done';
next.sourceFile = event.sourceFile ?? event.file ?? next.sourceFile;
@@ -359,9 +243,6 @@ function applyEvent(snapshot, entry, inheritedDiagnostics = []) {
break;
case 'discard':
next.phase = 'discard_requested';
next.generationCanceled = true;
next.generationCanceledAt = event.at ?? (Date.parse(entry.ts || '') || Date.now());
next.cancelReason = 'discard';
next.pendingEventSeq = entry.seq ?? next.pendingEventSeq;
next.pendingEvent = toPendingEvent(event);
break;
@@ -379,10 +260,6 @@ function applyEvent(snapshot, entry, inheritedDiagnostics = []) {
next.pendingEvent = null;
break;
case 'agent_error':
if (next.generationCanceled && event.sourceEventType === 'generate') {
next.diagnostics.push({ error: 'late_generation_event_ignored', type: event.type, phase: next.phase });
break;
}
next.phase = 'agent_error';
next.pendingEventSeq = null;
next.pendingEvent = null;
plugin/skills/impeccable/scripts/live/source-artifact.mjs
-76
View File
@@ -1,76 +0,0 @@
import fs from 'node:fs';
import path from 'node:path';
import { getLiveDir } from '../lib/impeccable-paths.mjs';
export const SOURCE_ARTIFACT_PREVIEW_MODE = 'source-artifact';
export function scaffoldSourceArtifactSession({
id,
count,
sourceFile,
sourceStartLine,
sourceEndLine,
originalSource,
previewContent,
cwd = process.cwd(),
} = {}) {
if (!/^[A-Za-z0-9_-]{1,128}$/.test(String(id || ''))) {
throw new Error('invalid source artifact session id');
}
const sourcePath = resolveInside(cwd, sourceFile);
if (!sourcePath || !fs.existsSync(sourcePath)) throw new Error('source artifact target missing');
const sessionDir = path.join(getLiveDir(cwd), 'previews', id);
const extension = path.extname(sourcePath) || '.html';
const previewPath = path.join(sessionDir, 'preview' + extension);
const manifestPath = path.join(sessionDir, 'manifest.json');
fs.mkdirSync(sessionDir, { recursive: true });
const manifest = {
id,
count: Number(count || 1),
previewMode: SOURCE_ARTIFACT_PREVIEW_MODE,
sourceFile: relative(cwd, sourcePath),
previewFile: relative(cwd, previewPath),
sourceStartLine: Number(sourceStartLine),
sourceEndLine: Number(sourceEndLine),
originalSource: String(originalSource || ''),
};
fs.writeFileSync(previewPath, String(previewContent || ''), 'utf-8');
fs.writeFileSync(manifestPath, JSON.stringify(manifest, null, 2) + '\n', 'utf-8');
return { ...manifest, manifestFile: relative(cwd, manifestPath), sessionDir: relative(cwd, sessionDir) };
}
export function findSourceArtifactManifest(id, cwd = process.cwd()) {
if (!/^[A-Za-z0-9_-]{1,128}$/.test(String(id || ''))) return null;
const manifestPath = path.join(getLiveDir(cwd), 'previews', id, 'manifest.json');
let manifest;
try { manifest = JSON.parse(fs.readFileSync(manifestPath, 'utf-8')); } catch { return null; }
if (manifest?.id !== id || manifest?.previewMode !== SOURCE_ARTIFACT_PREVIEW_MODE) return null;
const sourcePath = resolveInside(cwd, manifest.sourceFile);
const previewPath = resolveInside(cwd, manifest.previewFile);
if (!sourcePath || !previewPath || !fs.existsSync(sourcePath) || !fs.existsSync(previewPath)) return null;
return { ...manifest, manifestPath, sourcePath, previewPath };
}
export function removeSourceArtifactSession(id, cwd = process.cwd()) {
if (!/^[A-Za-z0-9_-]{1,128}$/.test(String(id || ''))) return false;
const sessionDir = path.join(getLiveDir(cwd), 'previews', id);
if (!fs.existsSync(sessionDir)) return false;
fs.rmSync(sessionDir, { recursive: true, force: true });
return true;
}
function resolveInside(cwd, value) {
if (!value || typeof value !== 'string') return null;
const root = path.resolve(cwd);
const resolved = path.resolve(root, value);
const rel = path.relative(root, resolved);
if (!rel || rel.startsWith('..') || path.isAbsolute(rel)) return null;
return resolved;
}
function relative(cwd, value) {
return path.relative(cwd, value).split(path.sep).join('/');
}
plugin/skills/impeccable/scripts/live/source-lock.mjs
-56
View File
@@ -1,56 +0,0 @@
import fs from 'node:fs';
import path from 'node:path';
import { createHash } from 'node:crypto';
import { getLiveDir } from '../lib/impeccable-paths.mjs';
const STALE_LOCK_MS = 60_000;
export function sourceLockPath(file, cwd = process.cwd()) {
const digest = createHash('sha256').update(path.resolve(cwd, file)).digest('hex').slice(0, 24);
return path.join(getLiveDir(cwd), 'locks', digest + '.lock');
}
export function withSourceLockSync(file, owner, fn, {
cwd = process.cwd(),
waitMs = 0,
retryMs = 5,
} = {}) {
const lockPath = sourceLockPath(file, cwd);
fs.mkdirSync(path.dirname(lockPath), { recursive: true });
const deadline = Date.now() + Math.max(0, Number(waitMs) || 0);
let fd;
while (fd === undefined) {
clearStaleLock(lockPath);
try {
fd = fs.openSync(lockPath, 'wx');
fs.writeFileSync(fd, JSON.stringify({ owner, pid: process.pid, at: Date.now(), file: path.resolve(cwd, file) }) + '\n');
} catch (error) {
if (error?.code !== 'EEXIST') throw error;
if (Date.now() >= deadline) {
const locked = new Error('source_locked');
locked.code = 'SOURCE_LOCKED';
locked.lockPath = lockPath;
throw locked;
}
sleepSync(Math.max(1, Math.min(Number(retryMs) || 5, deadline - Date.now())));
}
}
try {
return fn();
} finally {
try { if (fd !== undefined) fs.closeSync(fd); } catch {}
try { fs.unlinkSync(lockPath); } catch {}
}
}
function sleepSync(ms) {
Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, ms);
}
function clearStaleLock(lockPath) {
try {
const stat = fs.statSync(lockPath);
if (Date.now() - stat.mtimeMs > STALE_LOCK_MS) fs.unlinkSync(lockPath);
} catch {}
}
plugin/skills/impeccable/scripts/live/vue-component.mjs
-343
View File
@@ -1,343 +0,0 @@
/**
* Nuxt/Vue live-mode component previews.
*
* Generation writes real Vue SFCs into a generated app-local module tree.
* Nuxt/Vite compiles those modules without touching the active route; Accept
* is the only operation that writes the user's .vue source.
*/
import fs from 'node:fs';
import path from 'node:path';
const NUXT_CONFIG_RE = /^nuxt\.config\.(?:js|mjs|cjs|ts|mts|cts)$/;
export function detectNuxtVueProject(cwd = process.cwd()) {
const configFile = fs.readdirSync(cwd, { withFileTypes: true })
.find((entry) => entry.isFile() && NUXT_CONFIG_RE.test(entry.name))?.name;
if (!configFile) return null;
const config = fs.readFileSync(path.join(cwd, configFile), 'utf-8');
const srcDirMatch = config.match(/\bsrcDir\s*:\s*(['"])([^'"]+)\1/);
let appDir = fs.existsSync(path.join(cwd, 'app')) ? 'app' : '';
if (srcDirMatch) {
const candidate = path.posix.normalize(srcDirMatch[2].replace(/\\/g, '/').replace(/^\.\//, '').replace(/\/+$/, ''));
if (candidate !== '..' && !candidate.startsWith('../') && !path.isAbsolute(candidate)) {
appDir = candidate === '.' ? '' : candidate;
}
}
const componentRoot = [appDir, '.impeccable-live'].filter(Boolean).join('/');
return { configFile, appDir, componentRoot };
}
export function shouldUseVueComponentInjection(filePath, cwd = process.cwd()) {
if (/^(0|false|no)$/i.test(process.env.IMPECCABLE_LIVE_VUE_COMPONENT || '')) return false;
return path.extname(filePath).toLowerCase() === '.vue' && !!detectNuxtVueProject(cwd);
}
export function vueComponentSessionDir(id, cwd = process.cwd()) {
const project = detectNuxtVueProject(cwd);
if (!project) throw new Error('Nuxt project not found');
return path.join(cwd, project.componentRoot, id);
}
export function vueManifestPathForSession(id, cwd = process.cwd()) {
return path.join(vueComponentSessionDir(id, cwd), 'manifest.json');
}
function ensureVueRuntime(cwd = process.cwd()) {
const project = detectNuxtVueProject(cwd);
if (!project) throw new Error('Nuxt project not found');
const rel = `${project.componentRoot}/__runtime.js`;
const file = path.join(cwd, rel);
fs.mkdirSync(path.dirname(file), { recursive: true });
const source = `import { createApp } from 'vue';\n\nexport function mount(Component, options = {}) {\n const app = createApp(Component, options.props || {});\n app.mount(options.target);\n return app;\n}\n\nexport async function unmount(app) {\n app?.unmount?.();\n}\n`;
if (!fs.existsSync(file) || fs.readFileSync(file, 'utf-8') !== source) fs.writeFileSync(file, source, 'utf-8');
return nuxtViteFsModulePath(file, cwd);
}
/**
* Nuxt mounts Vite beneath its build-assets base (normally `/_nuxt/`).
* Keep the manifest path base-agnostic and let the browser prepend the
* runtime's actual buildAssetsDir. A page-route URL such as
* `/app/.impeccable-live/x.vue` is handled by Nitro and returns HTML.
*/
export function nuxtViteFsModulePath(file, cwd = process.cwd()) {
const absolute = path.resolve(cwd, file).split(path.sep).join('/');
const relative = path.relative(cwd, absolute);
if (relative.startsWith('..') || path.isAbsolute(relative)) {
throw new Error('Nuxt live module must stay inside the project root');
}
return '/@fs/' + absolute.replace(/^\/+/, '');
}
export function extractVueExpressions(markup) {
const out = [];
const seen = new Set();
const re = /\{\{\s*([^{}]+?)\s*\}\}/g;
let match;
while ((match = re.exec(String(markup || '')))) {
const expr = match[1].trim();
if (!expr || seen.has(expr)) continue;
seen.add(expr);
out.push({ expr, token: match[0] });
}
return out;
}
function buildVuePropContract(expressions) {
return expressions.map(({ expr, token }, index) => ({
prop: derivePropName(expr, index),
expr,
placeholder: token,
// DOMParser sees Vue interpolation `{{ user.name }}` as text containing
// the inner `{ user.name }` token; preserve its whitespace for the
// browser's source-text → rendered-text map.
previewToken: token.slice(1, -1),
}));
}
function derivePropName(expr, index) {
const tail = expr.match(/(?:^|\.|\[)([A-Za-z_$][\w$]*)\s*\]?$/);
return tail?.[1] || `prop${index}`;
}
function substituteVueExpressions(markup, contract) {
let out = String(markup || '');
for (const entry of contract) out = out.split(entry.placeholder).join(`{{ ${entry.prop} }}`);
return out;
}
function buildVueVariantStub(variant, markup, contract) {
const props = contract.length > 0
? `<script setup>\ndefineProps({\n${contract.map((entry) => ` ${entry.prop}: { default: '' },`).join('\n')}\n});\n</script>\n\n`
: '';
return `${props}<template>\n${markup.trim()}\n</template>\n\n<style scoped>\n/* Variant ${variant}: add scoped CSS here */\n</style>\n`;
}
export function scaffoldVueComponentSession({
id,
count,
sourceFile,
sourceStartLine,
sourceEndLine,
originalLines,
cwd = process.cwd(),
}) {
const runtimeModule = ensureVueRuntime(cwd);
const dir = vueComponentSessionDir(id, cwd);
fs.mkdirSync(dir, { recursive: true });
const originalMarkup = originalLines.join('\n');
const propContract = buildVuePropContract(extractVueExpressions(originalMarkup));
const previewMarkup = substituteVueExpressions(originalMarkup, propContract);
const manifest = {
id,
previewMode: 'vue-component',
framework: 'vue',
componentExtension: 'vue',
sourceFile: sourceFile.split(path.sep).join('/'),
sourceStartLine,
sourceEndLine,
count,
propContract,
originalMarkup,
componentDir: path.relative(cwd, dir).split(path.sep).join('/'),
componentModuleBase: nuxtViteFsModulePath(dir, cwd),
runtimeModule,
};
fs.writeFileSync(path.join(dir, 'manifest.json'), JSON.stringify(manifest, null, 2) + '\n', 'utf-8');
for (let variant = 1; variant <= count; variant++) {
const file = path.join(dir, `v${variant}.vue`);
if (!fs.existsSync(file)) fs.writeFileSync(file, buildVueVariantStub(variant, previewMarkup, propContract), 'utf-8');
}
return {
manifest,
manifestFile: path.relative(cwd, path.join(dir, 'manifest.json')).split(path.sep).join('/'),
componentDir: manifest.componentDir,
propContract,
};
}
export function findVueComponentManifest(id, cwd = process.cwd()) {
let direct;
try { direct = vueManifestPathForSession(id, cwd); } catch { return null; }
if (!fs.existsSync(direct)) return null;
try {
const manifest = JSON.parse(fs.readFileSync(direct, 'utf-8'));
return manifest?.id === id && manifest?.previewMode === 'vue-component'
? { ...manifest, manifestPath: direct }
: null;
} catch {
return null;
}
}
function parseVueSfc(source) {
const text = String(source || '');
const template = text.match(/<template\b[^>]*>([\s\S]*?)<\/template\s*>/i)?.[1]?.trim() || '';
const style = text.match(/<style\b[^>]*>([\s\S]*?)<\/style\s*>/i)?.[1]?.trim() || '';
return { template, cssLines: style ? style.split('\n').map((line) => line.trimEnd()) : [] };
}
function restoreVueExpressions(markup, contract) {
let out = String(markup || '');
for (const entry of contract || []) {
out = out.replace(new RegExp(`\\{\\{\\s*${escapeRegExp(entry.prop)}\\s*\\}\\}`, 'g'), entry.placeholder);
}
return out;
}
export function inlineVueComponentAccept(manifest, variantNum, cwd = process.cwd()) {
const sourcePath = resolveInside(cwd, manifest.sourceFile);
const componentDir = resolveInside(cwd, manifest.componentDir);
const variantPath = componentDir && path.join(componentDir, `v${variantNum}.vue`);
const resultBase = {
file: manifest.sourceFile,
sourceFile: manifest.sourceFile,
previewMode: 'vue-component',
componentDir: manifest.componentDir,
carbonize: false,
};
if (!sourcePath || !componentDir || !variantPath || !fs.existsSync(sourcePath) || !fs.existsSync(variantPath)) {
return { handled: false, error: `Variant ${variantNum} not found`, ...resultBase };
}
const { template, cssLines } = parseVueSfc(fs.readFileSync(variantPath, 'utf-8'));
if (!template) return { handled: false, error: 'Accepted Vue variant has no template', ...resultBase };
if (/\bdata-impeccable-[\w-]*\s*=/.test(template)) {
return { handled: false, error: 'Accepted Vue variant contains preview-only attributes', ...resultBase };
}
const sourceLines = fs.readFileSync(sourcePath, 'utf-8').split('\n');
const start = Number(manifest.sourceStartLine) - 1;
const end = Number(manifest.sourceEndLine) - 1;
if (!Number.isInteger(start) || !Number.isInteger(end) || start < 0 || end < start || end >= sourceLines.length) {
return { handled: false, error: 'Invalid source line range for ' + manifest.sourceFile, ...resultBase };
}
const indent = sourceLines[start].match(/^(\s*)/)?.[1] || '';
const mergedTemplate = mergeOriginalVueAttrs(template, manifest.originalMarkup || '');
const markupLines = restoreVueExpressions(mergedTemplate, manifest.propContract)
.split('\n')
.map((line) => line.trim() ? indent + line.trimStart() : '');
let next = [...sourceLines.slice(0, start), ...markupLines, ...sourceLines.slice(end + 1)];
const meaningfulCss = cssLines.filter((line) => line.trim() && !/^\/\*\s*Variant \d+:/.test(line.trim()));
if (meaningfulCss.length > 0) next = appendVueStyle(next, meaningfulCss);
fs.writeFileSync(sourcePath, next.join('\n'), 'utf-8');
retireVueComponentSession(manifest.id, cwd);
return { handled: true, ...resultBase };
}
function appendVueStyle(lines, cssLines) {
let close = -1;
for (let index = lines.length - 1; index >= 0; index--) {
if (/<\/style\s*>/.test(lines[index])) { close = index; break; }
}
const block = ['', ...cssLines.map((line) => line.trim() ? ' ' + line.trimStart() : '')];
if (close < 0) return [...lines, '', '<style scoped>', ...block.slice(1), '</style>'];
return [...lines.slice(0, close), ...block, ...lines.slice(close)];
}
function mergeOriginalVueAttrs(markup, originalMarkup) {
const variant = matchOpeningTag(markup);
const original = matchOpeningTag(originalMarkup);
if (!variant || !original || variant.tag.toLowerCase() !== original.tag.toLowerCase()) return markup;
const variantAttrs = parseStaticAttrs(variant.attrs);
const originalAttrs = parseStaticAttrs(original.attrs);
const additions = [];
let attrs = variant.attrs;
const originalClass = originalAttrs.get('class');
const variantClass = variantAttrs.get('class');
if (originalClass && variantClass) {
const classes = [
...variantClass.value.split(/\s+/),
...originalClass.value.split(/\s+/),
].filter(Boolean);
const replacement = `class=${variantClass.quote}${[...new Set(classes)].join(' ')}${variantClass.quote}`;
attrs = attrs.slice(0, variantClass.start) + replacement + attrs.slice(variantClass.end);
} else if (originalClass) {
additions.push(originalClass.raw);
}
for (const [name, attr] of originalAttrs) {
if (name === 'class' || variantAttrs.has(name)) continue;
additions.push(attr.raw);
}
const open = `<${variant.tag}${attrs}${additions.map((attr) => ' ' + attr.trim()).join('')}${variant.close}`;
return markup.slice(0, variant.index) + open + markup.slice(variant.index + variant.raw.length);
}
function matchOpeningTag(markup) {
const match = String(markup || '').match(/<([A-Za-z][\w:-]*)([^>]*?)(\/?>)/);
return match ? {
raw: match[0],
tag: match[1],
attrs: match[2] || '',
close: match[3],
index: match.index || 0,
} : null;
}
function parseStaticAttrs(attrs) {
const out = new Map();
const re = /([A-Za-z_:][\w:.-]*)\s*=\s*(["'])(.*?)\2/g;
let match;
while ((match = re.exec(attrs))) {
out.set(match[1], {
raw: match[0],
value: match[3],
quote: match[2],
start: match.index,
end: match.index + match[0].length,
});
}
return out;
}
export function removeVueComponentSession(id, cwd = process.cwd()) {
try { fs.rmSync(vueComponentSessionDir(id, cwd), { recursive: true, force: true }); } catch { /* best effort */ }
}
/**
* Make an accepted/discarded session undiscoverable immediately while keeping
* Vue modules that Vite has in its graph alive until Live shuts down. Deleting
* an imported SFC mid-session makes Nuxt's HMR client attempt to reload a
* missing module and emit a console error. The generated directory remains
* ignored and removeAllVueComponentSessions removes it on server shutdown.
*/
export function retireVueComponentSession(id, cwd = process.cwd()) {
let dir;
try { dir = vueComponentSessionDir(id, cwd); } catch { return; }
for (const name of ['manifest.json', 'params.json']) {
try { fs.rmSync(path.join(dir, name), { force: true }); } catch { /* best effort */ }
}
}
export function removeAllVueComponentSessions(cwd = process.cwd()) {
const project = detectNuxtVueProject(cwd);
if (!project) return;
const root = path.join(cwd, project.componentRoot);
if (!fs.existsSync(root)) return;
fs.rmSync(root, { recursive: true, force: true });
}
export function buildVueComponentCssAuthoring(count) {
return {
mode: 'vue-component',
count,
requirements: [
'Write each variant as a real Vue SFC in componentDir/vN.vue.',
'Keep one root element inside <template> and put variant CSS in <style scoped>.',
'Keep propContract bindings as {{ propName }} instead of snapshot text.',
'Do not add data-impeccable-* attributes.',
],
forbidden: ['Rewriting sourceFile during preview', 'data-impeccable-* attributes', 'Off-brand replacement content'],
};
}
function resolveInside(cwd, value) {
if (!value || path.isAbsolute(value)) return null;
const full = path.resolve(cwd, value);
const rel = path.relative(cwd, full);
return !rel || rel.startsWith('..') || path.isAbsolute(rel) ? null : full;
}
function escapeRegExp(value) {
return String(value).replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
}