skills/pbakaus_impeccable
1
0
Fork 0
mirror of https://github.com/pbakaus/impeccable.git synced 2026-09-19 01:26:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix: refuse inert exact ignore-value entries (#662)

Browse Source 
ignore-value stored exact values for rules that cannot extract one, so the entries never matched. Refuse them and point at "*" --file.

AI assistance: implemented with Cursor Grok 4.6.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Abdul Wahab
2026-08-28 05:43:36 +05:00
committed by Abdul Wahab
co-authored by Cursor
parent af2e8b3ac3
commit be87f5eb86
4 changed files with 38 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/hook.test.mjs
+22
View File
@@ -819,6 +819,28 @@ describe('hook-admin.mjs', () => {
assert.equal(fs.existsSync(getConfigPath(cwd)), false, 'a refused ignore must not write config');
});
it('ignore-value refuses exact values for rules that cannot extract one', () => {
assert.throws(
() => runAdmin(['ignore-value', 'cramped-padding', 'padding: 4px 8px']),
/cramped-padding has no extractable ignore value.*ignore-value cramped-padding "\*" --file <glob>/,
);
assert.throws(
() => runAdmin(['ignore-value', 'side-tab', 'Inter', '--file', 'a.css']),
/side-tab has no extractable ignore value.*ignore-value side-tab "\*" --file <glob>/,
);
assert.equal(fs.existsSync(getConfigPath(cwd)), false, 'a refused ignore must not write config');
const out = runAdmin(['ignore-value', 'overused-font', 'Inter']);
assert.match(out, /Added overused-font=inter/);
runAdmin(['ignore-value', 'cramped-padding', '*', '--file', 'index.html']);
const shared = JSON.parse(fs.readFileSync(getConfigPath(cwd), 'utf-8')).detector;
assert.equal(shared.ignoreValues.filter((e) => e.rule === 'cramped-padding').length, 1);
const entry = shared.ignoreValues.find((e) => e.rule === 'cramped-padding');
assert.equal(entry.value, '*');
assert.deepEqual(entry.files, ['index.html']);
});
it('ignore-value --file requires a glob', () => {
assert.throws(
() => runAdmin(['ignore-value', 'side-tab', '*', '--file']),