skills/pbakaus_impeccable
1
0
Fork 0
mirror of https://github.com/pbakaus/impeccable.git synced 2026-09-20 10:06:54 +03:00
Code Issues Packages Projects Releases Wiki Activity

Live: stop the preflight writing source, cache the resolution

Browse Source 
The polling-rework preflight wrote the variant scaffold into source during the
poll lease, before the agent acted. On source-preview targets (React/Vue/Vite,
everything but the svelte-component path) that write full-reloaded the
framework; a browser caught mid-reload missed the agent's variant write and the
SSE done, and sat stranded at 0/N.

Restore the 3.5 single-atomic-edit semantics: the preflight still resolves the
element location and computes the scaffold, but --defer-source-write leaves
source untouched and hands the agent the wrapper text plus the picked source
range. The agent splices variants into the wrapper and replaces the range in
one write, so the framework reloads exactly once. The svelte-component path is
untouched (it never writes route source). The missed-completion recovery stays
as defense in depth.

Also cache the resolved source file per target signature (locator + route):
the ~7.6s tree search re-ran on every generate for the same element; a hit now
points the helper straight at the file via --file, invalidated when the target
changes or a resolution fails.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Paul Bakaus
2026-07-22 22:49:44 -07:00
co-authored by Claude Fable 5
parent 4cd5ea7547
commit dbe0c12b91
8 changed files with 314 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files
skill/scripts/live-wrap.mjs
+29
View File
@@ -68,6 +68,13 @@ The agent should insert variant HTML at insertLine.`);
const filePath = argVal(args, '--file');
const text = argVal(args, '--text');
const pageUrl = argVal(args, '--page-url');
// Preflight passes this for source-preview targets. It computes the scaffold
// (element location + wrapper text) but does NOT write it into source. The
// agent then writes the wrapper + all variants in one atomic edit. The
// premature server-side write full-reloaded the framework mid-generate and
// stranded the browser at 0/N (live-server.mjs missed-completion note). It is
// a no-op on the svelte-component path, which never writes the route source.
const deferSourceWrite = args.includes('--defer-source-write');
if (!id) { console.error('Missing --id'); process.exit(1); }
if (!elementId && !classes && !query) {
@@ -334,6 +341,7 @@ The agent should insert variant HTML at insertLine.`);
let outputEndLine = startLine + wrapperLines.length + (originalLines.length - 1);
let insertLine;
let svelteSession = null;
let deferredWrapper = null;
if (useSvelteComponent) {
// Svelte/SvelteKit resets component-local state on markup HMR updates.
@@ -353,6 +361,20 @@ The agent should insert variant HTML at insertLine.`);
outputStartLine = 1;
outputEndLine = 1;
insertLine = 1;
} else if (deferSourceWrite) {
// Deferred source write: compute the scaffold text but leave source
// untouched. The agent replaces the picked element's source range with
// `wrapperBlock` (variants spliced at the marker) in one edit. Writing the
// scaffold here first would reload the framework before the agent's write
// lands, and a browser caught mid-reload misses the `done` and sits at 0/N.
deferredWrapper = {
block: wrapperLines.join('\n'),
replaceStartLine: startLine + 1, // 1-indexed picked-element range the
replaceEndLine: endLine + 1, // agent's wrapper block replaces
};
// insertLine matches the final file position the wrapper occupies once the
// agent replaces the picked range, so downstream consumers stay consistent.
insertLine = startLine + 6 + (originalLines.length - 1) + 1;
} else {
// Replace the original element with the wrapper
const newLines = [
@@ -383,6 +405,13 @@ The agent should insert variant HTML at insertLine.`);
file: outputRelFile,
sourceFile: useFrameworkComponent ? relTargetFile : undefined,
previewMode,
// Deferred source write: the wrapper is NOT yet in source. The agent
// replaces [replaceStartLine, replaceEndLine] with `wrapperBlock` (variants
// spliced at the "insert below this line" marker) in one atomic edit.
sourceWritten: deferredWrapper ? false : undefined,
wrapperBlock: deferredWrapper ? deferredWrapper.block : undefined,
replaceStartLine: deferredWrapper ? deferredWrapper.replaceStartLine : undefined,
replaceEndLine: deferredWrapper ? deferredWrapper.replaceEndLine : undefined,
componentDir: componentSession?.componentDir,
propContract: componentSession?.propContract,
sourceStartLine: useFrameworkComponent ? startLine + 1 : undefined,