skills/pbakaus_impeccable
1
0
Fork 0
mirror of https://github.com/pbakaus/impeccable.git synced 2026-09-17 08:36:25 +03:00
Code Issues Packages Projects Releases Wiki Activity

Skip page-level checks on partials/components

Browse Source 
Page-level typography checks (flat hierarchy, single font, overused font)
now only run on files that look like full pages (have <!DOCTYPE, <html>,
or <head> tags). Partials and components still get element-level border
checks.

isFullPage() strips HTML comments before checking to avoid false matches
on prose that mentions tag names.

Added partial-component.html fixture that has Inter, flat sizes, and a
side-tab border — verifies only the border is flagged.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Paul Bakaus
2026-03-17 11:49:32 -07:00
co-authored by Claude Opus 4.6
parent 37393f1793
commit ed1579ee37
4 changed files with 101 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
source/skills/critique/scripts/detect-antipatterns.mjs
+18 -6
View File
@@ -79,6 +79,13 @@ const ANTIPATTERNS = [
},
];
/** Check if content looks like a full page (not a component/partial) */
function isFullPage(content) {
// Strip HTML comments before checking — they might mention <html>/<head> in prose
const stripped = content.replace(/<!--[\s\S]*?-->/g, '');
return /<!doctype\s|<html[\s>]|<head[\s>]/i.test(stripped);
}
function getAP(id) {
return ANTIPATTERNS.find(a => a.id === id);
}
@@ -289,9 +296,11 @@ async function detectHtml(filePath) {
}
}
// Page-level typography checks
for (const f of checkPageTypography(document, window)) {
findings.push(finding(f.id, filePath, f.snippet));
// Page-level typography checks (only for full pages, not partials)
if (isFullPage(html)) {
for (const f of checkPageTypography(document, window)) {
findings.push(finding(f.id, filePath, f.snippet));
}
}
window.close();
@@ -540,8 +549,11 @@ function detectText(content, filePath) {
}
}
for (const analyzer of REGEX_ANALYZERS) {
findings.push(...analyzer(content, filePath));
// Page-level analyzers only run on full pages
if (isFullPage(content)) {
for (const analyzer of REGEX_ANALYZERS) {
findings.push(...analyzer(content, filePath));
}
}
return findings;
@@ -712,7 +724,7 @@ if (isMainModule) main();
export {
ANTIPATTERNS, SAFE_TAGS, OVERUSED_FONTS, GENERIC_FONTS,
checkElementBorders, checkPageTypography, isNeutralColor,
checkElementBorders, checkPageTypography, isNeutralColor, isFullPage,
detectHtml, detectUrl, detectText,
walkDir, formatFindings, SCANNABLE_EXTENSIONS, SKIP_DIRS,
};