skills/pbakaus_impeccable
1
0
Fork 0
mirror of https://github.com/pbakaus/impeccable.git synced 2026-09-21 18:47:02 +03:00
Code Issues Packages Projects Releases Wiki Activity

Keep the generate lane's boot extras behind flags

Browse Source 
The speed pass had every `impeccable live` boot probe for the dev
server and print three new keys (devUrl, contextMissing, contextNote),
which moved an oracle golden and cost a plain live session a probe it
never asked for. The lane's extras are opt-in now: `--dev-url` runs the
probe and reports devUrl; `--allow-missing-context` reports the context
keys. Without either flag the boot's work and payload are byte-identical
to before, which the restored golden and a new boot test pin.

generate.md passes both flags; the contract doc says so.

Written with AI assistance (Claude).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Abdul Wahab
2026-09-15 05:45:49 +05:00
committed by Abdul Wahab
co-authored by Claude Fable 5
parent 1220f26d08
commit f29636a3d5
5 changed files with 33 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/live-boot-fastpath.test.mjs
+11 -3
View File
@@ -60,7 +60,7 @@ describe('live boot fast lane', { skip: ENGINE_BIN ? false : ENGINE_MISSING_MESS
assert.equal(refused.error, 'context_missing');
assert.deepEqual(refused.missing, ['PRODUCT.md', 'DESIGN.md']);
const booted = await run(tmp, ['live', '--allow-missing-context'], { IMPECCABLE_DEV_URL_CANDIDATES: `http://127.0.0.1:1/, ${devUrl}` });
const booted = await run(tmp, ['live', '--allow-missing-context', '--dev-url'], { IMPECCABLE_DEV_URL_CANDIDATES: `http://127.0.0.1:1/, ${devUrl}` });
assert.equal(booted.ok, true, JSON.stringify(booted));
assert.deepEqual(booted.contextMissing, ['PRODUCT.md', 'DESIGN.md']);
assert.match(booted.contextNote, /do not run init or document/);
@@ -73,14 +73,22 @@ describe('live boot fast lane', { skip: ENGINE_BIN ? false : ENGINE_MISSING_MESS
assert.ok(stopped.ok !== false, JSON.stringify(stopped));
});
it('reports devUrl null when nothing serves the injected page, and no contextMissing when both files exist', async () => {
it('with both files present the flags report devUrl null and an empty contextMissing', async () => {
writeFileSync(join(tmp, 'PRODUCT.md'), '# Product\n\n## Platform\n\nweb\n');
writeFileSync(join(tmp, 'DESIGN.md'), '---\nname: Test\n---\n# Design\n');
const booted = await run(tmp, ['live'], { IMPECCABLE_DEV_URL_CANDIDATES: 'http://127.0.0.1:1/' });
const booted = await run(tmp, ['live', '--allow-missing-context', '--dev-url'], { IMPECCABLE_DEV_URL_CANDIDATES: 'http://127.0.0.1:1/' });
assert.equal(booted.ok, true, JSON.stringify(booted));
assert.deepEqual(booted.contextMissing, []);
assert.equal(booted.contextNote, null);
assert.equal(booted.devUrl, null);
await run(tmp, ['live-server', 'stop']);
});
it('a plain live boot is untouched by the lane: no probe, no new keys', async () => {
const booted = await run(tmp, ['live'], { IMPECCABLE_DEV_URL_CANDIDATES: devUrl });
assert.equal(booted.ok, true, JSON.stringify(booted));
assert.ok(!('devUrl' in booted), 'devUrl only appears with --dev-url');
assert.ok(!('contextMissing' in booted) && !('contextNote' in booted), 'context keys only appear with --allow-missing-context');
await run(tmp, ['live-server', 'stop']);
});
});