From f2c7051853848826aac2f4646581d62a732155ad Mon Sep 17 00:00:00 2001 From: Abdul Wahab Date: Wed, 16 Sep 2026 17:50:25 +0500 Subject: [PATCH] Fix: drop discard blank lines from live-accept oracle goldens (#793) The four discard goldens encoded the wrapper newlines as empty lines around the restored element. Re-recorded from the engine so they match the trim in extract_original. Written with AI assistance. Co-authored-by: Cursor --- tests/oracle/golden/live-accept-html-discard-then-accept.json | 2 +- tests/oracle/golden/live-accept-html-discard.json | 2 +- tests/oracle/golden/live-accept-jsx-discard.json | 2 +- .../golden/live-accept-svelte-fallback-source-wrapper.json | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/oracle/golden/live-accept-html-discard-then-accept.json b/tests/oracle/golden/live-accept-html-discard-then-accept.json index f0e035f5b..e9b534adf 100644 --- a/tests/oracle/golden/live-accept-html-discard-then-accept.json +++ b/tests/oracle/golden/live-accept-html-discard-then-accept.json @@ -16,6 +16,6 @@ "files": { ".impeccable/live/accept-receipts/ab12cd34.json": "{\n \"id\": \"ab12cd34\",\n \"operation\": \"discard\",\n \"variantId\": null,\n \"result\": {\n \"handled\": true,\n \"file\": \"index.html\",\n \"carbonize\": false\n },\n \"completedAt\": \"\"\n}\n", ".impeccable/live/config.json": "{\n \"files\": [\"index.html\", \"public/**/*.html\"],\n \"insertBefore\": \"\",\n \"commentSyntax\": \"html\"\n}\n", - "index.html": "\n\n \n \n Oracle Live HTML Fixture\n \n \n \n
\n\n

Oracle Fixture

\n\n

Minimal static page for oracle live-mode goldens.

\n
\n
One
\n
Two
\n
\n \n
\n \n\n" + "index.html": "\n\n \n \n Oracle Live HTML Fixture\n \n \n \n
\n

Oracle Fixture

\n

Minimal static page for oracle live-mode goldens.

\n
\n
One
\n
Two
\n
\n \n
\n \n\n" } } diff --git a/tests/oracle/golden/live-accept-html-discard.json b/tests/oracle/golden/live-accept-html-discard.json index 925e07d24..11322042b 100644 --- a/tests/oracle/golden/live-accept-html-discard.json +++ b/tests/oracle/golden/live-accept-html-discard.json @@ -6,6 +6,6 @@ "files": { ".impeccable/live/accept-receipts/ab12cd34.json": "{\n \"id\": \"ab12cd34\",\n \"operation\": \"discard\",\n \"variantId\": null,\n \"result\": {\n \"handled\": true,\n \"file\": \"index.html\",\n \"carbonize\": false\n },\n \"completedAt\": \"\"\n}\n", ".impeccable/live/config.json": "{\n \"files\": [\"index.html\", \"public/**/*.html\"],\n \"insertBefore\": \"\",\n \"commentSyntax\": \"html\"\n}\n", - "index.html": "\n\n \n \n Oracle Live HTML Fixture\n \n \n \n
\n\n

Oracle Fixture

\n\n

Minimal static page for oracle live-mode goldens.

\n
\n
One
\n
Two
\n
\n \n
\n \n\n" + "index.html": "\n\n \n \n Oracle Live HTML Fixture\n \n \n \n
\n

Oracle Fixture

\n

Minimal static page for oracle live-mode goldens.

\n
\n
One
\n
Two
\n
\n \n
\n \n\n" } } diff --git a/tests/oracle/golden/live-accept-jsx-discard.json b/tests/oracle/golden/live-accept-jsx-discard.json index 964f74075..d66a8f194 100644 --- a/tests/oracle/golden/live-accept-jsx-discard.json +++ b/tests/oracle/golden/live-accept-jsx-discard.json @@ -6,7 +6,7 @@ "files": { ".impeccable/live/accept-receipts/ab12cd34.json": "{\n \"id\": \"ab12cd34\",\n \"operation\": \"discard\",\n \"variantId\": null,\n \"result\": {\n \"handled\": true,\n \"file\": \"src/App.jsx\",\n \"carbonize\": false\n },\n \"completedAt\": \"\"\n}\n", ".impeccable/live/config.json": "{\n \"files\": [\"index.html\"],\n \"insertBefore\": \"\",\n \"commentSyntax\": \"html\"\n}\n", - "src/App.jsx": "export default function App() {\n return (\n
\n\n

Vite Fixture

\n\n

Minimal React tree for oracle live-mode goldens.

\n
\n
One
\n
Two
\n
\n
    \n {items.map((item) => (\n
  • {item.title}
    • \n ))}\n
\n
\n );\n}\n\nconst items = [\n { id: 1, title: 'First' },\n { id: 2, title: 'Second' },\n];\n", + "src/App.jsx": "export default function App() {\n return (\n
\n

Vite Fixture

\n

Minimal React tree for oracle live-mode goldens.

\n
\n
One
\n
Two
\n
\n
    \n {items.map((item) => (\n
  • {item.title}
    • \n ))}\n
\n
\n );\n}\n\nconst items = [\n { id: 1, title: 'First' },\n { id: 2, title: 'Second' },\n];\n", "src/main.jsx": "import { createRoot } from 'react-dom/client';\nimport App from './App.jsx';\n\ncreateRoot(document.getElementById('root')).render();\n", "src/Panel.tsx": "type PanelProps = { title: string; children?: React.ReactNode };\n\nexport function Panel({ title, children }: PanelProps) {\n return (\n
\n
\n

{title}

\n
\n
{children}
\n
\n );\n}\n" } diff --git a/tests/oracle/golden/live-accept-svelte-fallback-source-wrapper.json b/tests/oracle/golden/live-accept-svelte-fallback-source-wrapper.json index c600204dc..d159240df 100644 --- a/tests/oracle/golden/live-accept-svelte-fallback-source-wrapper.json +++ b/tests/oracle/golden/live-accept-svelte-fallback-source-wrapper.json @@ -17,6 +17,6 @@ ".impeccable/live/accept-receipts/ab12cd34.json": "{\n \"id\": \"ab12cd34\",\n \"operation\": \"discard\",\n \"variantId\": null,\n \"result\": {\n \"handled\": true,\n \"file\": \"src/routes/+page.svelte\",\n \"carbonize\": false\n },\n \"completedAt\": \"\"\n}\n", ".impeccable/live/config.json": "{\n \"files\": [\"src/app.html\"],\n \"insertBefore\": \"\",\n \"commentSyntax\": \"html\"\n}\n", "src/app.html": "\n\n \n \n SvelteKit Fixture\n %sveltekit.head%\n \n \n
%sveltekit.body%
\n \n\n", - "src/routes/+page.svelte": "\n\n
\n\n

{title}

\n\n

Minimal SvelteKit route for oracle live-mode goldens.

\n
    \n {#each expenses as expense (expense.id)}\n
  • {expense.label}: {expense.amount}
    • \n {/each}\n
\n
\n
One
\n
Two
\n
\n
\n\n\n" + "src/routes/+page.svelte": "\n\n
\n

{title}

\n

Minimal SvelteKit route for oracle live-mode goldens.

\n
    \n {#each expenses as expense (expense.id)}\n
  • {expense.label}: {expense.amount}
    • \n {/each}\n
\n
\n
One
\n
Two
\n
\n
\n\n\n" } }