skills/pbakaus_impeccable
1
0
Fork 0
mirror of https://github.com/pbakaus/impeccable.git synced 2026-09-14 07:06:45 +03:00
Code Issues Packages Projects Releases Wiki Activity

Soften sheriff stale classification (#360)

Browse Source
This commit is contained in:
Paul Bakaus
2026-07-09 10:19:18 -07:00
committed by GitHub
parent e34e53f140
commit fb6d3e9791
2 changed files with 49 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/github-sheriff.test.mjs
+25 -3
View File
@@ -288,14 +288,36 @@ describe('github sheriff', () => {
assert.equal(plan.shouldClose, false);
});
it('marks failing checks as waiting on contributor', () => {
it('marks failing checks as blocked without starting the contributor stale clock', () => {
const plan = evaluatePullRequest(pr({
createdAt: '2026-07-01T00:00:00Z',
statusState: 'FAILURE',
}), { now: NOW });
assert.equal(plan.contributorActionRequired, true);
assert.ok(plan.desiredLabels.includes('blocked: ci'));
assert.equal(plan.contributorActionRequired, false);
assert.deepEqual(plan.labelsToAdd, ['blocked: ci', 'needs maintainer review']);
assert.equal(plan.shouldWarn, false);
assert.equal(plan.shouldClose, false);
});
it('does not warn or close PRs blocked only by merge conflicts', () => {
const plan = evaluatePullRequest(pr({
createdAt: '2026-06-20T00:00:00Z',
mergeable: 'CONFLICTING',
labels: ['waiting on contributor', 'stale'],
labelEvents: [
labelEvent('LabeledEvent', 'waiting on contributor', 'github-actions[bot]', '2026-07-01T00:00:00Z'),
],
comments: [
comment('github-actions[bot]', '2026-07-01T00:00:00Z', WARNING_MARKER),
],
}), { now: NOW });
assert.equal(plan.contributorActionRequired, false);
assert.deepEqual(plan.labelsToAdd, ['blocked: merge conflicts', 'needs maintainer review']);
assert.deepEqual(plan.labelsToRemove, ['stale', 'waiting on contributor']);
assert.equal(plan.shouldWarn, false);
assert.equal(plan.shouldClose, false);
});
it('marks passing resolved PRs as ready to merge', () => {