3 Commits

Include renames

Author	SHA1	Message	Date
Paul BakausandClaude Fable 5	c3aba1e343	hooks: two-tier design hook — immediate per-edit rules + full-set Stop deep pass ... Eval evidence showed the per-edit PostToolUse stream fires overwhelmingly on copy-level rules (em-dash-overuse ~97x/session) and measurably makes models more conservative, while a full-detector pass at completion is what actually fixes contrast/padding/glow. Split the hook accordingly: - Per-edit (PostToolUse) now surfaces only IMMEDIATE_TIER_RULES: broken output (broken-image, text-overflow, clipped-overflow-container, body-text-viewport-edge), objective contrast/legibility failures (low-contrast, gray-on-color, tiny-text), single-property mechanical slop (gradient-text, dark-glow), and design-system drift (the four design-system-* rules, which compound if left uncorrected). Everything else defers. Override with hook.perEditRules: "all" in .impeccable/config.json. Tiering is off for Cursor/Copilot harnesses, which have no Stop pass wired, so nothing gets silently dropped there. - Stop deep pass (runStopHook): runs the FULL rule set over every UI file touched this session (tracked via the existing hook.cache.json session state; deferred-only edits now mark the file touched), dedupes against everything already surfaced per-edit, honors ignore-rule/file/value and inline disables, reuses the [impeccable@1] envelope, and no-ops fast when no UI files were touched. Emits hookSpecificOutput { hookEventName: "Stop", additionalContext } per the Claude Code SDK Stop contract (conversation continues so the model can act on it). Second Stop fire is silent - deep-pass findings are remembered. - Wiring: Stop entries (timeout 30) in plugin/hooks/hooks.json, the .claude settings + .codex hooks manifests (transformers + hook-admin repair path). Claude Code and Codex both dispatch a native Stop event; Cursor's stop hook is inconsistently dispatched (pre-write gate stays) and Copilot's agentStop/sessionEnd don't inject model context, so neither gets a Stop entry - documented in reference/hooks.md. - Tests: tiering split/override/harness gating, Stop dedupe + silent no-touched-files + ignore machinery + kill switches; existing per-edit tests moved to immediate-tier rule ids. 181 tests green; smoke-tested the built dist skill end to end (glow surfaced per-edit, em-dash only at Stop, second Stop silent). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-11 16:46:00 -07:00
3 people	44c27a72af	Fix Codex plugin hook load failure; bump skill to 3.9.1 (#333) ... Codex loads bundled plugin lifecycle hooks from `hooks/hooks.json` using a strict schema that accepts only the top-level `hooks` field. The plugin-packaged manifest carried a top-level `description`, so Codex rejected the whole manifest with `unknown field description, expected hooks` and the post-edit design detector never registered (issue #330). Drop `description` from `buildClaudePluginHooksManifest()` and regenerate `plugin/hooks/hooks.json`. The Claude Code plugin path is unaffected (it only reads the `hooks` object). Add a regression assertion for the plugin artifact and bump the skill version to 3.9.1. Claude-Session: https://claude.ai/code/session_013GTTHY6uHwESUyAgjUEm7x Co-authored-by: Claude <noreply@anthropic.com>	2026-07-01 11:03:55 -07:00
3 people	9c0012d4e1	feat(hooks): package design hook in plugin, install to settings.local.json (#243) ... * feat(hooks): package design hook in plugin, install to settings.local.json Three related changes to how the Impeccable design hook is distributed, plus an unrelated build fix discovered along the way. Package the hook in the Claude Code plugin - The marketplace / `/plugin install` path previously shipped the skill and agents but no hook, so those users never got the design detector. The build now emits `plugin/hooks/hooks.json` (auto-discovered at the plugin root), resolving the script via `${CLAUDE_PLUGIN_ROOT}` so it works wherever Claude Code unpacks the plugin instead of assuming a `.claude/skills/` layout. CLI installs the hook into settings.local.json, not shared settings.json - `npx impeccable skills install/update` now writes the Claude hook to the gitignored `.claude/settings.local.json` (a machine-local install side effect) rather than the team-shared `settings.json`, which could otherwise be committed and break for teammates without the skill installed. - Graceful handling (leave-it-never-duplicate): if our hook already lives in the shared `settings.json` (a legacy install or a deliberate user move), it is honored in place and never duplicated into the local override, which would otherwise run the detector twice per edit. - The skill's `/impeccable hooks on|off` toggle is unaffected: it only writes `.impeccable/hook.json`, never the settings files. Fix universal.zip build failure under archiver v8 - `archiver` was bumped to v8 (now ESM, factory function removed) but `scripts/lib/zip.js` still used the old `archiver('zip', ...)` API, so every build silently failed to produce `dist/universal.zip` (the skill-release artifact). Switched to `new ZipArchive({...})`. Also folds in a pre-existing local rename of the hook status message ("Scanning design" -> "Checking UI changes") and its regenerated provider output. Tests: new coverage for the plugin-packaged hook manifest and the shared-settings honor-in-place path; existing CLI assertions moved to settings.local.json. Full suite green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(cli): detect hook by marker, not file existence (Bugbot) hookInstalledForProvider treated any existing settings.local.json (or hooks.json) as proof the hook was installed. Those files commonly hold unrelated local settings, so the already-installed `skills install` path would skip repairing a genuinely missing hook that `update` would add. Detect the Impeccable marker in the file instead of mere existence. Adds a test for the exact case: a settings.local.json with only permissions still triggers hook repair and preserves the unrelated content. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(build): fail loud on a broken release zip + cover the zip writer Close the gap that let the archiver v8 break ship a 0-byte universal.zip with a green test suite: - createProviderZip no longer swallows failures. It throws on a missing source, an archive with zero entries, or a 0-byte output, and build() now exits non-zero on any such rejection. A build that can't produce its release artifact fails instead of deploying an empty bundle. - New tests/zip.test.mjs exercises the real zip writer and round-trips through extract-zip (the unpacker the CLI uses): a valid bundle unpacks to the skill tree, and the empty/missing-source cases throw. Wired into the core suite so it runs in `bun run test`. Why this matters: the prior CLI e2e tests stub the bundle as a local directory, so they never built, downloaded, or unzipped a real archive. The zip writer had no coverage and failed soft, so Dependabot's archiver 7->8 major bump merged green and the deploy shipped an unusable bundle. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(cli): scope hook marker scan to the hooks subtree + prune local dupes (Bugbot) Two follow-ups from Bugbot: - fileHasImpeccableHookMarker scanned the whole settings file as raw text, so an unrelated string (e.g. a permissions allow entry that mentions the hook path) could falsely read as an installed hook and block install/repair or the shared-settings skip. Now it parses the JSON and scans only the `hooks` subtree. - When the hook is honored in the shared settings.json, copyProviderHooks skipped the local write but left a stale hook in settings.local.json from an earlier machine-local install, so Claude Code loaded both and ran the detector twice per edit. It now prunes the local copy (preserving unrelated local settings, dropping the file if only our scaffolding remained). Adds tests for both: a permissions string mentioning the hook path still triggers repair, and a shared hook prunes the stale local duplicate while keeping unrelated permissions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-13 23:54:46 -07:00