Make critique storage the single owner of snapshot discovery and frontmatter parsing, and keep context signals focused on summarizing the canonical result.
AI-assisted: Prepared by Codex under pbakaus's scheduled architecture-refactor authorization.
* Add OpenAI plugin submission bundle
Build a Codex-native OpenAI plugin with bundled hooks, public listing metadata, submission guidance, privacy coverage, and regression tests.
AI assistance: OpenAI Codex prepared and validated these changes under maintainer direction.
* Fix provider script command rendering
Replace heuristic rewrites across executable scripts with one explicit provider marker, render pinned shortcuts per target harness, and remove the personal email from the public publisher manifest.
Addresses automated review feedback on PR #363.
AI assistance: OpenAI Codex prepared and validated these changes under maintainer direction.
The `import.meta.url === \`file://\${process.argv[1]}\`` guard at the
bottom of critique-storage.mjs silently failed on Windows: Node sets
import.meta.url to file:///D:/... (forward slashes) but process.argv[1]
is D:\... (backslashes), so the string compare returns false, main()
never runs, and the script exits 0 with no output. The OpenCode reporter
saw "/impeccable critique" skip the snapshot save with no error.
Switch to pathToFileURL(process.argv[1]).href, the standard cross-
platform pattern already used everywhere else in the repo.
Adds three CLI subprocess tests so future regressions of this guard
are caught even on macOS/Linux CI.
Fixes#155.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* critique-storage: new helper for per-run snapshot persistence
Adds skill/scripts/critique-storage.mjs with:
- slugFromTarget(): mechanically derive a stable slug from a resolved
file path or URL (NOT from the user's natural-language phrasing),
so the same target lands in the same stream across runs even when
dev-server ports drift or the user phrases it differently.
- writeSnapshot(): writes .impeccable/critique/<timestamp>__<slug>.md
with a small YAML frontmatter (timestamp, slug, target, total_score,
p0_count, p1_count) plus the report body.
- readLatestSnapshot(): newest snapshot for a slug, used by polish.
- readTrend(): last N frontmatter entries for a slug, used by critique
to print the score trend line.
- readIgnoreList(): non-empty non-comment lines from ignore.md, the
ONLY input critique consumes from prior runs.
No separate index.json. The snapshot files are the single source of
truth; trend reader globs them and parses frontmatter. Deleting a
snapshot removes it from the trend cleanly with no orphan rows.
CRITIQUE_DIR constant + getCritiqueDir / getCritiqueIgnorePath added
to impeccable-paths.mjs alongside the existing live-dir helpers.
19 unit tests in tests/critique-storage.test.mjs cover slug stability,
URL and file inputs, round-trip read/write, trend filtering by slug,
and ignore-list parsing.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* critique: persist snapshot per run, respect ignore.md
Two new steps wired into the critique flow:
- Setup: Resolve Target and Load Ignore List. Before gathering
assessments, resolve the user's natural-language target ("the
homepage") to a concrete artifact, compute the slug via
critique-storage.mjs, and read ignore.md. Matching findings drop
silently from the report. This is the only prior-run input
critique consumes; anchoring on prior findings would defeat
independent assessment.
- Persist the Snapshot. After the report is finalized (before Ask
the User), write it to .impeccable/critique/<ts>__<slug>.md with
structured frontmatter, then surface a one-line trend ("Trend for
index-astro: 24 → 28 → 32") and the written path. First run says
"no trend yet". Persistence is fire-and-forget; failures print and
move on rather than blocking the rest of the flow.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* polish: read latest matching critique as fix backlog
When polish is invoked after critique on the same target, the
critique's P0/P1 findings are the right backlog; don't re-derive
them.
Adds a Setup step that resolves the target, computes the slug via
critique-storage.mjs slug, and reads the latest matching snapshot
via critique-storage.mjs latest. Found → use those P0/P1 items as
the polish backlog and mention the snapshot path. Not found →
proceed independently from a clean slate.
Explicitly does NOT read snapshots for other targets (cross-target
context is pollution). Explicitly does NOT cascade to atomic moves
(bolder, quieter, clarify, animate, etc.); those act on a specific
selection where the page-level critique would be noise.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* gitignore: .impeccable/critique/, opt ignore.md back in
Per-run critique snapshots are local artifacts (same precedent as
.impeccable/live/sessions/), but ignore.md carries user-curated
deferrals that may be worth sharing across a team. Negate-pattern
keeps it trackable while the snapshot files stay local.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* polish: reframe prior critique as additional signal, not backlog
Three corrections to the previous polish.md addition:
- "Polish is usually invoked after critique" is wrong; people polish
without ever running critique. Dropped the presumption.
- "This is the only command that auto-reads prior critique" leaks
cross-command scope into polish's reference file. Dropped.
- Treating critique findings as THE polish backlog biased polish to
only fix what critique flagged, skipping its own checklist. The
critique is one input among many; fold its P0/P1 items into the
polish list, then do the normal pass.
Now lives as a short item 4 in Pre-Polish Assessment ("Pull in any
prior critique — optional signal") instead of a top-level Setup
section. Less prominent, doesn't presume invocation order.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* critique-storage: drop the ignore subcommand, read ignore.md directly
The ignore-list helper did nothing the model can't do inline: read a
markdown file, skip blank and #-prefix lines. It added a tool
roundtrip for no real value. Other helpers earn their keep by doing
work the model can't trivially do (path normalization, filename
generation, glob + frontmatter parsing); ignore-list did not.
Removed:
- `ignore` CLI subcommand
- readIgnoreList() module export + its tests
- getCritiqueIgnorePath() from impeccable-paths.mjs (now dead code)
Critique.md step 3 now just says "read .impeccable/critique/ignore.md
if it exists" and explains the format inline. Simpler.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* critique-storage: caller meta cannot override timestamp or slug
Spotted by Cursor Bugbot on the PR. writeSnapshot built frontmatter as
{ timestamp, slug, ...meta } so a caller-supplied meta blob (parsed
from the IMPECCABLE_CRITIQUE_META env var) could silently clobber the
computed timestamp and slug. The filename keeps the computed values,
so the frontmatter would drift from the filename and readTrend would
attribute scores to wrong timestamps with no visible error.
Swap to { ...meta, timestamp, slug } so internal values always win.
Add a regression test that passes corrupt meta and asserts the
frontmatter still matches the filename.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Paul BakausandGitHub
