pbakaus_impeccable/tests/serve-question.test.mjs

import { describe, it } from 'node:test';
import assert from 'node:assert/strict';
import { spawn, execSync } from 'node:child_process';
import { writeFileSync, readFileSync, rmSync, utimesSync, mkdtempSync, existsSync } from 'node:fs';
import { tmpdir } from 'node:os';
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import { EventEmitter } from 'node:events';

import { browserOpenCommand, openSystemBrowser } from '../skill/scripts/lib/open-system-browser.mjs';

const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
const SCRIPT = path.join(ROOT, 'skill', 'scripts', 'serve-question.mjs');

function startServer(payload, extraArgs = []) {
  const dir = mkdtempSync(path.join(tmpdir(), 'serve-question-'));
  const payloadPath = path.join(dir, 'q.json');
  writeFileSync(payloadPath, JSON.stringify(payload));
  const child = spawn(process.execPath, [SCRIPT, '--payload', payloadPath, '--no-open', '--timeout', '30', ...extraArgs], {
    stdio: ['ignore', 'pipe', 'pipe'],
  });
  return new Promise((resolve, reject) => {
    let out = '';
    const timer = setTimeout(() => reject(new Error(`no URL in output: ${out}`)), 10000);
    child.stdout.on('data', (chunk) => {
      out += chunk;
      const match = out.match(/QUESTION URL: (http:\/\/127\.0\.0\.1:\d+\/)/);
      if (match) { clearTimeout(timer); resolve({ child, url: match[1], read: () => out }); }
    });
  });
}

const PAYLOAD = {
  title: 'Choose the visual world',
  question: 'The roll assigned Fillmore Handbill.',
  options: [
    { id: 'assigned', label: 'Fillmore Handbill', kicker: 'THE ROLL', lineage: '1966-71 psychedelic handbills' },
    { id: 'challenger-1', label: 'Teletext Service', body: 'block-mosaic broadcast pages' },
  ],
  reroll: true,
  steer: true,
};

describe('serve-question', () => {
  it('opens Windows URLs through cmd.exe and reserves the start title argument', () => {
    assert.deepEqual(
      browserOpenCommand('http://127.0.0.1:1234/', { platform: 'win32', comspec: 'cmd.exe' }),
      { command: 'cmd.exe', args: ['/c', 'start', '', 'http://127.0.0.1:1234/'] },
    );
  });

  it('absorbs asynchronous system-opener failures after printing the URL', () => {
    const child = new EventEmitter();
    child.unref = () => {};
    assert.equal(openSystemBrowser('http://127.0.0.1:1234/', {
      platform: 'linux',
      spawnImpl: () => child,
    }), true);
    assert.equal(child.listenerCount('error'), 1);
    assert.doesNotThrow(() => child.emit('error', Object.assign(new Error('missing opener'), { code: 'ENOENT' })));
  });

  it('serves the page, records the answer, prints ANSWER, exits 0', async () => {
    const { child, url, read } = await startServer(PAYLOAD);
    const html = await (await fetch(url)).text();
    assert.match(html, /Fillmore Handbill/);
    assert.match(html, /THE ROLL/);
    assert.match(html, /Re-roll/);
    const post = await fetch(`${url}answer`, {
      method: 'POST',
      headers: { 'content-type': 'application/json' },
      body: JSON.stringify({ optionId: 'assigned', steer: 'warmer palette' }),
    });
    assert.equal(post.status, 200);
    const code = await new Promise((resolve) => child.on('exit', resolve));
    assert.equal(code, 0);
    assert.match(read(), /ANSWER: \{"optionId":"assigned","steer":"warmer palette"\}/);
  });

  it('re-roll answers round-trip with their own id', async () => {
    const { child, url, read } = await startServer(PAYLOAD);
    await fetch(`${url}answer`, {
      method: 'POST',
      headers: { 'content-type': 'application/json' },
      body: JSON.stringify({ optionId: 'reroll', steer: '' }),
    });
    const code = await new Promise((resolve) => child.on('exit', resolve));
    assert.equal(code, 0);
    assert.match(read(), /"optionId":"reroll"/);
  });

  it('start/wait cycle: daemonize, poll WAITING, then collect the answer', async () => {
    const dir = mkdtempSync(path.join(tmpdir(), 'serve-question-'));
    const payloadPath = path.join(dir, 'q.json');
    writeFileSync(payloadPath, JSON.stringify(PAYLOAD));
    const run = (args) => new Promise((resolve) => {
      const child = spawn(process.execPath, [SCRIPT, ...args], { cwd: dir, stdio: ['ignore', 'pipe', 'ignore'] });
      let out = '';
      child.stdout.on('data', (chunk) => { out += chunk; });
      child.on('exit', (code) => resolve({ code, out }));
    });
    const started = await run(['--start', '--payload', payloadPath, '--no-open', '--key', 'tk']);
    assert.equal(started.code, 0);
    const url = started.out.match(/QUESTION URL: (\S+)/)?.[1];
    assert.ok(url, started.out);
    const waiting = await run(['--wait', '--key', 'tk', '--poll', '1']);
    assert.equal(waiting.code, 3);
    await fetch(`${url}answer`, { method: 'POST', headers: { 'content-type': 'application/json' }, body: JSON.stringify({ optionId: 'assigned', steer: '' }) });
    const collected = await run(['--wait', '--key', 'tk', '--poll', '5']);
    assert.equal(collected.code, 0);
    assert.match(collected.out, /"optionId":"assigned"/);
  });

  it('headless detection spares the modes that never open a browser', async () => {
    // Only the blocking serve path auto-opens a URL. --wait polls a daemon
    // that is already running, --stop kills one, --schema just prints text,
    // so a headless environment must not turn any of them into exit 2: the
    // documented flow polls --wait while it exits 3, and new-work.md tells
    // the agent to read --schema first.
    const dir = mkdtempSync(path.join(tmpdir(), 'serve-question-'));
    const payloadPath = path.join(dir, 'q.json');
    writeFileSync(payloadPath, JSON.stringify(PAYLOAD));
    const headlessEnv = { ...process.env, CI: '1' };
    delete headlessEnv.IMPECCABLE_QUESTION_FORCE;
    const run = (args) => new Promise((resolve) => {
      const child = spawn(process.execPath, [SCRIPT, ...args], { cwd: dir, env: headlessEnv, stdio: ['ignore', 'pipe', 'ignore'] });
      let out = '';
      child.stdout.on('data', (chunk) => { out += chunk; });
      child.on('exit', (code) => resolve({ code, out }));
    });

    const schema = await run(['--schema']);
    assert.equal(schema.code, 0, `--schema under CI must print, got ${schema.code}: ${schema.out}`);

    const started = await run(['--start', '--payload', payloadPath, '--no-open', '--key', 'hk']);
    assert.equal(started.code, 0, started.out);
    try {
      const waiting = await run(['--wait', '--key', 'hk', '--poll', '1']);
      assert.equal(waiting.code, 3, `--wait under CI must report WAITING, got ${waiting.code}: ${waiting.out}`);
      // --update delivers a re-rolled hand to a page that is already open; a
      // headless gate that eats it strands that page mid-shuffle (issue #469).
      const updated = await run(['--update', '--key', 'hk', '--payload', payloadPath]);
      assert.equal(updated.code, 0, `--update under CI must deliver, got ${updated.code}: ${updated.out}`);
    } finally {
      const stopped = await run(['--stop', '--key', 'hk']);
      assert.equal(stopped.code, 0, `--stop under CI must kill the daemon, got ${stopped.code}: ${stopped.out}`);
    }
  });

  it('headless detection still blocks the path that would open a browser', async () => {
    const dir = mkdtempSync(path.join(tmpdir(), 'serve-question-'));
    const payloadPath = path.join(dir, 'q.json');
    writeFileSync(payloadPath, JSON.stringify(PAYLOAD));
    const headlessEnv = { ...process.env, CI: '1' };
    delete headlessEnv.IMPECCABLE_QUESTION_FORCE;
    const code = await new Promise((resolve) => {
      const child = spawn(process.execPath, [SCRIPT, '--payload', payloadPath], { cwd: dir, env: headlessEnv, stdio: 'ignore' });
      child.on('exit', resolve);
    });
    assert.equal(code, 2);
  });

  it('rejects an empty payload', async () => {
    const dir = mkdtempSync(path.join(tmpdir(), 'serve-question-'));
    const payloadPath = path.join(dir, 'q.json');
    writeFileSync(payloadPath, JSON.stringify({ options: [] }));
    const code = await new Promise((resolve) => {
      const child = spawn(process.execPath, [SCRIPT, '--payload', payloadPath, '--no-open'], { stdio: 'ignore' });
      child.on('exit', resolve);
    });
    assert.equal(code, 1);
  });

  it('trusts a fresh heartbeat over a failed kill probe, and still detects true death', async () => {
    const dir = mkdtempSync(path.join(tmpdir(), 'serve-question-'));
    const qdir = path.join(dir, '.impeccable', 'questions');
    const { mkdirSync } = await import('node:fs');
    mkdirSync(qdir, { recursive: true });
    // Fresh heartbeat + a pid that cannot be signaled (throws like a sandbox
    // EPERM or a recycled pid): the wait must keep WAITING (exit 3), never
    // declare the server gone (exit 2). Pid 1 throws EPERM for a normal user.
    writeFileSync(path.join(qdir, 'beat1.state.json'), JSON.stringify({ pid: 1, port: 1, url: 'http://127.0.0.1:1/', lastBeat: Date.now() }));
    const waiting = await new Promise((resolve) => {
      const child = spawn(process.execPath, [SCRIPT, '--wait', '--key', 'beat1', '--poll', '2'], { cwd: dir, stdio: 'ignore' });
      child.on('exit', resolve);
    });
    assert.equal(waiting, 3, 'fresh heartbeat must read as alive regardless of the kill probe');
    // Stale heartbeat + a pid that is genuinely gone (ESRCH): server dead, exit 2.
    writeFileSync(path.join(qdir, 'dead1.state.json'), JSON.stringify({ pid: 999999999 >>> 8, port: 1, url: 'http://127.0.0.1:1/' }));
    const dead = await new Promise((resolve) => {
      const child = spawn(process.execPath, [SCRIPT, '--wait', '--key', 'dead1', '--poll', '2'], { cwd: dir, stdio: 'ignore' });
      child.on('exit', resolve);
    });
    assert.equal(dead, 2, 'a truly missing process must still read as gone');
  });

  it('a heartbeating page keeps the daemon alive past --timeout; silence ends it after the idle grace', async () => {
    const dir = mkdtempSync(path.join(tmpdir(), 'serve-question-'));
    const payloadPath = path.join(dir, 'q.json');
    writeFileSync(payloadPath, JSON.stringify(PAYLOAD));
    const run = (args) => new Promise((resolve) => {
      const child = spawn(process.execPath, [SCRIPT, ...args], { cwd: dir, stdio: ['ignore', 'pipe', 'ignore'] });
      let out = '';
      child.stdout.on('data', (chunk) => { out += chunk; });
      child.on('exit', (code) => resolve({ code, out }));
    });
    const started = await run(['--start', '--payload', payloadPath, '--no-open', '--key', 'life', '--timeout', '3', '--idle-grace', '3']);
    assert.equal(started.code, 0, started.out);
    const url = started.out.match(/QUESTION URL: (\S+)/)?.[1];
    assert.ok(url, started.out);
    // Beat well past the 3s timeout: the timer must not fire under a live page.
    const beatUntil = Date.now() + 5500;
    while (Date.now() < beatUntil) {
      await fetch(`${url}heartbeat`, { method: 'POST' });
      await new Promise((r) => setTimeout(r, 400));
    }
    const alive = await fetch(url);
    assert.equal(alive.status, 200, 'the daemon outlives --timeout while the page heartbeats');
    // Then silence: the idle grace (3s here) plus the 2s check interval pass
    // with no beat, and the daemon must exit rather than leak. Poll rather
    // than sleep a fixed margin so a loaded runner cannot flake this.
    const deadline = Date.now() + 12000;
    let gone = false;
    while (Date.now() < deadline && !gone) {
      await new Promise((r) => setTimeout(r, 500));
      try { await fetch(url); } catch { gone = true; }
    }
    assert.ok(gone, 'the daemon exits after the idle grace passes with no heartbeat');
  });

  it('a page that never opens still ends the daemon at --timeout', async () => {
    const dir = mkdtempSync(path.join(tmpdir(), 'serve-question-'));
    const payloadPath = path.join(dir, 'q.json');
    writeFileSync(payloadPath, JSON.stringify(PAYLOAD));
    const run = (args) => new Promise((resolve) => {
      const child = spawn(process.execPath, [SCRIPT, ...args], { cwd: dir, stdio: ['ignore', 'pipe', 'ignore'] });
      let out = '';
      child.stdout.on('data', (chunk) => { out += chunk; });
      child.on('exit', (code) => resolve({ code, out }));
    });
    const started = await run(['--start', '--payload', payloadPath, '--no-open', '--key', 'leak', '--timeout', '1']);
    assert.equal(started.code, 0, started.out);
    const url = started.out.match(/QUESTION URL: (\S+)/)?.[1];
    const deadline = Date.now() + 8000;
    let gone = false;
    while (Date.now() < deadline && !gone) {
      await new Promise((r) => setTimeout(r, 500));
      try { await fetch(url); } catch { gone = true; }
    }
    assert.ok(gone, 'with no heartbeat ever, the daemon still exits at --timeout');
  });

  it('an unparseable or negative --timeout takes the default instead of disarming the no-page exit', async () => {
    const dir = mkdtempSync(path.join(tmpdir(), 'serve-question-'));
    const payloadPath = path.join(dir, 'q.json');
    writeFileSync(payloadPath, JSON.stringify(PAYLOAD));
    const run = (args) => new Promise((resolve) => {
      const child = spawn(process.execPath, [SCRIPT, ...args], { cwd: dir, stdio: ['ignore', 'pipe', 'ignore'] });
      let out = '';
      child.stdout.on('data', (chunk) => { out += chunk; });
      child.on('exit', (code) => resolve({ code, out }));
    });
    // NaN used to flow into the lifetime timer, where timeoutSec > 0 is false
    // and the no-page exit never fires: a daemon nothing would ever reclaim.
    // The clamped value is observable in the detached daemon's own argv.
    const started = await run(['--start', '--payload', payloadPath, '--no-open', '--key', 'clamp', '--timeout', 'bogus']);
    assert.equal(started.code, 0, started.out);
    try {
      const state = JSON.parse(readFileSync(path.join(dir, '.impeccable', 'questions', 'clamp.state.json'), 'utf8'));
      const argv = execSync(`ps -ww -o args= -p ${state.pid}`).toString();
      assert.match(argv, /--timeout 900/, 'the daemon runs with the clamped default, not NaN');
    } finally {
      await run(['--stop', '--key', 'clamp']);
    }
  });

  it('--timeout 0 waits for a page forever, but a page that beat and went silent still ends the daemon', async () => {
    const dir = mkdtempSync(path.join(tmpdir(), 'serve-question-'));
    const payloadPath = path.join(dir, 'q.json');
    writeFileSync(payloadPath, JSON.stringify(PAYLOAD));
    const run = (args) => new Promise((resolve) => {
      const child = spawn(process.execPath, [SCRIPT, ...args], { cwd: dir, stdio: ['ignore', 'pipe', 'ignore'] });
      let out = '';
      child.stdout.on('data', (chunk) => { out += chunk; });
      child.on('exit', (code) => resolve({ code, out }));
    });
    const started = await run(['--start', '--payload', payloadPath, '--no-open', '--key', 'zero', '--timeout', '0', '--idle-grace', '3']);
    assert.equal(started.code, 0, started.out);
    const url = started.out.match(/QUESTION URL: (\S+)/)?.[1];
    assert.ok(url, started.out);
    // No page yet: --timeout 0 means wait indefinitely, so the daemon must
    // survive well past where any small timeout would have fired.
    await new Promise((r) => setTimeout(r, 3000));
    const alive = await fetch(url);
    assert.equal(alive.status, 200, 'with --timeout 0 and no page yet, the daemon keeps waiting');
    // One beat, then silence: the idle grace must still reclaim the daemon.
    // Before the fix, the whole lifetime check sat inside timeoutSec > 0 and
    // a closed tab leaked this daemon forever.
    await fetch(`${url}heartbeat`, { method: 'POST' });
    const deadline = Date.now() + 12000;
    let gone = false;
    while (Date.now() < deadline && !gone) {
      await new Promise((r) => setTimeout(r, 500));
      try { await fetch(url); } catch { gone = true; }
    }
    assert.ok(gone, 'the idle grace applies under --timeout 0 once a page has beat');
  });

  it('a hand delivered just before the idle deadline holds the daemon for its claim window', async () => {
    const dir = mkdtempSync(path.join(tmpdir(), 'serve-question-'));
    const payloadPath = path.join(dir, 'q.json');
    writeFileSync(payloadPath, JSON.stringify(PAYLOAD));
    const run = (args) => new Promise((resolve) => {
      const child = spawn(process.execPath, [SCRIPT, ...args], { cwd: dir, stdio: ['ignore', 'pipe', 'ignore'] });
      let out = '';
      child.stdout.on('data', (chunk) => { out += chunk; });
      child.on('exit', (code) => resolve({ code, out }));
    });
    const started = await run(['--start', '--payload', payloadPath, '--no-open', '--key', 'latehand', '--timeout', '30', '--idle-grace', '3']);
    assert.equal(started.code, 0, started.out);
    const url = started.out.match(/QUESTION URL: (\S+)/)?.[1];
    assert.ok(url, started.out);
    try {
      await fetch(`${url}heartbeat`, { method: 'POST' });
      await fetch(`${url}answer`, { method: 'POST', headers: { 'content-type': 'application/json' }, body: JSON.stringify({ optionId: 'reroll', steer: '' }) });
      // Go silent like a stalled page until just before the 3s idle
      // deadline, then deliver: the daemon used to exit before the page's
      // watch could claim the hand, orphaning a delivery --update had
      // already confirmed.
      await new Promise((r) => setTimeout(r, 2500));
      const nextPath = path.join(dir, 'next.json');
      writeFileSync(nextPath, JSON.stringify({ ...PAYLOAD, title: 'Late round' }));
      const updated = await run(['--update', '--key', 'latehand', '--payload', nextPath]);
      assert.equal(updated.code, 0, updated.out);
      await new Promise((r) => setTimeout(r, 3000));
      const served = await (await fetch(url)).text();
      assert.ok(served.includes('Late round'), 'past the idle deadline, the daemon survives its claim window and deals the delivered hand');
      // The claim itself must hold the daemon too: that GET deleted the next
      // file before any page could beat, so a lifetime tick in the gap used
      // to exit under the hand just claimed.
      await new Promise((r) => setTimeout(r, 2500));
      const alive = await fetch(url);
      assert.equal(alive.status, 200, 'the daemon survives the claim-to-first-beat gap');
    } finally {
      await run(['--stop', '--key', 'latehand']);
    }
  });

  it('a refresh while a re-roll is outstanding re-enters the wait instead of re-serving the answered round', async () => {
    const dir = mkdtempSync(path.join(tmpdir(), 'serve-question-'));
    const payloadPath = path.join(dir, 'q.json');
    writeFileSync(payloadPath, JSON.stringify(PAYLOAD));
    const run = (args) => new Promise((resolve) => {
      const child = spawn(process.execPath, [SCRIPT, ...args], { cwd: dir, stdio: ['ignore', 'pipe', 'ignore'] });
      let out = '';
      child.stdout.on('data', (chunk) => { out += chunk; });
      child.on('exit', (code) => resolve({ code, out }));
    });
    const started = await run(['--start', '--payload', payloadPath, '--no-open', '--key', 'refresh', '--timeout', '30']);
    assert.equal(started.code, 0, started.out);
    const url = started.out.match(/QUESTION URL: (\S+)/)?.[1];
    assert.ok(url, started.out);
    try {
      const before = await (await fetch(url)).text();
      assert.ok(!before.includes('awaitNextRound(false,'), 'a fresh round serves the normal page');
      // A native refresh bypasses the page's own gated Reload button, so the
      // serving decision has to live here: once a re-roll answer is collected
      // and no replacement has landed, GET / re-enters the bounded shuffle
      // wait instead of re-serving the answered cards.
      await fetch(`${url}answer`, { method: 'POST', headers: { 'content-type': 'application/json' }, body: JSON.stringify({ optionId: 'reroll', steer: '' }) });
      const waitingPage = await (await fetch(url)).text();
      assert.ok(waitingPage.includes('awaitNextRound(false,'), 'a refresh mid re-roll re-enters the shuffle wait');
      const nextPath = path.join(dir, 'next.json');
      writeFileSync(nextPath, JSON.stringify({ ...PAYLOAD, title: 'Second round' }));
      const updated = await run(['--update', '--key', 'refresh', '--payload', nextPath]);
      assert.equal(updated.code, 0, updated.out);
      const after = await (await fetch(url)).text();
      assert.ok(after.includes('Second round'), 'the delivered hand is served');
      assert.ok(!after.includes('awaitNextRound(false,'), 'the wait ends once the hand lands');
    } finally {
      await run(['--stop', '--key', 'refresh']);
    }
  });

  it('a refresh cannot renew the delivery deadline: the waiting page inherits what remains and serves stalled and silent once it is spent', async () => {
    const dir = mkdtempSync(path.join(tmpdir(), 'serve-question-'));
    const payloadPath = path.join(dir, 'q.json');
    writeFileSync(payloadPath, JSON.stringify(PAYLOAD));
    const run = (args) => new Promise((resolve) => {
      const child = spawn(process.execPath, [SCRIPT, ...args], { cwd: dir, stdio: ['ignore', 'pipe', 'ignore'] });
      let out = '';
      child.stdout.on('data', (chunk) => { out += chunk; });
      child.on('exit', (code) => resolve({ code, out }));
    });
    const started = await run(['--start', '--payload', payloadPath, '--no-open', '--key', 'deadline', '--timeout', '30', '--idle-grace', '3']);
    assert.equal(started.code, 0, started.out);
    const url = started.out.match(/QUESTION URL: (\S+)/)?.[1];
    assert.ok(url, started.out);
    try {
      await fetch(`${url}answer`, { method: 'POST', headers: { 'content-type': 'application/json' }, body: JSON.stringify({ optionId: 'reroll', steer: '' }) });
      const fresh = await (await fetch(url)).text();
      const budget = Number(fresh.match(/awaitNextRound\(false, (\d+)\);/)?.[1]);
      assert.ok(budget > 0 && budget <= 3000, `the waiting page carries the remaining allowance, got ${budget}`);
      assert.match(fresh, /^\s*beat\(\);\s*$/m, 'a live wait still heartbeats');
      // A duplicate answer must not restamp the deadline either: the page's
      // click-time disable can race a second click, so the server keeps the
      // first stamp instead of renewing the allowance.
      await new Promise((r) => setTimeout(r, 1200));
      await fetch(`${url}answer`, { method: 'POST', headers: { 'content-type': 'application/json' }, body: JSON.stringify({ optionId: 'reroll', steer: '' }) });
      const restamped = Number((await (await fetch(url)).text()).match(/awaitNextRound\(false, (\d+)\);/)?.[1]);
      assert.ok(restamped > 0 && restamped < 2500, `a duplicate re-roll does not renew the allowance, got ${restamped}`);
      await new Promise((r) => setTimeout(r, 3500));
      const spent = await (await fetch(url)).text();
      assert.ok(spent.includes('awaitNextRound(false, 0);'), 'a refresh after the deadline gets no new allowance');
      assert.ok(!/^\s*beat\(\);\s*$/m.test(spent), 'an expired wait never starts the heartbeat');
    } finally {
      await run(['--stop', '--key', 'deadline']);
    }
  });

  it('an unloadable next hand fails at --update, and one already on disk is discarded instead of reload-looping', async () => {
    const dir = mkdtempSync(path.join(tmpdir(), 'serve-question-'));
    const payloadPath = path.join(dir, 'q.json');
    writeFileSync(payloadPath, JSON.stringify(PAYLOAD));
    const run = (args) => new Promise((resolve) => {
      const child = spawn(process.execPath, [SCRIPT, ...args], { cwd: dir, stdio: ['ignore', 'pipe', 'pipe'] });
      let out = '';
      child.stdout.on('data', (chunk) => { out += chunk; });
      child.stderr.on('data', (chunk) => { out += chunk; });
      child.on('exit', (code) => resolve({ code, out }));
    });
    const started = await run(['--start', '--payload', payloadPath, '--no-open', '--key', 'badhand', '--timeout', '30']);
    assert.equal(started.code, 0, started.out);
    const url = started.out.match(/QUESTION URL: (\S+)/)?.[1];
    assert.ok(url, started.out);
    try {
      const badPath = path.join(dir, 'bad.json');
      writeFileSync(badPath, JSON.stringify({ title: 'No options' }));
      const rejected = await run(['--update', '--key', 'badhand', '--payload', badPath]);
      assert.equal(rejected.code, 1, rejected.out);
      assert.match(rejected.out, /options array/, 'the sender hears why the hand was refused');
      // A bad file that reaches the disk anyway must not trap the page:
      // GET / discards it, so /next-status stops reporting a hand that can
      // never render and the bounded wait resumes instead of reload-looping.
      await fetch(`${url}answer`, { method: 'POST', headers: { 'content-type': 'application/json' }, body: JSON.stringify({ optionId: 'reroll', steer: '' }) });
      writeFileSync(path.join(dir, '.impeccable', 'questions', 'badhand.next.json'), JSON.stringify({ title: 'No options' }));
      const page = await (await fetch(url)).text();
      assert.ok(page.includes('awaitNextRound(false,'), 'the round stays in the wait');
      const status = await (await fetch(`${url}next-status`)).json();
      assert.equal(status.ready, false, 'the unloadable hand left the disk');
    } finally {
      await run(['--stop', '--key', 'badhand']);
    }
  });

  it('--wait does not conclude PAGE CLOSED while a delivered next hand sits unclaimed', async () => {
    const dir = mkdtempSync(path.join(tmpdir(), 'serve-question-'));
    const payloadPath = path.join(dir, 'q.json');
    writeFileSync(payloadPath, JSON.stringify(PAYLOAD));
    const run = (args) => new Promise((resolve) => {
      const child = spawn(process.execPath, [SCRIPT, ...args], { cwd: dir, stdio: ['ignore', 'pipe', 'ignore'] });
      let out = '';
      child.stdout.on('data', (chunk) => { out += chunk; });
      child.on('exit', (code) => resolve({ code, out }));
    });
    const started = await run(['--start', '--payload', payloadPath, '--no-open', '--key', 'silent', '--timeout', '30']);
    assert.equal(started.code, 0, started.out);
    const url = started.out.match(/QUESTION URL: (\S+)/)?.[1];
    assert.ok(url, started.out);
    try {
      await fetch(`${url}answer`, { method: 'POST', headers: { 'content-type': 'application/json' }, body: JSON.stringify({ optionId: 'reroll', steer: '' }) });
      const collected = await run(['--wait', '--key', 'silent', '--poll', '2']);
      assert.equal(collected.code, 0, collected.out);
      // The stalled page went silent by design: fake a beat older than the
      // 15s page-closed threshold, then deliver the hand late.
      const statePath = path.join(dir, '.impeccable', 'questions', 'silent.state.json');
      const state = JSON.parse(readFileSync(statePath, 'utf8'));
      state.lastBeat = Date.now() - 20000;
      writeFileSync(statePath, JSON.stringify(state));
      const nextPath = path.join(dir, 'next.json');
      writeFileSync(nextPath, JSON.stringify(PAYLOAD));
      // The delivery clock must be --update's own stamp, never the source
      // payload's: an old file delivered now still opens a full grace.
      const staleSource = new Date(Date.now() - 60000);
      utimesSync(nextPath, staleSource, staleSource);
      const updated = await run(['--update', '--key', 'silent', '--payload', nextPath]);
      assert.equal(updated.code, 0, updated.out);
      // Mid-delivery, the silence is the stall's, not a closed tab's: the
      // page's watch reloads into the hand and beats again. --wait must keep
      // waiting instead of routing the agent away from the open browser.
      const waiting = await run(['--wait', '--key', 'silent', '--poll', '2']);
      assert.equal(waiting.code, 3, `mid-delivery silence stays WAITING, got: ${waiting.out}`);
      // The suppression is age-bound: a hand nobody claimed within the grace
      // means the page is gone, and the delivered file must not mask that.
      const nextOnDisk = path.join(dir, '.impeccable', 'questions', 'silent.next.json');
      const aged = new Date(Date.now() - 20000);
      utimesSync(nextOnDisk, aged, aged);
      const masked = await run(['--wait', '--key', 'silent', '--poll', '2']);
      assert.equal(masked.code, 4, `an unclaimed stale delivery reads as a closed page, got: ${masked.out}`);
      // With no hand pending at all, the same stale beat also means closed.
      rmSync(nextOnDisk);
      const closed = await run(['--wait', '--key', 'silent', '--poll', '5']);
      assert.equal(closed.code, 4, closed.out);
    } finally {
      await run(['--stop', '--key', 'silent']);
    }
  });

  it('a claimed hand\'s reload gap must not read as a closed page', async () => {
    const dir = mkdtempSync(path.join(tmpdir(), 'serve-question-'));
    const payloadPath = path.join(dir, 'q.json');
    writeFileSync(payloadPath, JSON.stringify(PAYLOAD));
    const run = (args) => new Promise((resolve) => {
      const child = spawn(process.execPath, [SCRIPT, ...args], { cwd: dir, stdio: ['ignore', 'pipe', 'ignore'] });
      let out = '';
      child.stdout.on('data', (chunk) => { out += chunk; });
      child.on('exit', (code) => resolve({ code, out }));
    });
    const started = await run(['--start', '--payload', payloadPath, '--no-open', '--key', 'claimgap', '--timeout', '30']);
    assert.equal(started.code, 0, started.out);
    const url = started.out.match(/QUESTION URL: (\S+)/)?.[1];
    assert.ok(url, started.out);
    try {
      await fetch(`${url}answer`, { method: 'POST', headers: { 'content-type': 'application/json' }, body: JSON.stringify({ optionId: 'reroll', steer: '' }) });
      const collected = await run(['--wait', '--key', 'claimgap', '--poll', '2']);
      assert.equal(collected.code, 0, collected.out);
      const statePath = path.join(dir, '.impeccable', 'questions', 'claimgap.state.json');
      const state = JSON.parse(readFileSync(statePath, 'utf8'));
      state.lastBeat = Date.now() - 20000;
      writeFileSync(statePath, JSON.stringify(state));
      const nextPath = path.join(dir, 'next.json');
      writeFileSync(nextPath, JSON.stringify({ ...PAYLOAD, title: 'Claimed round' }));
      const updated = await run(['--update', '--key', 'claimgap', '--payload', nextPath]);
      assert.equal(updated.code, 0, updated.out);
      // The claim deletes the next file --wait's mid-delivery grace watches,
      // and the reloading page has not beat yet: --wait used to read the
      // stale beat as PAGE CLOSED while the daemon served the dealt round.
      const served = await (await fetch(url)).text();
      assert.ok(served.includes('Claimed round'), 'the GET claims the delivered hand');
      const waiting = await run(['--wait', '--key', 'claimgap', '--poll', '2']);
      assert.equal(waiting.code, 3, `the claim gap stays WAITING, got: ${waiting.out}`);
      // Bounded like the delivery grace: a claim nobody followed with a beat
      // still reads as the closed page it is.
      const aged = JSON.parse(readFileSync(statePath, 'utf8'));
      aged.claimedAt = Date.now() - 20000;
      writeFileSync(statePath, JSON.stringify(aged));
      const closed = await run(['--wait', '--key', 'claimgap', '--poll', '2']);
      assert.equal(closed.code, 4, `a claim nobody resumed reads as closed, got: ${closed.out}`);
    } finally {
      await run(['--stop', '--key', 'claimgap']);
    }
  });

  it('--update trusts a fresh heartbeat over a failed kill probe, and still detects true death', async () => {
    const dir = mkdtempSync(path.join(tmpdir(), 'serve-question-'));
    const qdir = path.join(dir, '.impeccable', 'questions');
    const { mkdirSync } = await import('node:fs');
    mkdirSync(qdir, { recursive: true });
    const nextPath = path.join(dir, 'next.json');
    writeFileSync(nextPath, JSON.stringify(PAYLOAD));
    const run = (key) => new Promise((resolve) => {
      const child = spawn(process.execPath, [SCRIPT, '--update', '--key', key, '--payload', nextPath], { cwd: dir, stdio: 'ignore' });
      child.on('exit', resolve);
    });
    // Fresh heartbeat + a pid the sandbox cannot signal (pid 1 throws EPERM):
    // --update is the documented re-roll delivery step, so a false "no live
    // server" here strands the page mid-shuffle. Must deliver, exit 0.
    writeFileSync(path.join(qdir, 'upbeat.state.json'), JSON.stringify({ pid: 1, port: 1, url: 'http://127.0.0.1:1/', lastBeat: Date.now() }));
    assert.equal(await run('upbeat'), 0, 'fresh heartbeat must read as alive regardless of the kill probe');
    assert.ok(existsSync(path.join(qdir, 'upbeat.next.json')), 'the next hand landed');
    // Stale heartbeat + a genuinely dead pid: exit 2, nothing delivered.
    writeFileSync(path.join(qdir, 'updead.state.json'), JSON.stringify({ pid: 999999999 >>> 8, port: 1, url: 'http://127.0.0.1:1/' }));
    assert.equal(await run('updead'), 2, 'a truly missing process must still read as gone');
    assert.ok(!existsSync(path.join(qdir, 'updead.next.json')), 'no hand is delivered to a dead server');
  });

  it('renders anatomy, streams late comps, and returns the chosen comp', async () => {
    const dir = mkdtempSync(path.join(tmpdir(), 'serve-question-'));
    const compPath = path.join(dir, 'comps', 'assigned.webp');
    const payload = {
      title: 'Choose the visual world',
      options: [
        {
          id: 'assigned', label: 'Fillmore Handbill', kicker: 'THE ROLL',
          thesis: 'The gig poster idea.', palette: ['#e8452c', '#f5d64c'], materials: ['letterpress'],
          viewport: 'Full-bleed dated bill.', risk: 'Nostalgia trap.',
          // The legacy key: a payload authored against the sketch-era schema
          // must keep rendering, so the lead card declares its comp as `sketch`.
          sketch: compPath, hero: 'https://impeccable.style/worlds/cards/x-hero.webp',
        },
        { id: 'challenger-1', label: 'Teletext Service', case: 'Fuses cleanly.' },
      ],
      reroll: true,
      canon: true,
      canonCard: { label: 'The category standard', thesis: 'What the category ships.' },
      steer: true,
      followup: true,
    };
    const { child, url, read } = await startServer(payload);
    const html = await (await fetch(url)).text();
    // Anatomy renders: chips, tags, fact labels, thesis.
    assert.match(html, /swatches/);
    // A blocking server has no update channel, so even a followup payload
    // must not arm the page's loading-hand path (detached mode arms it; the
    // new-work e2e suite covers that side).
    assert.match(html, /const FOLLOWUP = false/);
    assert.match(html, /background:#e8452c/);
    assert.match(html, /class="tag">letterpress/);
    assert.match(html, /The gig poster idea\./);
    assert.match(html, /Fuses cleanly\./);
    // The inspiration image rides picture-in-picture beside the comp slot.
    assert.match(html, /class="pip"/);
    assert.match(html, /media comp-pending/);
    // canonCard renders as a subordinate card and suppresses the footer action.
    assert.match(html, /card canon/);
    assert.match(html, /Play it straight</);
    assert.doesNotMatch(html, /<button id="canon"/);
    // The comp slot 404s until the file lands, then serves it.
    const slot = html.match(/data-comp="(\/img\/\d+)"/)?.[1];
    assert.ok(slot, 'comp slot registered before the file exists');
    assert.equal((await fetch(url.replace(/\/$/, '') + slot)).status, 404);
    const { mkdirSync } = await import('node:fs');
    mkdirSync(path.dirname(compPath), { recursive: true });
    writeFileSync(compPath, 'RIFFxxxxWEBP');
    assert.equal((await fetch(url.replace(/\/$/, '') + slot)).status, 200);
    // The page polls with a cache-busting query; the route must tolerate it.
    assert.equal((await fetch(url.replace(/\/$/, '') + slot + '?t=1')).status, 200);
    // The answer carries the chosen card's comp for comp seeding, under the
    // canonical key even when the payload declared it with the legacy one.
    await fetch(`${url}answer`, {
      method: 'POST',
      headers: { 'content-type': 'application/json' },
      body: JSON.stringify({ optionId: 'assigned', steer: '' }),
    });
    const code = await new Promise((resolve) => child.on('exit', resolve));
    assert.equal(code, 0);
    assert.match(read(), /"comp":/);
    assert.match(read(), /CHOSEN COMP:/);
  });
});