mirror of
https://github.com/pbakaus/impeccable.git
synced 2026-09-11 21:57:14 +03:00
Paul BakausandClaude
c654acb005
Comparing this branch's live against main's turned up two whole features that never made sense here. -2,466 lines. 1. The isolated source-artifact preview was never switched on. `scaffoldSourceArtifactSession` is only reachable via live-wrap's `--isolated`, and nothing passes it: not the server's preflight, not live.md, nothing. Proved it end-to-end — the default wrap writes markers straight into real source and creates no previews/ session. So the mode was wired through three modules, carried its own accept/discard branches, browser branches, server metadata resolution, preview-mode classifier entry, and test suites, and none of it could run. Worse, live.md documented it as the active path and told the agent "The true source is only the publisher's hash fence and must remain byte-identical until Accept." That is false: the wrapper lands in source at scaffold time and each revision rewrites it. An agent following that sentence believes source is protected when it isn't, and the leftover artifacts are what made accept resolve the wrong file in the first real run. live.md now describes what actually happens, including that markers are visible in source until Accept or Discard. Removed: source-artifact.mjs, --isolated, the preflight's isolated option, the accept/discard branches, four dead browser branches, the server's previews/ resolution, the classifier entry, and their tests. Kept the previews/ gitignore pattern: an ignore line for a directory that cannot exist is free, and a test pins it. 2. Quality judging belongs to the private evals repo, which says so. runner/live/README.md there is explicit: the public repo owns protocol correctness, framework coverage, timing, source commit, recovery, and a rubric-free evidence bundle; the private repo owns the task corpus, baselines, comparative judges, and release-quality decisions — "Do not add quality rubrics, competitor comparisons, or broad fixture corpora to the public Live benchmark." This branch added exactly those: an LLM judge scoring 1-10 on "off-brand, generic-AI" (live-rendered-quality.mjs, judge-live-rendered.mjs), a cross-provider comparison with a BRAND_CONTRACT rubric (live-provider-benchmark .mjs, benchmark-live-providers.mjs), and a brand-fidelity fixture corpus. All removed, with bench:live:providers and their suite entries. Also removed tests/framework-fixtures/README.md's "External quality-eval fixtures" section: it documented a bench:live workflow using --fixture-dir, --agent=codex, --action and --evidence-bundle, none of which benchmark-live.mjs implements, plus an evidenceCapture block nothing reads. Kept: timing benchmarks (the public repo's half of that boundary), progressive publication, the source lock, poll lanes, and Nuxt/Vue component previews. Coverage note: deleting the isolated suites took the only tests for `source_locked` classification with them, so the plain wrapper path — now the only non-component preview — gets equivalent accept and discard coverage. Both new tests fail if mode:'error' is removed. Prepared with AI assistance under maintainer direction. Co-Authored-By: Claude <noreply@anthropic.com>
30 lines
1.4 KiB
JavaScript
30 lines
1.4 KiB
JavaScript
// A preview whose variants live in component modules rather than in the user's
|
|
// source. These leave no markers in the real file, so a failed accept gives the
|
|
// agent nothing to hand-edit and must be reported as a failure rather than
|
|
// reference/live.md's manual-cleanup handoff. Previously only `svelte-component`
|
|
// was special-cased, so the same failure on a Vue preview read as success.
|
|
const PREVIEW_MODES_WITHOUT_SOURCE_MARKERS = new Set([
|
|
'svelte-component',
|
|
'vue-component',
|
|
]);
|
|
|
|
export function completionTypeForAcceptResult(eventType, acceptResult) {
|
|
if (eventType === 'discard') return acceptResult?.handled === true ? 'discarded' : 'error';
|
|
if (acceptResult?.handled === true && acceptResult?.carbonize === true) return 'agent_done';
|
|
if (acceptResult?.handled === true) return 'complete';
|
|
if (acceptResult?.mode === 'error') return 'error';
|
|
if (eventType === 'accept' && PREVIEW_MODES_WITHOUT_SOURCE_MARKERS.has(acceptResult?.previewMode)) return 'error';
|
|
return 'agent_done';
|
|
}
|
|
|
|
export function completionAckForAcceptResult(eventId, completionType, acceptResult) {
|
|
const ack = { ok: true, type: completionType };
|
|
if (acceptResult?.handled === true && acceptResult?.carbonize === true) {
|
|
ack.final = false;
|
|
ack.requiresComplete = true;
|
|
ack.nextCommand = `live-complete.mjs --id ${eventId}`;
|
|
ack.message = 'Carbonize cleanup must be verified, then the session must be completed explicitly before polling again.';
|
|
}
|
|
return ack;
|
|
}
|