mirror of
https://github.com/pbakaus/impeccable.git
synced 2026-09-12 06:06:37 +03:00
Paul BakausandClaude Code
17dabf4b7e
A ground-up hardening of live mode, driven by a production session in a nested-app monorepo that hit six distinct failure classes. Full design rationale in docs/LIVE-REWRITE-PLAN.md; every Codex-reported failure now has a mechanical fix and a regression test. Roots: live/roots.mjs resolves appRoot/repoRoot/contextRoot once at boot (keyed on dev-server configs, not monorepo brand markers), persists a manifest, and every live CLI re-anchors onto it at startup, so a helper run from the wrong directory can no longer fork session state. Context files are discovered upward to the git root. Render truth: variant_mounted / variant_mount_failed events give the journal per-variant mount state; failures reach the agent's poll queue, raise a persistent error card with Retry (no more localStorage wipe), and an attach probe names root/dev-server mismatches explicitly. The browser rehydrates from the server when localStorage is gone. Svelte: the scaffolder now parses with the app's own svelte 5 compiler. Control flow survives (an each collection crosses the contract as one structured prop), keyed each blocks hydrate synthetic keys, and anything a detached preview cannot support falls back to source-preview instead of shipping a wrong scaffold. Preview modules live in per-publish revision directories, defeating stale transform caches. Accept: CSS is reconciled, not appended. Matching selectors are replaced, params bake from params.json kinds, the compiler's unused-selector pass prunes superseded rules (pre-existing dead rules protected), a selector- loss postcondition refuses any write that would drop hand-written rules, and live-complete refuses to finish while live plumbing remains in source. Also: framework registry (live/frameworks/) with a crash-safe injection journal, session-store snapshot caching with read-only reads, protocol enum consolidation, steer Send button, honest DESIGN-panel empty states. Testing: new unit suites (roots, AST scaffolder, accept CSS, accept pipeline, framework conformance); e2e now fails on preview-tree 404s, proves computed-style mount for every variant, drives the Tune panel through baked params, and injects failures (broken mounts, republish, storage loss). New runtime fixtures: monorepo-nested-vite (repo root != app root) and vite8-sveltekit-stateful (each blocks + state). Nightly full-matrix cron. An independent adversarial review pass preceded this commit; its blocker and major findings are fixed and regression-tested. This work was produced with AI assistance (Claude Code). Co-Authored-By: Claude Code <noreply@anthropic.com>
56 lines
2.3 KiB
JavaScript
56 lines
2.3 KiB
JavaScript
/**
|
|
* Postcondition scanner for accepted/carbonized source. The carbonize
|
|
* contract used to exist only as prose in reference/live.md; nothing checked
|
|
* that an accept actually left the file clean, so dead param branches,
|
|
* preview attributes, and marker comments accumulated across sessions. This
|
|
* scanner is the mechanical form of that contract. live-complete refuses to
|
|
* mark a carbonize session complete while the file is dirty, and the
|
|
* mechanical Svelte accept runs it on its own output as a self-check.
|
|
*/
|
|
|
|
const FORBIDDEN = [
|
|
{ marker: 'impeccable-variants-start', why: 'variant wrapper comment left in source' },
|
|
{ marker: 'impeccable-variants-end', why: 'variant wrapper comment left in source' },
|
|
{ marker: 'impeccable-carbonize-start', why: 'carbonize block not rewritten into permanent form' },
|
|
{ marker: 'impeccable-carbonize-end', why: 'carbonize block not rewritten into permanent form' },
|
|
{ marker: 'impeccable-param-values', why: 'param-values comment not baked and removed' },
|
|
{ marker: 'data-impeccable-', why: 'live-mode plumbing attribute left on markup' },
|
|
{ marker: 'data-p-', why: 'preview parameter attribute left on markup' },
|
|
{ marker: 'var(--p-', why: 'preview parameter variable not baked to a literal' },
|
|
{ marker: '--impeccable-variant-ready', why: 'preview readiness sentinel left in CSS' },
|
|
];
|
|
|
|
/**
|
|
* Scan file text for live-mode leftovers. Returns { clean, findings } where
|
|
* each finding is { marker, line, excerpt, why }.
|
|
*/
|
|
export function verifyAcceptedSource(text) {
|
|
const findings = [];
|
|
const lines = String(text || '').split('\n');
|
|
for (let i = 0; i < lines.length; i++) {
|
|
const line = lines[i];
|
|
for (const { marker, why } of FORBIDDEN) {
|
|
if (line.includes(marker)) {
|
|
findings.push({
|
|
marker,
|
|
line: i + 1,
|
|
excerpt: line.trim().slice(0, 120),
|
|
why,
|
|
});
|
|
}
|
|
}
|
|
}
|
|
return { clean: findings.length === 0, findings };
|
|
}
|
|
|
|
/** Convenience wrapper for CLI callers: read + scan, tolerating a missing file. */
|
|
export function verifyAcceptedFile(fs, filePath) {
|
|
let text;
|
|
try {
|
|
text = fs.readFileSync(filePath, 'utf-8');
|
|
} catch {
|
|
return { clean: true, findings: [], missing: true };
|
|
}
|
|
return { ...verifyAcceptedSource(text), missing: false };
|
|
}
|