mirror of
https://github.com/pbakaus/impeccable.git
synced 2026-09-11 21:57:14 +03:00
1a3f588c71
* Fix: skip POSIX hook guard on Windows installs (#452) PowerShell rejects the `[ ! -f ... ] ||` guard at parse time, so Codex hooks generated by `npx impeccable install` on Windows never ran. Emit the direct `node "PATH"` invocation there; POSIX output is unchanged. AI-assisted (Cursor). Co-authored-by: Cursor <cursoragent@cursor.com> * Keep the missing-file no-op in Windows-generated hook commands Greptile review on #453: project hook manifests are committable, so a bare `node "PATH"` written on Windows loses the silent no-op when a POSIX teammate without the skill consumes it. Replace the bare form with a shell-agnostic `node -e` existence guard that parses in PowerShell, cmd.exe, and sh, and forwards the hook's exit code. AI-assisted (Cursor). Co-authored-by: Cursor <cursoragent@cursor.com> * Use Codex's commandWindows field for the Windows hook guard Per @PatrickSys on #452: Codex runs hooks through COMSPEC (cmd.exe /C), not PowerShell, and 0.146.0+ selects a commandWindows manifest field on Windows. Codex entries now always carry the POSIX guard in command plus an `if exist` cmd.exe guard in commandWindows (his Windows-tested form), so one .codex/hooks.json is correct on every OS regardless of where the install ran. Claude/Cursor keep the node -e wrapper on Windows installs since their manifests have no per-platform field. AI-assisted (Cursor). Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>