mirror of
https://github.com/pbakaus/impeccable.git
synced 2026-09-12 22:26:38 +03:00
Paul BakausandClaude Code
17dabf4b7e
A ground-up hardening of live mode, driven by a production session in a nested-app monorepo that hit six distinct failure classes. Full design rationale in docs/LIVE-REWRITE-PLAN.md; every Codex-reported failure now has a mechanical fix and a regression test. Roots: live/roots.mjs resolves appRoot/repoRoot/contextRoot once at boot (keyed on dev-server configs, not monorepo brand markers), persists a manifest, and every live CLI re-anchors onto it at startup, so a helper run from the wrong directory can no longer fork session state. Context files are discovered upward to the git root. Render truth: variant_mounted / variant_mount_failed events give the journal per-variant mount state; failures reach the agent's poll queue, raise a persistent error card with Retry (no more localStorage wipe), and an attach probe names root/dev-server mismatches explicitly. The browser rehydrates from the server when localStorage is gone. Svelte: the scaffolder now parses with the app's own svelte 5 compiler. Control flow survives (an each collection crosses the contract as one structured prop), keyed each blocks hydrate synthetic keys, and anything a detached preview cannot support falls back to source-preview instead of shipping a wrong scaffold. Preview modules live in per-publish revision directories, defeating stale transform caches. Accept: CSS is reconciled, not appended. Matching selectors are replaced, params bake from params.json kinds, the compiler's unused-selector pass prunes superseded rules (pre-existing dead rules protected), a selector- loss postcondition refuses any write that would drop hand-written rules, and live-complete refuses to finish while live plumbing remains in source. Also: framework registry (live/frameworks/) with a crash-safe injection journal, session-store snapshot caching with read-only reads, protocol enum consolidation, steer Send button, honest DESIGN-panel empty states. Testing: new unit suites (roots, AST scaffolder, accept CSS, accept pipeline, framework conformance); e2e now fails on preview-tree 404s, proves computed-style mount for every variant, drives the Tune panel through baked params, and injects failures (broken mounts, republish, storage loss). New runtime fixtures: monorepo-nested-vite (repo root != app root) and vite8-sveltekit-stateful (each blocks + state). Nightly full-matrix cron. An independent adversarial review pass preceded this commit; its blocker and major findings are fixed and regression-tested. This work was produced with AI assistance (Claude Code). Co-Authored-By: Claude Code <noreply@anthropic.com>
48 lines
1.7 KiB
JavaScript
48 lines
1.7 KiB
JavaScript
/**
|
|
* Astro registry entry.
|
|
*
|
|
* Astro takes the generic tag strategy, with two Astro-specific values that
|
|
* used to sit as inline `endsWith('.astro')` branches in live-inject.mjs and
|
|
* live-wrap.mjs:
|
|
*
|
|
* injectScriptAttrs Astro processes <script> tags by default and rewrites
|
|
* src to its own bundled URL; is:inline opts out.
|
|
* styleMode Astro scopes component styles, which strips preview CSS
|
|
* off the generated variant wrappers, so preview rules are
|
|
* authored global and prefixed instead of @scope'd.
|
|
*/
|
|
|
|
import { findConfigFile, hasAnyDependency, literalConfigFiles } from './detect-utils.mjs';
|
|
|
|
const ASTRO_CONFIG_RE = /^astro\.config\.(?:js|mjs|cjs|ts|mts|cts)$/;
|
|
|
|
export function detectAstroProject(cwd = process.cwd(), config = null) {
|
|
const configFile = findConfigFile(cwd, ASTRO_CONFIG_RE);
|
|
if (configFile) return { configFile, via: 'config' };
|
|
if (hasAnyDependency(cwd, ['astro'])) return { configFile: null, via: 'package' };
|
|
// A tree of .astro entry templates with no astro.config still belongs to
|
|
// Astro; the configured injection target names it.
|
|
const entry = literalConfigFiles(cwd, config).find((rel) => rel.endsWith('.astro'));
|
|
if (entry) return { configFile: null, via: 'config-files', entry };
|
|
return null;
|
|
}
|
|
|
|
export const astro = {
|
|
name: 'astro',
|
|
|
|
detect(cwd, config) {
|
|
return detectAstroProject(cwd, config);
|
|
},
|
|
|
|
inject: { kind: 'tag' },
|
|
|
|
source: {
|
|
extensions: ['.astro'],
|
|
preview: 'source',
|
|
styleMode: 'astro-global-prefixed',
|
|
styleTag: '<style is:inline data-impeccable-css="SESSION_ID">',
|
|
commentSyntax: 'html',
|
|
injectScriptAttrs: 'is:inline ',
|
|
},
|
|
};
|