mirror of
https://github.com/pbakaus/impeccable.git
synced 2026-09-11 21:57:14 +03:00
* Fix: verify touch gestures in adapt, audit, and harden (#805) The verification sections of adapt.md, audit.md, and harden.md listed environments and layout properties but never had the agent exercise a control's primary gesture, so an emulated viewport plus screenshots could pass as touch testing. adapt now exercises the primary gesture and the scroll-across trade and reports what produced the evidence, audit checks broken touch interaction with code-level tells, harden covers interrupted gestures and recovery, and a reference-contract test pins the three sections. Prepared with AI assistance (Claude Code), directed by @abdulwahabone. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * Pin the scroll, exercise, and cleanup sentences in the reference test (#805) Greptile flagged that the contract test pinned the new labels but not adapt's scroll-across trade, audit's instruction to exercise the gesture, or harden's drag-state and capture cleanup. Prepared with AI assistance (Claude Code), directed by @abdulwahabone. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
93 lines
5.1 KiB
JavaScript
93 lines
5.1 KiB
JavaScript
import { describe, it } from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
import { readFileSync } from 'node:fs';
|
|
import { join } from 'node:path';
|
|
import { fileURLToPath } from 'node:url';
|
|
|
|
const ROOT = fileURLToPath(new URL('..', import.meta.url));
|
|
|
|
describe('skill reference authoring contracts', () => {
|
|
it('keeps direction contracts in development-only surface briefs', () => {
|
|
const newWork = readFileSync(join(ROOT, 'skill/reference/new-work.md'), 'utf-8').replace(/\r\n?/g, '\n');
|
|
const recordDecision = newWork.match(/## 5\. Record the decision\n([\s\S]*?)\n## 6\./)?.[1] ?? '';
|
|
|
|
assert.match(recordDecision, /development-only contract/);
|
|
assert.match(recordDecision, /under `## Direction contract` in the relevant surface brief/);
|
|
assert.match(recordDecision, /read the brief once more/i);
|
|
assert.match(recordDecision, /all six contract blocks and the seed key/);
|
|
|
|
for (const block of ['THESIS', 'OWN-WORLD', 'STORY', 'FIRST VIEWPORT', 'FORM', 'FINISH']) {
|
|
assert.match(recordDecision, new RegExp(`${block}:`));
|
|
}
|
|
|
|
for (const browserArtifact of [
|
|
/HTML or framework comments/,
|
|
/hidden DOM/,
|
|
/<template>/,
|
|
/`data-\*` attributes/,
|
|
/serialized props or state/,
|
|
/React Server Component payloads/,
|
|
/client bundles/,
|
|
/metadata or JSON-LD/,
|
|
/accessibility-only text/,
|
|
]) {
|
|
assert.match(recordDecision, browserArtifact);
|
|
}
|
|
|
|
assert.match(recordDecision, /Never copy the direction contract into implementation source or any browser-delivered artifact/);
|
|
assert.doesNotMatch(newWork, /contract in the artifact's opening comment/);
|
|
assert.doesNotMatch(newWork, /survives the production build/);
|
|
assert.doesNotMatch(newWork, /grep the built output/);
|
|
assert.doesNotMatch(newWork, /emitted markup/);
|
|
assert.doesNotMatch(newWork, /first child of the document's body/);
|
|
});
|
|
|
|
it('keeps reduced-motion guidance on the animation build path', () => {
|
|
const animate = readFileSync(join(ROOT, 'skill/reference/animate.md'), 'utf-8').replace(/\r\n?/g, '\n');
|
|
const accessibility = animate.match(/## Accessibility and control\n([\s\S]*?)\n## Verify/)?.[1] ?? '';
|
|
const verify = animate.match(/## Verify\n([\s\S]*?)(?:\n## |$)/)?.[1] ?? '';
|
|
|
|
assert.match(accessibility, /prefers-reduced-motion/);
|
|
assert.match(accessibility, /intentional alternative/);
|
|
assert.match(accessibility, /not disabling all motion/);
|
|
assert.match(verify, /reduced[- ]motion/i);
|
|
});
|
|
|
|
it('uses an exact content fingerprint before inheriting a critique snapshot', () => {
|
|
const critique = readFileSync(join(ROOT, 'skill/reference/critique.md'), 'utf-8').replace(/\r\n?/g, '\n');
|
|
const polish = readFileSync(join(ROOT, 'skill/reference/polish.md'), 'utf-8').replace(/\r\n?/g, '\n');
|
|
|
|
assert.match(critique, /records an exact content fingerprint/);
|
|
assert.match(polish, /compares the file's exact current content fingerprint/);
|
|
assert.match(polish, /Unchanged staged, unstaged, or untracked content remains current/);
|
|
assert.match(polish, /any byte change, deletion, or replacement with a non-file closes the backlog/);
|
|
assert.match(polish, /latest "<resolved target>" --json/);
|
|
assert.match(polish, /exact `snapshot_file` identity/);
|
|
assert.match(polish, /close "<resolved target>" "<snapshot_file returned by latest>"/);
|
|
assert.match(polish, /if a newer critique landed meanwhile, its backlog stays live/);
|
|
assert.doesNotMatch(polish, /git status|git log/);
|
|
});
|
|
|
|
it('keeps touch-gesture verification in the adapt, audit, and harden references', () => {
|
|
const adapt = readFileSync(join(ROOT, 'skill/reference/adapt.md'), 'utf-8').replace(/\r\n?/g, '\n');
|
|
const audit = readFileSync(join(ROOT, 'skill/reference/audit.md'), 'utf-8').replace(/\r\n?/g, '\n');
|
|
const harden = readFileSync(join(ROOT, 'skill/reference/harden.md'), 'utf-8').replace(/\r\n?/g, '\n');
|
|
const verifyAdaptations = adapt.match(/## Verify Adaptations\n([\s\S]*?)\n## /)?.[1] ?? '';
|
|
const responsive = audit.match(/### 4\. Responsive Design\n([\s\S]*?)\n### 5\./)?.[1] ?? '';
|
|
const edgeCases = harden.match(/### Edge Cases & Boundary Conditions\n([\s\S]*?)\n### /)?.[1] ?? '';
|
|
const verifyHardening = harden.match(/## Verify Hardening\n([\s\S]*?)(?:\n## |$)/)?.[1] ?? '';
|
|
|
|
assert.match(verifyAdaptations, /\*\*Primary gesture\*\*/);
|
|
assert.match(verifyAdaptations, /produced the evidence/);
|
|
assert.match(verifyAdaptations, /verify layout, never a gesture/);
|
|
assert.match(verifyAdaptations, /reported gap, not a blocker/);
|
|
assert.match(verifyAdaptations, /\*\*Scroll across it\*\*[\s\S]*without activating it/);
|
|
assert.match(responsive, /\*\*Broken touch interaction\*\*/);
|
|
assert.match(responsive, /what stayed untested/);
|
|
assert.match(responsive, /Exercise the gesture when a browser tool can synthesize touch/);
|
|
assert.match(edgeCases, /\*\*Interrupted gestures\*\*[\s\S]*works without a reload/);
|
|
assert.match(edgeCases, /clear the dragging state and release capture/);
|
|
assert.match(verifyHardening, /\*\*Interrupted gestures\*\*/);
|
|
});
|
|
});
|