mirror of
https://github.com/pbakaus/impeccable.git
synced 2026-09-14 15:16:35 +03:00
The engine no longer lives in a separate repo. `crates/` is a snapshot of the
open crates (foundation, core, common, context, live, hook, skills, comp,
comp-verbs, html, browser, detect, cli) plus `Cargo.lock`, taken as a git
archive of the engine repo at the commit that finished the boundary split.
None of that repo's history comes with it, and none of it should: the closed
half stays private.
The closed half is the rule engine. It ships as a prebuilt native archive per
target, `libimpeccable_detector.a`, published as a `detector-v<X>` GitHub
Release on this repo. `crates/core/build.rs` resolves and links it three ways:
`IMPECCABLE_DETECTOR_LIB=<dir>` for a local detector build, else the
`~/.impeccable/detector/<version>/<target>/` cache, else a download verified
against its `.sha256` sidecar. `crates/core` is a thin shim over a three-symbol
C ABI; nothing above it knows the boundary exists.
What changed versus the engine repo copy:
- Every crate manifest moves from `license-file.workspace` to
`license.workspace` (this workspace declares Apache-2.0), and the workspace
gains the `postcard` dependency the boundary encoding needs.
- The launcher contract test reads `skill/scripts/impeccable{,.cmd}` instead of
a sibling `launcher/` dir, and `engine_binary` downloads from
`github.com/pbakaus/impeccable/releases/download/engine-v<version>/` instead
of the retired dist repo. No oracle golden carried the old URL, so no
re-recording was owed.
- The tests that hunted for a public repo through `IMPECCABLE_PUBLIC_REPO`,
`../impeccable-second` or a hardcoded home directory now resolve the root as
`CARGO_MANIFEST_DIR/../..`, because they are in it. The env var stays as an
override for an out-of-tree checkout.
- The in-page bundle (`detect-antipatterns-browser.js`, 2 MB of generated wasm
glue) is no longer tracked. `crates/core/build.rs` resolves it beside the
archive, hands the path to `impeccable_core::browser::IN_PAGE_BUNDLE_JS`, and
live mode serves that. `scripts/check-detector-release.mjs` now requires it
and its `.sha256` in a detector release.
- The live crate embeds `skill/scripts/live-browser*.js` and
`modern-screenshot.umd.js` directly rather than through vendored copies, so
the binary and the installed skill cannot drift.
- `crates/browser/assets/` (an unused second copy of the bundle) is gone.
- `tests/lib/engine-bin.mjs` also accepts `target/release/impeccable`, so a
plain `cargo build --release -p impeccable` is enough to run `bun run test`.
Verified with the archive from a local detector build: `cargo test --workspace`
267 pass, oracle 795 pass / 0 fail / 0 missing, `bun run build` clean, the
default suite green, and the launcher's `engine-probe` handshake answering
through `skill/scripts/impeccable`.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vau2X53xGTjjTCXWMVBoNY
212 lines
7.5 KiB
Rust
212 lines
7.5 KiB
Rust
//! Unit tests for the cascade helpers without recorded vectors. Expected
|
|
//! values were produced by running the JS `css-cascade.mjs` in Node.
|
|
|
|
use impeccable_html::cascade::checks_shim::{resolve_length_px, resolve_var_refs, CustomProps};
|
|
use impeccable_html::cascade::rules::{
|
|
apply_static_declaration, parse_static_style_attribute, DeclMeta, SpecifiedStore,
|
|
};
|
|
use impeccable_html::cascade::values::{normalize_color_for_check, unwrap_css_at_layer};
|
|
|
|
#[test]
|
|
fn normalize_color_for_check_matches_node() {
|
|
let cases: &[(&str, &str)] = &[
|
|
("#ffffff", "rgb(255, 255, 255)"),
|
|
("#FfF", "rgb(255, 255, 255)"),
|
|
("#abc", "rgb(170, 187, 204)"),
|
|
(" #ABCDEF ", "rgb(171, 205, 239)"),
|
|
("white", "rgb(255, 255, 255)"),
|
|
("Black", "rgb(0, 0, 0)"),
|
|
("GRAY", "rgb(128, 128, 128)"),
|
|
("grey", "rgb(128, 128, 128)"),
|
|
("silver", "rgb(192, 192, 192)"),
|
|
("red", "rgb(255, 0, 0)"),
|
|
("green", "rgb(0, 128, 0)"),
|
|
("blue", "rgb(0, 0, 255)"),
|
|
("yellow", "rgb(255, 255, 0)"),
|
|
("purple", "purple"),
|
|
("rgb(1, 2, 3)", "rgb(1, 2, 3)"),
|
|
("oklch(50% 0.1 20)", "oklch(50% 0.1 20)"),
|
|
("#abcd", "#abcd"),
|
|
("#12345", "#12345"),
|
|
("", ""),
|
|
(" ", ""),
|
|
("var(--x)", "var(--x)"),
|
|
("transparent", "transparent"),
|
|
];
|
|
for (input, expected) in cases {
|
|
assert_eq!(
|
|
normalize_color_for_check(input),
|
|
*expected,
|
|
"input {:?}",
|
|
input
|
|
);
|
|
}
|
|
}
|
|
|
|
fn meta(important: bool, specificity: [u32; 3], order: i64, inline: bool) -> DeclMeta {
|
|
DeclMeta {
|
|
important,
|
|
specificity,
|
|
order,
|
|
inline,
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn apply_static_declaration_matches_node() {
|
|
let mut specified: SpecifiedStore<&str> = SpecifiedStore::new();
|
|
let node = "n1";
|
|
let mut apply = |prop: &str, value: &str, m: DeclMeta| {
|
|
apply_static_declaration(&mut specified, node, prop, value, &m);
|
|
};
|
|
apply("margin", "0", meta(false, [0, 0, 0], 0, false));
|
|
apply("margin-top", "5px", meta(false, [0, 1, 0], 1, false));
|
|
apply("margin", "10px 20px", meta(false, [0, 0, 1], 2, false));
|
|
apply("color", "red", meta(true, [0, 0, 0], 3, false));
|
|
apply("color", "blue", meta(false, [1, 0, 0], 4, true));
|
|
apply("background", "var(--x)", meta(false, [0, 1, 0], 5, false));
|
|
apply("background", "none", meta(false, [0, 1, 0], 6, false));
|
|
apply("--brand", "#fff", meta(false, [0, 1, 0], 7, false));
|
|
apply(
|
|
"font",
|
|
"italic 700 12px/1.4 Inter, sans-serif",
|
|
meta(false, [0, 1, 0], 8, false),
|
|
);
|
|
apply("box-sizing", "border-box", meta(false, [0, 1, 0], 9, false));
|
|
apply("margin-top", "1px", meta(false, [0, 0, 0], 10, false));
|
|
apply("margin-top", "2px", meta(true, [0, 0, 0], 11, false));
|
|
apply("margin-top", "3px", meta(false, [9, 9, 9], 12, true));
|
|
apply("outline", "0", meta(false, [0, 0, 0], 13, false));
|
|
apply(
|
|
"border-left",
|
|
"3px solid teal",
|
|
meta(false, [0, 0, 0], 14, false),
|
|
);
|
|
|
|
let map = specified.get(&node).expect("node entry");
|
|
let got: Vec<(String, bool, [u32; 3], i64, bool, String)> = map
|
|
.iter()
|
|
.map(|(k, d)| {
|
|
(
|
|
k.clone(),
|
|
d.meta.important,
|
|
d.meta.specificity,
|
|
d.meta.order,
|
|
d.meta.inline,
|
|
d.value.clone(),
|
|
)
|
|
})
|
|
.collect();
|
|
let s = |x: &str| x.to_string();
|
|
let expected = vec![
|
|
(s("marginTop"), true, [0, 0, 0], 11, false, s("2px")),
|
|
(s("marginRight"), false, [0, 0, 1], 2, false, s("20px")),
|
|
(s("marginBottom"), false, [0, 0, 1], 2, false, s("10px")),
|
|
(s("marginLeft"), false, [0, 0, 1], 2, false, s("20px")),
|
|
(s("color"), true, [0, 0, 0], 3, false, s("red")),
|
|
(
|
|
s("backgroundColor"),
|
|
false,
|
|
[0, 1, 0],
|
|
6,
|
|
false,
|
|
s("rgba(0, 0, 0, 0)"),
|
|
),
|
|
(s("backgroundImage"), false, [0, 1, 0], 6, false, s("none")),
|
|
(s("--brand"), false, [0, 1, 0], 7, false, s("#fff")),
|
|
(s("fontStyle"), false, [0, 1, 0], 8, false, s("italic")),
|
|
(s("fontWeight"), false, [0, 1, 0], 8, false, s("700")),
|
|
(s("fontSize"), false, [0, 1, 0], 8, false, s("12px")),
|
|
(s("lineHeight"), false, [0, 1, 0], 8, false, s("1.4")),
|
|
(
|
|
s("fontFamily"),
|
|
false,
|
|
[0, 1, 0],
|
|
8,
|
|
false,
|
|
s("Inter, sans-serif"),
|
|
),
|
|
(s("outlineWidth"), false, [0, 0, 0], 13, false, s("0px")),
|
|
(s("borderLeftWidth"), false, [0, 0, 0], 14, false, s("3px")),
|
|
(s("borderLeftColor"), false, [0, 0, 0], 14, false, s("teal")),
|
|
];
|
|
assert_eq!(got, expected);
|
|
// prop is the expanded property name
|
|
assert_eq!(map.get("marginTop").unwrap().prop, "marginTop");
|
|
}
|
|
|
|
#[test]
|
|
fn parse_static_style_attribute_edge_cases_match_node() {
|
|
let decls = parse_static_style_attribute(
|
|
": x; a:b; c: d !important ; e:f!IMPORTANT; g; h:; :i; j:k:l",
|
|
5,
|
|
);
|
|
let got: Vec<(String, String, bool, i64)> = decls
|
|
.into_iter()
|
|
.map(|d| (d.prop, d.value, d.important, d.order))
|
|
.collect();
|
|
let s = |x: &str| x.to_string();
|
|
assert_eq!(
|
|
got,
|
|
vec![
|
|
(s("a"), s("b"), false, 5),
|
|
(s("c"), s("d"), true, 6),
|
|
(s("e"), s("f"), true, 7),
|
|
(s("h"), s(""), false, 8),
|
|
(s(""), s("i"), false, 9),
|
|
(s("j"), s("k:l"), false, 10),
|
|
]
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn unwrap_css_at_layer_shapes() {
|
|
assert_eq!(unwrap_css_at_layer(""), "");
|
|
assert_eq!(unwrap_css_at_layer(".a{color:red}"), ".a{color:red}");
|
|
assert_eq!(
|
|
unwrap_css_at_layer("@layer base { .a{color:red} } .b{c:d}"),
|
|
" .a{color:red} .b{c:d}"
|
|
);
|
|
assert_eq!(
|
|
unwrap_css_at_layer("@layer{ .a{ .n{x:y} } }@layer a.b { .c{d:e} }"),
|
|
" .a{ .n{x:y} } .c{d:e} "
|
|
);
|
|
// statement form is untouched
|
|
assert_eq!(
|
|
unwrap_css_at_layer("@layer a, b; .x{y:z}"),
|
|
"@layer a, b; .x{y:z}"
|
|
);
|
|
// unbalanced: source unchanged
|
|
assert_eq!(
|
|
unwrap_css_at_layer("@layer x { .a{color:red}"),
|
|
"@layer x { .a{color:red}"
|
|
);
|
|
// `@layered` does not match the word boundary
|
|
assert_eq!(
|
|
unwrap_css_at_layer("@layered x { .a{c:d} }"),
|
|
"@layered x { .a{c:d} }"
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn checks_shim_helpers() {
|
|
let mut props = CustomProps::new();
|
|
props.insert("--a".into(), "var(--b)".into());
|
|
props.insert("--b".into(), "#fff".into());
|
|
props.insert("--loop".into(), "var(--loop)".into());
|
|
assert_eq!(resolve_var_refs("var(--a)", &props), "#fff");
|
|
assert_eq!(resolve_var_refs("var( --b , red )", &props), "#fff");
|
|
assert_eq!(resolve_var_refs("var(--missing, red )", &props), "red");
|
|
assert_eq!(resolve_var_refs("var(--missing)", &props), "var(--missing)");
|
|
assert_eq!(resolve_var_refs("var(--loop)", &props), "var(--loop)");
|
|
assert_eq!(resolve_var_refs("plain", &props), "plain");
|
|
assert_eq!(resolve_length_px("normal", 16.0), None);
|
|
assert_eq!(resolve_length_px("", 16.0), None);
|
|
assert_eq!(resolve_length_px("abc", 16.0), None);
|
|
assert_eq!(resolve_length_px("12px", 16.0), Some(12.0));
|
|
assert_eq!(resolve_length_px("1.5rem", 10.0), Some(24.0));
|
|
assert_eq!(resolve_length_px("2em", 10.0), Some(20.0));
|
|
assert_eq!(resolve_length_px("50%", 10.0), Some(5.0));
|
|
assert_eq!(resolve_length_px("1.5", 10.0), Some(15.0));
|
|
}
|