mirror of
https://github.com/pbakaus/impeccable.git
synced 2026-09-12 06:06:37 +03:00
Paul BakausandClaude
4e381305e1
Addresses the review findings on #371, plus several the bots did not catch. All fixes have regression coverage that fails on the prior code. Source corruption: - Vue accept dropped valueless root attrs (disabled, v-cloak) and, worse, rewrote @click="x" as a literal click="x" DOM attribute, because the attr parser was name-anchored and skipped the sigil. Tokenize the whole Vue attr grammar and normalize shorthands so accept round-trips directives. - --variant was interpolated unescaped into a RegExp, so --variant '.*' matched the original block first and reported a successful accept while silently restoring the original. Validate against the digits pattern the browser and the /events schema already enforce. - --id reached path.join unvalidated, so --id ../../../../etc/evil wrote and read receipts outside the project. Hoist the existing safeSessionId check into impeccable-paths and apply it at every id-to-path sink. Accept/lock correctness: - Plain HTML/JSX accept and discard did not catch SOURCE_LOCKED, so contention exited non-zero with empty stdout and the agent got no JSON to retry on. - Lock staleness was mtime-only and never read the pid it records: a holder whose critical section outran 60s had its live lock swept, admitting a second writer to the same file, while a crashed holder blocked accepts for a full 60s. Decide staleness by owner liveness, and release only our own lock. Detector: - isNeutralColor only parses computed color forms, so routing authored CSS through it reported inset 4px 0 0 #000 / black / #e5e7eb as chromatic side-tab stripes. Add an authored-color neutrality test covering hex and named neutrals; the fixture had no literal-color cases at all. - Rule line numbers were off by one for every rule after the first, and commented-out CSS was scanned as live rules. Server: - An error reply carries no sourceEventType, and inferSourceEventType returned undefined, which acknowledgePendingEvent treats as a wildcard: a stale generate worker's failure consumed the user's queued Accept, which then reached no agent and left the browser in SAVING forever. - The generate preflight spawned live-wrap.mjs synchronously inside the request handler, freezing the single-threaded server for the whole scaffold (~7.6s measured on this repo, 15s ceiling) and stalling Accept/Discard/SSE. Make it async, claiming the lease before the first await so no event double-delivers. - Every browser checkpoint was echoed back as variant_progress, so a Tune slider drag remounted the preview under the user's cursor and latched the *_reviewable phases from the wrong trigger. Gate on the reason. Cleanup: - Collapse four divergent benchmark argv parsers into scripts/lib/cli-args.mjs. Three silently misread flags: --iterations 20 benchmarked 5, --agent llm ran the fake agent, --median-target=0.4 used the default threshold. - Drop a snapshot cache this branch made write-only (it grew per session for the server's lifetime and was never read), a dead exported reconcile helper, and the unused deferReply branch. Prepared with AI assistance under maintainer direction. Co-Authored-By: Claude <noreply@anthropic.com>
72 lines
2.6 KiB
JavaScript
72 lines
2.6 KiB
JavaScript
/**
|
|
* One argv parser for the Live benchmark / judging scripts.
|
|
*
|
|
* These scripts had four subtly different hand-rolled parsers, and the gaps
|
|
* failed silently rather than loudly: a parser without the `argv[i + 1]`
|
|
* lookahead turned `--iterations 20` into `iterations: true` and benchmarked
|
|
* the default 5 runs; a parser without kebab→camel mapping turned
|
|
* `--median-target=0.4` into a key nothing read, so the comparison ran against
|
|
* the default threshold. Both produce a clean-looking report of the wrong thing.
|
|
*
|
|
* Supported forms, per flag:
|
|
* --flag → true
|
|
* --flag=value → 'value'
|
|
* --flag value → 'value' (unless `value` itself starts with `--`)
|
|
*
|
|
* Keys are camel-cased, so `--simulated-tail-ms` and `--simulatedTailMs` both
|
|
* land on `simulatedTailMs`.
|
|
*/
|
|
export function parseArgs(argv) {
|
|
const out = {};
|
|
for (let index = 0; index < argv.length; index += 1) {
|
|
const arg = argv[index];
|
|
if (!arg.startsWith('--')) continue;
|
|
const body = arg.slice(2);
|
|
if (!body) continue;
|
|
const equals = body.indexOf('=');
|
|
if (equals !== -1) {
|
|
out[toCamel(body.slice(0, equals))] = body.slice(equals + 1);
|
|
continue;
|
|
}
|
|
const next = argv[index + 1];
|
|
if (next !== undefined && !next.startsWith('--')) {
|
|
out[toCamel(body)] = next;
|
|
index += 1;
|
|
} else {
|
|
out[toCamel(body)] = true;
|
|
}
|
|
}
|
|
return out;
|
|
}
|
|
|
|
export function toCamel(value) {
|
|
return String(value).replace(/-([a-z0-9])/gi, (_, char) => char.toUpperCase());
|
|
}
|
|
|
|
/**
|
|
* Read a boolean flag. `--headed` and `--headed=true` must mean the same thing;
|
|
* comparing the raw value against `true` silently ignores the second form.
|
|
*/
|
|
export function boolFlag(value, fallback = false) {
|
|
if (value === undefined) return fallback;
|
|
if (typeof value === 'boolean') return value;
|
|
const normalized = String(value).trim().toLowerCase();
|
|
if (['', 'true', '1', 'yes', 'on'].includes(normalized)) return true;
|
|
if (['false', '0', 'no', 'off'].includes(normalized)) return false;
|
|
return fallback;
|
|
}
|
|
|
|
/**
|
|
* Parse a positive integer flag, falling back when absent. Throws on a value
|
|
* that was clearly meant as a number but isn't one, so `--iterations abc`
|
|
* fails instead of quietly benchmarking the default.
|
|
*/
|
|
export function positiveIntFlag(value, fallback) {
|
|
if (value === undefined || value === true) return fallback;
|
|
const parsed = Number.parseInt(String(value), 10);
|
|
if (!Number.isFinite(parsed) || parsed <= 0 || String(parsed) !== String(value).trim()) {
|
|
throw new Error(`expected a positive integer, got: ${value}`);
|
|
}
|
|
return parsed;
|
|
}
|