mirror of https://github.com/pbakaus/impeccable.git synced 2026-09-12 14:16:28 +03:00

Files

T

Paul BakausandClaude Fable 5.1 453a6e1500 bundle: the page JS and the bundler become a library crate downstream packs can reuse

The in-page bundle, the extension pieces, the registry JSON and the
wasm-pack call were reachable only through `cargo xtask bundle`, which read
`browser-bundle/*.js` from the repo root. A downstream crate that links
impeccable-core + impeccable-wasm with its own rule pack had to copy the
page JS to produce a detector bundle for its module.

They move to `impeccable-bundle` (crates/bundle), which embeds every
`browser-bundle/*.js` with `include_str!` and exposes `in_page_bundle`,
`extension_pieces`, `registry_json`, `check_capture_contract` and
`wasm_pack_build`. Nothing writes files or exits the process; the caller
places the bytes. `registry_json` now reads `all_antipatterns()`, so an
installed pack's rows land in `antipatterns.json` too (no built-in change).

xtask becomes the workspace's caller and writes the same files to the same
places; `cargo xtask bundle` is byte-identical, tracked live asset included.
`IMPECCABLE_BUNDLE_SKIP_WASM_PACK` is the skip switch's new name, the old
`IMPECCABLE_XTASK_SKIP_WASM_PACK` still works.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vau2X53xGTjjTCXWMVBoNY

2026-09-03 10:49:42 -07:00

00-header.js

reorg C: the open Rust runtime joins this repo as one Cargo workspace

2026-09-01 15:31:26 -07:00

10-probe.js

reorg C: the open Rust runtime joins this repo as one Cargo workspace

2026-09-01 15:31:26 -07:00

15-snapshot.js

reorg C: the open Rust runtime joins this repo as one Cargo workspace

2026-09-01 15:31:26 -07:00

30-scan-common.js

reorg C: the open Rust runtime joins this repo as one Cargo workspace

2026-09-01 15:31:26 -07:00

35-visual.js

reorg C: the open Rust runtime joins this repo as one Cargo workspace

2026-09-01 15:31:26 -07:00

40-overlay.js

reorg C: the open Rust runtime joins this repo as one Cargo workspace

2026-09-01 15:31:26 -07:00

50-scan.js

reorg C: the open Rust runtime joins this repo as one Cargo workspace

2026-09-01 15:31:26 -07:00

60-offscreen.js

reorg C: the open Rust runtime joins this repo as one Cargo workspace

2026-09-01 15:31:26 -07:00

99-footer.js

reorg C: the open Rust runtime joins this repo as one Cargo workspace

2026-09-01 15:31:26 -07:00

README.md

bundle: the page JS and the bundler become a library crate downstream packs can reuse

2026-09-03 10:49:42 -07:00

README.md

browser-bundle: the page-side JavaScript of the detector

Plain JavaScript that runs inside a page or the extension: the DOM probe the wasm rule core calls back into, the page snapshot producer, the visual-contrast sampling IO, the overlay UI, the scan API and the extension's offscreen document. Measurement and presentation only; every rule decision is a call into the wasm rule core built from crates/core (docs/ENGINE.md).

Two consumers:

crates/browser embeds 15-snapshot.js (the snapshot producer the URL engine injects; no WebAssembly runs in the page).
crates/bundle (the impeccable-bundle library) embeds every file here with include_str! and concatenates them, in filename order, with the wasm core into the in-page bundle plus the extension's extension/detector/ pieces. cargo xtask bundle is its caller inside this workspace: it writes dist/detect-antipatterns-browser.js, copies that bundle to the tracked crates/live/assets/detect-antipatterns-browser.js the engine embeds, and writes the extension pieces. A downstream crate with its own rule pack calls the library directly (docs/ENGINE.md).

Because the files are embedded, a new one here has to be added to PAGE_JS in crates/bundle/src/lib.rs (and to the order it is concatenated in); a test fails when the two lists disagree.

15-snapshot.js lists the computed-style properties the rules read; the bundle build checks that list against the core's and fails when they drift.