mirror of
https://github.com/pbakaus/impeccable.git
synced 2026-09-15 23:56:29 +03:00
The engine no longer lives in a separate repo. `crates/` is a snapshot of the
open crates (foundation, core, common, context, live, hook, skills, comp,
comp-verbs, html, browser, detect, cli) plus `Cargo.lock`, taken as a git
archive of the engine repo at the commit that finished the boundary split.
None of that repo's history comes with it, and none of it should: the closed
half stays private.
The closed half is the rule engine. It ships as a prebuilt native archive per
target, `libimpeccable_detector.a`, published as a `detector-v<X>` GitHub
Release on this repo. `crates/core/build.rs` resolves and links it three ways:
`IMPECCABLE_DETECTOR_LIB=<dir>` for a local detector build, else the
`~/.impeccable/detector/<version>/<target>/` cache, else a download verified
against its `.sha256` sidecar. `crates/core` is a thin shim over a three-symbol
C ABI; nothing above it knows the boundary exists.
What changed versus the engine repo copy:
- Every crate manifest moves from `license-file.workspace` to
`license.workspace` (this workspace declares Apache-2.0), and the workspace
gains the `postcard` dependency the boundary encoding needs.
- The launcher contract test reads `skill/scripts/impeccable{,.cmd}` instead of
a sibling `launcher/` dir, and `engine_binary` downloads from
`github.com/pbakaus/impeccable/releases/download/engine-v<version>/` instead
of the retired dist repo. No oracle golden carried the old URL, so no
re-recording was owed.
- The tests that hunted for a public repo through `IMPECCABLE_PUBLIC_REPO`,
`../impeccable-second` or a hardcoded home directory now resolve the root as
`CARGO_MANIFEST_DIR/../..`, because they are in it. The env var stays as an
override for an out-of-tree checkout.
- The in-page bundle (`detect-antipatterns-browser.js`, 2 MB of generated wasm
glue) is no longer tracked. `crates/core/build.rs` resolves it beside the
archive, hands the path to `impeccable_core::browser::IN_PAGE_BUNDLE_JS`, and
live mode serves that. `scripts/check-detector-release.mjs` now requires it
and its `.sha256` in a detector release.
- The live crate embeds `skill/scripts/live-browser*.js` and
`modern-screenshot.umd.js` directly rather than through vendored copies, so
the binary and the installed skill cannot drift.
- `crates/browser/assets/` (an unused second copy of the bundle) is gone.
- `tests/lib/engine-bin.mjs` also accepts `target/release/impeccable`, so a
plain `cargo build --release -p impeccable` is enough to run `bun run test`.
Verified with the archive from a local detector build: `cargo test --workspace`
267 pass, oracle 795 pass / 0 fail / 0 missing, `bun run build` clean, the
default suite green, and the launcher's `engine-probe` handshake answering
through `skill/scripts/impeccable`.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vau2X53xGTjjTCXWMVBoNY
56 lines
2.0 KiB
Rust
56 lines
2.0 KiB
Rust
//! impeccable-hook: the design hook verbs (`hook`, `hook-before-edit`,
|
|
//! `hooks` / `hook-admin`), ported from `skill/scripts/hook.mjs`,
|
|
//! `hook-before-edit.mjs`, `hook-admin.mjs`, and `hook-lib.mjs`.
|
|
//!
|
|
//! The regex engine and design-system loader come from `impeccable-detect`;
|
|
//! the static HTML engine is reached through the `HtmlEngine` seam the `cli`
|
|
//! binary wires in (crates/html), so `.html` targets and configured
|
|
//! html-engine template extensions get the same DOM rules the JS applied.
|
|
//! The native-platform gate reads PRODUCT.md through `impeccable-context`'s
|
|
//! `resolve_context` / `extract_platform` (only the platform is observable,
|
|
//! so the rest of `loadContext` is skipped).
|
|
|
|
pub mod admin;
|
|
pub mod before_edit;
|
|
pub mod hook;
|
|
pub mod hook_lib;
|
|
pub mod util;
|
|
|
|
use impeccable_common::Io;
|
|
use impeccable_detect::engines::HtmlEngine;
|
|
|
|
pub use hook_lib::Runtime;
|
|
|
|
fn runtime<'a>(io: &Io, html: &'a dyn HtmlEngine) -> Runtime<'a> {
|
|
let cwd = io.cwd.to_string_lossy().into_owned();
|
|
let provider = impeccable_context::provider::detect(&io.env, &cwd);
|
|
Runtime::new(
|
|
cwd,
|
|
io.env.clone(),
|
|
provider.command,
|
|
&provider.self_cmd,
|
|
html,
|
|
)
|
|
}
|
|
|
|
/// `impeccable hook` (PostToolUse per-edit pass + Stop deep pass). Exit 0.
|
|
pub fn run_hook(_args: &[String], io: &mut Io, html: &dyn HtmlEngine) -> i32 {
|
|
let stdin = io.stdin().to_string();
|
|
let rt = runtime(io, html);
|
|
hook::run(&rt, &stdin, io)
|
|
}
|
|
|
|
/// `impeccable hook-before-edit` (Cursor preToolUse gate). Exit 0.
|
|
pub fn run_hook_before_edit(_args: &[String], io: &mut Io, html: &dyn HtmlEngine) -> i32 {
|
|
let stdin = io.stdin().to_string();
|
|
let rt = runtime(io, html);
|
|
before_edit::run(&rt, &stdin, io)
|
|
}
|
|
|
|
/// `impeccable hooks <action> [args]` (hook-admin.mjs).
|
|
pub fn run_hook_admin(args: &[String], io: &mut Io) -> i32 {
|
|
static NONE: impeccable_detect::MissingHtmlEngine = impeccable_detect::MissingHtmlEngine;
|
|
let rt = runtime(io, &NONE);
|
|
admin::run(&rt, args, io)
|
|
}
|