mirror of
https://github.com/pbakaus/impeccable.git
synced 2026-09-11 21:57:14 +03:00
A ground-up hardening of live mode, driven by a production session in a nested-app monorepo that hit six distinct failure classes. Full design rationale in docs/LIVE-REWRITE-PLAN.md; every Codex-reported failure now has a mechanical fix and a regression test. Roots: live/roots.mjs resolves appRoot/repoRoot/contextRoot once at boot (keyed on dev-server configs, not monorepo brand markers), persists a manifest, and every live CLI re-anchors onto it at startup, so a helper run from the wrong directory can no longer fork session state. Context files are discovered upward to the git root. Render truth: variant_mounted / variant_mount_failed events give the journal per-variant mount state; failures reach the agent's poll queue, raise a persistent error card with Retry (no more localStorage wipe), and an attach probe names root/dev-server mismatches explicitly. The browser rehydrates from the server when localStorage is gone. Svelte: the scaffolder now parses with the app's own svelte 5 compiler. Control flow survives (an each collection crosses the contract as one structured prop), keyed each blocks hydrate synthetic keys, and anything a detached preview cannot support falls back to source-preview instead of shipping a wrong scaffold. Preview modules live in per-publish revision directories, defeating stale transform caches. Accept: CSS is reconciled, not appended. Matching selectors are replaced, params bake from params.json kinds, the compiler's unused-selector pass prunes superseded rules (pre-existing dead rules protected), a selector- loss postcondition refuses any write that would drop hand-written rules, and live-complete refuses to finish while live plumbing remains in source. Also: framework registry (live/frameworks/) with a crash-safe injection journal, session-store snapshot caching with read-only reads, protocol enum consolidation, steer Send button, honest DESIGN-panel empty states. Testing: new unit suites (roots, AST scaffolder, accept CSS, accept pipeline, framework conformance); e2e now fails on preview-tree 404s, proves computed-style mount for every variant, drives the Tune panel through baked params, and injects failures (broken mounts, republish, storage loss). New runtime fixtures: monorepo-nested-vite (repo root != app root) and vite8-sveltekit-stateful (each blocks + state). Nightly full-matrix cron. An independent adversarial review pass preceded this commit; its blocker and major findings are fixed and regression-tested. This work was produced with AI assistance (Claude Code). Co-Authored-By: Claude Code <noreply@anthropic.com>
108 lines
4.7 KiB
JavaScript
108 lines
4.7 KiB
JavaScript
#!/usr/bin/env node
|
|
/**
|
|
* Canonical durable completion acknowledgement for Impeccable live sessions.
|
|
*/
|
|
|
|
import fs from 'node:fs';
|
|
import path from 'node:path';
|
|
import { createLiveSessionStore } from './live/session-store.mjs';
|
|
import { readLiveServerInfo } from './lib/impeccable-paths.mjs';
|
|
import { enterLiveRoot } from './live/roots.mjs';
|
|
import { verifyAcceptedFile } from './live/accept-verify.mjs';
|
|
|
|
function parseArgs(argv) {
|
|
const out = { status: 'complete' };
|
|
for (let i = 0; i < argv.length; i++) {
|
|
const arg = argv[i];
|
|
if (arg === '--id') out.id = argv[++i];
|
|
else if (arg.startsWith('--id=')) out.id = arg.slice('--id='.length);
|
|
else if (arg === '--discarded' || arg === '--discard') out.status = 'discarded';
|
|
else if (arg === '--error') { out.status = 'agent_error'; out.message = argv[++i] || 'unknown error'; }
|
|
else if (arg.startsWith('--error=')) { out.status = 'agent_error'; out.message = arg.slice('--error='.length); }
|
|
else if (arg === '--force') out.force = true;
|
|
else if (arg === '--help' || arg === '-h') out.help = true;
|
|
}
|
|
return out;
|
|
}
|
|
|
|
export async function completeCli() {
|
|
const args = parseArgs(process.argv.slice(2));
|
|
if (args.help || !args.id) {
|
|
console.log(`Usage: node live-complete.mjs --id SESSION_ID [--discarded|--error MESSAGE] [--force]\n\nAppend the final durable session acknowledgement. Use after accept/discard cleanup is verified.\nCompletion is refused while the session's source file still carries live-mode leftovers\n(markers, data-p-* attributes, unbaked --p-* vars); fix the file or pass --force.`);
|
|
process.exit(args.help ? 0 : 1);
|
|
}
|
|
|
|
// The carbonize contract used to be prose; this makes it mechanical. A
|
|
// "complete" while the source still carries live plumbing is how markers
|
|
// and dead param branches accumulated across sessions.
|
|
if (args.status === 'complete' && !args.force) {
|
|
const store = createLiveSessionStore({ cwd: process.cwd(), sessionId: args.id });
|
|
const snapshot = store.getSnapshot(args.id, { includeCompleted: true });
|
|
const sourceFile = snapshot?.sourceFile;
|
|
const absSource = sourceFile ? path.resolve(process.cwd(), sourceFile) : null;
|
|
const relSource = absSource ? path.relative(process.cwd(), absSource) : null;
|
|
const insideProject = relSource !== null && relSource !== '' && !relSource.startsWith('..') && !path.isAbsolute(relSource);
|
|
if (insideProject && !relSource.startsWith('node_modules' + path.sep) && !relSource.startsWith('node_modules/')) {
|
|
const verify = verifyAcceptedFile(fs, absSource);
|
|
if (!verify.clean) {
|
|
console.log(JSON.stringify({
|
|
ok: false,
|
|
error: 'source_dirty',
|
|
id: args.id,
|
|
file: sourceFile,
|
|
findings: verify.findings,
|
|
hint: 'The accepted source still carries live-mode leftovers. Finish the carbonize cleanup (bake params, remove markers and data-p-* attributes), then run live-complete again. Use --force only if a finding is a false positive.',
|
|
}, null, 2));
|
|
process.exit(1);
|
|
}
|
|
}
|
|
}
|
|
|
|
const serverInfo = readServerInfo();
|
|
const serverResult = serverInfo ? await completeThroughServer(serverInfo, args) : null;
|
|
if (serverResult?.ok) {
|
|
const store = createLiveSessionStore({ cwd: process.cwd(), sessionId: args.id });
|
|
const snapshot = store.getSnapshot(args.id, { includeCompleted: true });
|
|
console.log(JSON.stringify({ ok: true, id: args.id, phase: snapshot?.phase || args.status, snapshot }, null, 2));
|
|
return;
|
|
}
|
|
|
|
const store = createLiveSessionStore({ cwd: process.cwd(), sessionId: args.id });
|
|
const event = args.status === 'discarded'
|
|
? { type: 'discarded', id: args.id }
|
|
: args.status === 'agent_error'
|
|
? { type: 'agent_error', id: args.id, message: args.message || 'unknown error' }
|
|
: { type: 'complete', id: args.id };
|
|
const snapshot = store.appendEvent(event);
|
|
console.log(JSON.stringify({ ok: true, id: args.id, phase: snapshot.phase, snapshot }, null, 2));
|
|
}
|
|
|
|
function readServerInfo() {
|
|
return readLiveServerInfo(process.cwd())?.info || null;
|
|
}
|
|
|
|
async function completeThroughServer(info, args) {
|
|
const type = args.status === 'discarded'
|
|
? 'discarded'
|
|
: args.status === 'agent_error'
|
|
? 'error'
|
|
: 'complete';
|
|
try {
|
|
const res = await fetch(`http://localhost:${info.port}/poll`, {
|
|
method: 'POST',
|
|
headers: { 'Content-Type': 'application/json' },
|
|
body: JSON.stringify({ token: info.token, id: args.id, type, message: args.message }),
|
|
});
|
|
if (!res.ok) return null;
|
|
return await res.json();
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
const _running = process.argv[1];
|
|
if (_running?.endsWith('live-complete.mjs') || _running?.endsWith('live-complete.mjs/')) {
|
|
enterLiveRoot();
|
|
completeCli();
|
|
}
|