Files
pbakaus_impeccable/skill/reference/hooks.md
T
8cf2be110d feat(cli): interactive hook consent + unified .impeccable/config.json (#245)
* feat(cli): interactive hook consent + unified .impeccable/config.json

Make the design-hook install a conscious choice and unify scattered config
into one file.

Interactive consent
- On an interactive `skills install`/`update`, the CLI explains what the hook
  does and offers to install it (default yes), then records the per-developer
  decision in the gitignored `.impeccable/config.local.json`, so it never
  re-asks. A recorded decision or an already-installed hook short-circuits;
  `-y`/non-TTY keeps the historical install-by-default behavior; `--no-hooks`
  is a one-off skip that records nothing. The trigger keys on "is the hook
  installed?" + "is there a recorded decision?", not a brittle version check.

Unified config
- `.impeccable/config.json` (shared) and `.impeccable/config.local.json`
  (gitignored) now hold all Impeccable settings: hook settings under a `hook`
  key, plus top-level `updateCheck`. `/impeccable hooks` writes the `hook`
  subtree, preserving siblings. The hook runtime reads `hook.quiet` and
  `hook.auditLog`; context boot reads `updateCheck`. The legacy
  `IMPECCABLE_HOOK_DISABLED|QUIET|LOG` and `IMPECCABLE_NO_UPDATE_CHECK` env vars
  still work and override config; docs now lead with config and treat env vars
  as a legacy note.
- No backward compat for the pre-unification `hook.json`/`hook.local.json`
  (the hook shipped an hour ago; nothing in the wild uses it). This repo's own
  hook config is migrated to `.impeccable/config.json`.

The CLI and skill scripts are separate trees, so a small CLI-side config module
(cli/lib/impeccable-config.mjs) duplicates the config-path and .git/info/exclude
handling; comments flag the duplication.

Tests: new cli config unit test; skills-cli consent tests (declined skips,
accepted installs, --no-hooks records nothing); hook.test.mjs back-compat
removed and quiet/auditLog-from-config + gitexclude coverage added. Full suite
green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(hooks): preserve sibling config fields + resolve audit log from event cwd (Bugbot)

Two Bugbot findings:

- High: `/impeccable hooks` edits replaced the whole `hook` object with the
  merge-helper output, dropping fields those helpers don't manage — so an
  `ignore-value --local` could wipe the recorded install consent and make the
  CLI re-prompt. writeConfig now merges over the existing hook object, keeping
  consent/quiet/auditLog.
- Medium: config-based audit logging resolved hook.auditLog from process.cwd(),
  which can differ from the hook event's project root (and Cursor's pre-edit
  hook passed no cwd). The hook now stamps the resolved project root on the
  audit entry, and writeAuditLog reads config from entry.cwd when present.

Tests: a /impeccable hooks edit preserves consent + quiet; writeAuditLog
resolves config auditLog from entry.cwd, not the fallback cwd.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(hooks): resolve a relative auditLog path against the project root (Bugbot)

A relative hook.auditLog was read from the project root but written relative to
the hook process cwd, so when those differ the log went to the wrong place.
writeAuditLog now resolves a relative target (from env or config) against the
same project root it reads config from. Absolute and ~/ paths are unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Fix hook consent recovery and smoke config

* Fix hook consent explainer for Cursor

* Fix empty hook target consent

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-14 02:42:19 -07:00

6.5 KiB

/impeccable hooks

Manage the design detector hook for the current project.

The hook runs the impeccable design detector on direct file edits to design-relevant files (.tsx, .jsx, .html, .vue, .svelte, .astro, .css, .scss, .sass, .less, .ts, .js). Claude Code and Codex use PostToolUse and push a short system reminder into the agent's context after the edit; findings get a correction prompt, pending issues get a re-nudge, and clean UI-ish files get a short ack unless quiet mode is on (hook.quiet in config). Plain .ts and .js files are still scanned, but stay quiet unless the detector finds something. Cursor uses preToolUse to block bad proposed writes before they land and stays silent when it allows a clean write.

This command toggles the hook per project by editing .impeccable/config.json (the unified Impeccable config; hook settings live under its hook key). Per-developer overrides, including the install consent decision (hook.consent) the CLI records, live in the gitignored .impeccable/config.local.json. Set hook.enabled: false to turn the hook off, hook.quiet: true to silence the clean/pending acks, or hook.auditLog to a file path for an NDJSON log. The legacy IMPECCABLE_HOOK_DISABLED, IMPECCABLE_HOOK_QUIET, and IMPECCABLE_HOOK_LOG env vars are still honored and override these config values when set.

Supported harnesses: Claude Code (.claude/settings.local.json in the project, which is gitignored so the hook stays machine-local; a hook you move into the shared settings.json is honored in place too), Codex (.codex/hooks.json in the project), and Cursor (.cursor/hooks.json in the project).

On Cursor, preToolUse checks proposed Write/Edit/Shell write content and denies only when the real detector finds an issue. The denial message is visible to the agent as the tool error, so the agent can reconsider before the bad write lands.

Routing

The first argument is the action. Defaults to status.

Action What it does
status Print current state, shared/local config paths, ignored rules / files / values, env override.
on Set enabled: true in .impeccable/config.json, record local hook consent as accepted, and install/repair provider hook manifests when the skill is installed.
off Set enabled: false in .impeccable/config.json.
ignore-rule <id> Append <id> to ignoreRules; for overused-font, requires --all-values.
ignore-file <glob> Append <glob> to ignoreFiles.
ignore-value <id> <value> [--shared] [--reason "..."] Append a rule/value suppression to shared .impeccable/config.json.
ignore-value <id> <value> --local [--reason "..."] Append a private rule/value suppression to .impeccable/config.local.json.
reset Delete the project config, dedup cache, and Cursor pending queue.

Flow

  1. Resolve the action from the user's argument. If no action was given, default to status.

  2. Invoke the admin script and pass the user's output through verbatim:

    node {{scripts_path}}/hook-admin.mjs <action> [args...]
    
  3. If <action> is off, follow up with a one-line note: "Done. New edits will not trigger the design hook in this project until you run {{command_prefix}}impeccable hooks on."

  4. If <action> is on, follow up with: "Done. The design hook will fire after the next Edit/Write/MultiEdit on a UI file."

  5. If <action> is ignore-value, ignore-file, or ignore-rule, just print the script output. The default scope is shared .impeccable/config.json; add --local only when the user explicitly asks for a private exception.

  6. If <action> is status, just print the script output. Do not add commentary unless the user asked a follow-up question.

Intentional findings

The hook itself never writes ignore config. Persist an exception only after the user explicitly confirms the flagged issue is intentional, and always go through hook-admin.mjs.

Prefer the narrowest exception:

  • If the finding line shows an exact ignore-value command, run that command. This writes shared .impeccable/config.json by default.
  • For overused-font, use ignore-value when the user confirms a specific font. Do not use ignore-rule overused-font for a specific font.
  • If the finding has no value-specific command, such as side-tab, prefer ignore-file <path> for the current file.
  • Use ignore-rule <id> only when the user asks to suppress that whole rule across the project. For broad overused-font suppression, use ignore-rule overused-font --all-values only when the user asks to ignore overused fonts generally.
  • Do not add source comments such as impeccable: ignore; inline comments pollute code and are not a supported suppression mechanism.

Example value-specific exception:

node {{scripts_path}}/hook-admin.mjs ignore-value overused-font Inter --shared --reason "User confirmed Inter is intentional"

Example whole-rule font exception:

node {{scripts_path}}/hook-admin.mjs ignore-rule overused-font --all-values --reason "User asked to ignore overused fonts generally"

Example file-scoped exception:

node {{scripts_path}}/hook-admin.mjs ignore-file "src/legacy/Card.tsx"

Constraints

  • Never modify .impeccable/config.json or .impeccable/config.local.json by hand from this command. Always go through hook-admin.mjs so writes stay validated and the file shape stays consistent.
  • Do not edit the hook scripts themselves (hook.mjs, hook-lib.mjs, hook-before-edit.mjs) from this flow. Those are skill plumbing.
  • Cursor can block a proposed write when the detector finds a real issue. Claude Code and Codex do not block the edit; they emit a post-edit reminder instead. Disabling stops both blocking and reminders.
  • The hook is bundled with the Impeccable skill and installed through project-local manifests: .claude/settings.local.json, .codex/hooks.json, and .cursor/hooks.json. On Codex, the user must approve the hook via /hooks the first time. On Cursor, confirm hooks are enabled under Settings -> Hooks.

Failure modes

  • If .impeccable/config.json or .impeccable/config.local.json is unreadable or malformed, the hook ignores that file and uses the remaining valid config/defaults. hook-admin.mjs status will show malformed files as ignored.
  • If the user asks to "disable the hook" globally, lead with {{command_prefix}}impeccable hooks off (persistent for this project; writes hook.enabled: false to config). The legacy IMPECCABLE_HOOK_DISABLED=1 env var also works as a one-shot override that follows the shell.