Files
pbakaus_impeccable/scripts/check-engine-release.mjs
T
Paul Bakaus aa65db332d Enforce engine-before-skill release order (triage D4)
The launcher, npm shim, and `impeccable install` all resolve the engine
binary for the pinned ENGINE_VERSION, so a skill/CLI release or a rust-swap
merge published ahead of the engine release + platform packages dead-ends
every install path. Add a mechanical guard:

- scripts/check-engine-release.mjs: verifies all five dist binaries +
  .sha256 and the five @impeccable/cli-<os>-<arch> npm platform packages
  exist for the pinned ENGINE_VERSION; names missing assets, exits non-zero.
  Honors IMPECCABLE_DOWNLOAD_BASE.
- release.mjs: hard-fails release:skill and release:cli when assets are
  missing; extension is exempt (vendored WASM detector, no engine exec).
- CI engine-release-ready job: runs the check, continue-on-error with a
  loud ::warning until the first engine release exists (flip to false then).
- CLAUDE.md Releases: documents the enforced ordering.

Prepared with AI assistance (Claude Code).
2026-08-31 20:00:04 -07:00

136 lines
5.2 KiB
JavaScript

#!/usr/bin/env node
/**
* Release-order guard (triage decision D4).
*
* The launcher (skill/scripts/impeccable), the npm shim (cli/bin/cli.js), and
* `impeccable install` all dead-end unless the engine release for the pinned
* ENGINE_VERSION exists FIRST: the five platform binaries in the impeccable-dist
* release channel AND the five @impeccable/cli-<os>-<arch> npm platform packages.
* Nothing else mechanically stops a maintainer from tagging the skill release (or
* merging and letting the sync workflow rewrite provider dirs) before those assets
* are published, which breaks every install path.
*
* This script verifies, for the pinned engine version, that:
* 1. each of the five release binaries impeccable-<os>-<arch>[.exe] is fetchable
* 2. each binary's .sha256 sidecar is fetchable
* 3. each npm platform package @impeccable/cli-<os>-<arch>@<version> is published
*
* Exits 0 when everything is present, non-zero (naming exactly what is missing)
* otherwise. release.mjs runs it before an engine-dependent release; CI runs it
* as a soft warning until the first engine release exists.
*
* node scripts/check-engine-release.mjs # check the pinned ENGINE_VERSION
* node scripts/check-engine-release.mjs --json # machine-readable report
*
* Environment:
* IMPECCABLE_DOWNLOAD_BASE dist release channel root (default: the public dist releases)
*/
import {
ENGINE_TARGETS,
DEFAULT_DOWNLOAD_BASE,
readEngineVersion,
assetUrl,
} from './fetch-engine.mjs';
const NPM_REGISTRY = 'https://registry.npmjs.org';
// A ranged GET is the most portable existence probe: GitHub release downloads
// answer HEAD inconsistently across their 302 to object storage, but a
// `Range: bytes=0-0` GET follows the redirect and returns 200/206 for a real
// asset and 404 for a missing one without pulling the whole binary.
async function urlExists(url) {
try {
const res = await fetch(url, { redirect: 'follow', headers: { Range: 'bytes=0-0' } });
return res.ok || res.status === 206;
} catch (err) {
return false;
}
}
function npmPackageUrl(target, version) {
// Scoped name: the slash is percent-encoded for the registry path.
const name = `@impeccable/cli-${target}`;
return `${NPM_REGISTRY}/${name.replace('/', '%2f')}/${version}`;
}
async function npmVersionExists(target, version) {
const url = npmPackageUrl(target, version);
try {
const res = await fetch(url, { redirect: 'follow' });
return res.ok;
} catch {
return false;
}
}
/**
* Check every asset for one engine version. Returns { ok, version, base, missing }
* where missing is a list of { kind, target, what, url } entries.
*/
export async function checkEngineRelease({
version = readEngineVersion(),
base = process.env.IMPECCABLE_DOWNLOAD_BASE || DEFAULT_DOWNLOAD_BASE,
} = {}) {
const missing = [];
await Promise.all(
ENGINE_TARGETS.map(async (target) => {
const binUrl = assetUrl(version, target, base);
const shaUrl = `${binUrl}.sha256`;
const npmUrl = npmPackageUrl(target, version);
const [binOk, shaOk, npmOk] = await Promise.all([
urlExists(binUrl),
urlExists(shaUrl),
npmVersionExists(target, version),
]);
if (!binOk) missing.push({ kind: 'binary', target, what: `impeccable-${target} binary`, url: binUrl });
if (!shaOk) missing.push({ kind: 'checksum', target, what: `impeccable-${target} .sha256`, url: shaUrl });
if (!npmOk) missing.push({ kind: 'npm', target, what: `@impeccable/cli-${target}@${version}`, url: npmUrl });
})
);
// Stable ordering for a readable report: by target, then binary/checksum/npm.
const order = { binary: 0, checksum: 1, npm: 2 };
missing.sort((a, b) => ENGINE_TARGETS.indexOf(a.target) - ENGINE_TARGETS.indexOf(b.target) || order[a.kind] - order[b.kind]);
return { ok: missing.length === 0, version, base, missing };
}
function report(result) {
const { ok, version, base, missing } = result;
if (ok) {
console.log(`✓ engine v${version} release is complete: all ${ENGINE_TARGETS.length} binaries + .sha256 + npm platform packages are published.`);
console.log(` dist channel: ${base}`);
return;
}
console.error(`✗ engine v${version} release is INCOMPLETE — ${missing.length} asset(s) missing:`);
for (const m of missing) {
console.error(` · ${m.what}`);
console.error(` ${m.url}`);
}
console.error('');
console.error(`Publish engine v${version} to the impeccable-dist release channel AND the`);
console.error('five @impeccable/cli-<os>-<arch> npm platform packages BEFORE releasing the');
console.error('skill or merging rust-swap. Ordering: engine release → platform packages →');
console.error('skill release/merge. See CLAUDE.md "Releases" and docs REVIEW-TRIAGE.md D4.');
console.error(` dist channel: ${base}`);
}
async function main(argv = process.argv.slice(2)) {
const json = argv.includes('--json');
const result = await checkEngineRelease();
if (json) {
console.log(JSON.stringify(result, null, 2));
} else {
report(result);
}
return result.ok ? 0 : 1;
}
// Run only when invoked directly, not when imported by release.mjs.
if (import.meta.url === `file://${process.argv[1]}`) {
main().then((code) => process.exit(code));
}