mirror of
https://github.com/pbakaus/impeccable.git
synced 2026-09-11 21:57:14 +03:00
8eedb150c5
* Fix React hydration mismatch from live pick-cursor class on SSR roots Entering pick mode toggled a `impeccable-live-pick-cursor` class on `document.documentElement` (and the insert-axis cursor wrote an inline `style.cursor` on it). `<html>`/`<body>` are server-rendered by frameworks like Next.js App Router, so a client-only attribute the server HTML never emitted makes React 19 log "a tree hydrated but some attributes of the server rendered HTML didn't match" on the next Fast-Refresh re-render. It surfaced as a console.error that flaked the nextjs-app-router live-e2e fixture's expectConsoleClean probe. This is the same root-cause class as the scroll-anchor lock fixed in #276 (client mutation of a hydrated SSR root), but a separate offender that fix did not cover. Apply the same shape: drive the pick / insert cursor entirely through the textContent of one injected `<style>` keyed by PICK_CURSOR_STYLE_ID, never by a class or inline style on `<html>`. Same computed effect (global `cursor` rule, reverted inside the overlay chrome), recreated on activation and removed on teardown. Regression guard updated to pin the new shape: no `document.documentElement.classList.*` mutation anywhere in the overlay, the cursor applied through the injected style, and the style removed by id on exit. Verified end-to-end: the nextjs-app-router live-e2e fixture now passes the full click -> Go -> cycle -> accept cycle with a clean console. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Remove now-dead pageInteractionCursorActive flag The flag's only reader was the old inline-style cleanup branch in syncPageInteractionCursor, which the stylesheet refactor removed. It is now write-only, so drop the declaration and both writes (Greptile review). No behavior change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>