mirror of
https://github.com/pbakaus/impeccable.git
synced 2026-09-12 22:26:38 +03:00
The engine no longer lives in a separate repo. `crates/` is a snapshot of the
open crates (foundation, core, common, context, live, hook, skills, comp,
comp-verbs, html, browser, detect, cli) plus `Cargo.lock`, taken as a git
archive of the engine repo at the commit that finished the boundary split.
None of that repo's history comes with it, and none of it should: the closed
half stays private.
The closed half is the rule engine. It ships as a prebuilt native archive per
target, `libimpeccable_detector.a`, published as a `detector-v<X>` GitHub
Release on this repo. `crates/core/build.rs` resolves and links it three ways:
`IMPECCABLE_DETECTOR_LIB=<dir>` for a local detector build, else the
`~/.impeccable/detector/<version>/<target>/` cache, else a download verified
against its `.sha256` sidecar. `crates/core` is a thin shim over a three-symbol
C ABI; nothing above it knows the boundary exists.
What changed versus the engine repo copy:
- Every crate manifest moves from `license-file.workspace` to
`license.workspace` (this workspace declares Apache-2.0), and the workspace
gains the `postcard` dependency the boundary encoding needs.
- The launcher contract test reads `skill/scripts/impeccable{,.cmd}` instead of
a sibling `launcher/` dir, and `engine_binary` downloads from
`github.com/pbakaus/impeccable/releases/download/engine-v<version>/` instead
of the retired dist repo. No oracle golden carried the old URL, so no
re-recording was owed.
- The tests that hunted for a public repo through `IMPECCABLE_PUBLIC_REPO`,
`../impeccable-second` or a hardcoded home directory now resolve the root as
`CARGO_MANIFEST_DIR/../..`, because they are in it. The env var stays as an
override for an out-of-tree checkout.
- The in-page bundle (`detect-antipatterns-browser.js`, 2 MB of generated wasm
glue) is no longer tracked. `crates/core/build.rs` resolves it beside the
archive, hands the path to `impeccable_core::browser::IN_PAGE_BUNDLE_JS`, and
live mode serves that. `scripts/check-detector-release.mjs` now requires it
and its `.sha256` in a detector release.
- The live crate embeds `skill/scripts/live-browser*.js` and
`modern-screenshot.umd.js` directly rather than through vendored copies, so
the binary and the installed skill cannot drift.
- `crates/browser/assets/` (an unused second copy of the bundle) is gone.
- `tests/lib/engine-bin.mjs` also accepts `target/release/impeccable`, so a
plain `cargo build --release -p impeccable` is enough to run `bun run test`.
Verified with the archive from a local detector build: `cargo test --workspace`
267 pass, oracle 795 pass / 0 fail / 0 missing, `bun run build` clean, the
default suite green, and the launcher's `engine-probe` handshake answering
through `skill/scripts/impeccable`.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vau2X53xGTjjTCXWMVBoNY
39 lines
1.4 KiB
Rust
39 lines
1.4 KiB
Rust
//! Print the JS `detect --json` array for one HTML file through the static
|
|
//! engine (no design system, inline ignores as `--no-config`: disabled).
|
|
//!
|
|
//! cargo run -p impeccable-html --example detect_json -- path/to/file.html
|
|
//!
|
|
//! `--inline-ignores` re-enables the whole-file waivers. The regex engine's
|
|
//! text-content analyzers are wired from the `detect` crate so the output can
|
|
//! be diffed against the JS CLI directly.
|
|
|
|
use impeccable_html::{detect_html, DetectHtmlOptions};
|
|
use std::path::Path;
|
|
|
|
fn main() {
|
|
let args: Vec<String> = std::env::args().skip(1).collect();
|
|
let inline = args.iter().any(|a| a == "--inline-ignores");
|
|
let path = args.iter().find(|a| !a.starts_with("--")).cloned();
|
|
let Some(path) = path else {
|
|
eprintln!("usage: detect_json [--inline-ignores] <file.html>");
|
|
std::process::exit(1);
|
|
};
|
|
let analyzers = |content: &str, file_path: &str| {
|
|
impeccable_detect::detect_text::run_text_content_analyzers(content, file_path, None)
|
|
};
|
|
let opts = DetectHtmlOptions {
|
|
inline_ignores_disabled: !inline,
|
|
text_content_analyzers: Some(&analyzers),
|
|
..Default::default()
|
|
};
|
|
match detect_html(Path::new(&path), &opts) {
|
|
Ok(findings) => {
|
|
println!("{}", serde_json::to_string_pretty(&findings).unwrap());
|
|
}
|
|
Err(e) => {
|
|
eprintln!("Error: {e}");
|
|
std::process::exit(1);
|
|
}
|
|
}
|
|
}
|