mirror of
https://github.com/pbakaus/impeccable.git
synced 2026-09-15 07:36:50 +03:00
The engine no longer lives in a separate repo. `crates/` is a snapshot of the
open crates (foundation, core, common, context, live, hook, skills, comp,
comp-verbs, html, browser, detect, cli) plus `Cargo.lock`, taken as a git
archive of the engine repo at the commit that finished the boundary split.
None of that repo's history comes with it, and none of it should: the closed
half stays private.
The closed half is the rule engine. It ships as a prebuilt native archive per
target, `libimpeccable_detector.a`, published as a `detector-v<X>` GitHub
Release on this repo. `crates/core/build.rs` resolves and links it three ways:
`IMPECCABLE_DETECTOR_LIB=<dir>` for a local detector build, else the
`~/.impeccable/detector/<version>/<target>/` cache, else a download verified
against its `.sha256` sidecar. `crates/core` is a thin shim over a three-symbol
C ABI; nothing above it knows the boundary exists.
What changed versus the engine repo copy:
- Every crate manifest moves from `license-file.workspace` to
`license.workspace` (this workspace declares Apache-2.0), and the workspace
gains the `postcard` dependency the boundary encoding needs.
- The launcher contract test reads `skill/scripts/impeccable{,.cmd}` instead of
a sibling `launcher/` dir, and `engine_binary` downloads from
`github.com/pbakaus/impeccable/releases/download/engine-v<version>/` instead
of the retired dist repo. No oracle golden carried the old URL, so no
re-recording was owed.
- The tests that hunted for a public repo through `IMPECCABLE_PUBLIC_REPO`,
`../impeccable-second` or a hardcoded home directory now resolve the root as
`CARGO_MANIFEST_DIR/../..`, because they are in it. The env var stays as an
override for an out-of-tree checkout.
- The in-page bundle (`detect-antipatterns-browser.js`, 2 MB of generated wasm
glue) is no longer tracked. `crates/core/build.rs` resolves it beside the
archive, hands the path to `impeccable_core::browser::IN_PAGE_BUNDLE_JS`, and
live mode serves that. `scripts/check-detector-release.mjs` now requires it
and its `.sha256` in a detector release.
- The live crate embeds `skill/scripts/live-browser*.js` and
`modern-screenshot.umd.js` directly rather than through vendored copies, so
the binary and the installed skill cannot drift.
- `crates/browser/assets/` (an unused second copy of the bundle) is gone.
- `tests/lib/engine-bin.mjs` also accepts `target/release/impeccable`, so a
plain `cargo build --release -p impeccable` is enough to run `bun run test`.
Verified with the archive from a local detector build: `cargo test --workspace`
267 pass, oracle 795 pass / 0 fail / 0 missing, `bun run build` clean, the
default suite green, and the launcher's `engine-probe` handshake answering
through `skill/scripts/impeccable`.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vau2X53xGTjjTCXWMVBoNY
48 lines
1.9 KiB
Rust
48 lines
1.9 KiB
Rust
//! impeccable-comp-verbs: the four comp-fidelity verb orchestrators
|
|
//! (`comp-spec`, `comp-diff`, `font-match`, `build-phase`), ported from the
|
|
//! skill's JS scripts of the same name.
|
|
//!
|
|
//! OPEN and free of the closed `core` crate. It wires only the pure `comp`
|
|
//! foundation plus `common` (`Io`). Two things it cannot do on its own are
|
|
//! injected by the CLI so the browser (and its `core` dependency) stays out:
|
|
//!
|
|
//! - font-match's headless rendering of font specimens: a [`font_match::FontRenderer`].
|
|
//! - build-phase's organic-clip-path CSS scan (a rule that lives in `core`):
|
|
//! a [`build_phase::OrganicScan`] closure.
|
|
//!
|
|
//! The font-index catalog is resolved at run time the way concept-seed resolves
|
|
//! its catalog (`IMPECCABLE_CATALOG_DIR`, then the skill's shipped copy); it is
|
|
//! never committed to the engine repo. See [`font_match`].
|
|
|
|
pub mod build_phase;
|
|
pub mod comp_diff;
|
|
pub mod comp_spec;
|
|
pub mod font_match;
|
|
mod util;
|
|
|
|
use impeccable_common::Io;
|
|
|
|
/// `impeccable comp-spec ...`
|
|
pub fn run_comp_spec(argv: &[String], io: &mut Io) -> i32 {
|
|
comp_spec::run(argv, io)
|
|
}
|
|
|
|
/// `impeccable comp-diff ...`
|
|
pub fn run_comp_diff(argv: &[String], io: &mut Io) -> i32 {
|
|
comp_diff::run(argv, io)
|
|
}
|
|
|
|
/// `impeccable font-match ...`. `renderer` supplies the headless-browser
|
|
/// specimen rendering; pass [`font_match::NoRenderer`] where no browser is
|
|
/// available (the catalog/shortlist path owns the ranking then).
|
|
pub fn run_font_match(argv: &[String], io: &mut Io, renderer: &mut dyn font_match::FontRenderer) -> i32 {
|
|
font_match::run(argv, io, renderer)
|
|
}
|
|
|
|
/// `impeccable build-phase ...`. `organic_scan` is the injected CSS
|
|
/// organic-clip-path scanner (pass [`build_phase::no_organic_scan`] to skip it,
|
|
/// matching the JS degraded path).
|
|
pub fn run_build_phase(argv: &[String], io: &mut Io, organic_scan: build_phase::OrganicScan) -> i32 {
|
|
build_phase::run(argv, io, organic_scan)
|
|
}
|