mirror of https://github.com/pbakaus/impeccable.git synced 2026-09-19 09:36:59 +03:00

Files

T

Paul BakausandClaude Fable 5.1 f285b3d7f1 The rendered rules measure what rendered: the line instead of the box that holds it, the space around the text instead of the declared padding, gray by chroma at its own lightness, the AI palette by two tell hues rather than one accent, and the eyebrow named as the element its own design document declares

Five browser rules were reporting something other than what the reader sees,
and a review that charges those numbers is charging noise.

- `line-length` measured `rect.width / (fontSize * 0.5)`, the box's capacity.
  A paragraph in a 1022px column whose text stops at 571px was charged 142
  characters a line it never rendered. The probe now hands back the client
  rects of the direct text one per line box (`direct_text_line_rects`), the
  characters divide between the lines in proportion to the ink each carries,
  and the charge needs more than one long line: the harm named is the eye
  tracking back to the start of the next line, which takes a column to do.
- `cramped-padding` read the declared padding. A 44px control with
  `padding: 0 16px` and a flex-centred label has 12px of air above the label
  and was charged "0px vertical padding"; the measurement is now the inset
  between the rendered text and the inside of the border box. Its wrapper half
  read a text-bearing child's border box the same way, so a `<td>` that fills
  its table and insets its own text counted as flush; it reads the text now.
- `gray-on-color` called anything under 0.85 relative luminance gray, which
  takes in every off-white: `#e8edf2` measures 0.84 there and 0.93 as
  lightness. Gray is now low chroma at the lightness the ink actually sits at
  (saturation, which is chroma normalized for lightness) and neither of the
  two neutral inks a coloured surface carries. The contrast check beside it is
  untouched, and the recorded vectors still pass.
- `ai-color-palette` charged every hue between 160° and 200° on a dark ground
  as neon, which lit one ordinary teal accent 18 places on a page with nothing
  wrong with it. A gradient in a tell hue is still the pattern on its own;
  flat neon ink on near-black waits for a second tell hue to turn up somewhere
  on the page, because one saturated accent on a dark system is an accent.
- `kicker-above-heading` reported against `body`, so a charged row had nothing
  to point at, and it fired on eyebrows a design document documents. It names
  the eyebrow element now, and stands down where the repository's DESIGN.md
  declares the class by name — the prose's backticked class selectors travel
  on the design-system config the colour and radius rules already read.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LQBUunp8QttxZqihybNmtL

2026-09-18 15:12:16 -07:00

00-header.js

The Rust engine: one binary replaces every script and the JS detector, fully open (#714 )

2026-09-04 10:42:45 -07:00

10-probe.js

The rendered rules measure what rendered: the line instead of the box that holds it, the space around the text instead of the declared padding, gray by chroma at its own lightness, the AI palette by two tell hues rather than one accent, and the eyebrow named as the element its own design document declares

2026-09-18 15:12:16 -07:00

15-snapshot.js

The Rust engine: one binary replaces every script and the JS detector, fully open (#714 )

2026-09-04 10:42:45 -07:00

30-scan-common.js

The Rust engine: one binary replaces every script and the JS detector, fully open (#714 )

2026-09-04 10:42:45 -07:00

35-visual.js

The Rust engine: one binary replaces every script and the JS detector, fully open (#714 )

2026-09-04 10:42:45 -07:00

40-overlay.js

The Rust engine: one binary replaces every script and the JS detector, fully open (#714 )

2026-09-04 10:42:45 -07:00

50-scan.js

The Rust engine: one binary replaces every script and the JS detector, fully open (#714 )

2026-09-04 10:42:45 -07:00

60-offscreen.js

The Rust engine: one binary replaces every script and the JS detector, fully open (#714 )

2026-09-04 10:42:45 -07:00

99-footer.js

The Rust engine: one binary replaces every script and the JS detector, fully open (#714 )

2026-09-04 10:42:45 -07:00

README.md

The Rust engine: one binary replaces every script and the JS detector, fully open (#714 )

2026-09-04 10:42:45 -07:00

README.md

browser-bundle: the page-side JavaScript of the detector

Plain JavaScript that runs inside a page or the extension: the DOM probe the wasm rule core calls back into, the page snapshot producer, the visual-contrast sampling IO, the overlay UI, the scan API and the extension's offscreen document. Measurement and presentation only; every rule decision is a call into the wasm rule core built from crates/core (docs/ENGINE.md).

Two consumers:

crates/browser embeds 15-snapshot.js (the snapshot producer the URL engine injects; no WebAssembly runs in the page).
crates/bundle (the impeccable-bundle library) embeds every file here with include_str! and concatenates them, in filename order, with the wasm core into the in-page bundle plus the extension's extension/detector/ pieces. cargo xtask bundle is its caller inside this workspace: it writes dist/detect-antipatterns-browser.js, copies that bundle to the tracked crates/live/assets/detect-antipatterns-browser.js the engine embeds, and writes the extension pieces. A downstream crate with its own rule pack calls the library directly (docs/ENGINE.md).

Because the files are embedded, a new one here has to be added to PAGE_JS in crates/bundle/src/lib.rs (and to the order it is concatenated in); a test fails when the two lists disagree.

15-snapshot.js lists the computed-style properties the rules read; the bundle build checks that list against the core's and fails when they drift.