mirror of
https://github.com/pbakaus/impeccable.git
synced 2026-09-13 06:36:26 +03:00
Paul BakausandClaude
4e381305e1
Addresses the review findings on #371, plus several the bots did not catch. All fixes have regression coverage that fails on the prior code. Source corruption: - Vue accept dropped valueless root attrs (disabled, v-cloak) and, worse, rewrote @click="x" as a literal click="x" DOM attribute, because the attr parser was name-anchored and skipped the sigil. Tokenize the whole Vue attr grammar and normalize shorthands so accept round-trips directives. - --variant was interpolated unescaped into a RegExp, so --variant '.*' matched the original block first and reported a successful accept while silently restoring the original. Validate against the digits pattern the browser and the /events schema already enforce. - --id reached path.join unvalidated, so --id ../../../../etc/evil wrote and read receipts outside the project. Hoist the existing safeSessionId check into impeccable-paths and apply it at every id-to-path sink. Accept/lock correctness: - Plain HTML/JSX accept and discard did not catch SOURCE_LOCKED, so contention exited non-zero with empty stdout and the agent got no JSON to retry on. - Lock staleness was mtime-only and never read the pid it records: a holder whose critical section outran 60s had its live lock swept, admitting a second writer to the same file, while a crashed holder blocked accepts for a full 60s. Decide staleness by owner liveness, and release only our own lock. Detector: - isNeutralColor only parses computed color forms, so routing authored CSS through it reported inset 4px 0 0 #000 / black / #e5e7eb as chromatic side-tab stripes. Add an authored-color neutrality test covering hex and named neutrals; the fixture had no literal-color cases at all. - Rule line numbers were off by one for every rule after the first, and commented-out CSS was scanned as live rules. Server: - An error reply carries no sourceEventType, and inferSourceEventType returned undefined, which acknowledgePendingEvent treats as a wildcard: a stale generate worker's failure consumed the user's queued Accept, which then reached no agent and left the browser in SAVING forever. - The generate preflight spawned live-wrap.mjs synchronously inside the request handler, freezing the single-threaded server for the whole scaffold (~7.6s measured on this repo, 15s ceiling) and stalling Accept/Discard/SSE. Make it async, claiming the lease before the first await so no event double-delivers. - Every browser checkpoint was echoed back as variant_progress, so a Tune slider drag remounted the preview under the user's cursor and latched the *_reviewable phases from the wrong trigger. Gate on the reason. Cleanup: - Collapse four divergent benchmark argv parsers into scripts/lib/cli-args.mjs. Three silently misread flags: --iterations 20 benchmarked 5, --agent llm ran the fake agent, --median-target=0.4 used the default threshold. - Drop a snapshot cache this branch made write-only (it grew per session for the server's lifetime and was never read), a dead exported reconcile helper, and the unused deferReply branch. Prepared with AI assistance under maintainer direction. Co-Authored-By: Claude <noreply@anthropic.com>
87 lines
2.9 KiB
JavaScript
87 lines
2.9 KiB
JavaScript
#!/usr/bin/env node
|
|
|
|
import { readdir, readFile, writeFile } from 'node:fs/promises';
|
|
import { dirname, join, resolve } from 'node:path';
|
|
import { fileURLToPath } from 'node:url';
|
|
|
|
import Anthropic from '@anthropic-ai/sdk';
|
|
|
|
import { FIXTURES_DIR } from '../tests/live-e2e/session.mjs';
|
|
import { parseArgs } from './lib/cli-args.mjs';
|
|
import { loadBenchmarkEnv } from './lib/live-provider-benchmark.mjs';
|
|
import {
|
|
buildRenderedReviewContext,
|
|
judgeRenderedVariants,
|
|
summarizeRenderedJudgeRuns,
|
|
} from './lib/live-rendered-quality.mjs';
|
|
|
|
const ROOT = resolve(dirname(fileURLToPath(import.meta.url)), '..');
|
|
const args = parseArgs(process.argv.slice(2));
|
|
const artifactRoot = resolve(ROOT, required(args, 'artifacts'));
|
|
const fixtureName = String(args.fixture || 'vite8-react-brand-fidelity');
|
|
const fixture = JSON.parse(await readFile(join(FIXTURES_DIR, fixtureName, 'fixture.json'), 'utf-8'));
|
|
if (fixture.renderedQuality?.remoteSafe !== true) throw new Error(`fixture ${fixtureName} is not explicitly remote-safe`);
|
|
|
|
loadBenchmarkEnv({ repoRoot: ROOT, explicitPath: args.envFile ? resolve(String(args.envFile)) : null });
|
|
if (!process.env.ANTHROPIC_API_KEY) throw new Error('ANTHROPIC_API_KEY is required');
|
|
|
|
const review = buildRenderedReviewContext({
|
|
fixture: fixtureName,
|
|
fixtureConfig: fixture,
|
|
action: args.action,
|
|
brief: args.brief,
|
|
});
|
|
const model = String(args.model || 'claude-sonnet-4-6');
|
|
const scenario = String(args.scenario || 'plain');
|
|
const scenarioRoot = join(artifactRoot, scenario);
|
|
const runNames = (await readdir(scenarioRoot, { withFileTypes: true }))
|
|
.filter((entry) => entry.isDirectory() && /^run-\d+$/.test(entry.name))
|
|
.map((entry) => entry.name)
|
|
.sort();
|
|
if (runNames.length === 0) throw new Error(`no rendered runs found under ${scenarioRoot}`);
|
|
|
|
const client = new Anthropic({ apiKey: process.env.ANTHROPIC_API_KEY });
|
|
const runs = [];
|
|
for (const runName of runNames) {
|
|
const runRoot = join(scenarioRoot, runName);
|
|
const variants = [1, 2, 3].map((variantId) => ({
|
|
variantId,
|
|
path: join(runRoot, `variant-${variantId}.png`),
|
|
}));
|
|
process.stderr.write(`[live-rendered-judge] ${runName}\n`);
|
|
runs.push({
|
|
run: runName,
|
|
renderedJudge: await judgeRenderedVariants({
|
|
client,
|
|
model,
|
|
action: review.action,
|
|
brief: review.brief,
|
|
safeContext: review.safeContext,
|
|
originalPath: join(runRoot, 'original.png'),
|
|
variants,
|
|
}),
|
|
});
|
|
}
|
|
|
|
const report = {
|
|
schemaVersion: 1,
|
|
generatedAt: new Date().toISOString(),
|
|
fixture: fixtureName,
|
|
scenario,
|
|
model,
|
|
artifacts: artifactRoot,
|
|
review,
|
|
summary: summarizeRenderedJudgeRuns(runs),
|
|
runs,
|
|
};
|
|
const json = `${JSON.stringify(report, null, 2)}\n`;
|
|
if (args.output) await writeFile(resolve(ROOT, String(args.output)), json, 'utf-8');
|
|
process.stdout.write(json);
|
|
|
|
function required(values, key) {
|
|
const value = values[key];
|
|
if (!value) throw new Error(`--${key}=<value> is required`);
|
|
return String(value);
|
|
}
|
|
|