This PR was merged into the master branch.
Discussion
----------
[symfony] Correct versions for symfony/orm-pack and symfony/profiler-pack
| Q | A
| ------------- | ---
| License | MIT
Also added aliases `doctrine-orm` and `doctrine` for `symfony/orm-pack` to better address symfony/flex#28 and symfony/recipes#24.
Commits
-------
38f8251 [symfony] Correct versions for symfony/orm-pack and symfony/profiler-pack
This PR was merged into the master branch.
Discussion
----------
[lexik/jwt-authentication-bundle] Fix generate-jwt-keys target in Makefile
| Q | A |
| --- | --- |
| License | MIT |
The definition of the `generate-jwt-keys` target broke the `Makefile` when the `openssl` binary is not available.
Commits
-------
651c84f [lexik/jwt-authentication-bundle] Fix generate-jwt-keys target in Makefile
This PR was merged into the master branch.
Discussion
----------
Add the profiler pack
fixedsymfony/flex#90
License MIT
Commits
-------
5824ee7 added the profiler pack
This PR was squashed before being merged into the master branch (closes#76).
Discussion
----------
[Doc] Add missing doc about the "container" configurator
| Q | A
| ------------- | ---
| License | MIT
Was missing, not sure it was by purpose or not, but I propose to add it anyway, feel free to close it if you think it's not relevant.
Just about the bottom-note I added, it's because of [this "fixme" comment](https://github.com/symfony/flex/blob/master/src/Configurator/ContainerConfigurator.php#L27-L30), I'm not sure this warning should be present in the docs or if we shouldn't tell about it as the "fixme" might be solved one day 🤔
Commits
-------
c101117 [Doc] Add missing doc about the "container" configurator
This PR was squashed before being merged into the master branch (closes#75).
Discussion
----------
[Translation] Allow using "etc/translations" to store translations files
| Q | A
| ------------- | ---
| License | MIT
For now, translations are stored in Symfony's default directory which is `%kernel.root_dir%/Resources/translations`, resolved to `src/Resources/translations`.
I find it much more convenient to store it in `etc/translations`.
I'm not sure about some things though:
* The yaml file name, `translation.yaml`, as this config is part of the framework and we cannot "update" the `framework.yaml` file with this recipe 😕 Maybe should I rename it `symfony_translation.yaml` or `translator`, or even maybe `symfony_translator`?
* Adding `%locale%` parameter with `en` by default. As it's not mandatory to have a `%locale%` parameter in Symfony apps anymore, I thought it would be useful to setup at least this value and add a comment to tell the user to update it depending on his/her application.
What do you think?
Commits
-------
b3dc37b [Translation] Allow using "etc/translations" to store translations files
This PR was merged into the master branch.
Discussion
----------
[lexik/jwt-authentication-bundle] Fix configured key path
Only using `%ETC_DIR%` leads to
> Private key "etc/jwt/private.pem" does not exist or is not readable.
This fixes it by prefixing paths by `%kernel.project_dir%/` in the bundle config.
Commits
-------
7f5180d [lexik/jwt-authentication-bundle] Fix configured key path
This PR was merged into the master branch.
Discussion
----------
[doctrine/doctrine-bundle] Escape DATABASE_URL env value
When requiring `doctrine/doctrine-bundle` (more often `orm-pack`), the following is added to the project `.env`:
```
DATABASE_URL=mysql://root@127.0.0.1:3306/symfony?charset=utf8mb4&serverVersion=5.7
```
The makefile seems to parse that properly (tested on OSX and debian).
But running `source .env` from the cli (for debugging the .env vars, as shown in [dotenv docs](http://symfony.com/doc/master/components/dotenv.html)) gives
> .env:15: parse error near `&'
This fixes it by adding quotes around the value.
Commits
-------
1e60b1f [doctrine/doctrine-bundle] Escape DATABASE_URL env value
This PR was merged into the master branch.
Discussion
----------
Remove version_aliases configuration setting
`version_aliases` was a bad idea as it incurs too much manual maintenance as we need to remember to add new minor and major versions. That's fragile and we will probably forget to do it promptly. That's even worse for contributed recipes.
So, instead (and as already documented in the README, so not part of the diff), the version of the recipe if the minimum version that the recipe supports. So, if there is only one recipe for version "3.3", the recipe will be applied for all versions >= 3.3 (including 3.x, 4.x, ...).
If a version introduces changes that has an impact on the recipe , then a new directory with the version when the break appeared should be created with the new recipe, which makes total sense.
Commits
-------
07a5c67 removed version_aliases configuration setting
This PR was merged into the master branch.
Discussion
----------
Tweak configuration for app.yaml
symfony/symfony-standard#1070
Commits
-------
7581f44 tweaked configuration for app.yaml
This PR was merged into the master branch.
Discussion
----------
fix error exit code
In case that the server could not start we should indicate the failure
with a non-zero exit code.
This addresses @stof's comment in https://github.com/symfony/recipes/pull/54#discussion_r116276643.
Commits
-------
9acb162 fix error exit code
SymfonyandGitHub
Samuel ROZE
Fabien Potencier
Fabien PotencierandGitHub
Teoh Han Hui
Alex Rock AnceletandFabien Potencier
Robin Chalas
Christian Flothmann