This PR was merged into the master branch.
Discussion
----------
[lexik/jwt-authentication-bundle] Fix configured key path
Only using `%ETC_DIR%` leads to
> Private key "etc/jwt/private.pem" does not exist or is not readable.
This fixes it by prefixing paths by `%kernel.project_dir%/` in the bundle config.
Commits
-------
7f5180d [lexik/jwt-authentication-bundle] Fix configured key path
This PR was merged into the master branch.
Discussion
----------
[doctrine/doctrine-bundle] Escape DATABASE_URL env value
When requiring `doctrine/doctrine-bundle` (more often `orm-pack`), the following is added to the project `.env`:
```
DATABASE_URL=mysql://root@127.0.0.1:3306/symfony?charset=utf8mb4&serverVersion=5.7
```
The makefile seems to parse that properly (tested on OSX and debian).
But running `source .env` from the cli (for debugging the .env vars, as shown in [dotenv docs](http://symfony.com/doc/master/components/dotenv.html)) gives
> .env:15: parse error near `&'
This fixes it by adding quotes around the value.
Commits
-------
1e60b1f [doctrine/doctrine-bundle] Escape DATABASE_URL env value
This PR was merged into the master branch.
Discussion
----------
Remove version_aliases configuration setting
`version_aliases` was a bad idea as it incurs too much manual maintenance as we need to remember to add new minor and major versions. That's fragile and we will probably forget to do it promptly. That's even worse for contributed recipes.
So, instead (and as already documented in the README, so not part of the diff), the version of the recipe if the minimum version that the recipe supports. So, if there is only one recipe for version "3.3", the recipe will be applied for all versions >= 3.3 (including 3.x, 4.x, ...).
If a version introduces changes that has an impact on the recipe , then a new directory with the version when the break appeared should be created with the new recipe, which makes total sense.
Commits
-------
07a5c67 removed version_aliases configuration setting
This PR was merged into the master branch.
Discussion
----------
Tweak configuration for app.yaml
symfony/symfony-standard#1070
Commits
-------
7581f44 tweaked configuration for app.yaml
This PR was merged into the master branch.
Discussion
----------
fix error exit code
In case that the server could not start we should indicate the failure
with a non-zero exit code.
This addresses @stof's comment in https://github.com/symfony/recipes/pull/54#discussion_r116276643.
Commits
-------
9acb162 fix error exit code
This PR was merged into the master branch.
Discussion
----------
[FrameworkBundle] improve Makefile serve target
Related to #49, I don't know if this the best way to do it. But as the Makefile is composed I don't think it's possible to use advanced Makefile features 😟
@greg0ire suggested something like this:
```makefile
.PHONY: serve
CONSOLE=bin/console
$(CONSOLE):
@echo 'Woops! The console does not exist'
@exit
serve: bin/console
bin/console list server|grep server:start
bin/console server:start
```
But don't know if you can have multiple targets with the same name but different conditions?
Commits
-------
7a7de4b [FrameworkBundle] improve Makefile serve target
This PR was squashed before being merged into the master branch (closes#62).
Discussion
----------
Doctrine Migrations
This recipe adds doctrine migrations to the official Symfony recipes repository.
Commits
-------
52e1ebe Doctrine Migrations
This PR was merged into the master branch.
Discussion
----------
replaced php_sapi_name() with PHP_SAPI
Commits
-------
df6b8a0 replaced php_sapi_name() with PHP_SAPI
This PR was merged into the master branch.
Discussion
----------
[PhpUnit] Use the new KERNEL_CLASS var for KernelTestCase
Once https://github.com/symfony/symfony/pull/22668 is merged.
Commits
-------
c32f3e5 [PhpUnit] Use the new KERNEL_CLASS var for KernelTestCase
This PR was merged into the master branch.
Discussion
----------
Use single quotes in yaml files
Commits
-------
b39aa63 Use single quotes in yaml files
This PR was squashed before being merged into the master branch (closes#37).
Discussion
----------
Document the special %generate(secret)% env var value
Some recipes are starting to use this feature (see https://github.com/symfony/recipes-contrib/pull/5/files) so let's document it.
Commits
-------
8a103f4 Document the special %generate(secret)% env var value
Fabien Potencier
Robin Chalas
Christian Flothmann
Sebastiaan Stok
Ricardo de VriesandFabien Potencier
Maxime Steinhausser
Roland FranssenandGitHub
Yonel Ceruto
Sanpi
Maxime SteinhausserandGitHub
Jules Pietri
Guilhem Niot
Guilhem NiotandGitHub
