mirror of
https://github.com/magnus919/agent-skills.git
synced 2026-09-21 16:46:26 +03:00
Magnus Hedemark
c5c4d2434a
Comprehensive open source contribution guidance with progressive disclosure. Restructured from a single ~23K-token monolithic SKILL.md into a concise ~1.2K-token orchestrator with 10 focused reference files. Changes: - SKILL.md: 1,720 lines → 100 lines (AgentSkills.io compliant frontmatter) - 10 new reference files covering phases 0a-4, pitfalls, default posture - Portable PR template compliance checker script (stdlib-only) - All personal context scrubbed for public export - AGENTS.md + README.md updated with trigger table entry Signed-off-by: Magnus Hedemark <magnus919@pm.me>
21 lines
1.0 KiB
Markdown
21 lines
1.0 KiB
Markdown
## Phase 3: After Submitting
|
|
|
|
### CI and Code Review
|
|
|
|
1. **Monitor CI** — if it fails, fix it promptly. Don't leave a broken PR sitting.
|
|
2. **Respond to review feedback** — address each comment, even if just to acknowledge
|
|
3. **Don't take feedback personally** — code reviews are about the code, not you
|
|
4. **Explain your reasoning** when you disagree with a reviewer's suggestion
|
|
5. **Make requested changes promptly** — maintainers reviewing stale PRs is wasted effort
|
|
|
|
### What to Do If...
|
|
|
|
| Situation | Response |
|
|
|---|---|
|
|
| CI fails | Fix and push. Don't force-push over review history unless the project prefers it |
|
|
| Reviewer asks for changes | Make them, push new commits, re-request review when ready |
|
|
| PR goes stale (no response) | Bump politely after 1-2 weeks: "Friendly ping — anything else needed here?" |
|
|
| PR is closed without merge | Don't argue. If it's important, open a discussion to understand why |
|
|
| You need to abandon the PR | Close it and leave a comment explaining why so others don't duplicate |
|
|
|
|
--- |