skills/pbakaus_impeccable
1
0
Fork 0
mirror of https://github.com/pbakaus/impeccable.git synced 2026-09-12 06:06:37 +03:00
Code Issues Packages Projects Releases Wiki Activity

Keep decision body order in fallback

Browse Source 
Prepared and verified with AI assistance under maintainer authorization.
This commit is contained in:
Paul Bakaus
2026-08-12 15:25:04 -04:00
parent 37be3fa36b
commit 3a26dcb809
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
skill/scripts/serve-question.mjs
+2
View File
@@ -907,8 +907,10 @@ function page() {
const textOnlyFacts = m.querySelector('template.text-only-facts');
const choose = body?.querySelector(':scope > button.choose');
if (body && textOnlyFacts && choose) {
const plainDetail = body.querySelector(':scope > .detail:not(.more)');
[...body.children].filter((el) => el.classList.contains('fact') || el.matches('.detail.more')).forEach((el) => el.remove());
choose.before(textOnlyFacts.content.cloneNode(true));
if (plainDetail) choose.before(plainDetail);
}
card?.classList.remove('flipped');
front?.classList.add('text-only');
tests/new-work-e2e.test.mjs
+11 -1
View File
@@ -343,6 +343,12 @@ describe('new-work-e2e: serve-question decision page', () => {
body: 'Body copy must remain present exactly once.',
comp: path.join(cwd, '.impeccable', 'mocks', 'decision', 'body-missing.webp'),
},
{
id: 'plain-body', label: 'Plain Body',
body: 'Plain body follows the promoted facts.',
viewport: 'A compact neighborhood notice fills the first viewport.',
comp: path.join(cwd, '.impeccable', 'mocks', 'decision', 'plain-body-missing.webp'),
},
{
id: 'board-only', label: 'Board Fallback',
board,
@@ -366,7 +372,7 @@ describe('new-work-e2e: serve-question decision page', () => {
await page.waitForSelector('.card[data-id="assigned"] .media.comp-pending');
await page.evaluate(() => window.__advanceDecisionClock(241000));
await page.waitForFunction(() => ['assigned', 'kept-only', 'body-only'].every((id) =>
await page.waitForFunction(() => ['assigned', 'kept-only', 'body-only', 'plain-body'].every((id) =>
!document.querySelector(`.card[data-id="${id}"] .media`)), null, { timeout: 6000 });
await page.waitForSelector('.card[data-id="board-only"] .media.stand-in');
@@ -375,6 +381,8 @@ describe('new-work-e2e: serve-question decision page', () => {
const frontRead = await page.$eval('.card[data-id="assigned"] .face.front', (el) => el.textContent);
const keptOnlyRead = await page.$eval('.card[data-id="kept-only"] .face.front', (el) => el.textContent);
const bodyOnlyRead = await page.$eval('.card[data-id="body-only"] .face.front', (el) => el.textContent);
const plainBodyOrder = await page.$$eval('.card[data-id="plain-body"] .body > .fact, .card[data-id="plain-body"] .body > .detail',
(els) => els.map((el) => el.className));
const boardFallbackLabel = await page.$eval('.card[data-id="board-only"] .stand-in-label', (el) => el.textContent);
await context.close();
@@ -387,6 +395,8 @@ describe('new-work-e2e: serve-question decision page', () => {
assert.match(keptOnlyRead, /Keep the hand-painted timetable/, 'kept-only content survives without a back face');
assert.equal(bodyOnlyRead.match(/Body copy must remain present exactly once\./g)?.length, 1,
'body prose already on a no-back front is not duplicated');
assert.deepEqual(plainBodyOrder, ['fact', 'detail'],
'thesis-less body prose follows the facts promoted from the missing comp');
assert.equal(boardFallbackLabel, 'inspiration · comp pending', 'board-only art remains as the labeled fallback');
} finally {
await stopDaemon(cwd, key);