skills/pbakaus_impeccable
1
0
Fork 0
mirror of https://github.com/pbakaus/impeccable.git synced 2026-09-11 21:57:14 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(live): don't clear scroll key inside stopScrollLock

Browse Source 
startScrollLock calls stopScrollLock at the top as a reset. I had
clearScrollY() inside stopScrollLock, so every Go sequence was:
writeScrollY(6749.5) → startScrollLock → stopScrollLock → clearScrollY
— the persisted value was wiped right after being written, so resume
after reload read null and locked to 0.

Move clearScrollY to the three genuine session-end sites (hideBar
error path, confirmed/accept, cleanup/discard). stopScrollLock no
longer touches persistent storage.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Paul Bakaus
2026-04-22 10:41:15 -07:00
co-authored by Claude Opus 4.7
parent 868d8c4126
commit 5e04a9f25a
13 changed files with 108 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.agents/skills/impeccable/scripts/live-browser.js
+6 -1
View File
@@ -1468,7 +1468,9 @@
if (scrollLockRaf != null) { cancelAnimationFrame(scrollLockRaf); scrollLockRaf = null; }
if (scrollLockAbort) { scrollLockAbort.abort(); scrollLockAbort = null; }
scrollLockTargetY = null;
clearScrollY();
// NOTE: do NOT clear the persistent scroll key here. startScrollLock
// calls us as a reset, and clearing the key would nuke the Go-time
// scrollY that the next resume needs to read.
}
// ---------------------------------------------------------------------------
@@ -1647,6 +1649,7 @@
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2261,6 +2264,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2376,6 +2380,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
.claude/skills/impeccable/scripts/live-browser.js
+6 -1
View File
@@ -1468,7 +1468,9 @@
if (scrollLockRaf != null) { cancelAnimationFrame(scrollLockRaf); scrollLockRaf = null; }
if (scrollLockAbort) { scrollLockAbort.abort(); scrollLockAbort = null; }
scrollLockTargetY = null;
clearScrollY();
// NOTE: do NOT clear the persistent scroll key here. startScrollLock
// calls us as a reset, and clearing the key would nuke the Go-time
// scrollY that the next resume needs to read.
}
// ---------------------------------------------------------------------------
@@ -1647,6 +1649,7 @@
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2261,6 +2264,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2376,6 +2380,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
.cursor/skills/impeccable/scripts/live-browser.js
+6 -1
View File
@@ -1468,7 +1468,9 @@
if (scrollLockRaf != null) { cancelAnimationFrame(scrollLockRaf); scrollLockRaf = null; }
if (scrollLockAbort) { scrollLockAbort.abort(); scrollLockAbort = null; }
scrollLockTargetY = null;
clearScrollY();
// NOTE: do NOT clear the persistent scroll key here. startScrollLock
// calls us as a reset, and clearing the key would nuke the Go-time
// scrollY that the next resume needs to read.
}
// ---------------------------------------------------------------------------
@@ -1647,6 +1649,7 @@
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2261,6 +2264,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2376,6 +2380,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
.gemini/skills/impeccable/scripts/live-browser.js
+6 -1
View File
@@ -1468,7 +1468,9 @@
if (scrollLockRaf != null) { cancelAnimationFrame(scrollLockRaf); scrollLockRaf = null; }
if (scrollLockAbort) { scrollLockAbort.abort(); scrollLockAbort = null; }
scrollLockTargetY = null;
clearScrollY();
// NOTE: do NOT clear the persistent scroll key here. startScrollLock
// calls us as a reset, and clearing the key would nuke the Go-time
// scrollY that the next resume needs to read.
}
// ---------------------------------------------------------------------------
@@ -1647,6 +1649,7 @@
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2261,6 +2264,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2376,6 +2380,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
.github/skills/impeccable/scripts/live-browser.js
+6 -1
View File
@@ -1468,7 +1468,9 @@
if (scrollLockRaf != null) { cancelAnimationFrame(scrollLockRaf); scrollLockRaf = null; }
if (scrollLockAbort) { scrollLockAbort.abort(); scrollLockAbort = null; }
scrollLockTargetY = null;
clearScrollY();
// NOTE: do NOT clear the persistent scroll key here. startScrollLock
// calls us as a reset, and clearing the key would nuke the Go-time
// scrollY that the next resume needs to read.
}
// ---------------------------------------------------------------------------
@@ -1647,6 +1649,7 @@
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2261,6 +2264,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2376,6 +2380,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
.kiro/skills/impeccable/scripts/live-browser.js
+6 -1
View File
@@ -1468,7 +1468,9 @@
if (scrollLockRaf != null) { cancelAnimationFrame(scrollLockRaf); scrollLockRaf = null; }
if (scrollLockAbort) { scrollLockAbort.abort(); scrollLockAbort = null; }
scrollLockTargetY = null;
clearScrollY();
// NOTE: do NOT clear the persistent scroll key here. startScrollLock
// calls us as a reset, and clearing the key would nuke the Go-time
// scrollY that the next resume needs to read.
}
// ---------------------------------------------------------------------------
@@ -1647,6 +1649,7 @@
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2261,6 +2264,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2376,6 +2380,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
.opencode/skills/impeccable/scripts/live-browser.js
+6 -1
View File
@@ -1468,7 +1468,9 @@
if (scrollLockRaf != null) { cancelAnimationFrame(scrollLockRaf); scrollLockRaf = null; }
if (scrollLockAbort) { scrollLockAbort.abort(); scrollLockAbort = null; }
scrollLockTargetY = null;
clearScrollY();
// NOTE: do NOT clear the persistent scroll key here. startScrollLock
// calls us as a reset, and clearing the key would nuke the Go-time
// scrollY that the next resume needs to read.
}
// ---------------------------------------------------------------------------
@@ -1647,6 +1649,7 @@
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2261,6 +2264,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2376,6 +2380,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
.pi/skills/impeccable/scripts/live-browser.js
+6 -1
View File
@@ -1468,7 +1468,9 @@
if (scrollLockRaf != null) { cancelAnimationFrame(scrollLockRaf); scrollLockRaf = null; }
if (scrollLockAbort) { scrollLockAbort.abort(); scrollLockAbort = null; }
scrollLockTargetY = null;
clearScrollY();
// NOTE: do NOT clear the persistent scroll key here. startScrollLock
// calls us as a reset, and clearing the key would nuke the Go-time
// scrollY that the next resume needs to read.
}
// ---------------------------------------------------------------------------
@@ -1647,6 +1649,7 @@
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2261,6 +2264,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2376,6 +2380,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
.rovodev/skills/impeccable/scripts/live-browser.js
+6 -1
View File
@@ -1468,7 +1468,9 @@
if (scrollLockRaf != null) { cancelAnimationFrame(scrollLockRaf); scrollLockRaf = null; }
if (scrollLockAbort) { scrollLockAbort.abort(); scrollLockAbort = null; }
scrollLockTargetY = null;
clearScrollY();
// NOTE: do NOT clear the persistent scroll key here. startScrollLock
// calls us as a reset, and clearing the key would nuke the Go-time
// scrollY that the next resume needs to read.
}
// ---------------------------------------------------------------------------
@@ -1647,6 +1649,7 @@
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2261,6 +2264,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2376,6 +2380,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
.trae-cn/skills/impeccable/scripts/live-browser.js
+6 -1
View File
@@ -1468,7 +1468,9 @@
if (scrollLockRaf != null) { cancelAnimationFrame(scrollLockRaf); scrollLockRaf = null; }
if (scrollLockAbort) { scrollLockAbort.abort(); scrollLockAbort = null; }
scrollLockTargetY = null;
clearScrollY();
// NOTE: do NOT clear the persistent scroll key here. startScrollLock
// calls us as a reset, and clearing the key would nuke the Go-time
// scrollY that the next resume needs to read.
}
// ---------------------------------------------------------------------------
@@ -1647,6 +1649,7 @@
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2261,6 +2264,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2376,6 +2380,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
.trae/skills/impeccable/scripts/live-browser.js
+6 -1
View File
@@ -1468,7 +1468,9 @@
if (scrollLockRaf != null) { cancelAnimationFrame(scrollLockRaf); scrollLockRaf = null; }
if (scrollLockAbort) { scrollLockAbort.abort(); scrollLockAbort = null; }
scrollLockTargetY = null;
clearScrollY();
// NOTE: do NOT clear the persistent scroll key here. startScrollLock
// calls us as a reset, and clearing the key would nuke the Go-time
// scrollY that the next resume needs to read.
}
// ---------------------------------------------------------------------------
@@ -1647,6 +1649,7 @@
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2261,6 +2264,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2376,6 +2380,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
public/index.html
+36 -48
View File
@@ -723,8 +723,9 @@
<!-- impeccable-variants-start 92cc894b -->
<div data-impeccable-variants="92cc894b" data-impeccable-variant-count="3" style="display: contents">
<!-- impeccable-variants-start 708145d6 -->
<div data-impeccable-variants="708145d6" data-impeccable-variant-count="3" style="display: contents">
<!-- Original -->
<div data-impeccable-variant="original">
<div class="consulting-text">
@@ -733,15 +734,14 @@
</div>
</div>
<!-- Variants: insert below this line -->
<style data-impeccable-css="92cc894b">
<style data-impeccable-css="708145d6">
@scope ([data-impeccable-variant="1"]) {
.consulting-text {
display: flex;
flex-direction: column;
gap: 16px;
display: grid;
gap: 14px;
max-width: 56ch;
}
.v1-kicker {
.v1-tag {
font-family: var(--font-mono);
font-size: 0.6875rem;
text-transform: uppercase;
@@ -762,7 +762,7 @@
font-size: 1rem;
line-height: 1.6;
color: var(--color-charcoal);
margin: 0;
margin: 4px 0 0;
}
.v1-body a {
color: var(--color-ink);
@@ -773,42 +773,42 @@
}
@scope ([data-impeccable-variant="2"]) {
.consulting-text {
display: grid;
grid-template-columns: auto 1fr;
gap: 32px;
display: flex;
align-items: baseline;
gap: 28px;
padding: 20px 0;
border-block: 1px solid var(--color-ink);
}
.v2-num {
.v2-mark {
font-family: var(--font-display);
font-style: italic;
font-weight: 300;
font-size: 3.5rem;
font-weight: 400;
font-size: 3rem;
line-height: 0.9;
color: var(--color-accent);
}
.v2-body {
display: flex;
flex-direction: column;
gap: 10px;
gap: 8px;
max-width: 52ch;
}
.v2-title {
font-family: var(--font-display);
font-style: italic;
font-size: 2rem;
line-height: 1.1;
font-size: 1.875rem;
line-height: 1.15;
color: var(--color-ink);
margin: 0;
}
.v2-desc {
.v2-body p {
font-family: var(--font-body);
font-size: 0.9375rem;
line-height: 1.6;
color: var(--color-charcoal);
margin: 0;
}
.v2-desc a {
.v2-body a {
color: var(--color-ink);
text-decoration: underline;
text-underline-offset: 3px;
@@ -818,30 +818,18 @@
@scope ([data-impeccable-variant="3"]) {
.consulting-text {
display: grid;
grid-template-columns: 1fr;
gap: 24px;
max-width: 50ch;
}
.v3-head {
display: flex;
align-items: baseline;
gap: 16px;
font-family: var(--font-display);
}
.v3-amp {
font-style: italic;
font-size: clamp(4rem, 9vw, 6rem);
line-height: 0.85;
color: var(--color-accent);
font-weight: 300;
gap: 32px;
max-width: 54ch;
}
.v3-title {
font-family: var(--font-display);
font-style: italic;
font-weight: 400;
font-size: clamp(2rem, 4vw, 2.75rem);
line-height: 1;
font-weight: 300;
font-size: clamp(4rem, 8vw, 6rem);
line-height: 0.9;
color: var(--color-ink);
margin: 0;
letter-spacing: -0.02em;
}
.v3-body {
font-family: var(--font-body);
@@ -849,6 +837,8 @@
line-height: 1.65;
color: var(--color-charcoal);
margin: 0;
padding-left: 20px;
border-left: 1px solid var(--color-accent);
}
.v3-body a {
color: var(--color-ink);
@@ -860,31 +850,29 @@
</style>
<div data-impeccable-variant="1">
<div class="consulting-text">
<span class="v1-kicker">Consulting · Renaissance Geek</span>
<span class="v1-tag">Renaissance Geek · Consulting</span>
<h2 class="v1-title">Work with me.</h2>
<p class="v1-body">Rollouts, integrations, and training for enterprise teams, frontier labs, and design tool companies. By <a href="https://renaissance-geek.ai" target="_blank" rel="noopener">Renaissance Geek</a>.</p>
<p class="v1-body">Enterprise rollouts, custom integrations, and training for designers and developers. <a href="https://renaissance-geek.ai" target="_blank" rel="noopener">Get in touch</a>.</p>
</div>
</div>
<div data-impeccable-variant="2" style="display: none">
<div class="consulting-text">
<span class="v2-num">§</span>
<span class="v2-mark"></span>
<div class="v2-body">
<h2 class="v2-title">Work with me.</h2>
<p class="v2-desc">Impeccable is built by <a href="https://renaissance-geek.ai" target="_blank" rel="noopener">Renaissance Geek</a>. Enterprise rollouts, custom integrations, and training for designers and developers.</p>
<p>Impeccable is built by <a href="https://renaissance-geek.ai" target="_blank" rel="noopener">Renaissance Geek</a>. I work with enterprise teams on rollouts, integrations, and training.</p>
</div>
</div>
</div>
<div data-impeccable-variant="3" style="display: none">
<div class="consulting-text">
<div class="v3-head">
<span class="v3-amp">&amp;</span>
<h2 class="v3-title">Work with me.</h2>
</div>
<p class="v3-body">Impeccable is built by <a href="https://renaissance-geek.ai" target="_blank" rel="noopener">Renaissance Geek</a>. I work with enterprise teams on large-scale rollouts, custom integrations, and training.</p>
<h2 class="v3-title">Work <br>with me.</h2>
<p class="v3-body">Impeccable is built by <a href="https://renaissance-geek.ai" target="_blank" rel="noopener">Renaissance Geek</a>. I work with enterprise teams on large-scale rollouts, custom integrations, and training for designers and developers.</p>
</div>
</div>
</div>
<!-- impeccable-variants-end 92cc894b -->
<!-- impeccable-variants-end 708145d6 -->
source/skills/impeccable/scripts/live-browser.js
+6 -1
View File
@@ -1468,7 +1468,9 @@
if (scrollLockRaf != null) { cancelAnimationFrame(scrollLockRaf); scrollLockRaf = null; }
if (scrollLockAbort) { scrollLockAbort.abort(); scrollLockAbort = null; }
scrollLockTargetY = null;
clearScrollY();
// NOTE: do NOT clear the persistent scroll key here. startScrollLock
// calls us as a reset, and clearing the key would nuke the Go-time
// scrollY that the next resume needs to read.
}
// ---------------------------------------------------------------------------
@@ -1647,6 +1649,7 @@
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2261,6 +2264,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;
@@ -2376,6 +2380,7 @@ void main() {
stopScrollTracking();
if (variantObserver) { variantObserver.disconnect(); variantObserver = null; }
stopScrollLock();
clearScrollY();
clearSession();
selectedElement = null;
currentSessionId = null;