skills/pbakaus_impeccable
1
0
Fork 0
mirror of https://github.com/pbakaus/impeccable.git synced 2026-09-15 07:36:50 +03:00
Code Issues Packages Projects Releases Wiki Activity

Tests: size the live-server sweep's ps buffer for a busy machine

Browse Source 
The orphan reaper and every harness cleanup find live servers through
`ps -A -E`, run with spawnSync's default 1 MiB maxBuffer. A laptop with a
thousand processes produces more than that, spawnSync kills ps, reports
status null, and the sweep silently finds nothing: the SIGKILL leak guard
fails and, worse, real orphans survive. Seen on the maintainer's machine
mid-session, reproduced with main's own engine. A 256 MiB buffer covers
any realistic process table.

Written with AI assistance (Claude).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Abdul Wahab
2026-09-15 05:45:49 +05:00
committed by Abdul Wahab
co-authored by Claude Fable 5
parent f29636a3d5
commit 9cbe639101
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/lib/live-server-processes.mjs
+9 -2
View File
@@ -62,6 +62,13 @@ export const REPO_PATH_ENV = 'IMPECCABLE_TEST_REPO_PATH';
* A command line belonging to a live server. Matches the Node script
* (`.../live-server.mjs`) and the engine verb (`.../impeccable live-server`).
*/
// `ps -E` prints every process's whole environment. On a laptop with a thousand
// processes that passes Node's default 1 MiB `maxBuffer`, at which point
// spawnSync kills `ps`, reports `status: null`, and the sweep silently finds
// nothing: the exact orphan case the reaper exists for. Size the buffer for a
// busy machine instead.
const PS_MAX_BUFFER = 256 * 1024 * 1024;
const LIVE_SERVER_RE = /(^|[\s/\\])live-server(\.mjs|\.exe)?(\s|$)/;
/**
@@ -211,7 +218,7 @@ function assertMarkerValue(value) {
function listCommands() {
const map = new Map();
if (process.platform === 'win32') return map; // no supported sweep yet
const res = spawnSync('ps', ['-A', '-ww', '-o', 'pid=,command='], { encoding: 'utf-8' });
const res = spawnSync('ps', ['-A', '-ww', '-o', 'pid=,command='], { encoding: 'utf-8', maxBuffer: PS_MAX_BUFFER });
if (res.status !== 0 || !res.stdout) return map;
for (const line of res.stdout.split('\n')) {
const m = /^\s*(\d+)\s+(.*)$/.exec(line);
@@ -245,7 +252,7 @@ function pidsWithEnvMarker(markers, commands) {
return hits;
}
const res = spawnSync('ps', ['-A', '-E', '-ww', '-o', 'pid=,command='], { encoding: 'utf-8' });
const res = spawnSync('ps', ['-A', '-E', '-ww', '-o', 'pid=,command='], { encoding: 'utf-8', maxBuffer: PS_MAX_BUFFER });
if (res.status !== 0 || !res.stdout) return hits;
for (const line of res.stdout.split('\n')) {
const m = /^\s*(\d+)\s+(.*)$/.exec(line);