skills/pbakaus_impeccable
1
0
Fork 0
mirror of https://github.com/pbakaus/impeccable.git synced 2026-09-12 22:26:38 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #414 from pbakaus/live-error-clears-checkpoint

Browse Source 
Live mode: clear the durable session checkpoint on a terminal SSE error reply
This commit is contained in:
Paul Bakaus
2026-07-25 18:38:39 -07:00
committed by GitHub
parent 5a39675d3a 21d058e744
commit a4e99eda3a
2 changed files with 38 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
skill/scripts/live-browser.js
+13
View File
@@ -6499,6 +6499,19 @@
if (maybeCompleteSteer(msg)) break;
console.error('[impeccable] Error:', msg.message);
showToast('Error: ' + msg.message, 5000);
// An agent error reply is terminal for the session it names: tear
// it down exactly like 'discarded' (cleanup includes clearSession),
// or the durable localStorage checkpoint survives and every reload
// resurrects a GENERATING bar for a session the server no longer
// knows about (issue #362).
if (msg.id && msg.id === currentSessionId) {
markSessionHandled();
cleanup();
break;
}
// A stored-but-not-current checkpoint naming the errored session
// (the error raced a reload) must not resurrect either.
if (msg.id && loadSession()?.id === msg.id) clearSession();
hideBar();
renderEditBadge('hidden');
setLiveState('PICKING');
tests/live-browser-regression.test.mjs
+25
View File
@@ -273,6 +273,31 @@ describe('live-browser.js regression guards', () => {
);
});
it('SSE error reply clears the durable session checkpoint like discarded', () => {
// Issue #362: `live-poll.mjs --reply <id> error "..."` is the documented
// abort flow in reference/live.md, and an agent error reply is terminal
// for the session it names. The 'error' case used to reset only the UI
// (hideBar + PICKING) while the localStorage checkpoint written for the
// GENERATING phase survived — so every reload resurrected a dead session
// the server no longer knew about, until the user hand-cleared the
// impeccable-live* keys in the console. The error path must tear down the
// named session exactly like 'discarded' does (markSessionHandled +
// cleanup, which includes clearSession), and drop a stored-but-not-
// current checkpoint that matches the errored id.
const errorCase = SOURCE.match(/case 'error':[\s\S]{0,2500}?setLiveState\('PICKING'\);\s*break;/);
assert.ok(errorCase, 'expected an SSE case \'error\' handler in live-browser.js');
assert.match(
errorCase[0],
/if \(msg\.id && msg\.id === currentSessionId\) \{[\s\S]{0,160}?markSessionHandled\(\);[\s\S]{0,80}?cleanup\(\);[\s\S]{0,80}?break;/,
'an error reply naming the current session must run the same markSessionHandled + cleanup teardown as \'discarded\' so the durable checkpoint is cleared',
);
assert.match(
errorCase[0],
/if \(msg\.id && loadSession\(\)\?\.id === msg\.id\) clearSession\(\);/,
'an error reply naming a stored-but-not-current session must drop that checkpoint so a reload cannot resurrect it',
);
});
it('handleServerLost preserves the current recoverable phase', () => {
assert.doesNotMatch(
SOURCE,