skills/pbakaus_impeccable
1
0
Fork 0
mirror of https://github.com/pbakaus/impeccable.git synced 2026-09-16 08:06:24 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix browser nested card dedup — use WeakSet like CLI

Browse Source 
Same bug as the CLI had: Set with tag-name key ('DIV:DIV') deduped
all nested divs to one finding. Now uses WeakSet on actual elements
so each nested card instance gets its own outline.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Paul Bakaus
2026-03-17 16:04:12 -07:00
co-authored by Claude Opus 4.6
parent f90e640892
commit ae47758366
1 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/js/detect-antipatterns-browser.js
+4 -10
View File
@@ -291,16 +291,13 @@
const findings = [];
// --- Nested cards ---
const flaggedPairs = new Set();
const flaggedEls = new WeakSet();
for (const el of document.querySelectorAll('*')) {
if (!isCardLike(el)) continue;
const tag = el.tagName.toLowerCase();
if (!isCardLike(el) || flaggedEls.has(el)) continue;
const cls = el.getAttribute('class') || '';
const style = getComputedStyle(el);
// Exclude dropdowns, modals, tooltips
if (style.position === 'absolute' || style.position === 'fixed') continue;
if (/\b(?:dropdown|popover|tooltip|menu|modal|dialog)\b/i.test(cls)) continue;
// Exclude tiny elements (badges, chips)
if ((el.textContent?.trim().length || 0) < 20) continue;
const rect = el.getBoundingClientRect();
if (rect.width < 50 || rect.height < 30) continue;
@@ -308,11 +305,8 @@
let parent = el.parentElement;
while (parent) {
if (isCardLike(parent)) {
const key = el.tagName + ':' + parent.tagName;
if (!flaggedPairs.has(key)) {
flaggedPairs.add(key);
findings.push({ type: 'nested-cards', detail: `Card inside card`, el });
}
flaggedEls.add(el);
findings.push({ type: 'nested-cards', detail: `Card inside card`, el });
break;
}
parent = parent.parentElement;