skills/pbakaus_impeccable
1
0
Fork 0
mirror of https://github.com/pbakaus/impeccable.git synced 2026-09-12 06:06:37 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #644 from pbakaus/fix/642-grok-global-hook

Browse Source 
Fix: rewrite Grok project hooks to the global skill path (#642)
This commit is contained in:
Abdul Wahab
2026-08-24 06:14:38 +05:00
committed by GitHub
parent c39b6425fa 49571365a8
commit c0b1ec6fef
2 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cli/bin/commands/skills.mjs
+3 -3
View File
@@ -1402,7 +1402,7 @@ function hookScriptPathForProvider(skillRoot, provider) {
if (provider === '.cursor') {
return join(skillRoot, provider, 'skills', 'impeccable', 'scripts', 'hook-before-edit.mjs');
}
if (provider === '.claude' || provider === '.agents') {
if (provider === '.claude' || provider === '.agents' || provider === '.grok') {
return join(skillRoot, provider, 'skills', 'impeccable', 'scripts', 'hook.mjs');
}
return null;
@@ -1478,8 +1478,8 @@ function guardHookCommand(quotedPath, provider) {
// entries additionally get a `commandWindows` sibling for cmd.exe.
function rewriteHookCommandsForSkillRoot(value, provider, { skillRoot, absolute }) {
const hookScript = hookScriptPathForProvider(skillRoot, provider);
// Providers we don't own a `node "PATH"` command hook for (.github, .grok)
// carry their own portable command forms; leave them untouched.
// Providers we don't own a `node "PATH"` command hook for (.github) carry
// their own portable command forms; leave them untouched.
if (!hookScript) return value;
// Project-scope installs derive the provider's own project-relative path
tests/skills-cli.test.js
+13 -4
View File
@@ -108,6 +108,12 @@ function createFakeUniversalBundle(root, providers = ['.claude', '.agents', '.cu
hooks: { PostToolUse: [{ matcher: 'apply_patch', hooks: [{ type: 'command', command: 'node ".codex/skills/impeccable/scripts/hook.mjs"' }] }] },
}, null, 2));
}
if (providers.includes('.grok')) {
mkdirSync(join(bundleRoot, '.grok', 'hooks'), { recursive: true });
writeFileSync(join(bundleRoot, '.grok', 'hooks', 'impeccable.json'), JSON.stringify({
hooks: { PostToolUse: [{ matcher: 'Edit|Write|MultiEdit', hooks: [{ type: 'command', command: 'node ".grok/skills/impeccable/scripts/hook.mjs"' }] }] },
}, null, 2));
}
// Native subagent definitions, mirroring the build's provider agents output.
if (providers.includes('.github')) {
mkdirSync(join(bundleRoot, '.github', 'agents'), { recursive: true });
@@ -1125,21 +1131,24 @@ describe('skills install/update: local universal bundle e2e', () => {
const tmp = mkdtempSync(join(tmpdir(), 'imp-test-scope-user-hooks-'));
const home = mkdtempSync(join(tmpdir(), 'imp-home-scope-user-hooks-'));
execSync('git init', { cwd: tmp });
const bundleRoot = createFakeUniversalBundle(tmp, ['.claude', '.agents', '.cursor']);
const bundleRoot = createFakeUniversalBundle(tmp, ['.claude', '.agents', '.cursor', '.grok']);
const output = run('skills install -y --providers=claude,codex,cursor --scope=global', {
const output = run('skills install -y --providers=claude,codex,cursor,grok --scope=global', {
cwd: tmp,
env: { ...process.env, HOME: home, IMPECCABLE_BUNDLE_PATH: bundleRoot },
});
expect(output).toContain('Installed impeccable into: .claude, .agents, .cursor (global)');
for (const provider of ['.claude', '.agents', '.cursor']) {
expect(output).toContain('Installed impeccable into: .claude, .agents, .cursor, .grok (global)');
for (const provider of ['.claude', '.agents', '.cursor', '.grok']) {
expect(existsSync(join(home, provider, 'skills', 'impeccable', 'SKILL.md'))).toBe(true);
expect(existsSync(join(tmp, provider, 'skills', 'impeccable', 'SKILL.md'))).toBe(false);
}
expect(readFileSync(join(tmp, '.claude', 'settings.local.json'), 'utf8')).toContain(join(home, '.claude', 'skills', 'impeccable', 'scripts', 'hook.mjs'));
expect(readFileSync(join(tmp, '.codex', 'hooks.json'), 'utf8')).toContain(join(home, '.agents', 'skills', 'impeccable', 'scripts', 'hook.mjs'));
expect(readFileSync(join(tmp, '.cursor', 'hooks.json'), 'utf8')).toContain(join(home, '.cursor', 'skills', 'impeccable', 'scripts', 'hook-before-edit.mjs'));
const grokHooks = readFileSync(join(tmp, '.grok', 'hooks', 'impeccable.json'), 'utf8');
expect(grokHooks).toContain(join(home, '.grok', 'skills', 'impeccable', 'scripts', 'hook.mjs'));
expect(grokHooks).not.toContain('".grok/skills/impeccable/scripts/hook.mjs"');
rmSync(tmp, { recursive: true, force: true });
rmSync(home, { recursive: true, force: true });