skills/pbakaus_impeccable
1
0
Fork 0
mirror of https://github.com/pbakaus/impeccable.git synced 2026-09-14 07:06:45 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #449 from pbakaus/codex/fix-issue-424

Browse Source 
Fix rounded-none border accent false positive
This commit is contained in:
Paul Bakaus
2026-07-29 14:55:41 -07:00
committed by GitHub
parent 7ed60fc917 872c032582
commit cbba80cdb3
2 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cli/engine/engines/regex/detect-text.mjs
+2 -1
View File
@@ -12,7 +12,8 @@ import { profileFindings, profileStep } from '../../profile/profiler.mjs';
// Regex fallback (non-HTML files: CSS, JSX, TSX, etc.)
// ---------------------------------------------------------------------------
const hasRounded = (line) => /\brounded(?:-\w+)?\b/.test(line);
const hasRounded = (line) =>
/\brounded(?:-\w+)?\b/.test(line.replace(/\brounded-none\b/g, ''));
const hasBorderRadius = (line) => /border-radius/i.test(line);
const isSafeElement = (line) => /<(?:blockquote|nav[\s>]|pre[\s>]|code[\s>]|a\s|input[\s>]|span[\s>])/i.test(line);
tests/detect-antipatterns.test.js
+16
View File
@@ -199,6 +199,22 @@ describe('detectText — Tailwind side-tab', () => {
const f = detectText('<div class="border-t-4 border-b-4">', 'test.html');
expect(f.filter(r => r.antipattern === 'border-accent-on-rounded')).toHaveLength(0);
});
test('ignores border accent paired with rounded-none', () => {
const f = detectText(
'<TabsTrigger className="rounded-none border-b-2 border-transparent data-[state=active]:border-primary" />',
'test.tsx',
);
expect(f.filter(r => r.antipattern === 'border-accent-on-rounded')).toHaveLength(0);
});
test('still detects a real rounded token alongside rounded-none', () => {
const f = detectText(
'<div className="rounded-none md:rounded-lg border-b-2 border-primary" />',
'test.tsx',
);
expect(f.some(r => r.antipattern === 'border-accent-on-rounded')).toBe(true);
});
});
describe('detectText — CSS borders', () => {