mirror of
https://github.com/pbakaus/impeccable.git
synced 2026-09-12 14:16:28 +03:00
* refactor(content): merge content/site/ into site/content/ Phase 1 step 1 of the directory restructure. The dual content tree was called out in CLAUDE.md as cleanup; both trees were already in sync except for anti-patterns-catalog.js, which moves to site/data/. - Delete content/site/skills/ and content/site/tutorials/ (duplicates of site/content/, which is what Astro's content collection actually reads). - Move content/site/anti-patterns-catalog.js -> site/data/. - Update scripts/lib/sub-pages-data.js and scripts/build.js to read from site/content/ and site/data/. - Drop content/site/ from validateProse target list (site/content was already there). - Rewrite the "Two content trees" section in CLAUDE.md as a single-tree pointer; update stale dev-server text mentioning the deleted server/index.js. Tests: 186/186 pass. Skills build: clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(skill): rename source/skills/impeccable/ -> skill/ Phase 1 step 2 of the directory restructure. The path was redundantly nested ("source/" wrapper plus "skills/impeccable/" — singular content hidden behind the plural). Collapses to flat skill/SKILL.md + skill/reference/ + skill/scripts/. - Move source/skills/impeccable/ -> skill/. - Rewrite scripts/lib/utils.js readSourceFiles(): drop the multi-skill iteration (CLAUDE.md commits to a single user-invocable skill); read skill/SKILL.md directly. - Update scripts/build.js, scripts/generate-og-image.js, and the sub-pages data layer to point at skill/. - Update tests/lib/utils.test.js: drop the "multi-skill" and "dir-name fallback" cases, update single-skill paths to skill/. - Update tests/build.test.js similarly: drop "multiple skills" integration test, update paths. - Update non-glob path joins in tests/framework-fixtures.test.mjs, tests/live-e2e/session.mjs, tests/live-e2e/agents/llm-agent.mjs, tools/live-loop.mjs. - Update prose/text references in CLAUDE.md, AGENTS.md, DEVELOP.md, README.md, scripts/lib/sub-pages-data.js, bin/commands/skills.mjs, site/data/anti-patterns-catalog.js, site/pages/docs/[...slug].astro, docs/adr-live-variant-mode.md, docs/plans/. Eval framework note: the separate impeccable-evals repo reads ../impeccable/source/skills/impeccable/ and needs a coordinated rename to ../impeccable/skill/. Tests: 186/186 pass. Skills build: clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor: rename docs/ -> notes/ Phase 1 step 3 of the directory restructure. The internal docs/ dir (ADRs and plans) clashed with the site's /docs route. Renaming it "notes/" makes the difference unambiguous: notes/ is project-internal process, /docs is the user-facing route under site/pages/docs/. No code references the dir; the rename is a clean git mv. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(site): move public/ under site/public/ Phase 2 step 4 of the directory restructure. Public assets and the Astro publicDir now live alongside the rest of the site, so site/ is fully self-contained for static content. - git mv public site/public. - astro.config.mjs: add publicDir: './site/public'. Astro defaults to ./public at the project root, so the override is required. - scripts/build.js: write generated _data, _headers, _redirects, _routes.json, and js/detect-antipatterns-browser.js into site/public/. Also delete the dead _REMOVED() Bun static-site builder (replaced by Astro at #130; the placeholder no longer earns its keep). - scripts/build.js validateProse: replace the stale public/index.html reference (deleted at the Astro migration) with site/pages/index.astro in the count-validation file list, restoring homepage drift detection. - scripts/generate-og-image.js: write OG image into site/public/. - scripts/screenshot-antipatterns.js: read examples from + write screenshots to site/public/antipattern-{examples,images}/. - scripts/lib/sub-pages-data.js: load command demos from site/public/js/demos/commands. - .gitignore: rename the public/* generator-output entries to site/public/*. - CLAUDE.md: refresh CSS/data-file paths (still pointing at the old pre-Astro public/css/ + public/js/ tree), point the changelog and command-add checklists at site/pages/index.astro and site/scripts/data.js + site/scripts/components/framework-viz.js. Cloudflare Pages note: functions/ stays at the repo root because CF Pages auto-discovers it there with no configuration knob to relocate. Moving it under site/ would either break deployment or require a build-time copy step that adds more complexity than the cleanup is worth. Tests: 186/186 pass. Skills + site build clean. _headers, _redirects, _routes.json, _data/ all land in build/ correctly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(cli): consolidate bin/ + src/ + lib/ under cli/ Phase 2 step 5 of the directory restructure. The CLI surface was split across three top-level dirs whose names were easy to mistake for each other (especially src/ vs source/ pre-step-2). Consolidates under cli/. - git mv bin -> cli/bin (CLI entry + skills sub-command) - git mv src -> cli/engine (detect-antipatterns engine + browser variant) - git mv lib -> cli/lib (download-providers helper) Update package.json: - bin.impeccable: cli/bin/cli.js - main + exports: cli/engine/detect-antipatterns.mjs and the ./browser variant - files: ["cli/", "LICENSE"] Update internal references: - cli/bin/cli.js: dynamic import points at ../engine/, package.json read goes one level deeper (../../package.json). - functions/api/download/[type]/[provider]/[id].js + bundle/[provider].js: cli/lib/download-providers.js path. - scripts/build.js, scripts/build-browser-detector.js, scripts/build-extension.js: cli/engine path constants. - scripts/lib/sub-pages-data.js, scripts/lib/utils.js, skill/scripts/ live-server.mjs: comment refs. - tests/detect-antipatterns{,-browser,-fixtures}.test.{js,mjs}, tests/windows-path-fix.test.js: import + read paths. - AGENTS.md, CLAUDE.md: doc paths. Verified: - npx node cli/bin/cli.js --version, --help, detect --help all work. - bun run build, bun run build:browser, bun run build:extension all clean. Browser detector lands at cli/engine/detect-antipatterns-browser.js; extension/detector/detect.js still emits to the same location. - bun run test: 186/186 pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix: update browser-detector paths missed in cli/ rename Bugbot caught two runtime path leaks where the comment got renamed to cli/engine/ but the actual code still used the old src/ segment. - skill/scripts/live-server.mjs: detectPaths array now joins cli, engine, detect-antipatterns-browser.js for both the repo-relative lookup (4 dirs up from .claude/skills/impeccable/scripts/ to repo root) and the npm node_modules fallback. Without this fix, the detection overlay would silently not load during live-server sessions. - scripts/build.js: the post-build copy of the browser detector into site/public/js/ was reading from src/. The if (fs.existsSync(...)) guard meant the copy was silently skipping, so antipattern-examples pages would 404 on /js/detect-antipatterns-browser.js once the site was deployed. Tests: 186/186 pass. Build clean. site/public/js/detect-antipatterns-browser.js re-emits as expected. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix: cleanup-deprecated import path missed an extra .. in cli/ rename Bugbot caught three call sites in cli/bin/commands/skills.mjs that import '../../skill/scripts/cleanup-deprecated.mjs'. Pre-rename, that was correct from bin/commands/ (one parent to bin/, one to repo root). After moving the file from bin/commands/ to cli/bin/commands/, the path is one directory deeper, so it needs three .. segments to reach the repo root. Without the fix, every cleanup invocation throws on import and gets swallowed by the surrounding try/catch — silent skip. cli/bin/cli.js's package.json read already uses '../../package.json' (the same depth pattern), confirming three levels is correct. Verified: dynamic import resolves and exports the expected functions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore: sweep stale path/file references missed in the restructure Same root cause as the two bugbot finds: some references in moved or related files weren't tracked because they didn't match a simple sed pattern. Caught the rest by walking each moved dir's depth and each Astro-migration deletion. Stale path references (post-Astro migration, missed earlier): - CLAUDE.md: legacy URL redirects "live in server/index.js" -> point at the actual sources (scripts/build.js generateCFConfig + site/public/_redirects). - AGENTS.md: counts.js path (public/ -> site/public/), changelog file (public/index.html -> site/pages/index.astro), screenshots note (public/ -> site/), source-of-truth dirs (source/, src/ -> skill/, cli/). - tests/detect-antipatterns-browser.test.mjs: comment about routes "in server/index.js". - skill/reference/live.md: workflow.css example for "this repo" was pre-Astro (public/css/) -> site/styles/. (User-project Vite/Next example unchanged.) Stale path that pointed at moved files: - tests/skills-cli.test.js: CLI path was '..', 'bin', 'cli.js'; now '..', 'cli', 'bin', 'cli.js'. Test isn't wired into bun run test but it would have failed if invoked. Dead files (orphaned by Astro migration, never cleaned up): - tests/server/download-validation.test.js: imported from ../../server/lib/{validation,api-handlers}.js which were deleted inb8f09c8. Test was a silent failure waiting to happen. - scripts/lib/render-markdown.js: 156-line module with zero consumers (the only caller, scripts/lib/render-page.js, was deleted in the Astro cleanup). - scripts/build.js: dead commented-out generateSubPages import. Tests: 186/186 pass. Build clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(build): remove invalid Corepack packageManager spec Cloudflare Pages rejects the build with `Unsupported package manager specification (bun@1.3.11)`. The packageManager field follows Corepack's syntax which only validates npm/pnpm/yarn — `bun@X.Y.Z` parses as a malformed Corepack directive even though Bun itself treats it as a hint. Pre-existing on main sinced874af0(CF Pages deploy on main also failing); just surfaces here because the PR triggers a fresh deploy. CF Pages auto-detects Bun anyway (the build log confirms: "Detected the following tools from environment: bun@1.3.11, pnpm@10.11.1, nodejs@22.16.0"). Removing the field unblocks the deploy without changing local dev behavior. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Paul Bakaus <paulbakaus@pauls-mbp-3.lan> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
176 lines
7.6 KiB
Markdown
176 lines
7.6 KiB
Markdown
> **Additional context needed**: performance constraints.
|
||
|
||
Add motion that conveys state, gives feedback, and clarifies hierarchy. Cut motion that exists only for decoration. Animation fatigue is a real cost; spend the budget on the moments that need it.
|
||
|
||
---
|
||
|
||
## Register
|
||
|
||
Brand: orchestrated page-load sequences, staggered reveals, scroll-driven animation. Motion is part of the voice; one well-rehearsed entrance beats scattered micro-interactions.
|
||
|
||
Product: 150–250 ms on most transitions. Motion conveys state: feedback, reveal, loading, transitions between views. No page-load choreography; users are in a task and won't wait for it.
|
||
|
||
---
|
||
|
||
## Assess Animation Opportunities
|
||
|
||
Analyze where motion would improve the experience:
|
||
|
||
1. **Identify static areas**:
|
||
- **Missing feedback**: Actions without visual acknowledgment (button clicks, form submission, etc.)
|
||
- **Jarring transitions**: Instant state changes that feel abrupt (show/hide, page loads, route changes)
|
||
- **Unclear relationships**: Spatial or hierarchical relationships that aren't obvious
|
||
- **Lack of delight**: Functional but joyless interactions
|
||
- **Missed guidance**: Opportunities to direct attention or explain behavior
|
||
|
||
2. **Understand the context**:
|
||
- What's the personality? (Playful vs serious, energetic vs calm)
|
||
- What's the performance budget? (Mobile-first? Complex page?)
|
||
- Who's the audience? (Motion-sensitive users? Power users who want speed?)
|
||
- What matters most? (One hero animation vs many micro-interactions?)
|
||
|
||
If any of these are unclear from the codebase, {{ask_instruction}}
|
||
|
||
**CRITICAL**: Respect `prefers-reduced-motion`. Always provide non-animated alternatives for users who need them.
|
||
|
||
## Plan Animation Strategy
|
||
|
||
Create a purposeful animation plan:
|
||
|
||
- **Hero moment**: What's the ONE signature animation? (Page load? Hero section? Key interaction?)
|
||
- **Feedback layer**: Which interactions need acknowledgment?
|
||
- **Transition layer**: Which state changes need smoothing?
|
||
- **Delight layer**: Where can we surprise and delight?
|
||
|
||
**IMPORTANT**: One well-orchestrated experience beats scattered animations everywhere. Focus on high-impact moments.
|
||
|
||
## Implement Animations
|
||
|
||
Add motion systematically across these categories:
|
||
|
||
### Entrance Animations
|
||
- **Page load choreography**: Stagger element reveals (100-150ms delays), fade + slide combinations
|
||
- **Hero section**: Dramatic entrance for primary content (scale, parallax, or creative effects)
|
||
- **Content reveals**: Scroll-triggered animations using intersection observer
|
||
- **Modal/drawer entry**: Smooth slide + fade, backdrop fade, focus management
|
||
|
||
### Micro-interactions
|
||
- **Button feedback**:
|
||
- Hover: Subtle scale (1.02-1.05), color shift, shadow increase
|
||
- Click: Quick scale down then up (0.95 → 1), ripple effect
|
||
- Loading: Spinner or pulse state
|
||
- **Form interactions**:
|
||
- Input focus: Border color transition, slight scale or glow
|
||
- Validation: Shake on error, check mark on success, smooth color transitions
|
||
- **Toggle switches**: Smooth slide + color transition (200-300ms)
|
||
- **Checkboxes/radio**: Check mark animation, ripple effect
|
||
- **Like/favorite**: Scale + rotation, particle effects, color transition
|
||
|
||
### State Transitions
|
||
- **Show/hide**: Fade + slide (not instant), appropriate timing (200-300ms)
|
||
- **Expand/collapse**: Height transition with overflow handling, icon rotation
|
||
- **Loading states**: Skeleton screen fades, spinner animations, progress bars
|
||
- **Success/error**: Color transitions, icon animations, gentle scale pulse
|
||
- **Enable/disable**: Opacity transitions, cursor changes
|
||
|
||
### Navigation & Flow
|
||
- **Page transitions**: Crossfade between routes, shared element transitions
|
||
- **Tab switching**: Slide indicator, content fade/slide
|
||
- **Carousel/slider**: Smooth transforms, snap points, momentum
|
||
- **Scroll effects**: Parallax layers, sticky headers with state changes, scroll progress indicators
|
||
|
||
### Feedback & Guidance
|
||
- **Hover hints**: Tooltip fade-ins, cursor changes, element highlights
|
||
- **Drag & drop**: Lift effect (shadow + scale), drop zone highlights, smooth repositioning
|
||
- **Copy/paste**: Brief highlight flash on paste, "copied" confirmation
|
||
- **Focus flow**: Highlight path through form or workflow
|
||
|
||
### Delight Moments
|
||
- **Empty states**: Subtle floating animations on illustrations
|
||
- **Completed actions**: Confetti, check mark flourish, success celebrations
|
||
- **Easter eggs**: Hidden interactions for discovery
|
||
- **Contextual animation**: Weather effects, time-of-day themes, seasonal touches
|
||
|
||
## Technical Implementation
|
||
|
||
Use appropriate techniques for each animation:
|
||
|
||
### Timing & Easing
|
||
|
||
**Durations by purpose:**
|
||
- **100-150ms**: Instant feedback (button press, toggle)
|
||
- **200-300ms**: State changes (hover, menu open)
|
||
- **300-500ms**: Layout changes (accordion, modal)
|
||
- **500-800ms**: Entrance animations (page load)
|
||
|
||
**Easing curves (use these, not CSS defaults):**
|
||
```css
|
||
/* Recommended: natural deceleration */
|
||
--ease-out-quart: cubic-bezier(0.25, 1, 0.5, 1); /* Smooth */
|
||
--ease-out-quint: cubic-bezier(0.22, 1, 0.36, 1); /* Slightly snappier */
|
||
--ease-out-expo: cubic-bezier(0.16, 1, 0.3, 1); /* Confident, decisive */
|
||
|
||
/* AVOID: feel dated and tacky */
|
||
/* bounce: cubic-bezier(0.34, 1.56, 0.64, 1); */
|
||
/* elastic: cubic-bezier(0.68, -0.6, 0.32, 1.6); */
|
||
```
|
||
|
||
**Exit animations are faster than entrances.** Use ~75% of enter duration.
|
||
|
||
### CSS Animations
|
||
```css
|
||
/* Prefer for simple, declarative animations */
|
||
- transitions for state changes
|
||
- @keyframes for complex sequences
|
||
- transform and opacity for reliable movement
|
||
- blur, filters, masks, clip paths, shadows, and color shifts for premium atmospheric effects when verified smooth
|
||
```
|
||
|
||
### JavaScript Animation
|
||
```javascript
|
||
/* Use for complex, interactive animations */
|
||
- Web Animations API for programmatic control
|
||
- Framer Motion for React
|
||
- GSAP for complex sequences
|
||
```
|
||
|
||
### Performance
|
||
- **Motion materials**: Use transform/opacity for reliable movement, but use blur, filters, masks, shadows, and color shifts when they materially improve the effect
|
||
- **Layout safety**: Avoid casual animation of layout-driving properties (`width`, `height`, `top`, `left`, margins)
|
||
- **will-change**: Add sparingly for known expensive animations
|
||
- **Bound expensive effects**: Keep blur/filter/shadow areas small or isolated, use `contain` where appropriate
|
||
- **Monitor FPS**: Ensure 60fps on target devices
|
||
|
||
### Accessibility
|
||
```css
|
||
@media (prefers-reduced-motion: reduce) {
|
||
* {
|
||
animation-duration: 0.01ms !important;
|
||
animation-iteration-count: 1 !important;
|
||
transition-duration: 0.01ms !important;
|
||
}
|
||
}
|
||
```
|
||
|
||
**NEVER**:
|
||
- Use bounce or elastic easing curves; they feel dated and draw attention to the animation itself
|
||
- Animate layout properties casually (`width`, `height`, `top`, `left`, margins) when transform, FLIP, or grid-based techniques would work
|
||
- Use durations over 500ms for feedback (it feels laggy)
|
||
- Animate without purpose (every animation needs a reason)
|
||
- Ignore `prefers-reduced-motion` (this is an accessibility violation)
|
||
- Animate everything (animation fatigue makes interfaces feel exhausting)
|
||
- Block interaction during animations unless intentional
|
||
|
||
## Verify Quality
|
||
|
||
Test animations thoroughly:
|
||
|
||
- **Smooth at 60fps**: No jank on target devices
|
||
- **Feels natural**: Easing curves feel organic, not robotic
|
||
- **Appropriate timing**: Not too fast (jarring) or too slow (laggy)
|
||
- **Reduced motion works**: Animations disabled or simplified appropriately
|
||
- **Doesn't block**: Users can interact during/after animations
|
||
- **Adds value**: Makes interface clearer or more delightful
|
||
|
||
When the motion clarifies state instead of decorating it, hand off to `{{command_prefix}}impeccable polish` for the final pass.
|